Changeset 12877 in vbox for trunk/src/VBox/VMM/DBGF.cpp

Timestamp:

Oct 1, 2008 9:11:15 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

37275

Message:

DBGF: Don't linger in DBGFR3Detach.

File:

• trunk/src/VBox/VMM/DBGF.cpp (modified) (1 diff)

trunk/src/VBox/VMM/DBGF.cpp

@@ -879 +879 @@
 
     /*
-     * If we're in the wrong mode, wait a wee bit first to avoid speaking
-     * out of turn and racing EMT. We shouldn't  linger too long though,
-     * because we might be in a screwed up state.
-     */
-    if (RTSemPongShouldWait(&pVM->dbgf.s.PingPong))
-        RTSemPongWait(&pVM->dbgf.s.PingPong, 5000);
-
-    /*
-     * Send detach command.
-     * This may or may not be in response to an EMT termination event.
-     */
-    DBGFCMD enmCmd;
+     * Try send the detach command.
+     * Keep in mind that we might be racing EMT, so, be extra careful.
+     */
+    DBGFCMD enmCmd = dbgfR3SetCmd(pVM, DBGFCMD_DETACH_DEBUGGER);
     if (RTSemPongIsSpeaker(&pVM->dbgf.s.PingPong))
     {
-        enmCmd = dbgfR3SetCmd(pVM, DBGFCMD_DETACH_DEBUGGER);
         rc = RTSemPong(&pVM->dbgf.s.PingPong);
         AssertMsgRCReturn(rc, ("Failed to signal emulation thread. rc=%Rrc\n", rc), rc);
-        Log(("DBGFR3Detach: enmCmd=%d (pong -> ping)\n", enmCmd));
-    }
-    else
-    {
-        enmCmd = dbgfR3SetCmd(pVM, DBGFCMD_DETACH_DEBUGGER);
-        LogRel(("DBGFR3Detach: enmCmd=%d (ping)\n", enmCmd));
+        LogRel(("DBGFR3Detach: enmCmd=%d (pong -> ping)\n", enmCmd));
     }