Changeset 13561 in vbox for trunk/src/VBox/VMM/VMMAll/EMAll.cpp

Timestamp:

Oct 24, 2008 4:27:26 PM (16 years ago)

Author:

vboxsync

Message:

Emulate (lock) cmpxchg8b in ring 0 & 3. Added testcase for instruction emulation.

File:

• trunk/src/VBox/VMM/VMMAll/EMAll.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/EMAll.cpp

@@ -1482 +1482 @@
 
     /* Update guest's eflags and finish. */
-    pRegFrame->eflags.u32 = (pRegFrame->eflags.u32 & ~(X86_EFL_CF | X86_EFL_PF | X86_EFL_AF | X86_EFL_ZF | X86_EFL_SF | X86_EFL_OF))
+    pRegFrame->eflags.u32 =   (pRegFrame->eflags.u32 & ~(X86_EFL_CF | X86_EFL_PF | X86_EFL_AF | X86_EFL_ZF | X86_EFL_SF | X86_EFL_OF))
                             | (eflags                &  (X86_EFL_CF | X86_EFL_PF | X86_EFL_AF | X86_EFL_ZF | X86_EFL_SF | X86_EFL_OF));
 
     *pcbSize = param2.size;
+    return VINF_SUCCESS;
+}
+
+/*
+ * [LOCK] CMPXCHG8B emulation.
+ */
+static int emInterpretCmpXchg8b(PVM pVM, PDISCPUSTATE pCpu, PCPUMCTXCORE pRegFrame, RTGCPTR pvFault, uint32_t *pcbSize)
+{
+    Assert(pCpu->mode != CPUMODE_64BIT);    /** @todo check */
+    OP_PARAMVAL param1;
+
+    /* Source to make DISQueryParamVal read the register value - ugly hack */
+    int rc = DISQueryParamVal(pRegFrame, pCpu, &pCpu->param1, &param1, PARAM_SOURCE);
+    if(VBOX_FAILURE(rc))
+        return VERR_EM_INTERPRETER;
+
+    RTGCPTR  GCPtrPar1;
+    void    *pvParam1;
+    uint64_t eflags;
+
+    AssertReturn(pCpu->param1.size == 8, VERR_EM_INTERPRETER);
+    switch(param1.type)
+    {
+    case PARMTYPE_ADDRESS:
+        GCPtrPar1 = param1.val.val64;
+        GCPtrPar1 = emConvertToFlatAddr(pVM, pRegFrame, pCpu, &pCpu->param1, GCPtrPar1);
+
+        rc = PGMPhysGCPtr2HCPtr(pVM, GCPtrPar1, &pvParam1);
+        if (VBOX_FAILURE(rc))
+        {
+            AssertRC(rc);
+            return VERR_EM_INTERPRETER;
+        }
+        break;
+
+    default:
+        return VERR_EM_INTERPRETER;
+    }
+
+    LogFlow(("%s %VGv=%08x eax=%08x\n", emGetMnemonic(pCpu), pvParam1, pRegFrame->eax));
+
+    if (pCpu->prefix & PREFIX_LOCK)
+        eflags = EMEmulateLockCmpXchg8b(pvParam1, &pRegFrame->eax, &pRegFrame->edx, pRegFrame->ebx, pRegFrame->ecx);
+    else
+        eflags = EMEmulateCmpXchg8b(pvParam1, &pRegFrame->eax, &pRegFrame->edx, pRegFrame->ebx, pRegFrame->ecx);
+
+    LogFlow(("%s %VGv=%08x eax=%08x ZF=%d\n", emGetMnemonic(pCpu), pvParam1, pRegFrame->eax, !!(eflags & X86_EFL_ZF)));
+
+    /* Update guest's eflags and finish; note that *only* ZF is affected. */
+    pRegFrame->eflags.u32 =   (pRegFrame->eflags.u32 & ~(X86_EFL_ZF))
+                            | (eflags                &  (X86_EFL_ZF));
+
+    *pcbSize = 8;
     return VINF_SUCCESS;
 }
@@ -2833 +2886 @@
              && pCpu->pCurInstr->opcode != OP_OR
              && pCpu->pCurInstr->opcode != OP_BTR
+             && pCpu->pCurInstr->opcode != OP_CMPXCHG
+             && pCpu->pCurInstr->opcode != OP_CMPXCHG8B
             )
        )
@@ -2930 +2985 @@
 #ifdef IN_GC
         INTERPRET_CASE(OP_STI,Sti);
+        INTERPRET_CASE(OP_XADD, XAdd);
+#endif
         INTERPRET_CASE(OP_CMPXCHG8B, CmpXchg8b);
-        INTERPRET_CASE(OP_XADD, XAdd);
-#endif
         INTERPRET_CASE(OP_HLT,Hlt);
         INTERPRET_CASE(OP_IRET,Iret);
@@ -2938 +2993 @@
 #ifdef VBOX_WITH_STATISTICS
 #ifndef IN_GC
-        INTERPRET_STAT_CASE(OP_CMPXCHG8B, CmpXchg8b);
         INTERPRET_STAT_CASE(OP_XADD, XAdd);
 #endif