Changeset 14012 in vbox for trunk/src/VBox/Runtime/common/misc/req.cpp

Timestamp:

Nov 10, 2008 1:46:18 PM (16 years ago)

Author:

vboxsync

Message:

pReq may be invalid after queuing it (RTREQFLAGS_NO_WAIT), similar to r27120.

File:

• trunk/src/VBox/Runtime/common/misc/req.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/misc/req.cpp

@@ -659 +659 @@
      * Insert it.
      */
+    PRTREQQUEUE pQueue = ((RTREQ volatile *)pReq)->pQueue;                 /* volatile paranoia */
+    unsigned fFlags = ((RTREQ volatile *)pReq)->fFlags;                    /* volatile paranoia */
     pReq->enmState = RTREQSTATE_QUEUED;
     PRTREQ pNext;
     do
     {
-        pNext = pReq->pQueue->pReqs;
+        pNext = pQueue->pReqs;
         pReq->pNext = pNext;
-    } while (!ASMAtomicCmpXchgPtr((void * volatile *)&pReq->pQueue->pReqs, (void *)pReq, (void *)pNext));
+    } while (!ASMAtomicCmpXchgPtr((void * volatile *)&pQueue->pReqs, (void *)pReq, (void *)pNext));
 
     /*
      * Notify queue thread.
      */
-    RTSemEventSignal(pReq->pQueue->EventSem);
+    RTSemEventSignal(pQueue->EventSem);
 
     /*
      * Wait and return.
      */
-    if (!(pReq->fFlags & RTREQFLAGS_NO_WAIT))
+    if (!(fFlags & RTREQFLAGS_NO_WAIT))
         rc = RTReqWait(pReq, cMillies);
     LogFlow(("RTReqQueue: returns %Rrc\n", rc));