Changeset 14874 in vbox for trunk/src/VBox/Main/VirtualBoxImpl.cpp

Timestamp:

Dec 1, 2008 4:18:38 PM (16 years ago)

Author:

vboxsync

Message:

#3285: Improve error handling API to include unique error numbers
Document

• IVirtualBox::getHardDisk2
• IVirtualBox::findHardDisk2
• IVirtualBox::openDVDImage (todo: document file not found)

File:

• trunk/src/VBox/Main/VirtualBoxImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -1175 +1175 @@
                                         IHardDisk2 **aHardDisk)
 {
-   if (!aLocation)
+    if (!aLocation)
         return E_INVALIDARG;
-   if (!aHardDisk)
+    if (!aHardDisk)
         return E_POINTER;
 
@@ -2702 +2702 @@
     }
 
-    HRESULT rc = result == 0 ? S_OK : E_INVALIDARG;
+    HRESULT rc = result == 0 ? S_OK : VBOX_E_OBJECT_NOT_FOUND;
 
     if (aSetError && result != 0)
@@ -3469 +3469 @@
     if (!conflict.isNull())
     {
-        return setError (E_INVALIDARG,
+        return setError (VBOX_E_FILE_ERROR,
             tr ("Cannot register the CD/DVD image '%ls' with UUID {%RTuuid} "
                 "because a %s already exists in the media registry ('%ls')"),