Changeset 14972 in vbox for trunk/src/VBox/Main/AudioAdapterImpl.cpp

Timestamp:

Dec 4, 2008 12:10:37 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

40340

Message:

#3285: Improve error handling API to include unique error numbers

The mega commit that implements Main-wide usage of new CheckCom*
macros, mostly CheckComArgNotNull, CheckComArgStrNotEmptyOrNull,
CheckComArgOutSafeArrayPointerValid, CheckComArgExpr.
Note that some methods incorrectly returned E_INVALIDARG where they
should have returned E_POINTER and vice versa. If any higher level
function tests these, they will behave differently now...

Special thanks to: vi macros, making it easy to semi-automatically
find and replace several hundred instances of if (!aName) ...

File:

• trunk/src/VBox/Main/AudioAdapterImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/AudioAdapterImpl.cpp

@@ -161 +161 @@
 STDMETHODIMP AudioAdapter::COMGETTER(Enabled)(BOOL *aEnabled)
 {
-    if (!aEnabled)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aEnabled);
 
     AutoCaller autoCaller (this);
@@ -196 +195 @@
 STDMETHODIMP AudioAdapter::COMGETTER(AudioDriver)(AudioDriverType_T *aAudioDriver)
 {
-    if (!aAudioDriver)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aAudioDriver);
 
     AutoCaller autoCaller (this);
@@ -274 +272 @@
 STDMETHODIMP AudioAdapter::COMGETTER(AudioController)(AudioControllerType_T *aAudioController)
 {
-    if (!aAudioController)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aAudioController);
 
     AutoCaller autoCaller (this);