Changeset 14972 in vbox for trunk/src/VBox/Main/ParallelPortImpl.cpp

Timestamp:

Dec 4, 2008 12:10:37 PM (16 years ago)

Author:

vboxsync

Message:

#3285: Improve error handling API to include unique error numbers

The mega commit that implements Main-wide usage of new CheckCom*
macros, mostly CheckComArgNotNull, CheckComArgStrNotEmptyOrNull,
CheckComArgOutSafeArrayPointerValid, CheckComArgExpr.
Note that some methods incorrectly returned E_INVALIDARG where they
should have returned E_POINTER and vice versa. If any higher level
function tests these, they will behave differently now...

Special thanks to: vi macros, making it easy to semi-automatically
find and replace several hundred instances of if (!aName) ...

File:

• trunk/src/VBox/Main/ParallelPortImpl.cpp (modified) (5 diffs)

trunk/src/VBox/Main/ParallelPortImpl.cpp

@@ -323 +323 @@
 STDMETHODIMP ParallelPort::COMGETTER(Enabled) (BOOL *aEnabled)
 {
-    if (!aEnabled)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aEnabled);
 
     AutoCaller autoCaller (this);
@@ -372 +371 @@
 STDMETHODIMP ParallelPort::COMGETTER(Slot) (ULONG *aSlot)
 {
-    if (!aSlot)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aSlot);
 
     AutoCaller autoCaller (this);
@@ -387 +385 @@
 STDMETHODIMP ParallelPort::COMGETTER(IRQ) (ULONG *aIRQ)
 {
-    if (!aIRQ)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aIRQ);
 
     AutoCaller autoCaller (this);
@@ -442 +439 @@
 STDMETHODIMP ParallelPort::COMGETTER(IOBase) (ULONG *aIOBase)
 {
-    if (!aIOBase)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aIOBase);
 
     AutoCaller autoCaller (this);
@@ -497 +493 @@
 STDMETHODIMP ParallelPort::COMGETTER(Path) (BSTR *aPath)
 {
-    if (!aPath)
-        return E_POINTER;
+    CheckComArgOutPointerValid(aPath);
 
     AutoCaller autoCaller (this);