Changeset 16505 in vbox for trunk/src/recompiler_new/target-i386/op_helper.c

Timestamp:

Feb 4, 2009 10:47:13 AM (16 years ago)

Author:

vboxsync

Message:

REM: safer fix for 3588

File:

• trunk/src/recompiler_new/target-i386/op_helper.c (modified) (2 diffs)

trunk/src/recompiler_new/target-i386/op_helper.c

@@ -385 +385 @@
             raise_exception_err(EXCP0A_TSS, selector & 0xfffc);
 #ifdef VBOX
+#if 0
+        /** @todo: now we ignore loading 0 selectors, need to check what is correct once */
         cpu_x86_load_seg_cache(env, seg_reg, selector,
                                0, 0, 0);
+#endif
 #endif
     }
@@ -5701 +5704 @@
             }
             else
-                tss_load_seg(seg_reg, selector);
+                helper_load_seg(seg_reg, selector);
+            /* We used to use tss_load_seg(seg_reg, selector); which, for some reasons ignored
+               loading 0 selectors, what, in order, lead to subtle problems like #3588 */
+
             env = savedenv;