Changeset 19251 in vbox for trunk/src/VBox/Devices/Storage/VDIHDDCore.cpp

Timestamp:

Apr 29, 2009 9:40:48 AM (16 years ago)

Author:

vboxsync

Message:

VBoxHDD/VDI: fix heap corruption in compacting VDI.

File:

• trunk/src/VBox/Devices/Storage/VDIHDDCore.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/VDIHDDCore.cpp

@@ -1905 +1905 @@
          * compacting the image, just to be on the safe side. Update the
          * image contents straight away, as this enables cancelling. */
-        for (unsigned i = 0; i < cBlocks; i++)
+        for (unsigned i = 0; i < cBlocksAllocated; i++)
             paBlocks2[i] = VDI_IMAGE_BLOCK_FREE;
         rc = VINF_SUCCESS;
@@ -1931 +1931 @@
                     LogFunc(("Freed out of bounds reference for block %u in file \"%s\"\n",
                              i, pImage->pszFilename));
-                    pImage->paBlocks[i] = VDI_IMAGE_BLOCK_FREE;;
+                    pImage->paBlocks[i] = VDI_IMAGE_BLOCK_FREE;
                     rc = vdiUpdateBlockInfo(pImage, i);
                     if (RT_FAILURE(rc))