Changeset 19294 in vbox

Timestamp:

May 1, 2009 4:18:59 PM (16 years ago)

Author:

vboxsync

Message:

DBGFDisas.cpp: overlooked one SMP todo.

File:

• trunk/src/VBox/VMM/DBGFDisas.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/DBGFDisas.cpp

@@ -373 +373 @@
         if (CPUMAreHiddenSelRegsValid(pVM))
         {   /* Assume the current CS defines the execution mode. */
-            pCtxCore   = CPUMGetGuestCtxCore(VMMGetCpu(pVM));  /* @todo SMP support!! */
+            pCtxCore   = CPUMGetGuestCtxCore(pVCpu);
             pHiddenSel = (CPUMSELREGHID *)&pCtxCore->csHid;
 
@@ -540 +540 @@
     AssertReturn(idCpu < pVM->cCPUs, VERR_INVALID_CPU_ID);
 
+    /*
+     * Optimize the common case where we're called on the EMT of idCpu since
+     * we're using this all the time when logging.
+     */
     int     rc;
     PVMCPU  pVCpu = VMMGetCpu(pVM);
     if (    pVCpu
-        &&  pVCpu->idCpu == idCpu) /* not necessary, but it's faster. */
+        &&  pVCpu->idCpu == idCpu)
         rc = dbgfR3DisasInstrExOnVCpu(pVM, pVCpu, Sel, &GCPtr, fFlags, pszOutput, cchOutput, pcbInstr);
     else