Changeset 20773 in vbox for trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

Timestamp:

Jun 22, 2009 12:54:03 PM (15 years ago)

Author:

vboxsync

Message:

pgmPoolAccessHandler: Disassemble with the pgm lock taken to avoid unnecessary lock contention

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -1102 +1102 @@
     LogFlow(("pgmPoolAccessHandler: pvFault=%RGv pPage=%p:{.idx=%d} GCPhysFault=%RGp\n", pvFault, pPage, pPage->idx, GCPhysFault));
 
+    pgmLock(pVM);
+
     /*
      * Disassemble the faulting instruction.
@@ -1107 +1109 @@
     PDISCPUSTATE pDis = &pVCpu->pgm.s.DisState;
     int rc = EMInterpretDisasOne(pVM, pVCpu, pRegFrame, pDis, NULL);
-    AssertRCReturn(rc, rc);
-
-    pgmLock(pVM);
+    AssertReturnStmt(rc == VINF_SUCCESS, pgmUnlock(pVM), rc);
 
     if (PHYS_PAGE_ADDRESS(GCPhysFault) != PHYS_PAGE_ADDRESS(pPage->GCPhys))