Changeset 20871 in vbox for trunk/src/VBox/VMM/VMMAll/REMAll.cpp

Timestamp:

Jun 24, 2009 1:56:19 AM (15 years ago)

Author:

vboxsync

Message:

VMM: Make sure there is enough room for a few physical handler notification before we disable ring-3 calls. Partial VMM[GC|R0]CallHost unification.

File:

• trunk/src/VBox/VMM/VMMAll/REMAll.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/REMAll.cpp

@@ -22 +22 @@
 
 /*******************************************************************************
-*   Global Variables                                                           *
+*   Header Files                                                               *
 *******************************************************************************/
 #define LOG_GROUP LOG_GROUP_REM
@@ -80 +80 @@
 
 /**
- * Flushes the handler notifications by calling the host.
- *
- * @param   pVM     The VM handle.
- */
-static void remFlushHandlerNotifications(PVM pVM)
-{
-#ifdef IN_RC
-    VMMGCCallHost(pVM, VMMCALLHOST_REM_REPLAY_HANDLER_NOTIFICATIONS, 0);
-#elif defined(IN_RING0)
-    /** @todo necessary? */
-    VMMR0CallHost(pVM, VMMCALLHOST_REM_REPLAY_HANDLER_NOTIFICATIONS, 0);
-#else
-    AssertReleaseMsgFailed(("Ring 3 call????.\n"));
-#endif
-}
-
-
-/**
  * Insert pending notification
  *
@@ -120 +102 @@
                 Assert(cFlushes++ != 128);
                 AssertFatal(cFlushes < _1M);
-                remFlushHandlerNotifications(pVM);
+                VMMRZCallRing3NoCpu(pVM, VMMCALLHOST_REM_REPLAY_HANDLER_NOTIFICATIONS, 0);
                 idxFree = ASMAtomicUoReadU32(&pVM->rem.s.idxFreeList);
             } while (idxFree == (uint32_t)-1);
@@ -145 +127 @@
 
     VM_FF_SET(pVM, VM_FF_REM_HANDLER_NOTIFY);
-
-#if 0 /* Enable this to trigger odd flush bugs. */
-    remFlushHandlerNotifications(pVM);
-#endif
 }
 
@@ -222 +200 @@
 #endif /* !IN_RING3 */
 
+#ifdef IN_RC
+/**
+ * Flushes the physical handler notifications if the queue is almost full.
+ *
+ * This is for avoiding trouble in RC when changing CR3.
+ *
+ * @param   pVM         The VM handle.
+ * @param   pVCpu       The virtual CPU handle of the calling EMT.
+ */
+VMMDECL(void) REMNotifyHandlerPhysicalFlushIfAlmostFull(PVM pVM, PVMCPU pVCpu)
+{
+    Assert(pVM->cCPUs == 1);
+
+    /*
+     * Less than 10 items means we should flush.
+     */
+    uint32_t cFree = 0;
+    for (uint32_t idx = pVM->rem.s.idxFreeList;
+         idx != UINT32_MAX;
+         idx = pVM->rem.s.aHandlerNotifications[idx].idxNext)
+    {
+        Assert(idx < RT_ELEMENTS(pVM->rem.s.aHandlerNotifications));
+        if (++cFree > 10)
+            return;
+    }
+
+    /* Ok, we gotta flush them. */
+    VMMRZCallRing3NoCpu(pVM, VMMCALLHOST_REM_REPLAY_HANDLER_NOTIFICATIONS, 0);
+}
+#endif /* IN_RC */
+
+
 /**
  * Make REM flush all translation block upon the next call to REMR3State().