Changeset 21806 in vbox for trunk/src/VBox/Main/HardDiskImpl.cpp

Timestamp:

Jul 27, 2009 10:14:11 AM (15 years ago)

Author:

vboxsync

Message:

Storage/VBoxHDD: resurrect the facility to dump information about disk images, and bare minimum fix for creating diff images.

File:

• trunk/src/VBox/Main/HardDiskImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/HardDiskImpl.cpp

@@ -665 +665 @@
     mm.vdIfCallsError.enmInterface = VDINTERFACETYPE_ERROR;
     mm.vdIfCallsError.pfnError = vdErrorCall;
+    mm.vdIfCallsError.pfnMessage = NULL;
 
     /* Initialize the callbacks of the VD progress interface */
@@ -3250 +3251 @@
 
             /** @todo This kind of opening of images is assuming that diff
-             * images can be opened as base images. Not very clean, and should
-             * be fixed eventually. */
+             * images can be opened as base images. Should be fixed ASAP. */
             vrc = VDOpen(hdd,
                          Utf8Str(mm.format),
@@ -3275 +3275 @@
                 if (mm.setParentId)
                 {
-                    vrc = VDSetUuid(hdd, 0, mm.parentId);
+                    vrc = VDSetParentUuid(hdd, 0, mm.parentId);
                     ComAssertRCThrow(vrc, E_FAIL);
                 }
@@ -3900 +3900 @@
                     that->mm.vdProgress = task->progress;
 
+                    /** @todo add VD_IMAGE_FLAGS_DIFF to the image flags, to
+                     * be on the safe side. */
                     vrc = VDCreateDiff (hdd, targetFormat, targetLocation,
                                         task->d.variant,