Changeset 22105 in vbox for trunk/src/VBox/VMM/SELM.cpp

Timestamp:

Aug 8, 2009 2:54:59 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

50854

Message:

DBGF: Added DBGFSELQI_FLAGS_DT_ADJ_64BIT_MODE for making stack walking work - it's a gross hack. A more proper solution would mean adding more context to sel:off conversions, no time for that now.

File:

• trunk/src/VBox/VMM/SELM.cpp (modified) (1 diff)

trunk/src/VBox/VMM/SELM.cpp

@@ -2055 +2055 @@
     if (Desc.Gen.u1DescType)
     {
+        /*
+         * 64-bit code selectors are wide open, it's not possible to detect
+         * 64-bit data or stack selectors without also dragging in assumptions
+         * about current CS (i.e. that's we're executing in 64-bit mode).  So,
+         * the selinfo user needs to deal with this in the context the info is
+         * used unfortunately.
+         */
         if (    Desc.Gen.u1Long
             &&  !Desc.Gen.u1DefBig
             &&  (Desc.Gen.u4Type & X86_SEL_TYPE_CODE))
         {
-            /* 64-bit code selectors are wide open. It's not possible to
-               detect 64-bit data or stack selectors without also dragging
-               in assumptions about current CS. So, the selinfo user needs
-               to deal with this in the context the info is used unfortunately.
-               Note. We ignore the segment limit hacks that was added by AMD. */
+            /* Note! We ignore the segment limit hacks that was added by AMD. */
             pSelInfo->GCPtrBase = 0;
             pSelInfo->cbLimit   = ~(RTGCUINTPTR)0;