Changeset 22698 in vbox

Timestamp:

Sep 2, 2009 9:17:59 AM (15 years ago)

Author:

vboxsync

Message:

PGMPoolFlushPage must be called in an EMT.

Location:

trunk/src/VBox/VMM

Files:

• PGMPhys.cpp (modified) (3 diffs)
• VMMAll/PGMAllPool.cpp (modified) (1 diff)

trunk/src/VBox/VMM/PGMPhys.cpp

@@ -422 +422 @@
     AssertPtr(pLock);
 
+    Assert(VM_IS_EMT(pVM) || !PGMIsLockOwner(pVM));
+
     int rc = pgmLock(pVM);
     AssertRCReturn(rc, rc);
@@ -436 +438 @@
             rc = VERR_PGM_PHYS_PAGE_RESERVED;
         else
-#if 0
-        if (PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage))
-        {
-            /* We *must* flush any corresponding pgm pool page here, otherwise we'll
-             * not be informed about writes and keep bogus gst->shw mappings around.
-             */
-            PGMPoolFlushPage(pVM, GCPhys);
-            Assert(!PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage));
-        }
-        else
-#endif
         {
             /*
@@ -453 +444 @@
              * This has to be done on an EMT.
              */
-            if (RT_UNLIKELY(PGM_PAGE_GET_STATE(pPage) != PGM_PAGE_STATE_ALLOCATED))
+            if (    PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage)
+                ||  RT_UNLIKELY(PGM_PAGE_GET_STATE(pPage) != PGM_PAGE_STATE_ALLOCATED))
             {
                 pgmUnlock(pVM);

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -4711 +4711 @@
     PPGMPOOL pPool = pVM->pgm.s.CTX_SUFF(pPool);
 
+    VM_ASSERT_EMT(pVM);
+
     /*
      * Look up the GCPhys in the hash.