Changeset 23973 in vbox for trunk/src/VBox/Runtime/r3/xml.cpp

Timestamp:

Oct 22, 2009 12:34:22 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53801

Message:

*,RTFileOpen: Fixing RTFileOpen flag misdesign: The deny, access and action flags are mandatory now.

File:

• trunk/src/VBox/Runtime/r3/xml.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/xml.cpp

@@ -181 +181 @@
     m->strFileName = aFileName;
 
-    unsigned flags = 0;
+    uint32_t flags = 0;
     switch (aMode)
     {
+        /** @todo change to RTFILE_O_DENY_WRITE where appropriate. */
         case Mode_Read:
-            flags = RTFILE_O_READ;
+            flags = RTFILE_O_READ      | RTFILE_O_OPEN           | RTFILE_O_DENY_NONE;
             break;
         case Mode_WriteCreate:      // fail if file exists
-            flags = RTFILE_O_WRITE | RTFILE_O_CREATE;
+            flags = RTFILE_O_WRITE     | RTFILE_O_CREATE         | RTFILE_O_DENY_NONE;
             break;
         case Mode_Overwrite:        // overwrite if file exists
-            flags = RTFILE_O_WRITE | RTFILE_O_CREATE_REPLACE;
+            flags = RTFILE_O_WRITE     | RTFILE_O_CREATE_REPLACE | RTFILE_O_DENY_NONE;
             break;
         case Mode_ReadWrite:
-            flags = RTFILE_O_READ | RTFILE_O_WRITE;
-    }
-
-    int vrc = RTFileOpen (&m->handle, aFileName, flags);
-    if (RT_FAILURE (vrc))
-        throw EIPRTFailure (vrc);
+            flags = RTFILE_O_READWRITE | RTFILE_O_OPEN           | RTFILE_O_DENY_NONE;;
+    }
+
+    int vrc = RTFileOpen(&m->handle, aFileName, flags);
+    if (RT_FAILURE(vrc))
+        throw EIPRTFailure(vrc);
 
     m->opened = true;