Changeset 24278 in vbox for trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp

Timestamp:

Nov 2, 2009 8:26:07 PM (15 years ago)

Author:

vboxsync

Message:

AsyncCompletion: Cleanup in the cache and more statistics (more to come)

File:

• trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp (modified) (6 diffs)

trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp

@@ -42 +42 @@
 #include <iprt/string.h>
 #include <iprt/thread.h>
+#include <iprt/path.h>
 
 #include "PDMAsyncCompletionFileInternal.h"
@@ -693 +694 @@
     }
 
+#ifdef VBOX_WITH_STATISTICS
+    if (RT_SUCCESS(rc))
+    {
+        STAMR3RegisterF(pEpClassFile->Core.pVM, &pEpFile->StatRead,
+                       STAMTYPE_PROFILE_ADV, STAMVISIBILITY_ALWAYS,
+                       STAMUNIT_TICKS_PER_CALL, "Time taken to read from the endpoint",
+                       "/PDM/AsyncCompletion/File/%s/Read", RTPathFilename(pEpFile->Core.pszUri));
+
+        STAMR3RegisterF(pEpClassFile->Core.pVM, &pEpFile->StatWrite,
+                       STAMTYPE_PROFILE_ADV, STAMVISIBILITY_ALWAYS,
+                       STAMUNIT_TICKS_PER_CALL, "Time taken to write to the endpoint",
+                       "/PDM/AsyncCompletion/File/%s/Write", RTPathFilename(pEpFile->Core.pszUri));
+    }
+#endif
+
     return rc;
 }
@@ -728 +744 @@
     RTFileClose(pEpFile->File);
 
+#ifdef VBOX_WITH_STATISTICS
+    STAMR3Deregister(pEpClassFile->Core.pVM, &pEpFile->StatRead);
+    STAMR3Deregister(pEpClassFile->Core.pVM, &pEpFile->StatWrite);
+#endif
+
     return VINF_SUCCESS;
 }
@@ -736 +757 @@
                            size_t cbRead)
 {
+    int rc = VINF_SUCCESS;
     PPDMASYNCCOMPLETIONENDPOINTFILE pEpFile = (PPDMASYNCCOMPLETIONENDPOINTFILE)pEndpoint;
 
+    STAM_PROFILE_ADV_START(&pEpFile->StatRead, Read);
+
     if (pEpFile->fCaching)
-        return pdmacFileEpCacheRead(pEpFile, (PPDMASYNCCOMPLETIONTASKFILE)pTask,
-                                    off, paSegments, cSegments, cbRead);
+        rc = pdmacFileEpCacheRead(pEpFile, (PPDMASYNCCOMPLETIONTASKFILE)pTask,
+                                  off, paSegments, cSegments, cbRead);
     else
-        return pdmacFileEpTaskInitiate(pTask, pEndpoint, off, paSegments, cSegments, cbRead,
-                                       PDMACTASKFILETRANSFER_READ);
+        rc = pdmacFileEpTaskInitiate(pTask, pEndpoint, off, paSegments, cSegments, cbRead,
+                                     PDMACTASKFILETRANSFER_READ);
+
+    STAM_PROFILE_ADV_STOP(&pEpFile->StatRead, Read);
+
+    return rc;
 }
 
@@ -751 +779 @@
                             size_t cbWrite)
 {
+    int rc = VINF_SUCCESS;
     PPDMASYNCCOMPLETIONENDPOINTFILE pEpFile = (PPDMASYNCCOMPLETIONENDPOINTFILE)pEndpoint;
 
@@ -756 +785 @@
         return VERR_NOT_SUPPORTED;
 
+    STAM_PROFILE_ADV_START(&pEpFile->StatWrite, Write);
+
     if (pEpFile->fCaching)
-        return pdmacFileEpCacheWrite(pEpFile, (PPDMASYNCCOMPLETIONTASKFILE)pTask,
-                                     off, paSegments, cSegments, cbWrite);
+        rc = pdmacFileEpCacheWrite(pEpFile, (PPDMASYNCCOMPLETIONTASKFILE)pTask,
+                                   off, paSegments, cSegments, cbWrite);
     else
-        return pdmacFileEpTaskInitiate(pTask, pEndpoint, off, paSegments, cSegments, cbWrite,
-                                       PDMACTASKFILETRANSFER_WRITE);
+        rc = pdmacFileEpTaskInitiate(pTask, pEndpoint, off, paSegments, cSegments, cbWrite,
+                                     PDMACTASKFILETRANSFER_WRITE);
+
+    STAM_PROFILE_ADV_STOP(&pEpFile->StatWrite, Write);
+
+    return rc;
 }