Changeset 24773 in vbox for trunk/src/VBox/VMM/VM.cpp

Timestamp:

Nov 18, 2009 7:15:52 PM (15 years ago)

Author:

vboxsync

Message:

VM.cpp: Memory zeroing todo.

File:

• trunk/src/VBox/VMM/VM.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VM.cpp

@@ -2694 +2694 @@
         PGMR3Reset(pVM);                    /* We clear VM RAM in PGMR3Reset. It's vital PDMR3Reset is executed
                                              * _afterwards_. E.g. ACPI sets up RAM tables during init/reset. */
+/** @todo PGMR3Reset should be called after PDMR3Reset really, because we'll trash OS <-> hardware
+ * communication structures residing in RAM when done in the other order.  I.e. the device must be
+ * quiesced first, then we clear the memory and plan tables. Probably have to make these things
+ * explicit in some way, some memory setup pass or something.
+ * (Example: DevAHCI may assert if memory is zeroed before it've read the FIS.) */
         MMR3Reset(pVM);
         PDMR3Reset(pVM);