Changeset 25170 in vbox for trunk/src/VBox/Main/VirtualBoxImpl.cpp

Timestamp:

Dec 3, 2009 3:40:52 PM (15 years ago)

Author:

vboxsync

Message:

Main: rework VirtualBox implemenation to no longer use VirtualBoxBaseWithChildren; instead use individual lists for media, machines, shared folders etc. with individual locking; implement new ObjectsList class template for that

File:

• trunk/src/VBox/Main/VirtualBoxImpl.cpp (modified) (80 diffs)

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -70 +70 @@
 
 #include "Logging.h"
+#include "objectslist.h"
 
 #ifdef RT_OS_WINDOWS
@@ -82 +83 @@
 
 #define VBOX_GLOBAL_SETTINGS_FILE "VirtualBox.xml"
-
-typedef std::vector< ComObjPtr<Machine> > MachineVector;
-
-typedef std::list< ComObjPtr<Machine> > MachineList;
-typedef std::vector< ComObjPtr<SessionMachine> > SessionMachineVector;
-typedef std::list< ComObjPtr<GuestOSType> > GuestOSTypeList;
-
-typedef std::map<Guid, ComPtr<IProgress> > ProgressMap;
-
-typedef std::list <ComObjPtr<SharedFolder> > SharedFolderList;
-typedef std::list <ComObjPtr<DHCPServer> > DHCPServerList;
-
-typedef std::map<Guid, ComObjPtr<Medium> > HardDiskMap;
-
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -169 +156 @@
 #endif
 
+typedef ObjectsList<Machine> MachinesOList;
+typedef ObjectsList<Medium> MediaOList;
+typedef ObjectsList<GuestOSType> GuestOSTypesOList;
+typedef ObjectsList<SharedFolder> SharedFoldersOList;
+typedef ObjectsList<DHCPServer> DHCPServersOList;
+
+typedef std::map<Guid, ComPtr<IProgress> > ProgressMap;
+typedef std::map<Guid, ComObjPtr<Medium> > HardDiskMap;
+
 /**
  *  Main VirtualBox data structure.
@@ -198 +194 @@
 #endif /* VBOX_WITH_RESOURCE_USAGE_API */
 
-    MachineList                         llMachines;
-    GuestOSTypeList                     llGuestOSTypes;
+    // the following lists all have an RWLockHandle as a member and are locked
+    // individually; getting the VirtualBox object lock is NOT necessary, but
+    // see the remarks which ObjectsList method lock themselves and which require
+    // external locking
+    MachinesOList                       ollMachines;
+    GuestOSTypesOList                   ollGuestOSTypes;
+
+    MediaOList                          ollHardDisks,           // only base hard disks; the RWLockHandle in here is also used
+                                                                // for hardDiskTreeLockHandle()
+                                        ollDVDImages,
+                                        ollFloppyImages;
+    SharedFoldersOList                  ollSharedFolders;
+    DHCPServersOList                    ollDHCPServers;
+
+    // the hard disks map is an additional map sorted by UUID for quick lookup
+    // and contains ALL hard disks (base and differencing);
+    // the map must also be protected by ollHardDisks.getLockHandle()!
+    HardDiskMap                         mapHardDisks;
 
     ProgressMap                         mapProgressOperations;
-
-    MediaList                           llHardDisks,
-                                        llDVDImages,
-                                        llFloppyImages;
-    SharedFolderList                    llSharedFolders;
-    DHCPServerList                      llDHCPServers;
-
-    /// @todo NEWMEDIA do we really need this map? Used only in
-    /// find() it seems
-    HardDiskMap                         mapHardDisks;
-
     CallbackList                        llCallbacks;
 
     RWLockHandle                        mtxProgressOperations;
             // protects mutex operations; "leaf" lock, no other lock may be requested after this
-    RWLockHandle                        mtxHardDiskTree;
-            // protects the hard disk tree; this is implemented here, but only requested through
-            // Medium::treeLock, which returns exactly this
-    RWLockHandle                        mtxChildrenMap;
-            // used for VirtualBoxWithChildrenNEXT management
 
     // the following are data for the client watcher thread
@@ -373 +369 @@
                                           Global::sOSTypes [i].numSerialEnabled);
                 if (SUCCEEDED(rc))
-                    m->llGuestOSTypes.push_back (guestOSTypeObj);
+                    m->ollGuestOSTypes.addChild(guestOSTypeObj);
             }
             ComAssertComRCThrowRC (rc);
@@ -533 +529 @@
         if (FAILED(rc)) return rc;
 
-        rc = registerDVDImage(pImage, false /* aSaveRegistry */);
+        rc = registerImage(pImage, DeviceType_DVD, false /* aSaveRegistry */);
         if (FAILED(rc)) return rc;
     }
@@ -548 +544 @@
         if (FAILED(rc)) return rc;
 
-        rc = registerFloppyImage(pImage, false /* aSaveRegistry */);
+        rc = registerImage(pImage, DeviceType_Floppy, false /* aSaveRegistry */);
         if (FAILED(rc)) return rc;
     }
@@ -568 +564 @@
     /* tell all our child objects we've been uninitialized */
 
-    LogFlowThisFunc(("Uninitializing machines (%d)...\n", m->llMachines.size()));
-    if (m->llMachines.size())
-    {
-        MachineList::iterator it = m->llMachines.begin();
-        while (it != m->llMachines.end())
-            (*it++)->uninit();
-        m->llMachines.clear();
-    }
-
-    /* Uninit all other children still referenced by clients (unregistered
-     * machines, hard disks, DVD/floppy images, server-side progress
-     * operations). */
-    uninitDependentChildren();
-
-    m->mapHardDisks.clear();
-
-    m->llFloppyImages.clear();
-    m->llDVDImages.clear();
-    m->llHardDisks.clear();
-    m->llDHCPServers.clear();
+    LogFlowThisFunc(("Uninitializing machines (%d)...\n", m->ollMachines.size()));
+    m->ollMachines.uninitAll();
+    m->ollFloppyImages.uninitAll();
+    m->ollDVDImages.uninitAll();
+    m->ollHardDisks.uninitAll();
+    m->ollDHCPServers.uninitAll();
 
     m->mapProgressOperations.clear();
 
-    m->llGuestOSTypes.clear();
+    m->ollGuestOSTypes.uninitAll();
 
     /* Note that we release singleton children after we've all other children.
@@ -788 +770 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock(this);
-
-    SafeIfaceArray<IMachine> machines(m->llMachines);
+    AutoReadLock al(m->ollMachines.getLockHandle());
+    SafeIfaceArray<IMachine> machines(m->ollMachines.getList());
     machines.detachTo(ComSafeArrayOutArg(aMachines));
 
@@ -804 +785 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock(this);
-
-    SafeIfaceArray<IMedium> hardDisks(m->llHardDisks);
+    AutoReadLock al(m->ollHardDisks.getLockHandle());
+    SafeIfaceArray<IMedium> hardDisks(m->ollHardDisks.getList());
     hardDisks.detachTo(ComSafeArrayOutArg(aHardDisks));
 
@@ -812 +792 @@
 }
 
-STDMETHODIMP
-VirtualBox::COMGETTER(DVDImages) (ComSafeArrayOut(IMedium *, aDVDImages))
+STDMETHODIMP VirtualBox::COMGETTER(DVDImages) (ComSafeArrayOut(IMedium *, aDVDImages))
 {
     if (ComSafeArrayOutIsNull(aDVDImages))
@@ -821 +800 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock(this);
-
-    SafeIfaceArray<IMedium> images(m->llDVDImages);
+    AutoReadLock al(m->ollDVDImages.getLockHandle());
+    SafeIfaceArray<IMedium> images(m->ollDVDImages.getList());
     images.detachTo(ComSafeArrayOutArg(aDVDImages));
 
@@ -829 +807 @@
 }
 
-STDMETHODIMP
-VirtualBox::COMGETTER(FloppyImages) (ComSafeArrayOut(IMedium *, aFloppyImages))
+STDMETHODIMP VirtualBox::COMGETTER(FloppyImages) (ComSafeArrayOut(IMedium *, aFloppyImages))
 {
     if (ComSafeArrayOutIsNull(aFloppyImages))
@@ -838 +815 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock(this);
-
-    SafeIfaceArray<IMedium> images(m->llFloppyImages);
+    AutoReadLock al(m->ollFloppyImages.getLockHandle());
+    SafeIfaceArray<IMedium> images(m->ollFloppyImages.getList());
     images.detachTo(ComSafeArrayOutArg(aFloppyImages));
 
@@ -855 +831 @@
     /* protect mProgressOperations */
     AutoReadLock safeLock(m->mtxProgressOperations);
-
     SafeIfaceArray<IProgress> progress(m->mapProgressOperations);
     progress.detachTo(ComSafeArrayOutArg(aOperations));
@@ -869 +844 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock(this);
-
-    SafeIfaceArray<IGuestOSType> ostypes(m->llGuestOSTypes);
+    AutoReadLock al(m->ollGuestOSTypes.getLockHandle());
+    SafeIfaceArray<IGuestOSType> ostypes(m->ollGuestOSTypes.getList());
     ostypes.detachTo(ComSafeArrayOutArg(aGuestOSTypes));
 
@@ -877 +851 @@
 }
 
-STDMETHODIMP
-VirtualBox::COMGETTER(SharedFolders) (ComSafeArrayOut(ISharedFolder *, aSharedFolders))
+STDMETHODIMP VirtualBox::COMGETTER(SharedFolders) (ComSafeArrayOut(ISharedFolder *, aSharedFolders))
 {
 #ifndef RT_OS_WINDOWS
@@ -919 +892 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock(this);
-
-    SafeIfaceArray<IDHCPServer> svrs (m->llDHCPServers);
+    AutoReadLock al(m->ollDHCPServers.getLockHandle());
+    SafeIfaceArray<IDHCPServer> svrs (m->ollDHCPServers.getList());
     svrs.detachTo(ComSafeArrayOutArg(aDHCPServers));
 
@@ -1177 +1149 @@
 
 /** @note Locks objects! */
-STDMETHODIMP VirtualBox::RegisterMachine (IMachine *aMachine)
+STDMETHODIMP VirtualBox::RegisterMachine(IMachine *aMachine)
 {
     CheckComArgNotNull(aMachine);
@@ -1190 +1162 @@
     if (FAILED(rc)) return rc;
 
-    /* We need the children map lock here to keep the getDependentChild() result
-     * valid until we finish */
-    AutoReadLock chLock (childrenLock());
-
     /* We can safely cast child to Machine * here because only Machine
      * implementations of IMachine can be among our children. */
-    Machine *machine = static_cast <Machine *> (getDependentChild (aMachine));
-    if (machine == NULL)
-    {
-        /* this machine was not created by CreateMachine() or opened by
-         * OpenMachine() or loaded during startup */
-        return setError (VBOX_E_INVALID_OBJECT_STATE,
-            tr ("The machine named '%ls' is not created within this "
-                "VirtualBox instance"), name.raw());
-    }
-
-    AutoCaller machCaller (machine);
-    ComAssertComRCRetRC (machCaller.rc());
-
-    rc = registerMachine (machine);
-
+    Machine *pMachine = static_cast<Machine*>(aMachine);
+
+    AutoCaller machCaller(pMachine);
+    ComAssertComRCRetRC(machCaller.rc());
+
+    rc = registerMachine(pMachine);
     /* fire an event */
     if (SUCCEEDED(rc))
-        onMachineRegistered(machine->getId(), TRUE);
+        onMachineRegistered(pMachine->getId(), TRUE);
 
     return rc;
@@ -1219 +1178 @@
 
 /** @note Locks objects! */
-STDMETHODIMP VirtualBox::GetMachine (IN_BSTR aId, IMachine **aMachine)
+STDMETHODIMP VirtualBox::GetMachine(IN_BSTR aId, IMachine **aMachine)
 {
     CheckComArgOutSafeArrayPointerValid(aMachine);
@@ -1236 +1195 @@
 
 /** @note Locks this object for reading, then some machine objects for reading. */
-STDMETHODIMP VirtualBox::FindMachine (IN_BSTR aName, IMachine **aMachine)
+STDMETHODIMP VirtualBox::FindMachine(IN_BSTR aName, IMachine **aMachine)
 {
     LogFlowThisFuncEnter();
@@ -1248 +1207 @@
 
     /* start with not found */
-    ComObjPtr<Machine> machine;
-    MachineList machines;
-    {
-        /* take a copy for safe iteration outside the lock */
-        AutoReadLock alock(this);
-        machines = m->llMachines;
-    }
-
-    for (MachineList::iterator it = machines.begin();
-         !machine && it != machines.end();
-         ++ it)
+    ComObjPtr<Machine> pMachineFound;
+
+    AutoReadLock al(m->ollMachines.getLockHandle());
+    for (MachinesOList::iterator it = m->ollMachines.begin();
+         it != m->ollMachines.end();
+         ++it)
     {
         ComObjPtr<Machine> &pMachine2 = *it;
@@ -1269 +1223 @@
             AutoReadLock machLock(pMachine2);
             if (pMachine2->getName() == aName)
-                machine = pMachine2;
+            {
+                pMachineFound = pMachine2;
+                break;
+            }
         }
     }
 
     /* this will set (*machine) to NULL if machineObj is null */
-    machine.queryInterfaceTo(aMachine);
-
-    HRESULT rc = machine
+    pMachineFound.queryInterfaceTo(aMachine);
+
+    HRESULT rc = pMachineFound
         ? S_OK
-        : setError (VBOX_E_OBJECT_NOT_FOUND,
-            tr ("Could not find a registered machine named '%ls'"), aName);
+        : setError(VBOX_E_OBJECT_NOT_FOUND,
+                   tr("Could not find a registered machine named '%ls'"), aName);
 
     LogFlowThisFunc(("aName=\"%ls\", aMachine=%p, rc=%08X\n", aName, *aMachine, rc));
@@ -1288 +1245 @@
 
 /** @note Locks objects! */
-STDMETHODIMP VirtualBox::UnregisterMachine (IN_BSTR  aId,
-                                            IMachine **aMachine)
+STDMETHODIMP VirtualBox::UnregisterMachine(IN_BSTR  aId,
+                                           IMachine **aMachine)
 {
     Guid id(aId);
@@ -1298 +1255 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
+    // find machine from the given ID
+    ComObjPtr<Machine> pMachine;
+    HRESULT rc = findMachine(id, true /* setError */, &pMachine);
+    if (FAILED(rc)) return rc;
+
+    rc = pMachine->trySetRegistered(FALSE);
+    if (FAILED(rc)) return rc;
+
+    /* remove from the collection of registered machines */
+    m->ollMachines.removeChild(pMachine);
+
+    /* save the global registry */
     AutoWriteLock alock(this);
-
-    ComObjPtr<Machine> machine;
-
-    HRESULT rc = findMachine (id, true /* setError */, &machine);
-    if (FAILED(rc)) return rc;
-
-    rc = machine->trySetRegistered (FALSE);
-    if (FAILED(rc)) return rc;
-
-    /* remove from the collection of registered machines */
-    m->llMachines.remove (machine);
-
-    /* save the global registry */
     rc = saveSettings();
 
     /* return the unregistered machine to the caller */
-    machine.queryInterfaceTo(aMachine);
+    pMachine.queryInterfaceTo(aMachine);
 
     /* fire an event */
-    onMachineRegistered (id, FALSE);
+    onMachineRegistered(id, FALSE);
 
     return rc;
@@ -1461 +1417 @@
     if (SUCCEEDED(rc))
     {
-        rc = registerDVDImage (image);
+        rc = registerImage(image, DeviceType_DVD);
 
         if (SUCCEEDED(rc))
@@ -1528 +1484 @@
     if (SUCCEEDED(rc))
     {
-        rc = registerFloppyImage (image);
+        rc = registerImage(image, DeviceType_Floppy);
 
         if (SUCCEEDED(rc))
@@ -1616 +1572 @@
     *aType = NULL;
 
-    AutoReadLock alock(this);
-
-    for (GuestOSTypeList::iterator it = m->llGuestOSTypes.begin();
-         it != m->llGuestOSTypes.end();
-         ++ it)
+    AutoReadLock alock(m->ollGuestOSTypes.getLockHandle());
+    for (GuestOSTypesOList::iterator it = m->ollGuestOSTypes.begin();
+         it != m->ollGuestOSTypes.end();
+         ++it)
     {
         const Bstr &typeId = (*it)->id();
@@ -1637 +1592 @@
 }
 
-STDMETHODIMP
-VirtualBox::CreateSharedFolder (IN_BSTR aName, IN_BSTR aHostPath, BOOL /* aWritable */)
+STDMETHODIMP VirtualBox::CreateSharedFolder(IN_BSTR aName, IN_BSTR aHostPath, BOOL /* aWritable */)
 {
     CheckComArgNotNull(aName);
@@ -1649 +1603 @@
 }
 
-STDMETHODIMP VirtualBox::RemoveSharedFolder (IN_BSTR aName)
+STDMETHODIMP VirtualBox::RemoveSharedFolder(IN_BSTR aName)
 {
     CheckComArgNotNull(aName);
@@ -2006 +1960 @@
 void VirtualBox::dumpAllBackRefs()
 {
-    for (MediaList::const_iterator mt = m->llHardDisks.begin();
-         mt != m->llHardDisks.end();
-         ++mt)
-    {
-        ComObjPtr<Medium> pMedium = *mt;
-        pMedium->dumpBackRefs();
-    }
-    for (MediaList::const_iterator mt = m->llDVDImages.begin();
-         mt != m->llDVDImages.end();
-         ++mt)
-    {
-        ComObjPtr<Medium> pMedium = *mt;
-        pMedium->dumpBackRefs();
+    {
+        AutoReadLock al(m->ollHardDisks.getLockHandle());
+        for (MediaList::const_iterator mt = m->ollHardDisks.begin();
+             mt != m->ollHardDisks.end();
+             ++mt)
+        {
+            ComObjPtr<Medium> pMedium = *mt;
+            pMedium->dumpBackRefs();
+        }
+    }
+    {
+        AutoReadLock al(m->ollDVDImages.getLockHandle());
+        for (MediaList::const_iterator mt = m->ollDVDImages.begin();
+             mt != m->ollDVDImages.end();
+             ++mt)
+        {
+            ComObjPtr<Medium> pMedium = *mt;
+            pMedium->dumpBackRefs();
+        }
     }
 }
@@ -2662 +2622 @@
 {
     ComObjPtr<GuestOSType> type;
-
     AutoCaller autoCaller(this);
     AssertComRCReturn(autoCaller.rc(), type);
 
-    AutoReadLock alock(this);
-
     /* unknown type must always be the first */
-    ComAssertRet (m->llGuestOSTypes.size() > 0, type);
-
-    type = m->llGuestOSTypes.front();
-    return type;
+    ComAssertRet(m->ollGuestOSTypes.size() > 0, type);
+
+    return m->ollGuestOSTypes.front();
 }
 
@@ -2703 +2659 @@
     AutoReadLock alock(this);
 
-    for (MachineList::iterator it = m->llMachines.begin();
-         it != m->llMachines.end();
+    for (MachinesOList::iterator it = m->ollMachines.begin();
+         it != m->ollMachines.end();
          ++it)
     {
@@ -2739 +2695 @@
                                 ComObjPtr<Machine> *aMachine /* = NULL */)
 {
+    HRESULT rc = VBOX_E_OBJECT_NOT_FOUND;
+
     AutoCaller autoCaller(this);
     AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
 
-    bool found = false;
-
-    {
-        AutoReadLock alock(this);
-
-        for (MachineList::iterator it = m->llMachines.begin();
-             !found && it != m->llMachines.end();
-             ++ it)
+    {
+        AutoReadLock al(m->ollMachines.getLockHandle());
+
+        for (MachinesOList::iterator it = m->ollMachines.begin();
+             it != m->ollMachines.end();
+             ++it)
         {
             ComObjPtr<Machine> pMachine2 = *it;
@@ -2756 +2712 @@
             AssertComRC(machCaller.rc());
 
-            found = pMachine2->getId() == aId;
-            if (found && aMachine)
-                *aMachine = pMachine2;
-        }
-    }
-
-    HRESULT rc = found ? S_OK : VBOX_E_OBJECT_NOT_FOUND;
-
-    if (aSetError && !found)
-    {
-        setError (VBOX_E_OBJECT_NOT_FOUND,
-            tr ("Could not find a registered machine with UUID {%RTuuid}"),
-            aId.raw());
-    }
+            if (pMachine2->getId() == aId)
+            {
+                rc = S_OK;
+                if (aMachine)
+                    *aMachine = pMachine2;
+                break;
+            }
+        }
+    }
+
+    if (aSetError && FAILED(rc))
+        setError(VBOX_E_OBJECT_NOT_FOUND,
+                 tr("Could not find a registered machine with UUID {%RTuuid}"),
+                 aId.raw());
 
     return rc;
@@ -2796 +2752 @@
     AssertReturn(aId || aLocation, E_INVALIDARG);
 
-    AutoReadLock alock(this);
+    // we use the hard disks map, but it is protected by the
+    // hard disk _list_ lock handle
+    AutoReadLock alock(m->ollHardDisks.getLockHandle());
 
     /* first, look up by UUID in the map if UUID is provided */
     if (aId)
     {
-        HardDiskMap::const_iterator it = m->mapHardDisks.find (*aId);
+        HardDiskMap::const_iterator it = m->mapHardDisks.find(*aId);
         if (it != m->mapHardDisks.end())
         {
@@ -2887 +2845 @@
     }
 
-    AutoReadLock alock(this);
+    AutoReadLock alock(m->ollDVDImages.getLockHandle());
 
     bool found = false;
 
-    for (MediaList::const_iterator it = m->llDVDImages.begin();
-         it != m->llDVDImages.end();
+    for (MediaList::const_iterator it = m->ollDVDImages.begin();
+         it != m->ollDVDImages.end();
          ++ it)
     {
@@ -2963 +2921 @@
     }
 
-    AutoReadLock alock(this);
+    AutoReadLock alock(m->ollFloppyImages.getLockHandle());
 
     bool found = false;
 
-    for (MediaList::const_iterator it = m->llFloppyImages.begin();
-         it != m->llFloppyImages.end();
+    for (MediaList::const_iterator it = m->ollFloppyImages.begin();
+         it != m->ollFloppyImages.end();
          ++ it)
     {
@@ -3009 +2967 @@
                                     GuestOSType*& pGuestOSType)
 {
-    AutoReadLock alock(this);
-
     /* Look for a GuestOSType object */
-    AssertMsg(m->llGuestOSTypes.size() != 0,
+    AssertMsg(m->ollGuestOSTypes.size() != 0,
               ("Guest OS types array must be filled"));
 
@@ -3021 +2977 @@
     }
 
-    for (GuestOSTypeList::const_iterator it = m->llGuestOSTypes.begin();
-         it != m->llGuestOSTypes.end();
+    AutoReadLock alock(m->ollGuestOSTypes.getLockHandle());
+    for (GuestOSTypesOList::const_iterator it = m->ollGuestOSTypes.begin();
+         it != m->ollGuestOSTypes.end();
          ++it)
     {
@@ -3166 +3123 @@
  * @note Locks this object and media objects for reading.
  */
-HRESULT VirtualBox::checkMediaForConflicts2 (const Guid &aId,
-                                             const Utf8Str &aLocation,
-                                             Utf8Str &aConflict)
+HRESULT VirtualBox::checkMediaForConflicts2(const Guid &aId,
+                                            const Utf8Str &aLocation,
+                                            Utf8Str &aConflict)
 {
     aConflict.setNull();
@@ -3239 +3196 @@
     HRESULT rc = S_OK;
 
-    /* serialize file access (prevents concurrent reads and writes) */
-    AutoWriteLock alock(this);
-
     try
     {
         // machines
-        m->pMainConfigFile->llMachines.clear();
-        for (MachineList::iterator it = m->llMachines.begin();
-             it != m->llMachines.end();
-             ++it)
-        {
-            settings::MachineRegistryEntry mre;
-            rc = (*it)->saveRegistryEntry(mre);
-            m->pMainConfigFile->llMachines.push_back(mre);
+        settings::MachinesRegistry machinesTemp;
+        {
+            AutoReadLock al(m->ollMachines.getLockHandle());
+            for (MachinesOList::iterator it = m->ollMachines.begin();
+                 it != m->ollMachines.end();
+                 ++it)
+            {
+                settings::MachineRegistryEntry mre;
+                rc = (*it)->saveRegistryEntry(mre);
+                machinesTemp.push_back(mre);
+            }
         }
 
         // hard disks
-        m->pMainConfigFile->llHardDisks.clear();
-        for (MediaList::const_iterator it = m->llHardDisks.begin();
-             it != m->llHardDisks.end();
-             ++it)
-        {
-            settings::Medium med;
-            rc = (*it)->saveSettings(med);
-            m->pMainConfigFile->llHardDisks.push_back(med);
-            if (FAILED(rc)) throw rc;
+        settings::MediaList hardDisksTemp;
+        {
+            AutoReadLock al(m->ollHardDisks.getLockHandle());
+            for (MediaList::const_iterator it = m->ollHardDisks.begin();
+                 it != m->ollHardDisks.end();
+                 ++it)
+            {
+                settings::Medium med;
+                rc = (*it)->saveSettings(med);
+                if (FAILED(rc)) throw rc;
+                hardDisksTemp.push_back(med);
+            }
         }
 
         /* CD/DVD images */
-        m->pMainConfigFile->llDvdImages.clear();
-        for (MediaList::const_iterator it = m->llDVDImages.begin();
-             it != m->llDVDImages.end();
-             ++it)
-        {
-            settings::Medium med;
-            rc = (*it)->saveSettings(med);
-            if (FAILED(rc)) throw rc;
-            m->pMainConfigFile->llDvdImages.push_back(med);
+        settings::MediaList dvdsTemp;
+        {
+            AutoReadLock al(m->ollDVDImages.getLockHandle());
+            for (MediaList::const_iterator it = m->ollDVDImages.begin();
+                 it != m->ollDVDImages.end();
+                 ++it)
+            {
+                settings::Medium med;
+                rc = (*it)->saveSettings(med);
+                if (FAILED(rc)) throw rc;
+                dvdsTemp.push_back(med);
+            }
         }
 
         /* floppy images */
-        m->pMainConfigFile->llFloppyImages.clear();
-        for (MediaList::const_iterator it = m->llFloppyImages.begin();
-             it != m->llFloppyImages.end();
-             ++it)
-        {
-            settings::Medium med;
-            rc = (*it)->saveSettings(med);
-            if (FAILED(rc)) throw rc;
-            m->pMainConfigFile->llFloppyImages.push_back(med);
-        }
-
-        m->pMainConfigFile->llDhcpServers.clear();
-        for (DHCPServerList::const_iterator it =
-                m->llDHCPServers.begin();
-                it != m->llDHCPServers.end();
-                ++ it)
-        {
-            settings::DHCPServer d;
-            rc = (*it)->saveSettings(d);
-            if (FAILED(rc)) throw rc;
-            m->pMainConfigFile->llDhcpServers.push_back(d);
-        }
+        settings::MediaList floppiesTemp;
+        {
+            AutoReadLock al(m->ollFloppyImages.getLockHandle());
+            for (MediaList::const_iterator it = m->ollFloppyImages.begin();
+                 it != m->ollFloppyImages.end();
+                 ++it)
+            {
+                settings::Medium med;
+                rc = (*it)->saveSettings(med);
+                if (FAILED(rc)) throw rc;
+                floppiesTemp.push_back(med);
+            }
+        }
+
+        settings::DHCPServersList dhcpServersTemp;
+        {
+            AutoReadLock al(m->ollDHCPServers.getLockHandle());
+            for (DHCPServersOList::const_iterator it = m->ollDHCPServers.begin();
+                 it != m->ollDHCPServers.end();
+                 ++it)
+            {
+                settings::DHCPServer d;
+                rc = (*it)->saveSettings(d);
+                if (FAILED(rc)) throw rc;
+                dhcpServersTemp.push_back(d);
+            }
+        }
+
+        /* finally, lock VirtualBox object for writing */
+        AutoWriteLock alock(this);
+
+        /* now copy the temp data to the config file under the VirtualBox lock */
+        m->pMainConfigFile->llMachines = machinesTemp;
+        m->pMainConfigFile->llHardDisks = hardDisksTemp;
+        m->pMainConfigFile->llDvdImages = dvdsTemp;
+        m->pMainConfigFile->llFloppyImages = floppiesTemp;
+        m->pMainConfigFile->llDhcpServers = dhcpServersTemp;
+
+        // leave extra data alone, it's still in the config file
 
         /* host data (USB filters) */
@@ -3310 +3290 @@
         if (FAILED(rc)) throw rc;
 
-        // now write out the XML
+        // and write out the XML, still under the lock
         m->pMainConfigFile->write(m->strSettingsFilePath);
     }
@@ -3348 +3328 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoWriteLock alock(this);
-
     HRESULT rc = S_OK;
 
@@ -3379 +3357 @@
 
     /* add to the collection of registered machines */
-    m->llMachines.push_back(aMachine);
+    m->ollMachines.addChild(aMachine);
 
     if (autoCaller.state() != InInit)
@@ -3410 +3388 @@
     AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
 
-    AutoWriteLock alock(this);
-
-    AutoCaller hardDiskCaller (aHardDisk);
+    AutoCaller hardDiskCaller(aHardDisk);
     AssertComRCReturn(hardDiskCaller.rc(), hardDiskCaller.rc());
 
-    AutoReadLock hardDiskLock (aHardDisk);
-
-    Utf8Str strConflict;
-    HRESULT rc = checkMediaForConflicts2(aHardDisk->getId(),
-                                         aHardDisk->getLocationFull(),
-                                         strConflict);
-    if (FAILED(rc)) return rc;
-
-    if (strConflict.length())
-    {
-        return setError(E_INVALIDARG,
-                        tr("Cannot register the hard disk '%s' with UUID {%RTuuid} because a %s already exists in the media registry ('%s')"),
-                        aHardDisk->getLocationFull().raw(),
-                        aHardDisk->getId().raw(),
-                        strConflict.raw(),
-                        m->strSettingsFilePath.raw());
-    }
-
-    if (aHardDisk->getParent().isNull())
-    {
-        /* base (root) hard disk */
-        m->llHardDisks.push_back (aHardDisk);
-    }
-
-    m->mapHardDisks.insert(HardDiskMap::value_type(aHardDisk->getId(),
-                                                   HardDiskMap::mapped_type(aHardDisk)));
+    Guid id;
+    Utf8Str strLocationFull;
+    ComObjPtr<Medium> pParent;
+    {
+        AutoReadLock hardDiskLock(aHardDisk);
+        id = aHardDisk->getId();
+        strLocationFull = aHardDisk->getLocationFull();
+        pParent = aHardDisk->getParent();
+    }
+
+    HRESULT rc;
+    {
+        // lock the hard disk lists (list + map) while checking for conflicts
+        AutoWriteLock al(m->ollHardDisks.getLockHandle());
+
+        Utf8Str strConflict;
+        rc = checkMediaForConflicts2(id,
+                                     strLocationFull,
+                                     strConflict);
+        if (FAILED(rc)) return rc;
+        if (strConflict.length())
+            return setError(E_INVALIDARG,
+                            tr("Cannot register the hard disk '%s' with UUID {%RTuuid} because a %s already exists in the media registry ('%s')"),
+                            strLocationFull.raw(),
+                            id.raw(),
+                            strConflict.raw(),
+                            m->strSettingsFilePath.raw());
+
+        // store base (root) hard disks in the list
+        if (pParent.isNull())
+            m->ollHardDisks.getList().push_back(aHardDisk);
+                    // access the list directly because we already locked the list above
+
+        // store all hard disks (even differencing images) in the map
+        m->mapHardDisks[id] = aHardDisk;
+    }
 
     if (aSaveRegistry)
     {
         rc = saveSettings();
-        if (FAILED (rc))
+        if (FAILED(rc))
             unregisterHardDisk(aHardDisk, false /* aSaveRegistry */);
     }
@@ -3475 +3461 @@
     AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
 
-    AutoWriteLock alock(this);
-
     AutoCaller hardDiskCaller (aHardDisk);
     AssertComRCReturn(hardDiskCaller.rc(), hardDiskCaller.rc());
 
-    AutoReadLock hardDiskLock (aHardDisk);
-
-    size_t cnt = m->mapHardDisks.erase(aHardDisk->getId());
-    Assert(cnt == 1);
-    NOREF(cnt);
-
-    if (aHardDisk->getParent().isNull())
-    {
-        /* base (root) hard disk */
-        m->llHardDisks.remove(aHardDisk);
+    Guid id;
+    ComObjPtr<Medium> pParent;
+    {
+        AutoReadLock hardDiskLock(aHardDisk);
+        id = aHardDisk->getId();
+        pParent = aHardDisk->getParent();
+    }
+
+    {
+        // lock the hard disk lists (list + map)
+        AutoWriteLock al(m->ollHardDisks.getLockHandle());
+
+        // remove base (root) hard disks from the list
+        if (pParent.isNull())
+            m->ollHardDisks.getList().remove(aHardDisk);
+                    // access the list directly because we already locked the list above
+
+        // remove all hard disks (even differencing images) from map
+        size_t cnt = m->mapHardDisks.erase(id);
+        Assert(cnt == 1);
+        NOREF(cnt);
     }
 
@@ -3497 +3492 @@
     {
         rc = saveSettings();
-        if (FAILED (rc))
+        if (FAILED(rc))
             registerHardDisk(aHardDisk, false /* aSaveRegistry */);
     }
@@ -3505 +3500 @@
 
 /**
- * Remembers the given image by storing it in the CD/DVD image registry.
- *
- * @param aImage        Image object to remember.
+ * Remembers the given image by storing it in the CD/DVD or floppy image registry.
+ *
+ * @param argImage      Image object to remember.
+ * @param argType       Either DeviceType_DVD or DeviceType_Floppy.
  * @param aSaveRegistry @c true to save the image registry to disk (default).
  *
@@ -3519 +3515 @@
  * @note Locks this object for writing and @a aImage for reading.
  */
-HRESULT VirtualBox::registerDVDImage (Medium *aImage,
-                                      bool aSaveRegistry /*= true*/)
-{
-    AssertReturn(aImage != NULL, E_INVALIDARG);
+HRESULT VirtualBox::registerImage(Medium *argImage,
+                                  DeviceType_T argType,
+                                  bool argSaveRegistry /*= true*/)
+{
+    AssertReturn(argImage != NULL, E_INVALIDARG);
 
     AutoCaller autoCaller(this);
     AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
 
-    AutoWriteLock alock(this);
-
-    AutoCaller imageCaller (aImage);
+    AutoCaller imageCaller(argImage);
     AssertComRCReturn(imageCaller.rc(), imageCaller.rc());
 
-    AutoReadLock imageLock (aImage);
-
-    Utf8Str strConflict;
-    HRESULT rc = checkMediaForConflicts2(aImage->getId(),
-                                         aImage->getLocationFull(),
-                                         strConflict);
-    if (FAILED(rc)) return rc;
-
-    if (strConflict.length())
-    {
-        return setError(VBOX_E_INVALID_OBJECT_STATE,
-                        tr("Cannot register the CD/DVD image '%s' with UUID {%RTuuid} because a %s already exists in the media registry ('%s')"),
-                        aImage->getLocationFull().raw(),
-                        aImage->getId().raw(),
-                        strConflict.raw(),
-                        m->strSettingsFilePath.raw());
-    }
-
-    /* add to the collection */
-    m->llDVDImages.push_back (aImage);
-
-    if (aSaveRegistry)
+    Guid id;
+    Utf8Str strLocationFull;
+    ComObjPtr<Medium> pParent;
+    {
+        AutoReadLock al(argImage);
+        id = argImage->getId();
+        strLocationFull = argImage->getLocationFull();
+        pParent = argImage->getParent();
+    }
+
+    // work on DVDs or floppies list?
+    ObjectsList<Medium> &oll = (argType == DeviceType_DVD) ? m->ollDVDImages : m->ollFloppyImages;
+
+    HRESULT rc;
+    {
+        // lock the images lists (list + map) while checking for conflicts
+        AutoWriteLock al(oll.getLockHandle());
+
+        Utf8Str strConflict;
+        rc = checkMediaForConflicts2(id,
+                                     strLocationFull,
+                                     strConflict);
+        if (FAILED(rc)) return rc;
+
+        if (strConflict.length())
+            return setError(VBOX_E_INVALID_OBJECT_STATE,
+                            tr("Cannot register the image '%s' with UUID {%RTuuid} because a %s already exists in the media registry ('%s')"),
+                            strLocationFull.raw(),
+                            id.raw(),
+                            strConflict.raw(),
+                            m->strSettingsFilePath.raw());
+
+        // add to the collection
+        oll.getList().push_back(argImage);
+                // access the list directly because we already locked the list above
+    }
+
+    if (argSaveRegistry)
     {
         rc = saveSettings();
-        if (FAILED (rc))
-            unregisterDVDImage (aImage, false /* aSaveRegistry */);
+        if (FAILED(rc))
+            unregisterImage(argImage, argType, false /* aSaveRegistry */);
     }
 
@@ -3564 +3575 @@
 
 /**
- * Removes the given image from the CD/DVD image registry registry.
- *
- * @param aImage        Image object to remove.
- * @param aSaveRegistry @c true to save hard disk registry to disk (default).
+ * Removes the given image from the CD/DVD or floppy image registry.
+ *
+ * @param argImage        Image object to remove.
+ * @param argType         Either DeviceType_DVD or DeviceType_Floppy.
+ * @param argSaveRegistry @c true to save hard disk registry to disk (default).
  *
  * When @a aSaveRegistry is @c true, this operation may fail because of the
@@ -3578 +3590 @@
  * @note Locks this object for writing and @a aImage for reading.
  */
-HRESULT VirtualBox::unregisterDVDImage (Medium *aImage,
-                                        bool aSaveRegistry /*= true*/)
-{
-    AssertReturn(aImage != NULL, E_INVALIDARG);
+HRESULT VirtualBox::unregisterImage(Medium *argImage,
+                                    DeviceType_T argType,
+                                    bool argSaveRegistry /*= true*/)
+{
+    AssertReturn(argImage != NULL, E_INVALIDARG);
 
     AutoCaller autoCaller(this);
     AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
 
-    AutoWriteLock alock(this);
-
-    AutoCaller imageCaller (aImage);
+    AutoCaller imageCaller(argImage);
     AssertComRCReturn(imageCaller.rc(), imageCaller.rc());
 
-    AutoReadLock imageLock (aImage);
-
-    m->llDVDImages.remove (aImage);
+    Guid id;
+    ComObjPtr<Medium> pParent;
+    {
+        AutoReadLock al(argImage);
+        id = argImage->getId();
+        pParent = argImage->getParent();
+    }
+
+    // work on DVDs or floppies list?
+    ObjectsList<Medium> &oll = (argType == DeviceType_DVD) ? m->ollDVDImages : m->ollFloppyImages;
+
+    oll.removeChild(argImage);
 
     HRESULT rc = S_OK;
 
-    if (aSaveRegistry)
+    if (argSaveRegistry)
     {
         rc = saveSettings();
-        if (FAILED (rc))
-            registerDVDImage (aImage, false /* aSaveRegistry */);
+        if (FAILED(rc))
+            registerImage(argImage, argType, false /* aSaveRegistry */);
     }
 
     return rc;
-}
-
-/**
- * Remembers the given image by storing it in the floppy image registry.
- *
- * @param aImage        Image object to remember.
- * @param aSaveRegistry @c true to save the image registry to disk (default).
- *
- * When @a aSaveRegistry is @c true, this operation may fail because of the
- * failed #saveSettings() method it calls. In this case, the image object
- * will not be remembered. It is therefore the responsibility of the caller to
- * call this method as the last step of some action that requires registration
- * in order to make sure that only fully functional image objects get
- * registered.
- *
- * @note Locks this object for writing and @a aImage for reading.
- */
-HRESULT VirtualBox::registerFloppyImage(Medium *aImage,
-                                        bool aSaveRegistry /*= true*/)
-{
-    AssertReturn(aImage != NULL, E_INVALIDARG);
-
-    AutoCaller autoCaller(this);
-    AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
-
-    AutoWriteLock alock(this);
-
-    AutoCaller imageCaller (aImage);
-    AssertComRCReturn(imageCaller.rc(), imageCaller.rc());
-
-    AutoReadLock imageLock (aImage);
-
-    Utf8Str strConflict;
-    HRESULT rc = checkMediaForConflicts2(aImage->getId(),
-                                         aImage->getLocationFull(),
-                                         strConflict);
-    if (FAILED(rc)) return rc;
-
-    if (strConflict.length())
-    {
-        return setError(VBOX_E_INVALID_OBJECT_STATE,
-                        tr("Cannot register the floppy image '%s' with UUID {%RTuuid} because a %s already exists in the media registry ('%s')"),
-                        aImage->getLocationFull().raw(),
-                        aImage->getId().raw(),
-                        strConflict.raw(),
-                        m->strSettingsFilePath.raw());
-    }
-
-    /* add to the collection */
-    m->llFloppyImages.push_back (aImage);
-
-    if (aSaveRegistry)
-    {
-        rc = saveSettings();
-        if (FAILED (rc))
-            unregisterFloppyImage(aImage, false /* aSaveRegistry */);
-    }
-
-    return rc;
-}
-
-/**
- * Removes the given image from the floppy image registry registry.
- *
- * @param aImage        Image object to remove.
- * @param aSaveRegistry @c true to save hard disk registry to disk (default).
- *
- * When @a aSaveRegistry is @c true, this operation may fail because of the
- * failed #saveSettings() method it calls. In this case, the image object
- * will NOT be removed from the registry when this method returns. It is
- * therefore the responsibility of the caller to call this method as the first
- * step of some action that requires unregistration, before calling uninit() on
- * @a aImage.
- *
- * @note Locks this object for writing and @a aImage for reading.
- */
-HRESULT VirtualBox::unregisterFloppyImage(Medium *aImage,
-                                          bool aSaveRegistry /*= true*/)
-{
-    AssertReturn(aImage != NULL, E_INVALIDARG);
-
-    AutoCaller autoCaller(this);
-    AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
-
-    AutoWriteLock alock(this);
-
-    AutoCaller imageCaller (aImage);
-    AssertComRCReturn(imageCaller.rc(), imageCaller.rc());
-
-    AutoReadLock imageLock (aImage);
-
-    m->llFloppyImages.remove (aImage);
-
-    HRESULT rc = S_OK;
-
-    if (aSaveRegistry)
-    {
-        rc = saveSettings();
-        if (FAILED (rc))
-            registerFloppyImage (aImage, false /* aSaveRegistry */);
-    }
-
-    return rc;
-}
-
-/**
- * Attempts to cast from a raw interface pointer to an underlying object.
- * On success, @a aTo will contain the object reference. On failure, @a aTo will
- * be set to @c null and an extended error info will be returned.
- *
- * @param aFrom     Interface pointer to cast from.
- * @param aTo       Where to store a reference to the underlying object.
- *
- * @note Locks #childrenLock() for reading.
- */
-HRESULT VirtualBox::cast (IMedium *aFrom, ComObjPtr<Medium> &aTo)
-{
-    AssertReturn(aFrom != NULL, E_INVALIDARG);
-
-    AutoCaller autoCaller(this);
-    AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
-
-    /* We need the children map lock here to keep the getDependentChild() result
-     * valid until we finish */
-    AutoReadLock chLock (childrenLock());
-
-    VirtualBoxBase *child = getDependentChild (aFrom);
-    if (!child)
-        return setError (E_FAIL, tr ("The given hard disk object is not created "
-                                     "within this VirtualBox instance"));
-
-    /* we can safely cast child to Medium * here because only Medium
-     * implementations of IMedium can be among our children */
-
-    aTo = static_cast<Medium*>(child);
-
-    return S_OK;
 }
 
@@ -3754 +3637 @@
  * @note Locks this object + DVD, Floppy and HardDisk children for writing.
  */
-HRESULT VirtualBox::updateSettings (const char *aOldPath, const char *aNewPath)
+HRESULT VirtualBox::updateSettings(const char *aOldPath, const char *aNewPath)
 {
     LogFlowThisFunc(("aOldPath={%s} aNewPath={%s}\n", aOldPath, aNewPath));
@@ -3764 +3647 @@
     AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
 
-    AutoWriteLock alock(this);
-
-    /* check DVD paths */
-    for (MediaList::iterator it = m->llDVDImages.begin();
-         it != m->llDVDImages.end();
+    ObjectsList<Medium> ollAll;
+    ollAll.appendOtherList(m->ollDVDImages);
+    ollAll.appendOtherList(m->ollFloppyImages);
+    ollAll.appendOtherList(m->ollHardDisks);
+
+    for (MediaList::iterator it = ollAll.begin();
+         it != ollAll.end();
          ++ it)
     {
         (*it)->updatePath(aOldPath, aNewPath);
-    }
-
-    /* check Floppy paths */
-    for (MediaList::iterator it = m->llFloppyImages.begin();
-         it != m->llFloppyImages  .end();
-         ++ it)
-    {
-        (*it)->updatePath(aOldPath, aNewPath);
-    }
-
-    /* check HardDisk paths */
-    for (MediaList::const_iterator it = m->llHardDisks.begin();
-         it != m->llHardDisks.end();
-         ++ it)
-    {
-        (*it)->updatePaths(aOldPath, aNewPath);
     }
 
@@ -3899 +3768 @@
 RWLockHandle& VirtualBox::hardDiskTreeLockHandle()
 {
-    return m->mtxHardDiskTree;
-}
-
-/**
- * Reimplements VirtualBoxWithTypedChildren::childrenLock() to return a
- * dedicated lock instead of the main object lock. The dedicated lock for
- * child map operations frees callers of init() methods of these children
- * from acquiring a write parent (VirtualBox) lock (which would be mandatory
- * otherwise). Since VirtualBox has a lot of heterogenous children which
- * init() methods are called here and there, it definitely makes sense.
- */
-RWLockHandle* VirtualBox::childrenLock()
-{
-    return &m->mtxChildrenMap;
+    return m->ollHardDisks.getLockHandle();
 }
 
@@ -3924 +3780 @@
     LogFlowFuncEnter();
 
-    VirtualBox *that = (VirtualBox *) pvUser;
-    Assert (that);
+    VirtualBox *that = (VirtualBox*)pvUser;
+    Assert(that);
+
+    typedef std::vector< ComObjPtr<Machine> > MachineVector;
+    typedef std::vector< ComObjPtr<SessionMachine> > SessionMachineVector;
 
     SessionMachineVector machines;
@@ -3978 +3837 @@
             {
                 /* machine mutex is released */
-                (machines [rc - WAIT_OBJECT_0 - 1])->checkForDeath();
+                (machines[rc - WAIT_OBJECT_0 - 1])->checkForDeath();
                 update = true;
             }
@@ -3984 +3843 @@
             {
                 /* machine mutex is abandoned due to client process termination */
-                (machines [rc - WAIT_ABANDONED_0 - 1])->checkForDeath();
+                (machines[rc - WAIT_ABANDONED_0 - 1])->checkForDeath();
                 update = true;
             }
@@ -3998 +3857 @@
             {
                 /* close old process handles */
-                for (size_t i = 1 + cnt; i < 1 + cnt + cntSpawned; ++ i)
-                    CloseHandle (handles [i]);
-
-                AutoReadLock thatLock (that);
+                for (size_t i = 1 + cnt; i < 1 + cnt + cntSpawned; ++i)
+                    CloseHandle(handles[i]);
+
+                // lock the machines list for reading
+                AutoReadLock thatLock(that->m->ollMachines.getLockHandle());
 
                 /* obtain a new set of opened machines */
@@ -4007 +3867 @@
                 machines.clear();
 
-                for (MachineList::iterator it = that->m->llMachines.begin();
-                     it != that->m->llMachines.end(); ++ it)
+                for (MachinesOList::iterator it = that->m->ollMachines.begin();
+                     it != that->m->ollMachines.end();
+                     ++it)
                 {
                     /// @todo handle situations with more than 64 objects
@@ -4016 +3877 @@
                     ComObjPtr<SessionMachine> sm;
                     HANDLE ipcSem;
-                    if ((*it)->isSessionOpenOrClosing (sm, NULL, &ipcSem))
+                    if ((*it)->isSessionOpenOrClosing(sm, NULL, &ipcSem))
                     {
-                        machines.push_back (sm);
-                        handles [1 + cnt] = ipcSem;
-                        ++ cnt;
+                        machines.push_back(sm);
+                        handles[1 + cnt] = ipcSem;
+                        ++cnt;
                     }
                 }
@@ -4030 +3891 @@
                 spawnedMachines.clear();
 
-                for (MachineList::iterator it = that->m->llMachines.begin();
-                     it != that->m->llMachines.end(); ++ it)
+                for (MachinesOList::iterator it = that->m->ollMachines.begin();
+                     it != that->m->ollMachines.end();
+                     ++it)
                 {
                     /// @todo handle situations with more than 64 objects
@@ -4038 +3900 @@
 
                     RTPROCESS pid;
-                    if ((*it)->isSessionSpawning (&pid))
+                    if ((*it)->isSessionSpawning(&pid))
                     {
-                        HANDLE ph = OpenProcess (SYNCHRONIZE, FALSE, pid);
+                        HANDLE ph = OpenProcess(SYNCHRONIZE, FALSE, pid);
                         AssertMsg (ph != NULL, ("OpenProcess (pid=%d) failed with %d\n",
                                                 pid, GetLastError()));
                         if (rc == 0)
                         {
-                            spawnedMachines.push_back (*it);
-                            handles [1 + cnt + cntSpawned] = ph;
-                            ++ cntSpawned;
+                            spawnedMachines.push_back(*it);
+                            handles[1 + cnt + cntSpawned] = ph;
+                            ++cntSpawned;
                         }
                     }
@@ -4053 +3915 @@
 
                 LogFlowFunc (("UPDATE: spawned session count = %d\n", cntSpawned));
+
+                // machines lock unwinds here
             }
         }
@@ -4090 +3954 @@
             autoCaller.release();
 
-            int vrc = RTSemEventWait (that->m->updateReq, 500);
+            int vrc = RTSemEventWait(that->m->updateReq, 500);
 
             /* Restore the caller before using VirtualBox. If it fails, this
@@ -4129 +3993 @@
 #ifdef DEBUG
                             {
-                                AutoReadLock machineLock (machines [semId]);
+                                AutoReadLock machineLock(machines[semId]);
                                 LogFlowFunc (("released mutex: machine='%ls'\n",
-                                              machines [semId]->name().raw()));
+                                              machines[semId]->name().raw()));
                             }
 #endif
-                            machines [semId]->checkForDeath();
+                            machines[semId]->checkForDeath();
                         }
                         update = true;
@@ -4159 +4023 @@
 #ifdef DEBUG
                                     {
-                                        AutoReadLock machineLock (machines [semId]);
-                                        LogFlowFunc (("mutex owner dead: machine='%ls'\n",
-                                                      machines [i]->name().raw()));
+                                        AutoReadLock machineLock(machines[semId]);
+                                        LogFlowFunc(("mutex owner dead: machine='%ls'\n",
+                                                     machines[i]->name().raw()));
                                     }
 #endif
-                                    machines [i]->checkForDeath();
+                                    machines[i]->checkForDeath();
                                 }
                             }
@@ -4198 +4062 @@
                     machines.clear();
 
-                    for (MachineList::iterator it = that->m->llMachines.begin();
+                    for (MachinesOList::iterator it = that->m->llMachines.begin();
                          it != that->m->llMachines.end(); ++ it)
                     {
@@ -4211 +4075 @@
                         {
                             machines.push_back (sm);
-                            handles [cnt].hsemCur = (HSEM) ipcSem;
-                            handles [cnt].ulUser = cnt;
+                            handles[cnt].hsemCur = (HSEM) ipcSem;
+                            handles[cnt].ulUser = cnt;
                             ++ cnt;
                         }
@@ -4236 +4100 @@
                     spawnedMachines.clear();
 
-                    for (MachineList::iterator it = that->m->llMachines.begin();
+                    for (MachinesOList::iterator it = that->m->llMachines.begin();
                          it != that->m->llMachines.end(); ++ it)
                     {
@@ -4290 +4154 @@
                 /* RT_SUCCESS(rc) means an update event is signaled */
 
-                AutoReadLock thatLock (that);
+                // lock the machines list for reading
+                AutoReadLock thatLock(that->m->ollMachines.getLockHandle());
 
                 if (RT_SUCCESS(rc) || update)
@@ -4297 +4162 @@
                     machines.clear();
 
-                    for (MachineList::iterator it = that->m->llMachines.begin();
-                         it != that->m->llMachines.end(); ++ it)
+                    for (MachinesOList::iterator it = that->m->ollMachines.begin();
+                         it != that->m->ollMachines.end();
+                         ++it)
                     {
                         ComObjPtr<SessionMachine> sm;
-                        if ((*it)->isSessionOpenOrClosing (sm))
-                            machines.push_back (sm);
+                        if ((*it)->isSessionOpenOrClosing(sm))
+                            machines.push_back(sm);
                     }
 
                     cnt = machines.size();
-                    LogFlowFunc (("UPDATE: direct session count = %d\n", cnt));
+                    LogFlowFunc(("UPDATE: direct session count = %d\n", cnt));
                 }
 
@@ -4314 +4180 @@
                     spawnedMachines.clear();
 
-                    for (MachineList::iterator it = that->m->llMachines.begin();
-                         it != that->m->llMachines.end(); ++ it)
+                    for (MachinesOList::iterator it = that->m->ollMachines.begin();
+                         it != that->m->ollMachines.end();
+                         ++it)
                     {
                         if ((*it)->isSessionSpawning())
-                            spawnedMachines.push_back (*it);
+                            spawnedMachines.push_back(*it);
                     }
 
                     cntSpawned = spawnedMachines.size();
-                    LogFlowFunc (("UPDATE: spawned session count = %d\n", cntSpawned));
+                    LogFlowFunc(("UPDATE: spawned session count = %d\n", cntSpawned));
                 }
+
+                // machines lock unwinds here
             }
 
@@ -4490 +4359 @@
 }
 
-//STDMETHODIMP VirtualBox::FindDHCPServerForInterface (IHostNetworkInterface * aIinterface, IDHCPServer ** aServer)
-//{
-//    return E_NOTIMPL;
-//}
-
-STDMETHODIMP VirtualBox::FindDHCPServerByNetworkName (IN_BSTR aName, IDHCPServer ** aServer)
+STDMETHODIMP VirtualBox::FindDHCPServerByNetworkName(IN_BSTR aName, IDHCPServer ** aServer)
 {
     CheckComArgNotNull(aName);
@@ -4502 +4366 @@
     AutoCaller autoCaller(this);
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
-
-    AutoWriteLock alock(this);
 
     HRESULT rc;
@@ -4509 +4371 @@
     ComPtr<DHCPServer> found;
 
-    for (DHCPServerList::const_iterator it =
-            m->llDHCPServers.begin();
-         it != m->llDHCPServers.end();
-         ++ it)
-    {
-        rc = (*it)->COMGETTER(NetworkName) (bstr.asOutParam());
+    AutoReadLock alock(m->ollDHCPServers.getLockHandle());
+
+    for (DHCPServersOList::const_iterator it = m->ollDHCPServers.begin();
+         it != m->ollDHCPServers.end();
+         ++it)
+    {
+        rc = (*it)->COMGETTER(NetworkName)(bstr.asOutParam());
         if (FAILED(rc)) throw rc;
 
-        if(bstr == aName)
+        if (bstr == aName)
         {
             found = *it;
@@ -4558 +4421 @@
  */
 HRESULT VirtualBox::registerDHCPServer(DHCPServer *aDHCPServer,
-                                     bool aSaveRegistry /*= true*/)
+                                       bool aSaveRegistry /*= true*/)
 {
     AssertReturn(aDHCPServer != NULL, E_INVALIDARG);
@@ -4565 +4428 @@
     AssertComRCReturn(autoCaller.rc(), autoCaller.rc());
 
-    AutoWriteLock alock(this);
-
-    AutoCaller dhcpServerCaller (aDHCPServer);
+    AutoCaller dhcpServerCaller(aDHCPServer);
     AssertComRCReturn(dhcpServerCaller.rc(), dhcpServerCaller.rc());
-
-    AutoReadLock dhcpServerLock (aDHCPServer);
 
     Bstr name;
     HRESULT rc;
-    rc = aDHCPServer->COMGETTER(NetworkName) (name.asOutParam());
+    rc = aDHCPServer->COMGETTER(NetworkName)(name.asOutParam());
     if (FAILED(rc)) return rc;
 
     ComPtr<IDHCPServer> existing;
     rc = FindDHCPServerByNetworkName(name.mutableRaw(), existing.asOutParam());
-    if(SUCCEEDED(rc))
+    if (SUCCEEDED(rc))
     {
         return E_INVALIDARG;
     }
+
     rc = S_OK;
 
-    m->llDHCPServers.push_back (aDHCPServer);
+    m->ollDHCPServers.addChild(aDHCPServer);
 
     if (aSaveRegistry)
@@ -4625 +4485 @@
     AssertComRCReturn(dhcpServerCaller.rc(), dhcpServerCaller.rc());
 
-    AutoReadLock dhcpServerLock (aDHCPServer);
-
-    m->llDHCPServers.remove (aDHCPServer);
+    m->ollDHCPServers.removeChild(aDHCPServer);
 
     HRESULT rc = S_OK;