Changeset 26323 in vbox for trunk/src/VBox/Main/ConsoleImpl.cpp

Timestamp:

Feb 8, 2010 11:13:28 AM (15 years ago)

Author:

vboxsync

Message:

Main/Machine+Console: Extend the scope of the power up progress object, and collect error information from the frontend. Much better error signalling when the VM is started via openRemoteSession. Adjusted documentation accordingly, and finally fixed the incomprehensible messages emitted by VBoxManage startvm.

File:

• trunk/src/VBox/Main/ConsoleImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -49 +49 @@
 
 #include "Global.h"
+#include "VirtualBoxErrorInfoImpl.h"
 #include "GuestImpl.h"
 #include "KeyboardImpl.h"
@@ -7406 +7407 @@
         /* Notify the progress object of the success */
         task->mProgress->notifyComplete(S_OK);
+        console->mControl->SetPowerUpInfo(NULL);
     }
     else
@@ -7411 +7413 @@
         /* The progress object will fetch the current error info */
         task->mProgress->notifyComplete(rc);
+        ProgressErrorInfo info(task->mProgress);
+        ComObjPtr<VirtualBoxErrorInfo> errorInfo;
+        rc = errorInfo.createObject();
+        if (SUCCEEDED(rc))
+        {
+            errorInfo->init(info.getResultCode(),
+                            info.getInterfaceID(),
+                            info.getComponent(),
+                            info.getText());
+            console->mControl->SetPowerUpInfo(errorInfo);
+        }
+        else
+        {
+            /* If it's not possible to create an IVirtualBoxErrorInfo object
+             * signal success, as not signalling anything will cause a stuck
+             * progress object in VBoxSVC. */
+            console->mControl->SetPowerUpInfo(NULL);
+        }
 
         LogRel(("Power up failed (vrc=%Rrc, rc=%Rhrc (%#08X))\n", vrc, rc, rc));