Changeset 27557 in vbox for trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp

Timestamp:

Mar 20, 2010 9:14:43 PM (15 years ago)

Author:

vboxsync

Message:

I/O cache: Increase the endpoint size for every appending write, even if it isn't immediately written to the file (delay in the cache). Fixes data corruption when appending data in VMDK images

File:

• trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp

@@ -868 +868 @@
                 PPDMACEPFILEMGR pAioMgr = NULL;
 
+                pEpFile->cbEndpoint     = pEpFile->cbFile;
                 pEpFile->pTasksFreeTail = pEpFile->pTasksFreeHead;
                 pEpFile->cTasksCached   = 0;
@@ -970 +971 @@
     AssertRC(rc);
 
+    /* endpoint and real file size should better be equal now. */
+    AssertMsg(pEpFile->cbFile == pEpFile->cbEndpoint,
+              ("Endpoint and real file size should match now!\n"));
+
     /*
      * If the async I/O manager is in failsafe mode this is the only endpoint
@@ -1051 +1056 @@
     STAM_PROFILE_ADV_STOP(&pEpFile->StatWrite, Write);
 
+    /* Increase endpoint size. */
+    if (   RT_SUCCESS(rc)
+        && ((uint64_t)off + cbWrite) > pEpFile->cbEndpoint)
+        ASMAtomicWriteU64(&pEpFile->cbEndpoint, (uint64_t)off + cbWrite);
+
     return rc;
 }
@@ -1088 +1098 @@
     PPDMASYNCCOMPLETIONENDPOINTFILE pEpFile = (PPDMASYNCCOMPLETIONENDPOINTFILE)pEndpoint;
 
-    *pcbSize = ASMAtomicReadU64(&pEpFile->cbFile);
+    *pcbSize = ASMAtomicReadU64(&pEpFile->cbEndpoint);
 
     return VINF_SUCCESS;