Changeset 27714 in vbox for trunk/src/VBox/Main

Timestamp:

Mar 25, 2010 3:37:32 PM (15 years ago)

Author:

vboxsync

Message:

#4750: Do not call NetworkAdapter::Detach on error as it causes a deadlock.

File:

• trunk/src/VBox/Main/ConsoleImpl2.cpp (modified) (1 diff)

trunk/src/VBox/Main/ConsoleImpl2.cpp

@@ -2627 +2627 @@
             if (!pszColon)
             {
-                hrc = aNetworkAdapter->Detach();                        H();
+                /*
+                 * Dynamic changing of attachment causes an attempt to configure
+                 * network with invalid host adapter (as it is must be changed before
+                 * the attachment), calling Detach here will cause a deadlock.
+                 * See #4750.
+                 * hrc = aNetworkAdapter->Detach();                        H();
+                 */
                 return VMSetError(pVM, VERR_INTERNAL_ERROR, RT_SRC_POS,
                                   N_("Malformed host interface networking name '%ls'"),