Changeset 29024 in vbox for trunk/src/VBox/VMM/PGMSharedPage.cpp

Timestamp:

May 4, 2010 2:12:15 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

61064

Message:

Shared paging updates

File:

• trunk/src/VBox/VMM/PGMSharedPage.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/PGMSharedPage.cpp

@@ -24 +24 @@
 #include <VBox/stam.h>
 #include "PGMInternal.h"
+#include "PGMInline.h"
 #include <VBox/vm.h>
 #include <VBox/sup.h>
@@ -31 +32 @@
 #include <iprt/assert.h>
 #include <iprt/asm.h>
+#include <iprt/string.h>
+#include <iprt/mem.h>
 
+
+#ifdef VBOX_WITH_PAGE_SHARING
+/**
+ * Shared module registration helper (called on the way out).
+ *
+ * @param   pVM         The VM handle.
+ * @param   pReq        Registration request info
+ */
+static DECLCALLBACK(void) pgmR3SharedModuleRegisterHelper(PVM pVM, PGMMREGISTERSHAREDMODULEREQ pReq)
+{
+    int rc;
+    
+    rc = GMMR3RegisterSharedModule(pVM, pReq);
+    Assert(rc == VINF_SUCCESS || rc == VINF_PGM_SHARED_MODULE_COLLISION || rc == VINF_PGM_SHARED_MODULE_ALREADY_REGISTERED);
+    if (rc == VINF_PGM_SHARED_MODULE_ALREADY_REGISTERED)
+    {
+        PVMCPU   pVCpu = VMMGetCpu(pVM);
+        unsigned cFlushedPages = 0;
+
+        /** todo count copy-on-write actions in the trap handler so we don't check everything all the time! */
+
+        /* Count the number of shared pages that were changed (copy-on-write). */
+        for (unsigned i = 0; i < pReq->cRegions; i++)
+        {
+            Assert((pReq->aRegions[i].cbRegion & 0xfff) == 0);
+            Assert((pReq->aRegions[i].GCRegionAddr & 0xfff) == 0);
+
+            RTGCPTR GCRegion  = pReq->aRegions[i].GCRegionAddr;
+            uint32_t cbRegion = pReq->aRegions[i].cbRegion & ~0xfff;
+
+            while (cbRegion)
+            {
+                RTGCPHYS GCPhys;
+                uint64_t fFlags;
+
+                rc = PGMGstGetPage(pVCpu, GCRegion, &GCPhys, &fFlags);
+                if (    rc == VINF_SUCCESS
+                    &&  !(fFlags & X86_PTE_RW))
+                {
+                    PPGMPAGE pPage = pgmPhysGetPage(&pVM->pgm.s, GCPhys);
+                    if (    pPage
+                        &&  !PGM_PAGE_IS_SHARED(pPage))
+                    {
+                        cFlushedPages++;
+                    }
+                }
+
+                GCRegion += PAGE_SIZE;
+                cbRegion -= PAGE_SIZE;
+            }
+        }
+
+        if (cFlushedPages > 32)
+            rc = VINF_SUCCESS;  /* force recheck below */
+    }
+    /* Full (re)check needed? */
+    if (rc == VINF_SUCCESS)
+    {
+
+    }
+    RTMemFree(pReq);
+    return;
+}
+#endif
 
 /**
@@ -49 +116 @@
 {
 #ifdef VBOX_WITH_PAGE_SHARING
-    return GMMR3RegisterSharedModule(pVM, pszModuleName, pszVersion, GCBaseAddr, cbModule, cRegions, pRegions);
-#else 
+    PGMMREGISTERSHAREDMODULEREQ pReq;
+
+    /* Sanity check. */
+    AssertReturn(cRegions < VMMDEVSHAREDREGIONDESC_MAX, VERR_INVALID_PARAMETER);
+
+    pReq = (PGMMREGISTERSHAREDMODULEREQ)RTMemAllocZ(RT_OFFSETOF(GMMREGISTERSHAREDMODULEREQ, aRegions[cRegions]));
+    AssertReturn(pReq, VERR_NO_MEMORY);
+
+    pReq->Hdr.u32Magic  = SUPVMMR0REQHDR_MAGIC;
+    pReq->Hdr.cbReq     = sizeof(*pReq);
+    pReq->GCBaseAddr    = GCBaseAddr;
+    pReq->cbModule      = cbModule;
+    pReq->cRegions      = cRegions;
+    for (unsigned i = 0; i < cRegions; i++)
+        pReq->aRegions[i] = pRegions[i];
+
+    if (    RTStrCopy(pReq->szName, sizeof(pReq->szName), pszModuleName) != VINF_SUCCESS
+        ||  RTStrCopy(pReq->szVersion, sizeof(pReq->szVersion), pszVersion) != VINF_SUCCESS)
+    {
+        RTMemFree(pReq);
+        return VERR_BUFFER_OVERFLOW;
+    }
+
+    /* Queue the actual registration as we are under the IOM lock right now. Perform this operation on the way out. */
+    return VMR3ReqCallNoWait(pVM, VMMGetCpuId(pVM), (PFNRT)pgmR3SharedModuleRegisterHelper, 2, pVM, pReq);
+#else
     return VERR_NOT_IMPLEMENTED;
 #endif