Changeset 32410 in vbox

Timestamp:

Sep 10, 2010 2:19:33 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

65772

Message:

Got rid of unnecessary dirty page flush in InvalidatePage. (NOTE: high risk change)

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllBth.h (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -1119 +1119 @@
     LogFlow(("InvalidatePage %RGv\n", GCPtrPage));
 
-# ifdef PGMPOOL_WITH_OPTIMIZED_DIRTY_PT
-    /** @todo this shouldn't be necessary. */
-    if (pPool->cDirtyPages)
-        pgmPoolResetDirtyPages(pVM);
-# endif
-
     /*
      * Get the shadow PD entry and skip out if this PD isn't present.
@@ -1278 +1272 @@
 # ifdef PGMPOOL_WITH_OPTIMIZED_DIRTY_PT
             /* Reset the modification counter (OpenSolaris trashes tlb entries very often) */
-            if (pShwPage->cModifications)
+            if (    !pShwPage->fDirty 
+                &&  pShwPage->cModifications)
                 pShwPage->cModifications = 1;
 # endif