Changeset 32724 in vbox for trunk/src/VBox/Devices/Network/DevE1000.cpp

Timestamp:

Sep 23, 2010 1:54:39 PM (14 years ago)

Author:

vboxsync

Message:

e1k: few PCI-related notes

File:

• trunk/src/VBox/Devices/Network/DevE1000.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -5546 +5546 @@
     e1kPCICfgSetU16(pci, VBOX_PCI_COMMAND,            0x0000);
     /* DEVSEL Timing (medium device), 66 MHz Capable, New capabilities */
-    e1kPCICfgSetU16(pci, VBOX_PCI_STATUS,             0x0230);
+    e1kPCICfgSetU16(pci, VBOX_PCI_STATUS,
+                    VBOX_PCI_STATUS_DEVSEL_MEDIUM | VBOX_PCI_STATUS_CAP_LIST |  VBOX_PCI_STATUS_66MHZ);
     /* Stepping A2 */
     e1kPCICfgSetU8( pci, VBOX_PCI_REVISION_ID,          0x02);
@@ -5572 +5573 @@
     /* PCI Power Management Registers ****************************************/
     /* Capability ID: PCI Power Management Registers */
-    e1kPCICfgSetU8( pci, 0xDC,                          0x01);
+    e1kPCICfgSetU8( pci, 0xDC,                           VBOX_PCI_CAP_ID_PM);
     /* Next Item Pointer: PCI-X */
     e1kPCICfgSetU8( pci, 0xDC + 1,                      0xE4);
     /* Power Management Capabilities: PM disabled, DSI */
-    e1kPCICfgSetU16(pci, 0xDC + 2,                    0x0022);
+    e1kPCICfgSetU16(pci, 0xDC + 2,
+                    0x0002 | VBOX_PCI_PM_CAP_DSI);
     /* Power Management Control / Status Register: PM disabled */
     e1kPCICfgSetU16(pci, 0xDC + 4,                    0x0000);
@@ -5586 +5588 @@
     /* PCI-X Configuration Registers *****************************************/
     /* Capability ID: PCI-X Configuration Registers */
-    e1kPCICfgSetU8( pci, 0xE4,                          0x07);
+    e1kPCICfgSetU8( pci, 0xE4,                           VBOX_PCI_CAP_ID_PCIX);
     /* Next Item Pointer: None (Message Signalled Interrupts are disabled) */
     e1kPCICfgSetU8( pci, 0xE4 + 1,                      0x00);
     /* PCI-X Command: Enable Relaxed Ordering */
-    e1kPCICfgSetU16(pci, 0xE4 + 2,                    0x0002);
+    e1kPCICfgSetU16(pci, 0xE4 + 2,                    VBOX_PCI_X_CMD_ERO);
     /* PCI-X Status: 32-bit, 66MHz*/
+    /// @todo: is this value really correct? fff8 doesn't look like actual PCI address 
     e1kPCICfgSetU32(pci, 0xE4 + 4,                0x0040FFF8);
 }
@@ -5966 +5969 @@
 #endif /* IN_RING3 */
 #endif /* !VBOX_DEVICE_STRUCT_TESTCASE */
-