Changeset 32827 in vbox for trunk/src/VBox/Main/ConsoleImpl.cpp

Timestamp:

Sep 29, 2010 6:48:37 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

66284

Message:

Main/Guest+Console: fix lock ordering issues, and mark code where this still needs to be done

File:

• trunk/src/VBox/Main/ConsoleImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -1820 +1820 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
+    /** @todo r=klaus holding the lock while triggering VMMDev/EMT activity is
+     * asking for deadlocks. Code MUST drop any lock before touching VMMDev. */
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
@@ -1972 +1974 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
+    /** @todo r=klaus holding the lock while triggering VMMDev/EMT activity is
+     * asking for deadlocks. Code MUST drop any lock before touching VMMDev. */
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);