Changeset 34691 in vbox for trunk

Timestamp:

Dec 3, 2010 12:43:16 PM (14 years ago)

Author:

vboxsync

Message:

PIT: Fixed mode 3 timer interrupts (no longer doubled IRQ0 frequency).

File:

• trunk/src/VBox/Devices/PC/DevPit-i8254.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/PC/DevPit-i8254.cpp

@@ -425 +425 @@
         return;
     expire_time = pit_get_next_transition_time(s, current_time);
-    irq_level = pit_get_out1(s, current_time);
-
-    /* We just flip-flop the irq level to save that extra timer call, which isn't generally required (we haven't served it for months). */
-    pDevIns = s->CTX_SUFF(pPit)->pDevIns;
+    irq_level = pit_get_out1(s, current_time) ? PDM_IRQ_LEVEL_HIGH : PDM_IRQ_LEVEL_LOW;
 
     /* If PIT disabled by HPET - just disconnect ticks from interrupt controllers, and not modify
@@ -436 +433 @@
     if (!s->pPitR3->fDisabledByHpet)
     {
-        PDMDevHlpISASetIrq(pDevIns, s->irq, irq_level);
-        if (irq_level)
-            PDMDevHlpISASetIrq(pDevIns, s->irq, 0);
+        pDevIns = s->CTX_SUFF(pPit)->pDevIns;
+
+        if (s->mode == 2)
+        {
+            /* We just flip-flop the irq level to save that extra timer call, which isn't generally required (we haven't served it for years). */
+            PDMDevHlpISASetIrq(pDevIns, s->irq, PDM_IRQ_LEVEL_FLIP_FLOP);
+        } else
+            PDMDevHlpISASetIrq(pDevIns, s->irq, irq_level);
     }