Changeset 34779 in vbox for trunk/src/VBox/Main/MediumImpl.cpp

Timestamp:

Dec 7, 2010 1:53:04 PM (14 years ago)

Author:

vboxsync

Message:

Main/Medium: do not allow changing the medium type of an already attached medium to immutable.

File:

• trunk/src/VBox/Main/MediumImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MediumImpl.cpp

@@ -1645 +1645 @@
                         m->strLocationFull.c_str());
 
-    /* cannot change the type of a medium being in use by more than one VM */
-    if (m->backRefs.size() > 1)
+    /* Cannot change the type of a medium being in use by more than one VM.
+     * If the change is to Immutable then it must not be attached to any VM,
+     * otherwise assumptions elsewhere are violated and the VM becomes
+     * inaccessible. Attaching an immutable medium triggers the diff creation,
+     * and this is vital for the correct operation. */
+    if (   m->backRefs.size() > 1
+        || (aType == MediumType_Immutable && m->backRefs.size() > 0))
         return setError(VBOX_E_INVALID_OBJECT_STATE,
                         tr("Cannot change the type of medium '%s' because it is attached to %d virtual machines"),