Changeset 3613 in kBuild for trunk/src/sed/lib/regcomp.c

Timestamp:

Sep 19, 2024 12:34:43 AM (7 months ago)

Author:

bird

Message:

src/sed: Merged in changes between 4.1.5 and 4.9 from the vendor branch. (svn merge ^{/vendor/sed/4.1.5} /vendor/sed/current .)

Location:

trunk/src/sed

Files:

• . (modified) (1 prop)
• lib/regcomp.c (modified) (191 diffs)

trunk/src/sed/lib/regcomp.c

@@ -1 +1 @@
 /* Extended regular expression matching and search library.
-   Copyright (C) 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
+   Copyright (C) 2002-2022 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Isamu Hasegawa <[email protected]>.
@@ -15 +15 @@
 
    You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, write to the Free
-   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
-   02111-1307 USA.  */
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#ifdef _LIBC
+# include <locale/weight.h>
+#endif
 
 static reg_errcode_t re_compile_internal (regex_t *preg, const char * pattern,
@@ -25 +28 @@
                                      char *fastmap);
 static reg_errcode_t init_dfa (re_dfa_t *dfa, size_t pat_len);
-#ifdef RE_ENABLE_I18N
 static void free_charset (re_charset_t *cset);
-#endif /* RE_ENABLE_I18N */
 static void free_workarea_compile (regex_t *preg);
 static reg_errcode_t create_initial_state (re_dfa_t *dfa);
-#ifdef RE_ENABLE_I18N
 static void optimize_utf8 (re_dfa_t *dfa);
-#endif
 static reg_errcode_t analyze (regex_t *preg);
 static reg_errcode_t preorder (bin_tree_t *root,
@@ -47 +46 @@
 static reg_errcode_t calc_next (void *extra, bin_tree_t *node);
 static reg_errcode_t link_nfa_nodes (void *extra, bin_tree_t *node);
-static int duplicate_node (re_dfa_t *dfa, int org_idx, unsigned int constraint);
-static int search_duplicated_node (const re_dfa_t *dfa, int org_node,
+static Idx duplicate_node (re_dfa_t *dfa, Idx org_idx, unsigned int constraint);
+static Idx search_duplicated_node (const re_dfa_t *dfa, Idx org_node,
                                    unsigned int constraint);
 static reg_errcode_t calc_eclosure (re_dfa_t *dfa);
 static reg_errcode_t calc_eclosure_iter (re_node_set *new_set, re_dfa_t *dfa,
-                                         int node, int root);
+                                         Idx node, bool root);
 static reg_errcode_t calc_inveclosure (re_dfa_t *dfa);
-static int fetch_number (re_string_t *input, re_token_t *token,
+static Idx fetch_number (re_string_t *input, re_token_t *token,
                          reg_syntax_t syntax);
 static int peek_token (re_token_t *token, re_string_t *input,
-                        reg_syntax_t syntax) internal_function;
+                        reg_syntax_t syntax);
 static bin_tree_t *parse (re_string_t *regexp, regex_t *preg,
                           reg_syntax_t syntax, reg_errcode_t *err);
 static bin_tree_t *parse_reg_exp (re_string_t *regexp, regex_t *preg,
                                   re_token_t *token, reg_syntax_t syntax,
-                                  int nest, reg_errcode_t *err);
+                                  Idx nest, reg_errcode_t *err);
 static bin_tree_t *parse_branch (re_string_t *regexp, regex_t *preg,
                                  re_token_t *token, reg_syntax_t syntax,
-                                 int nest, reg_errcode_t *err);
+                                 Idx nest, reg_errcode_t *err);
 static bin_tree_t *parse_expression (re_string_t *regexp, regex_t *preg,
                                      re_token_t *token, reg_syntax_t syntax,
-                                     int nest, reg_errcode_t *err);
+                                     Idx nest, reg_errcode_t *err);
 static bin_tree_t *parse_sub_exp (re_string_t *regexp, regex_t *preg,
                                   re_token_t *token, reg_syntax_t syntax,
-                                  int nest, reg_errcode_t *err);
+                                  Idx nest, reg_errcode_t *err);
 static bin_tree_t *parse_dup_op (bin_tree_t *dup_elem, re_string_t *regexp,
                                  re_dfa_t *dfa, re_token_t *token,
@@ -83 +82 @@
                                             re_dfa_t *dfa,
                                             reg_syntax_t syntax,
-                                            int accept_hyphen);
+                                            bool accept_hyphen);
 static reg_errcode_t parse_bracket_symbol (bracket_elem_t *elem,
                                           re_string_t *regexp,
                                           re_token_t *token);
-#ifdef RE_ENABLE_I18N
 static reg_errcode_t build_equiv_class (bitset_t sbcset,
                                         re_charset_t *mbcset,
-                                        int *equiv_class_alloc,
+                                        Idx *equiv_class_alloc,
                                         const unsigned char *name);
 static reg_errcode_t build_charclass (RE_TRANSLATE_TYPE trans,
                                       bitset_t sbcset,
                                       re_charset_t *mbcset,
-                                      int *char_class_alloc,
-                                      const unsigned char *class_name,
+                                      Idx *char_class_alloc,
+                                      const char *class_name,
                                       reg_syntax_t syntax);
-#else  /* not RE_ENABLE_I18N */
-static reg_errcode_t build_equiv_class (bitset_t sbcset,
-                                        const unsigned char *name);
-static reg_errcode_t build_charclass (RE_TRANSLATE_TYPE trans,
-                                      bitset_t sbcset,
-                                      const unsigned char *class_name,
-                                      reg_syntax_t syntax);
-#endif /* not RE_ENABLE_I18N */
 static bin_tree_t *build_charclass_op (re_dfa_t *dfa,
                                        RE_TRANSLATE_TYPE trans,
-                                       const unsigned char *class_name,
-                                       const unsigned char *extra,
-                                       int non_match, reg_errcode_t *err);
+                                       const char *class_name,
+                                       const char *extra,
+                                       bool non_match, reg_errcode_t *err);
 static bin_tree_t *create_tree (re_dfa_t *dfa,
                                 bin_tree_t *left, bin_tree_t *right,
@@ -128 +118 @@
    but why not be nice?  */
 
-const char __re_error_msgid[] attribute_hidden =
+static const char __re_error_msgid[] =
   {
 #define REG_NOERROR_IDX 0
@@ -152 +142 @@
     "\0"
 #define REG_EBRACK_IDX  (REG_ESUBREG_IDX + sizeof "Invalid back reference")
-    gettext_noop ("Unmatched [ or [^")  /* REG_EBRACK */
+    gettext_noop ("Unmatched [, [^, [:, [., or [=")     /* REG_EBRACK */
     "\0"
-#define REG_EPAREN_IDX  (REG_EBRACK_IDX + sizeof "Unmatched [ or [^")
+#define REG_EPAREN_IDX  (REG_EBRACK_IDX + sizeof "Unmatched [, [^, [:, [., or [=")
     gettext_noop ("Unmatched ( or \\(") /* REG_EPAREN */
     "\0"
@@ -182 +172 @@
   };
 
-const size_t __re_error_msgid_idx[] attribute_hidden =
+static const size_t __re_error_msgid_idx[] =
   {
     REG_NOERROR_IDX,
@@ -210 +200 @@
    Returns 0 if the pattern was valid, otherwise an error string.
 
-   Assumes the `allocated' (and perhaps `buffer') and `translate' fields
+   Assumes the 'allocated' (and perhaps 'buffer') and 'translate' fields
    are set in BUFP on entry.  */
 
 const char *
-re_compile_pattern (pattern, length, bufp)
-    const char *pattern;
-    size_t length;
-    struct re_pattern_buffer *bufp;
+re_compile_pattern (const char *pattern, size_t length,
+                    struct re_pattern_buffer *bufp)
 {
   reg_errcode_t ret;
@@ -235 +223 @@
   return gettext (__re_error_msgid + __re_error_msgid_idx[(int) ret]);
 }
-#ifdef _LIBC
 weak_alias (__re_compile_pattern, re_compile_pattern)
-#endif
-
-/* Set by `re_set_syntax' to the current regexp syntax to recognize.  Can
+
+/* Set by 're_set_syntax' to the current regexp syntax to recognize.  Can
    also be assigned to arbitrarily: each pattern buffer stores its own
    syntax, so it can be changed between regex compilations.  */
@@ -255 +241 @@
 
 reg_syntax_t
-re_set_syntax (syntax)
-    reg_syntax_t syntax;
+re_set_syntax (reg_syntax_t syntax)
 {
   reg_syntax_t ret = re_syntax_options;
@@ -263 +248 @@
   return ret;
 }
-#ifdef _LIBC
 weak_alias (__re_set_syntax, re_set_syntax)
-#endif
 
 int
-re_compile_fastmap (bufp)
-    struct re_pattern_buffer *bufp;
-{
-  re_dfa_t *dfa = (re_dfa_t *) bufp->buffer;
+re_compile_fastmap (struct re_pattern_buffer *bufp)
+{
+  re_dfa_t *dfa = bufp->buffer;
   char *fastmap = bufp->fastmap;
 
@@ -285 +267 @@
   return 0;
 }
-#ifdef _LIBC
 weak_alias (__re_compile_fastmap, re_compile_fastmap)
-#endif
-
-static inline void
-__attribute ((always_inline))
-re_set_fastmap (char *fastmap, int icase, int ch)
+
+static __always_inline void
+re_set_fastmap (char *fastmap, bool icase, int ch)
 {
   fastmap[ch] = 1;
@@ -305 +284 @@
                          char *fastmap)
 {
-  re_dfa_t *dfa = (re_dfa_t *) bufp->buffer;
-  int node_cnt;
-  int icase = (dfa->mb_cur_max == 1 && (bufp->syntax & RE_ICASE));
+  re_dfa_t *dfa = bufp->buffer;
+  Idx node_cnt;
+  bool icase = (dfa->mb_cur_max == 1 && (bufp->syntax & RE_ICASE));
   for (node_cnt = 0; node_cnt < init_state->nodes.nelem; ++node_cnt)
     {
-      int node = init_state->nodes.elems[node_cnt];
+      Idx node = init_state->nodes.elems[node_cnt];
       re_token_type_t type = dfa->nodes[node].type;
 
@@ -316 +295 @@
         {
           re_set_fastmap (fastmap, icase, dfa->nodes[node].opr.c);
-#ifdef RE_ENABLE_I18N
           if ((bufp->syntax & RE_ICASE) && dfa->mb_cur_max > 1)
             {
-              unsigned char *buf = alloca (dfa->mb_cur_max), *p;
+              unsigned char buf[MB_LEN_MAX];
+              unsigned char *p;
               wchar_t wc;
               mbstate_t state;
@@ -330 +309 @@
                 *p++ = dfa->nodes[node].opr.c;
               memset (&state, '\0', sizeof (state));
-              if (mbrtowc (&wc, (const char *) buf, p - buf,
-                           &state) == p - buf
-                  && (__wcrtomb ((char *) buf, towlower (wc), &state)
+              if (__mbrtowc (&wc, (const char *) buf, p - buf,
+                             &state) == p - buf
+                  && (__wcrtomb ((char *) buf, __towlower (wc), &state)
                       != (size_t) -1))
-                re_set_fastmap (fastmap, 0, buf[0]);
+                re_set_fastmap (fastmap, false, buf[0]);
             }
-#endif
         }
       else if (type == SIMPLE_BRACKET)
@@ -350 +328 @@
             }
         }
-#ifdef RE_ENABLE_I18N
       else if (type == COMPLEX_BRACKET)
         {
-          int i;
           re_charset_t *cset = dfa->nodes[node].opr.mbcset;
-          if (cset->non_match || cset->ncoll_syms || cset->nequiv_classes
-              || cset->nranges || cset->nchar_classes)
-            {
-# ifdef _LIBC
-              if (_NL_CURRENT_WORD (LC_COLLATE, _NL_COLLATE_NRULES) != 0)
+          Idx i;
+
+#ifdef _LIBC
+          /* See if we have to try all bytes which start multiple collation
+             elements.
+             e.g. In da_DK, we want to catch 'a' since "aa" is a valid
+                  collation element, and don't catch 'b' since 'b' is
+                  the only collation element which starts from 'b' (and
+                  it is caught by SIMPLE_BRACKET).  */
+              if (_NL_CURRENT_WORD (LC_COLLATE, _NL_COLLATE_NRULES) != 0
+                  && (cset->ncoll_syms || cset->nranges))
                 {
-                  /* In this case we want to catch the bytes which are
-                     the first byte of any collation elements.
-                     e.g. In da_DK, we want to catch 'a' since "aa"
-                          is a valid collation element, and don't catch
-                          'b' since 'b' is the only collation element
-                          which starts from 'b'.  */
                   const int32_t *table = (const int32_t *)
                     _NL_CURRENT (LC_COLLATE, _NL_COLLATE_TABLEMB);
@@ -373 +349 @@
                       re_set_fastmap (fastmap, icase, i);
                 }
-# else
-              if (dfa->mb_cur_max > 1)
-                for (i = 0; i < SBC_MAX; ++i)
-                  if (__btowc (i) == WEOF)
-                    re_set_fastmap (fastmap, icase, i);
-# endif /* not _LIBC */
+#endif /* _LIBC */
+
+          /* See if we have to start the match at all multibyte characters,
+             i.e. where we would not find an invalid sequence.  This only
+             applies to multibyte character sets; for single byte character
+             sets, the SIMPLE_BRACKET again suffices.  */
+          if (dfa->mb_cur_max > 1
+              && (cset->nchar_classes || cset->non_match || cset->nranges
+#ifdef _LIBC
+                  || cset->nequiv_classes
+#endif /* _LIBC */
+                 ))
+            {
+              unsigned char c = 0;
+              do
+                {
+                  mbstate_t mbs;
+                  memset (&mbs, 0, sizeof (mbs));
+                  if (__mbrtowc (NULL, (char *) &c, 1, &mbs) == (size_t) -2)
+                    re_set_fastmap (fastmap, false, (int) c);
+                }
+              while (++c != 0);
             }
-          for (i = 0; i < cset->nmbchars; ++i)
+
+          else
             {
-              char buf[256];
-              mbstate_t state;
-              memset (&state, '\0', sizeof (state));
-              if (__wcrtomb (buf, cset->mbchars[i], &state) != (size_t) -1)
-                re_set_fastmap (fastmap, icase, *(unsigned char *) buf);
-              if ((bufp->syntax & RE_ICASE) && dfa->mb_cur_max > 1)
+              /* ... Else catch all bytes which can start the mbchars.  */
+              for (i = 0; i < cset->nmbchars; ++i)
                 {
-                  if (__wcrtomb (buf, towlower (cset->mbchars[i]), &state)
-                      != (size_t) -1)
-                    re_set_fastmap (fastmap, 0, *(unsigned char *) buf);
+                  char buf[256];
+                  mbstate_t state;
+                  memset (&state, '\0', sizeof (state));
+                  if (__wcrtomb (buf, cset->mbchars[i], &state) != (size_t) -1)
+                    re_set_fastmap (fastmap, icase, *(unsigned char *) buf);
+                  if ((bufp->syntax & RE_ICASE) && dfa->mb_cur_max > 1)
+                    {
+                      if (__wcrtomb (buf, __towlower (cset->mbchars[i]), &state)
+                          != (size_t) -1)
+                        re_set_fastmap (fastmap, false, *(unsigned char *) buf);
+                    }
                 }
             }
         }
-#endif /* RE_ENABLE_I18N */
-      else if (type == OP_PERIOD
-#ifdef RE_ENABLE_I18N
-               || type == OP_UTF8_PERIOD
-#endif /* RE_ENABLE_I18N */
-               || type == END_OF_RE)
+      else if (type == OP_PERIOD || type == OP_UTF8_PERIOD || type == END_OF_RE)
         {
           memset (fastmap, '\1', sizeof (char) * SBC_MAX);
@@ -417 +409 @@
    since POSIX says we shouldn't.  Thus, we set
 
-     `buffer' to the compiled pattern;
-     `used' to the length of the compiled pattern;
-     `syntax' to RE_SYNTAX_POSIX_EXTENDED if the
+     'buffer' to the compiled pattern;
+     'used' to the length of the compiled pattern;
+     'syntax' to RE_SYNTAX_POSIX_EXTENDED if the
        REG_EXTENDED bit in CFLAGS is set; otherwise, to
        RE_SYNTAX_POSIX_BASIC;
-     `newline_anchor' to REG_NEWLINE being set in CFLAGS;
-     `fastmap' to an allocated space for the fastmap;
-     `fastmap_accurate' to zero;
-     `re_nsub' to the number of subexpressions in PATTERN.
+     'newline_anchor' to REG_NEWLINE being set in CFLAGS;
+     'fastmap' to an allocated space for the fastmap;
+     'fastmap_accurate' to zero;
+     're_nsub' to the number of subexpressions in PATTERN.
 
    PATTERN is the address of the pattern string.
@@ -448 +440 @@
 
 int
-regcomp (preg, pattern, cflags)
-    regex_t *__restrict preg;
-    const char *__restrict pattern;
-    int cflags;
+regcomp (regex_t *__restrict preg, const char *__restrict pattern, int cflags)
 {
   reg_errcode_t ret;
@@ -463 +452 @@
   /* Try to allocate space for the fastmap.  */
   preg->fastmap = re_malloc (char, SBC_MAX);
-  if (BE (preg->fastmap == NULL, 0))
+  if (__glibc_unlikely (preg->fastmap == NULL))
     return REG_ESPACE;
 
@@ -489 +478 @@
 
   /* We have already checked preg->fastmap != NULL.  */
-  if (BE (ret == REG_NOERROR, 1))
+  if (__glibc_likely (ret == REG_NOERROR))
     /* Compute the fastmap now, since regexec cannot modify the pattern
        buffer.  This function never fails in this implementation.  */
@@ -502 +491 @@
   return (int) ret;
 }
-#ifdef _LIBC
+libc_hidden_def (__regcomp)
 weak_alias (__regcomp, regcomp)
-#endif
 
 /* Returns a message corresponding to an error code, ERRCODE, returned
@@ -510 +498 @@
 
 size_t
-regerror (errcode, preg, errbuf, errbuf_size)
-    int errcode;
-    const regex_t *__restrict preg;
-    char *__restrict errbuf;
-    size_t errbuf_size;
+regerror (int errcode, const regex_t *__restrict preg, char *__restrict errbuf,
+          size_t errbuf_size)
 {
   const char *msg;
   size_t msg_size;
-
-  if (BE (errcode < 0
-          || errcode >= (int) (sizeof (__re_error_msgid_idx)
-                               / sizeof (__re_error_msgid_idx[0])), 0))
+  int nerrcodes = sizeof __re_error_msgid_idx / sizeof __re_error_msgid_idx[0];
+
+  if (__glibc_unlikely (errcode < 0 || errcode >= nerrcodes))
     /* Only error codes returned by the rest of the code should be passed
        to this routine.  If we are given anything else, or if other regex
@@ -532 +516 @@
   msg_size = strlen (msg) + 1; /* Includes the null.  */
 
-  if (BE (errbuf_size != 0, 1))
-    {
-      if (BE (msg_size > errbuf_size, 0))
-        {
-#if defined HAVE_MEMPCPY || defined _LIBC
-          *((char *) __mempcpy (errbuf, msg, errbuf_size - 1)) = '\0';
-#else
-          memcpy (errbuf, msg, errbuf_size - 1);
-          errbuf[errbuf_size - 1] = 0;
-#endif
-        }
-      else
-        memcpy (errbuf, msg, msg_size);
+  if (__glibc_likely (errbuf_size != 0))
+    {
+      size_t cpy_size = msg_size;
+      if (__glibc_unlikely (msg_size > errbuf_size))
+        {
+          cpy_size = errbuf_size - 1;
+          errbuf[cpy_size] = '\0';
+        }
+      memcpy (errbuf, msg, cpy_size);
     }
 
   return msg_size;
 }
-#ifdef _LIBC
 weak_alias (__regerror, regerror)
-#endif
-
-
-#ifdef RE_ENABLE_I18N
+
+
 /* This static array is used for the map to single-byte characters when
    UTF-8 is used.  Otherwise we would allocate memory just to initialize
@@ -562 +539 @@
 {
     /* Set the first 128 bits.  */
-#ifdef _MSC_VER
-  BITSET_WORD_MAX, BITSET_WORD_MAX, BITSET_WORD_MAX, BITSET_WORD_MAX, 0, 0, 0, 0
+#if (defined __GNUC__ || __clang_major__ >= 4) && !defined __STRICT_ANSI__
+  [0 ... 0x80 / BITSET_WORD_BITS - 1] = BITSET_WORD_MAX
 #else
-  [0 ... 0x80 / BITSET_WORD_BITS - 1] = BITSET_WORD_MAX
+# if 4 * BITSET_WORD_BITS < ASCII_CHARS
+#  error "bitset_word_t is narrower than 32 bits"
+# elif 3 * BITSET_WORD_BITS < ASCII_CHARS
+  BITSET_WORD_MAX, BITSET_WORD_MAX, BITSET_WORD_MAX,
+# elif 2 * BITSET_WORD_BITS < ASCII_CHARS
+  BITSET_WORD_MAX, BITSET_WORD_MAX,
+# elif 1 * BITSET_WORD_BITS < ASCII_CHARS
+  BITSET_WORD_MAX,
+# endif
+  (BITSET_WORD_MAX
+   >> (SBC_MAX % BITSET_WORD_BITS == 0
+       ? 0
+       : BITSET_WORD_BITS - SBC_MAX % BITSET_WORD_BITS))
 #endif
 };
-#endif
 
 
@@ -574 +562 @@
 free_dfa_content (re_dfa_t *dfa)
 {
-  int i, j;
+  Idx i, j;
 
   if (dfa->nodes)
@@ -603 +591 @@
             free_state (state);
           }
-        re_free (entry->array);
+        re_free (entry->array);
       }
   re_free (dfa->state_table);
-#ifdef RE_ENABLE_I18N
   if (dfa->sb_char != utf8_sb_map)
     re_free (dfa->sb_char);
-#endif
   re_free (dfa->subexp_map);
 #ifdef DEBUG
@@ -622 +608 @@
 
 void
-regfree (preg)
-    regex_t *preg;
-{
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
-  if (BE (dfa != NULL, 1))
-    free_dfa_content (dfa);
+regfree (regex_t *preg)
+{
+  re_dfa_t *dfa = preg->buffer;
+  if (__glibc_likely (dfa != NULL))
+    {
+      lock_fini (dfa->lock);
+      free_dfa_content (dfa);
+    }
   preg->buffer = NULL;
   preg->allocated = 0;
@@ -637 +625 @@
   preg->translate = NULL;
 }
-#ifdef _LIBC
+libc_hidden_def (__regfree)
 weak_alias (__regfree, regfree)
-#endif
 
 
@@ -657 +644 @@
 weak_function
 # endif
-re_comp (s)
-     const char *s;
+re_comp (const char *s)
 {
   reg_errcode_t ret;
@@ -681 +667 @@
   if (re_comp_buf.fastmap == NULL)
     {
-      re_comp_buf.fastmap = (char *) malloc (SBC_MAX);
+      re_comp_buf.fastmap = re_malloc (char, SBC_MAX);
       if (re_comp_buf.fastmap == NULL)
         return (char *) gettext (__re_error_msgid
@@ -687 +673 @@
     }
 
-  /* Since `re_exec' always passes NULL for the `regs' argument, we
+  /* Since 're_exec' always passes NULL for the 'regs' argument, we
      don't need to initialize the pattern buffer fields which affect it.  */
 
@@ -698 +684 @@
     return NULL;
 
-  /* Yes, we're discarding `const' here if !HAVE_LIBINTL.  */
+  /* Yes, we're discarding 'const' here if !HAVE_LIBINTL.  */
   return (char *) gettext (__re_error_msgid + __re_error_msgid_idx[(int) ret]);
 }
@@ -734 +720 @@
 
   /* Initialize the dfa.  */
-  dfa = (re_dfa_t *) preg->buffer;
-  if (BE (preg->allocated < sizeof (re_dfa_t), 0))
+  dfa = preg->buffer;
+  if (__glibc_unlikely (preg->allocated < sizeof (re_dfa_t)))
     {
       /* If zero allocated, but buffer is non-null, try to realloc
@@ -745 +731 @@
         return REG_ESPACE;
       preg->allocated = sizeof (re_dfa_t);
-      preg->buffer = (unsigned char *) dfa;
+      preg->buffer = dfa;
     }
   preg->used = sizeof (re_dfa_t);
 
   err = init_dfa (dfa, length);
-  if (BE (err != REG_NOERROR, 0))
+  if (__glibc_unlikely (err == REG_NOERROR && lock_init (dfa->lock) != 0))
+    err = REG_ESPACE;
+  if (__glibc_unlikely (err != REG_NOERROR))
     {
       free_dfa_content (dfa);
@@ -763 +751 @@
 #endif
 
-  __libc_lock_init (dfa->lock);
-
   err = re_string_construct (&regexp, pattern, length, preg->translate,
-                             syntax & RE_ICASE, dfa);
-  if (BE (err != REG_NOERROR, 0))
+                             (syntax & RE_ICASE) != 0, dfa);
+  if (__glibc_unlikely (err != REG_NOERROR))
     {
     re_compile_internal_free_return:
       free_workarea_compile (preg);
       re_string_destruct (&regexp);
+      lock_fini (dfa->lock);
       free_dfa_content (dfa);
       preg->buffer = NULL;
@@ -781 +768 @@
   preg->re_nsub = 0;
   dfa->str_tree = parse (&regexp, preg, syntax, &err);
-  if (BE (dfa->str_tree == NULL, 0))
+  if (__glibc_unlikely (dfa->str_tree == NULL))
     goto re_compile_internal_free_return;
 
   /* Analyze the tree and create the nfa.  */
   err = analyze (preg);
-  if (BE (err != REG_NOERROR, 0))
+  if (__glibc_unlikely (err != REG_NOERROR))
     goto re_compile_internal_free_return;
 
-#ifdef RE_ENABLE_I18N
   /* If possible, do searching in single byte encoding to speed things up.  */
   if (dfa->is_utf8 && !(syntax & RE_ICASE) && preg->translate == NULL)
     optimize_utf8 (dfa);
-#endif
 
   /* Then create the initial state of the dfa.  */
@@ -802 +787 @@
   re_string_destruct (&regexp);
 
-  if (BE (err != REG_NOERROR, 0))
-    {
+  if (__glibc_unlikely (err != REG_NOERROR))
+    {
+      lock_fini (dfa->lock);
       free_dfa_content (dfa);
       preg->buffer = NULL;
@@ -818 +804 @@
 init_dfa (re_dfa_t *dfa, size_t pat_len)
 {
-  unsigned int table_size;
+  __re_size_t table_size;
 #ifndef _LIBC
-  char *codeset_name;
+  const char *codeset_name;
 #endif
+  size_t max_i18n_object_size = MAX (sizeof (wchar_t), sizeof (wctype_t));
+  size_t max_object_size =
+    MAX (sizeof (struct re_state_table_entry),
+         MAX (sizeof (re_token_t),
+              MAX (sizeof (re_node_set),
+                   MAX (sizeof (regmatch_t),
+                        max_i18n_object_size))));
 
   memset (dfa, '\0', sizeof (re_dfa_t));
@@ -828 +821 @@
   dfa->str_tree_storage_idx = BIN_TREE_STORAGE_SIZE;
 
-  /* Avoid overflows.  */
-  if (pat_len == SIZE_MAX)
+  /* Avoid overflows.  The extra "/ 2" is for the table_size doubling
+     calculation below, and for similar doubling calculations
+     elsewhere.  And it's <= rather than <, because some of the
+     doubling calculations add 1 afterwards.  */
+  if (__glibc_unlikely (MIN (IDX_MAX, SIZE_MAX / max_object_size) / 2
+                        <= pat_len))
     return REG_ESPACE;
 
@@ -855 +852 @@
   if (get_crt_codepage() == MY_CP_UTF8)
 # else
-#  ifdef HAVE_LANGINFO_CODESET
   codeset_name = nl_langinfo (CODESET);
-#  else
-  codeset_name = getenv ("LC_ALL");
-  if (codeset_name == NULL || codeset_name[0] == '\0')
-    codeset_name = getenv ("LC_CTYPE");
-  if (codeset_name == NULL || codeset_name[0] == '\0')
-    codeset_name = getenv ("LANG");
-  if (codeset_name == NULL)
-    codeset_name = "";
-  else if (strchr (codeset_name, '.') !=  NULL)
-    codeset_name = strchr (codeset_name, '.') + 1;
-#  endif
-
-  if (strcasecmp (codeset_name, "UTF-8") == 0
-      || strcasecmp (codeset_name, "UTF8") == 0)
+  if ((codeset_name[0] == 'U' || codeset_name[0] == 'u')
+      && (codeset_name[1] == 'T' || codeset_name[1] == 't')
+      && (codeset_name[2] == 'F' || codeset_name[2] == 'f')
+      && strcmp (codeset_name + 3 + (codeset_name[3] == '-'), "8") == 0)
 # endif
     dfa->is_utf8 = 1;
@@ -879 +865 @@
 #endif
 
-#ifdef RE_ENABLE_I18N
   if (dfa->mb_cur_max > 1)
     {
@@ -889 +874 @@
 
           dfa->sb_char = (re_bitset_ptr_t) calloc (sizeof (bitset_t), 1);
-          if (BE (dfa->sb_char == NULL, 0))
+          if (__glibc_unlikely (dfa->sb_char == NULL))
             return REG_ESPACE;
 
@@ -899 +884 @@
                 if (wch != WEOF)
                   dfa->sb_char[i] |= (bitset_word_t) 1 << j;
-# ifndef _LIBC
+#ifndef _LIBC
                 if (isascii (ch) && wch != ch)
                   dfa->map_notascii = 1;
-# endif
+#endif
               }
         }
     }
-#endif
-
-  if (BE (dfa->nodes == NULL || dfa->state_table == NULL, 0))
+
+  if (__glibc_unlikely (dfa->nodes == NULL || dfa->state_table == NULL))
     return REG_ESPACE;
   return REG_NOERROR;
@@ -918 +902 @@
 
 static void
-internal_function
 init_word_char (re_dfa_t *dfa)
 {
-  int i, j, ch;
+  int i = 0;
+  int j;
+  int ch = 0;
   dfa->word_ops_used = 1;
-  for (i = 0, ch = 0; i < BITSET_WORDS; ++i)
+  if (__glibc_likely (dfa->map_notascii == 0))
+    {
+      bitset_word_t bits0 = 0x00000000;
+      bitset_word_t bits1 = 0x03ff0000;
+      bitset_word_t bits2 = 0x87fffffe;
+      bitset_word_t bits3 = 0x07fffffe;
+      if (BITSET_WORD_BITS == 64)
+        {
+          /* Pacify gcc -Woverflow on 32-bit platformns.  */
+          dfa->word_char[0] = bits1 << 31 << 1 | bits0;
+          dfa->word_char[1] = bits3 << 31 << 1 | bits2;
+          i = 2;
+        }
+      else if (BITSET_WORD_BITS == 32)
+        {
+          dfa->word_char[0] = bits0;
+          dfa->word_char[1] = bits1;
+          dfa->word_char[2] = bits2;
+          dfa->word_char[3] = bits3;
+          i = 4;
+        }
+      else
+        goto general_case;
+      ch = 128;
+
+      if (__glibc_likely (dfa->is_utf8))
+        {
+          memset (&dfa->word_char[i], '\0', (SBC_MAX - ch) / 8);
+          return;
+        }
+    }
+
+ general_case:
+  for (; i < BITSET_WORDS; ++i)
     for (j = 0; j < BITSET_WORD_BITS; ++j, ++ch)
       if (isalnum (ch) || ch == '_')
@@ -934 +952 @@
 free_workarea_compile (regex_t *preg)
 {
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+  re_dfa_t *dfa = preg->buffer;
   bin_tree_storage_t *storage, *next;
   for (storage = dfa->str_tree_storage; storage; storage = next)
@@ -953 +971 @@
 create_initial_state (re_dfa_t *dfa)
 {
-  int first, i;
+  Idx first, i;
   reg_errcode_t err;
   re_node_set init_nodes;
@@ -962 +980 @@
   dfa->init_node = first;
   err = re_node_set_init_copy (&init_nodes, dfa->eclosures + first);
-  if (BE (err != REG_NOERROR, 0))
+  if (__glibc_unlikely (err != REG_NOERROR))
     return err;
 
@@ -972 +990 @@
     for (i = 0; i < init_nodes.nelem; ++i)
       {
-        int node_idx = init_nodes.elems[i];
+        Idx node_idx = init_nodes.elems[i];
         re_token_type_t type = dfa->nodes[node_idx].type;
 
-        int clexp_idx;
+        Idx clexp_idx;
         if (type != OP_BACK_REF)
           continue;
@@ -991 +1009 @@
         if (type == OP_BACK_REF)
           {
-            int dest_idx = dfa->edests[node_idx].elems[0];
+            Idx dest_idx = dfa->edests[node_idx].elems[0];
             if (!re_node_set_contains (&init_nodes, dest_idx))
               {
-                re_node_set_merge (&init_nodes, dfa->eclosures + dest_idx);
+                reg_errcode_t merge_err
+                  = re_node_set_merge (&init_nodes, dfa->eclosures + dest_idx);
+                if (merge_err != REG_NOERROR)
+                  return merge_err;
                 i = 0;
               }
@@ -1003 +1024 @@
   dfa->init_state = re_acquire_state_context (&err, dfa, &init_nodes, 0);
   /* We don't check ERR here, since the initial state must not be NULL.  */
-  if (BE (dfa->init_state == NULL, 0))
+  if (__glibc_unlikely (dfa->init_state == NULL))
     return err;
   if (dfa->init_state->has_constraint)
@@ -1015 +1036 @@
                                                          CONTEXT_NEWLINE
                                                          | CONTEXT_BEGBUF);
-      if (BE (dfa->init_state_word == NULL || dfa->init_state_nl == NULL
-              || dfa->init_state_begbuf == NULL, 0))
+      if (__glibc_unlikely (dfa->init_state_word == NULL
+                            || dfa->init_state_nl == NULL
+                            || dfa->init_state_begbuf == NULL))
         return err;
     }
@@ -1028 +1050 @@
 
 
-#ifdef RE_ENABLE_I18N
 /* If it is possible to do searching in single byte encoding instead of UTF-8
    to speed things up, set dfa->mb_cur_max to 1, clear is_utf8 and change
@@ -1036 +1057 @@
 optimize_utf8 (re_dfa_t *dfa)
 {
-  int node, i, mb_chars = 0, has_period = 0;
+  Idx node;
+  int i;
+  bool mb_chars = false;
+  bool has_period = false;
 
   for (node = 0; node < dfa->nodes_len; ++node)
@@ -1042 +1066 @@
       {
       case CHARACTER:
-        if (dfa->nodes[node].opr.c >= 0x80)
-          mb_chars = 1;
+        if (dfa->nodes[node].opr.c >= ASCII_CHARS)
+          mb_chars = true;
         break;
       case ANCHOR:
-        switch (dfa->nodes[node].opr.idx)
+        switch (dfa->nodes[node].opr.ctx_type)
           {
           case LINE_FIRST:
@@ -1054 +1078 @@
             break;
           default:
-            /* Word anchors etc. cannot be handled.  */
+            /* Word anchors etc. cannot be handled.  It's okay to test
+               opr.ctx_type since constraints (for all DFA nodes) are
+               created by ORing one or more opr.ctx_type values.  */
             return;
           }
         break;
       case OP_PERIOD:
-        has_period = 1;
-        break;
+        has_period = true;
+        break;
       case OP_BACK_REF:
       case OP_ALT:
@@ -1071 +1097 @@
         return;
       case SIMPLE_BRACKET:
-        /* Just double check.  The non-ASCII range starts at 0x80.  */
-        assert (0x80 % BITSET_WORD_BITS == 0);
-        for (i = 0x80 / BITSET_WORD_BITS; i < BITSET_WORDS; ++i)
-          if (dfa->nodes[node].opr.sbcset[i])
-            return;
+        /* Just double check.  */
+        {
+          int rshift = (ASCII_CHARS % BITSET_WORD_BITS == 0
+                        ? 0
+                        : BITSET_WORD_BITS - ASCII_CHARS % BITSET_WORD_BITS);
+          for (i = ASCII_CHARS / BITSET_WORD_BITS; i < BITSET_WORDS; ++i)
+            {
+              if (dfa->nodes[node].opr.sbcset[i] >> rshift != 0)
+                return;
+              rshift = 0;
+            }
+        }
         break;
       default:
@@ -1085 +1118 @@
       {
         if (dfa->nodes[node].type == CHARACTER
-            && dfa->nodes[node].opr.c >= 0x80)
+            && dfa->nodes[node].opr.c >= ASCII_CHARS)
           dfa->nodes[node].mb_partial = 0;
         else if (dfa->nodes[node].type == OP_PERIOD)
@@ -1096 +1129 @@
   dfa->has_mb_node = dfa->nbackref > 0 || has_period;
 }
-#endif
 
 
@@ -1105 +1137 @@
 analyze (regex_t *preg)
 {
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+  re_dfa_t *dfa = preg->buffer;
   reg_errcode_t ret;
 
   /* Allocate arrays.  */
-  dfa->nexts = re_malloc (int, dfa->nodes_alloc);
-  dfa->org_indices = re_malloc (int, dfa->nodes_alloc);
+  dfa->nexts = re_malloc (Idx, dfa->nodes_alloc);
+  dfa->org_indices = re_malloc (Idx, dfa->nodes_alloc);
   dfa->edests = re_malloc (re_node_set, dfa->nodes_alloc);
   dfa->eclosures = re_malloc (re_node_set, dfa->nodes_alloc);
-  if (BE (dfa->nexts == NULL || dfa->org_indices == NULL || dfa->edests == NULL
-          || dfa->eclosures == NULL, 0))
+  if (__glibc_unlikely (dfa->nexts == NULL || dfa->org_indices == NULL
+                        || dfa->edests == NULL || dfa->eclosures == NULL))
     return REG_ESPACE;
 
-  dfa->subexp_map = re_malloc (int, preg->re_nsub);
+  dfa->subexp_map = re_malloc (Idx, preg->re_nsub);
   if (dfa->subexp_map != NULL)
     {
-      int i;
+      Idx i;
       for (i = 0; i < preg->re_nsub; i++)
         dfa->subexp_map[i] = i;
@@ -1129 +1161 @@
       if (i == preg->re_nsub)
         {
-          free (dfa->subexp_map);
+          re_free (dfa->subexp_map);
           dfa->subexp_map = NULL;
         }
@@ -1135 +1167 @@
 
   ret = postorder (dfa->str_tree, lower_subexps, preg);
-  if (BE (ret != REG_NOERROR, 0))
+  if (__glibc_unlikely (ret != REG_NOERROR))
     return ret;
   ret = postorder (dfa->str_tree, calc_first, dfa);
-  if (BE (ret != REG_NOERROR, 0))
+  if (__glibc_unlikely (ret != REG_NOERROR))
     return ret;
   preorder (dfa->str_tree, calc_next, dfa);
   ret = preorder (dfa->str_tree, link_nfa_nodes, dfa);
-  if (BE (ret != REG_NOERROR, 0))
+  if (__glibc_unlikely (ret != REG_NOERROR))
     return ret;
   ret = calc_eclosure (dfa);
-  if (BE (ret != REG_NOERROR, 0))
+  if (__glibc_unlikely (ret != REG_NOERROR))
     return ret;
 
@@ -1154 +1186 @@
     {
       dfa->inveclosures = re_malloc (re_node_set, dfa->nodes_len);
-      if (BE (dfa->inveclosures == NULL, 0))
-        return REG_ESPACE;
+      if (__glibc_unlikely (dfa->inveclosures == NULL))
+        return REG_ESPACE;
       ret = calc_inveclosure (dfa);
     }
@@ -1177 +1209 @@
       while (node->left || node->right)
         if (node->left)
-          node = node->left;
-        else
-          node = node->right;
+          node = node->left;
+        else
+          node = node->right;
 
       do
         {
           reg_errcode_t err = fn (extra, node);
-          if (BE (err != REG_NOERROR, 0))
+          if (__glibc_unlikely (err != REG_NOERROR))
             return err;
-          if (node->parent == NULL)
+          if (node->parent == NULL)
             return REG_NOERROR;
           prev = node;
@@ -1206 +1238 @@
     {
       reg_errcode_t err = fn (extra, node);
-      if (BE (err != REG_NOERROR, 0))
+      if (__glibc_unlikely (err != REG_NOERROR))
         return err;
 
@@ -1220 +1252 @@
               node = node->parent;
               if (!node)
-                return REG_NOERROR;
+                return REG_NOERROR;
             }
           node = node->right;
@@ -1243 +1275 @@
 
   else if (node->token.type == SUBEXP
-           && node->left && node->left->token.type == SUBEXP)
-    {
-      int other_idx = node->left->token.opr.idx;
+           && node->left && node->left->token.type == SUBEXP)
+    {
+      Idx other_idx = node->left->token.opr.idx;
 
       node->left = node->left->left;
       if (node->left)
-        node->left->parent = node;
+        node->left->parent = node;
 
       dfa->subexp_map[other_idx] = dfa->subexp_map[node->token.opr.idx];
       if (other_idx < BITSET_WORD_BITS)
-          dfa->used_bkref_map &= ~((bitset_word_t) 1 << other_idx);
+        dfa->used_bkref_map &= ~((bitset_word_t) 1 << other_idx);
     }
 
@@ -1286 +1318 @@
 lower_subexp (reg_errcode_t *err, regex_t *preg, bin_tree_t *node)
 {
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+  re_dfa_t *dfa = preg->buffer;
   bin_tree_t *body = node->left;
   bin_tree_t *op, *cls, *tree1, *tree;
@@ -1307 +1339 @@
   tree1 = body ? create_tree (dfa, body, cls, CONCAT) : cls;
   tree = create_tree (dfa, op, tree1, CONCAT);
-  if (BE (tree == NULL || tree1 == NULL || op == NULL || cls == NULL, 0))
+  if (__glibc_unlikely (tree == NULL || tree1 == NULL
+                        || op == NULL || cls == NULL))
     {
       *err = REG_ESPACE;
@@ -1333 +1366 @@
       node->first = node;
       node->node_idx = re_dfa_add_node (dfa, node->token);
-      if (BE (node->node_idx == -1, 0))
-        return REG_ESPACE;
+      if (__glibc_unlikely (node->node_idx == -1))
+        return REG_ESPACE;
+      if (node->token.type == ANCHOR)
+        dfa->nodes[node->node_idx].constraint = node->token.opr.ctx_type;
     }
   return REG_NOERROR;
@@ -1356 +1391 @@
         node->left->next = node->next;
       if (node->right)
-        node->right->next = node->next;
+        node->right->next = node->next;
       break;
     }
@@ -1367 +1402 @@
 {
   re_dfa_t *dfa = (re_dfa_t *) extra;
-  int idx = node->node_idx;
+  Idx idx = node->node_idx;
   reg_errcode_t err = REG_NOERROR;
 
@@ -1376 +1411 @@
 
     case END_OF_RE:
-      assert (node->next == NULL);
+      DEBUG_ASSERT (node->next == NULL);
       break;
 
@@ -1382 +1417 @@
     case OP_ALT:
       {
-        int left, right;
+        Idx left, right;
         dfa->has_plural_match = 1;
         if (node->left != NULL)
@@ -1392 +1427 @@
         else
           right = node->next->node_idx;
-        assert (left > -1);
-        assert (right > -1);
+        DEBUG_ASSERT (left > -1);
+        DEBUG_ASSERT (right > -1);
         err = re_node_set_init_2 (dfa->edests + idx, left, right);
       }
@@ -1407 +1442 @@
       dfa->nexts[idx] = node->next->node_idx;
       if (node->token.type == OP_BACK_REF)
-        re_node_set_init_1 (dfa->edests + idx, dfa->nexts[idx]);
+        err = re_node_set_init_1 (dfa->edests + idx, dfa->nexts[idx]);
       break;
 
     default:
-      assert (!IS_EPSILON_NODE (node->token.type));
+      DEBUG_ASSERT (!IS_EPSILON_NODE (node->token.type));
       dfa->nexts[idx] = node->next->node_idx;
       break;
@@ -1424 +1459 @@
 
 static reg_errcode_t
-internal_function
-duplicate_node_closure (re_dfa_t *dfa, int top_org_node, int top_clone_node,
-                        int root_node, unsigned int init_constraint)
-{
-  int org_node, clone_node, ret;
+duplicate_node_closure (re_dfa_t *dfa, Idx top_org_node, Idx top_clone_node,
+                        Idx root_node, unsigned int init_constraint)
+{
+  Idx org_node, clone_node;
+  bool ok;
   unsigned int constraint = init_constraint;
   for (org_node = top_org_node, clone_node = top_clone_node;;)
     {
-      int org_dest, clone_dest;
+      Idx org_dest, clone_dest;
       if (dfa->nodes[org_node].type == OP_BACK_REF)
         {
@@ -1442 +1477 @@
           re_node_set_empty (dfa->edests + clone_node);
           clone_dest = duplicate_node (dfa, org_dest, constraint);
-          if (BE (clone_dest == -1, 0))
+          if (__glibc_unlikely (clone_dest == -1))
             return REG_ESPACE;
           dfa->nexts[clone_node] = dfa->nexts[org_node];
-          ret = re_node_set_insert (dfa->edests + clone_node, clone_dest);
-          if (BE (ret < 0, 0))
+          ok = re_node_set_insert (dfa->edests + clone_node, clone_dest);
+          if (__glibc_unlikely (! ok))
             return REG_ESPACE;
         }
@@ -1463 +1498 @@
           org_dest = dfa->edests[org_node].elems[0];
           re_node_set_empty (dfa->edests + clone_node);
-          if (dfa->nodes[org_node].type == ANCHOR)
+          /* If the node is root_node itself, it means the epsilon closure
+             has a loop.  Then tie it to the destination of the root_node.  */
+          if (org_node == root_node && clone_node != org_node)
             {
-              /* In case of the node has another constraint, append it.  */
-              if (org_node == root_node && clone_node != org_node)
-                {
-                  /* ...but if the node is root_node itself, it means the
-                     epsilon closure have a loop, then tie it to the
-                     destination of the root_node.  */
-                  ret = re_node_set_insert (dfa->edests + clone_node,
-                                            org_dest);
-                  if (BE (ret < 0, 0))
-                    return REG_ESPACE;
-                  break;
-                }
-              constraint |= dfa->nodes[org_node].opr.ctx_type;
+              ok = re_node_set_insert (dfa->edests + clone_node, org_dest);
+              if (__glibc_unlikely (! ok))
+                return REG_ESPACE;
+              break;
             }
+          /* In case the node has another constraint, append it.  */
+          constraint |= dfa->nodes[org_node].constraint;
           clone_dest = duplicate_node (dfa, org_dest, constraint);
-          if (BE (clone_dest == -1, 0))
+          if (__glibc_unlikely (clone_dest == -1))
             return REG_ESPACE;
-          ret = re_node_set_insert (dfa->edests + clone_node, clone_dest);
-          if (BE (ret < 0, 0))
+          ok = re_node_set_insert (dfa->edests + clone_node, clone_dest);
+          if (__glibc_unlikely (! ok))
             return REG_ESPACE;
         }
@@ -1496 +1526 @@
           if (clone_dest == -1)
             {
-              /* There are no such a duplicated node, create a new one.  */
+              /* There is no such duplicated node, create a new one.  */
               reg_errcode_t err;
               clone_dest = duplicate_node (dfa, org_dest, constraint);
-              if (BE (clone_dest == -1, 0))
+              if (__glibc_unlikely (clone_dest == -1))
                 return REG_ESPACE;
-              ret = re_node_set_insert (dfa->edests + clone_node, clone_dest);
-              if (BE (ret < 0, 0))
+              ok = re_node_set_insert (dfa->edests + clone_node, clone_dest);
+              if (__glibc_unlikely (! ok))
                 return REG_ESPACE;
               err = duplicate_node_closure (dfa, org_dest, clone_dest,
                                             root_node, constraint);
-              if (BE (err != REG_NOERROR, 0))
+              if (__glibc_unlikely (err != REG_NOERROR))
                 return err;
             }
           else
             {
-              /* There are a duplicated node which satisfy the constraint,
+              /* There is a duplicated node which satisfies the constraint,
                  use it to avoid infinite loop.  */
-              ret = re_node_set_insert (dfa->edests + clone_node, clone_dest);
-              if (BE (ret < 0, 0))
+              ok = re_node_set_insert (dfa->edests + clone_node, clone_dest);
+              if (__glibc_unlikely (! ok))
                 return REG_ESPACE;
             }
@@ -1520 +1550 @@
           org_dest = dfa->edests[org_node].elems[1];
           clone_dest = duplicate_node (dfa, org_dest, constraint);
-          if (BE (clone_dest == -1, 0))
+          if (__glibc_unlikely (clone_dest == -1))
             return REG_ESPACE;
-          ret = re_node_set_insert (dfa->edests + clone_node, clone_dest);
-          if (BE (ret < 0, 0))
+          ok = re_node_set_insert (dfa->edests + clone_node, clone_dest);
+          if (__glibc_unlikely (! ok))
             return REG_ESPACE;
         }
@@ -1535 +1565 @@
    satisfies the constraint CONSTRAINT.  */
 
-static int
-search_duplicated_node (const re_dfa_t *dfa, int org_node,
+static Idx
+search_duplicated_node (const re_dfa_t *dfa, Idx org_node,
                         unsigned int constraint)
 {
-  int idx;
+  Idx idx;
   for (idx = dfa->nodes_len - 1; dfa->nodes[idx].duplicated && idx > 0; --idx)
     {
@@ -1553 +1583 @@
    available.  */
 
-static int
-duplicate_node (re_dfa_t *dfa, int org_idx, unsigned int constraint)
-{
-  int dup_idx = re_dfa_add_node (dfa, dfa->nodes[org_idx]);
-  if (BE (dup_idx != -1, 1))
+static Idx
+duplicate_node (re_dfa_t *dfa, Idx org_idx, unsigned int constraint)
+{
+  Idx dup_idx = re_dfa_add_node (dfa, dfa->nodes[org_idx]);
+  if (__glibc_likely (dup_idx != -1))
     {
       dfa->nodes[dup_idx].constraint = constraint;
-      if (dfa->nodes[org_idx].type == ANCHOR)
-        dfa->nodes[dup_idx].constraint |= dfa->nodes[org_idx].opr.ctx_type;
+      dfa->nodes[dup_idx].constraint |= dfa->nodes[org_idx].constraint;
       dfa->nodes[dup_idx].duplicated = 1;
 
@@ -1573 +1602 @@
 calc_inveclosure (re_dfa_t *dfa)
 {
-  int src, idx, ret;
+  Idx src, idx;
+  bool ok;
   for (idx = 0; idx < dfa->nodes_len; ++idx)
     re_node_set_init_empty (dfa->inveclosures + idx);
@@ -1579 +1609 @@
   for (src = 0; src < dfa->nodes_len; ++src)
     {
-      int *elems = dfa->eclosures[src].elems;
+      Idx *elems = dfa->eclosures[src].elems;
       for (idx = 0; idx < dfa->eclosures[src].nelem; ++idx)
         {
-          ret = re_node_set_insert_last (dfa->inveclosures + elems[idx], src);
-          if (BE (ret == -1, 0))
+          ok = re_node_set_insert_last (dfa->inveclosures + elems[idx], src);
+          if (__glibc_unlikely (! ok))
             return REG_ESPACE;
         }
@@ -1596 +1626 @@
 calc_eclosure (re_dfa_t *dfa)
 {
-  int node_idx, incomplete;
-#ifdef DEBUG
-  assert (dfa->nodes_len > 0);
-#endif
-  incomplete = 0;
+  Idx node_idx;
+  bool incomplete;
+  DEBUG_ASSERT (dfa->nodes_len > 0);
+  incomplete = false;
   /* For each nodes, calculate epsilon closure.  */
   for (node_idx = 0; ; ++node_idx)
@@ -1610 +1639 @@
           if (!incomplete)
             break;
-          incomplete = 0;
+          incomplete = false;
           node_idx = 0;
         }
 
-#ifdef DEBUG
-      assert (dfa->eclosures[node_idx].nelem != -1);
-#endif
+      DEBUG_ASSERT (dfa->eclosures[node_idx].nelem != -1);
 
       /* If we have already calculated, skip it.  */
       if (dfa->eclosures[node_idx].nelem != 0)
         continue;
-      /* Calculate epsilon closure of `node_idx'.  */
-      err = calc_eclosure_iter (&eclosure_elem, dfa, node_idx, 1);
-      if (BE (err != REG_NOERROR, 0))
+      /* Calculate epsilon closure of 'node_idx'.  */
+      err = calc_eclosure_iter (&eclosure_elem, dfa, node_idx, true);
+      if (__glibc_unlikely (err != REG_NOERROR))
         return err;
 
       if (dfa->eclosures[node_idx].nelem == 0)
         {
-          incomplete = 1;
+          incomplete = true;
           re_node_set_free (&eclosure_elem);
         }
@@ -1638 +1665 @@
 
 static reg_errcode_t
-calc_eclosure_iter (re_node_set *new_set, re_dfa_t *dfa, int node, int root)
+calc_eclosure_iter (re_node_set *new_set, re_dfa_t *dfa, Idx node, bool root)
 {
   reg_errcode_t err;
-  unsigned int constraint;
-  int i, incomplete;
+  Idx i;
   re_node_set eclosure;
-  incomplete = 0;
+  bool incomplete = false;
   err = re_node_set_alloc (&eclosure, dfa->edests[node].nelem + 1);
-  if (BE (err != REG_NOERROR, 0))
+  if (__glibc_unlikely (err != REG_NOERROR))
     return err;
+
+  /* An epsilon closure includes itself.  */
+  eclosure.elems[eclosure.nelem++] = node;
 
   /* This indicates that we are calculating this node now.
@@ -1653 +1682 @@
   dfa->eclosures[node].nelem = -1;
 
-  constraint = ((dfa->nodes[node].type == ANCHOR)
-                ? dfa->nodes[node].opr.ctx_type : 0);
-  /* If the current node has constraints, duplicate all nodes.
-     Since they must inherit the constraints.  */
-  if (constraint
+  /* If the current node has constraints, duplicate all nodes
+     since they must inherit the constraints.  */
+  if (dfa->nodes[node].constraint
       && dfa->edests[node].nelem
       && !dfa->nodes[dfa->edests[node].elems[0]].duplicated)
     {
-      int org_node, cur_node;
-      org_node = cur_node = node;
-      err = duplicate_node_closure (dfa, node, node, node, constraint);
-      if (BE (err != REG_NOERROR, 0))
+      err = duplicate_node_closure (dfa, node, node, node,
+                                    dfa->nodes[node].constraint);
+      if (__glibc_unlikely (err != REG_NOERROR))
         return err;
     }
@@ -1673 +1699 @@
       {
         re_node_set eclosure_elem;
-        int edest = dfa->edests[node].elems[i];
-        /* If calculating the epsilon closure of `edest' is in progress,
+        Idx edest = dfa->edests[node].elems[i];
+        /* If calculating the epsilon closure of 'edest' is in progress,
            return intermediate result.  */
         if (dfa->eclosures[edest].nelem == -1)
           {
-            incomplete = 1;
+            incomplete = true;
             continue;
           }
-        /* If we haven't calculated the epsilon closure of `edest' yet,
+        /* If we haven't calculated the epsilon closure of 'edest' yet,
            calculate now. Otherwise use calculated epsilon closure.  */
         if (dfa->eclosures[edest].nelem == 0)
           {
-            err = calc_eclosure_iter (&eclosure_elem, dfa, edest, 0);
-            if (BE (err != REG_NOERROR, 0))
+            err = calc_eclosure_iter (&eclosure_elem, dfa, edest, false);
+            if (__glibc_unlikely (err != REG_NOERROR))
               return err;
           }
         else
           eclosure_elem = dfa->eclosures[edest];
-        /* Merge the epsilon closure of `edest'.  */
-        re_node_set_merge (&eclosure, &eclosure_elem);
-        /* If the epsilon closure of `edest' is incomplete,
+        /* Merge the epsilon closure of 'edest'.  */
+        err = re_node_set_merge (&eclosure, &eclosure_elem);
+        if (__glibc_unlikely (err != REG_NOERROR))
+          return err;
+        /* If the epsilon closure of 'edest' is incomplete,
            the epsilon closure of this node is also incomplete.  */
         if (dfa->eclosures[edest].nelem == 0)
           {
-            incomplete = 1;
+            incomplete = true;
             re_node_set_free (&eclosure_elem);
           }
       }
 
-  /* Epsilon closures include itself.  */
-  re_node_set_insert (&eclosure, node);
   if (incomplete && !root)
     dfa->eclosures[node].nelem = 0;
@@ -1719 +1745 @@
 
 static void
-internal_function
 fetch_token (re_token_t *result, re_string_t *input, reg_syntax_t syntax)
 {
@@ -1729 +1754 @@
 
 static int
-internal_function
 peek_token (re_token_t *token, re_string_t *input, reg_syntax_t syntax)
 {
@@ -1744 +1768 @@
 
   token->word_char = 0;
-#ifdef RE_ENABLE_I18N
   token->mb_partial = 0;
-  if (input->mb_cur_max > 1 &&
-      !re_string_first_byte (input, re_string_cur_idx (input)))
+  if (input->mb_cur_max > 1
+      && !re_string_first_byte (input, re_string_cur_idx (input)))
     {
       token->type = CHARACTER;
@@ -1753 +1776 @@
       return 1;
     }
-#endif
   if (c == '\\')
     {
@@ -1766 +1788 @@
       token->opr.c = c2;
       token->type = CHARACTER;
-#ifdef RE_ENABLE_I18N
       if (input->mb_cur_max > 1)
         {
@@ -1774 +1795 @@
         }
       else
-#endif
         token->word_char = IS_WORD_CHAR (c2) != 0;
 
@@ -1880 +1900 @@
 
   token->type = CHARACTER;
-#ifdef RE_ENABLE_I18N
   if (input->mb_cur_max > 1)
     {
@@ -1887 +1906 @@
     }
   else
-#endif
     token->word_char = IS_WORD_CHAR (token->opr.c);
 
@@ -1934 +1952 @@
       break;
     case '^':
-      if (!(syntax & (RE_CONTEXT_INDEP_ANCHORS | RE_CARET_ANCHORS_HERE)) &&
-          re_string_cur_idx (input) != 0)
+      if (!(syntax & (RE_CONTEXT_INDEP_ANCHORS | RE_CARET_ANCHORS_HERE))
+          && re_string_cur_idx (input) != 0)
         {
           char prev = re_string_peek_byte (input, -1);
@@ -1945 +1963 @@
       break;
     case '$':
-      if (!(syntax & RE_CONTEXT_INDEP_ANCHORS) &&
-          re_string_cur_idx (input) + 1 != re_string_length (input))
+      if (!(syntax & RE_CONTEXT_INDEP_ANCHORS)
+          && re_string_cur_idx (input) + 1 != re_string_length (input))
         {
           re_token_t next;
@@ -1968 +1986 @@
 
 static int
-internal_function
 peek_token_bracket (re_token_t *token, re_string_t *input, reg_syntax_t syntax)
 {
@@ -1980 +1997 @@
   token->opr.c = c;
 
-#ifdef RE_ENABLE_I18N
-  if (input->mb_cur_max > 1 &&
-      !re_string_first_byte (input, re_string_cur_idx (input)))
+  if (input->mb_cur_max > 1
+      && !re_string_first_byte (input, re_string_cur_idx (input)))
     {
       token->type = CHARACTER;
       return 1;
     }
-#endif /* RE_ENABLE_I18N */
 
   if (c == '\\' && (syntax & RE_BACKSLASH_ESCAPE_IN_LISTS)
@@ -2015 +2030 @@
           token->type = OP_OPEN_COLL_ELEM;
           break;
+
         case '=':
           token->type = OP_OPEN_EQUIV_CLASS;
           break;
+
         case ':':
           if (syntax & RE_CHAR_CLASSES)
@@ -2024 +2041 @@
               break;
             }
-          /* else fall through.  */
+          FALLTHROUGH;
         default:
           token->type = CHARACTER;
@@ -2035 +2052 @@
   switch (c)
     {
-    case '-':
-      token->type = OP_CHARSET_RANGE;
-      break;
     case ']':
       token->type = OP_CLOSE_BRACKET;
@@ -2044 +2058 @@
       token->type = OP_NON_MATCH_LIST;
       break;
+    case '-':
+      /* In V7 Unix grep and Unix awk and mawk, [...---...]
+         (3 adjacent minus signs) stands for a single minus sign.
+         Support that without breaking anything else.  */
+      if (! (re_string_cur_idx (input) + 2 < re_string_length (input)
+             && re_string_peek_byte (input, 1) == '-'
+             && re_string_peek_byte (input, 2) == '-'))
+        {
+          token->type = OP_CHARSET_RANGE;
+          break;
+        }
+      re_string_skip_bytes (input, 2);
+      FALLTHROUGH;
     default:
       token->type = CHARACTER;
@@ -2055 +2082 @@
 /* Entry point of the parser.
    Parse the regular expression REGEXP and return the structure tree.
-   If an error is occured, ERR is set by error code, and return NULL.
+   If an error occurs, ERR is set by error code, and return NULL.
    This function build the following tree, from regular expression <reg_exp>:
            CAT
@@ -2069 +2096 @@
        reg_errcode_t *err)
 {
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+  re_dfa_t *dfa = preg->buffer;
   bin_tree_t *tree, *eor, *root;
   re_token_t current_token;
@@ -2075 +2102 @@
   fetch_token (&current_token, regexp, syntax | RE_CARET_ANCHORS_HERE);
   tree = parse_reg_exp (regexp, preg, &current_token, syntax, 0, err);
-  if (BE (*err != REG_NOERROR && tree == NULL, 0))
+  if (__glibc_unlikely (*err != REG_NOERROR && tree == NULL))
     return NULL;
   eor = create_tree (dfa, NULL, NULL, END_OF_RE);
@@ -2082 +2109 @@
   else
     root = eor;
-  if (BE (eor == NULL || root == NULL, 0))
+  if (__glibc_unlikely (eor == NULL || root == NULL))
     {
       *err = REG_ESPACE;
@@ -2097 +2124 @@
    <branch1> <branch2>
 
-   ALT means alternative, which represents the operator `|'.  */
+   ALT means alternative, which represents the operator '|'.  */
 
 static bin_tree_t *
 parse_reg_exp (re_string_t *regexp, regex_t *preg, re_token_t *token,
-               reg_syntax_t syntax, int nest, reg_errcode_t *err)
-{
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+               reg_syntax_t syntax, Idx nest, reg_errcode_t *err)
+{
+  re_dfa_t *dfa = preg->buffer;
   bin_tree_t *tree, *branch = NULL;
+  bitset_word_t initial_bkref_map = dfa->completed_bkref_map;
   tree = parse_branch (regexp, preg, token, syntax, nest, err);
-  if (BE (*err != REG_NOERROR && tree == NULL, 0))
+  if (__glibc_unlikely (*err != REG_NOERROR && tree == NULL))
     return NULL;
 
@@ -2115 +2143 @@
           && (nest == 0 || token->type != OP_CLOSE_SUBEXP))
         {
+          bitset_word_t accumulated_bkref_map = dfa->completed_bkref_map;
+          dfa->completed_bkref_map = initial_bkref_map;
           branch = parse_branch (regexp, preg, token, syntax, nest, err);
-          if (BE (*err != REG_NOERROR && branch == NULL, 0))
-            return NULL;
+          if (__glibc_unlikely (*err != REG_NOERROR && branch == NULL))
+            {
+              if (tree != NULL)
+                postorder (tree, free_tree, NULL);
+              return NULL;
+            }
+          dfa->completed_bkref_map |= accumulated_bkref_map;
         }
       else
         branch = NULL;
       tree = create_tree (dfa, tree, branch, OP_ALT);
-      if (BE (tree == NULL, 0))
+      if (__glibc_unlikely (tree == NULL))
         {
           *err = REG_ESPACE;
@@ -2142 +2177 @@
 static bin_tree_t *
 parse_branch (re_string_t *regexp, regex_t *preg, re_token_t *token,
-              reg_syntax_t syntax, int nest, reg_errcode_t *err)
-{
-  bin_tree_t *tree, *exp;
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+              reg_syntax_t syntax, Idx nest, reg_errcode_t *err)
+{
+  bin_tree_t *tree, *expr;
+  re_dfa_t *dfa = preg->buffer;
   tree = parse_expression (regexp, preg, token, syntax, nest, err);
-  if (BE (*err != REG_NOERROR && tree == NULL, 0))
+  if (__glibc_unlikely (*err != REG_NOERROR && tree == NULL))
     return NULL;
 
@@ -2153 +2188 @@
          && (nest == 0 || token->type != OP_CLOSE_SUBEXP))
     {
-      exp = parse_expression (regexp, preg, token, syntax, nest, err);
-      if (BE (*err != REG_NOERROR && exp == NULL, 0))
-        {
+      expr = parse_expression (regexp, preg, token, syntax, nest, err);
+      if (__glibc_unlikely (*err != REG_NOERROR && expr == NULL))
+        {
+          if (tree != NULL)
+            postorder (tree, free_tree, NULL);
           return NULL;
         }
-      if (tree != NULL && exp != NULL)
-        {
-          tree = create_tree (dfa, tree, exp, CONCAT);
-          if (tree == NULL)
+      if (tree != NULL && expr != NULL)
+        {
+          bin_tree_t *newtree = create_tree (dfa, tree, expr, CONCAT);
+          if (newtree == NULL)
             {
+              postorder (expr, free_tree, NULL);
+              postorder (tree, free_tree, NULL);
               *err = REG_ESPACE;
               return NULL;
             }
+          tree = newtree;
         }
       else if (tree == NULL)
-        tree = exp;
-      /* Otherwise exp == NULL, we don't need to create new tree.  */
+        tree = expr;
+      /* Otherwise expr == NULL, we don't need to create new tree.  */
     }
   return tree;
@@ -2182 +2222 @@
 static bin_tree_t *
 parse_expression (re_string_t *regexp, regex_t *preg, re_token_t *token,
-                  reg_syntax_t syntax, int nest, reg_errcode_t *err)
-{
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+                  reg_syntax_t syntax, Idx nest, reg_errcode_t *err)
+{
+  re_dfa_t *dfa = preg->buffer;
   bin_tree_t *tree;
   switch (token->type)
@@ -2190 +2230 @@
     case CHARACTER:
       tree = create_token_tree (dfa, NULL, NULL, token);
-      if (BE (tree == NULL, 0))
+      if (__glibc_unlikely (tree == NULL))
         {
           *err = REG_ESPACE;
           return NULL;
         }
-#ifdef RE_ENABLE_I18N
       if (dfa->mb_cur_max > 1)
         {
@@ -2205 +2244 @@
               mbc_remain = create_token_tree (dfa, NULL, NULL, token);
               tree = create_tree (dfa, tree, mbc_remain, CONCAT);
-              if (BE (mbc_remain == NULL || tree == NULL, 0))
+              if (__glibc_unlikely (mbc_remain == NULL || tree == NULL))
                 {
                   *err = REG_ESPACE;
@@ -2212 +2251 @@
             }
         }
-#endif
       break;
+
     case OP_OPEN_SUBEXP:
       tree = parse_sub_exp (regexp, preg, token, syntax, nest + 1, err);
-      if (BE (*err != REG_NOERROR && tree == NULL, 0))
+      if (__glibc_unlikely (*err != REG_NOERROR && tree == NULL))
         return NULL;
       break;
+
     case OP_OPEN_BRACKET:
       tree = parse_bracket_exp (regexp, dfa, token, syntax, err);
-      if (BE (*err != REG_NOERROR && tree == NULL, 0))
+      if (__glibc_unlikely (*err != REG_NOERROR && tree == NULL))
         return NULL;
       break;
+
     case OP_BACK_REF:
-      if (!BE (dfa->completed_bkref_map & (1 << token->opr.idx), 1))
+      if (!__glibc_likely (dfa->completed_bkref_map & (1 << token->opr.idx)))
         {
           *err = REG_ESUBREG;
@@ -2232 +2273 @@
       dfa->used_bkref_map |= 1 << token->opr.idx;
       tree = create_token_tree (dfa, NULL, NULL, token);
-      if (BE (tree == NULL, 0))
+      if (__glibc_unlikely (tree == NULL))
         {
           *err = REG_ESPACE;
@@ -2240 +2281 @@
       dfa->has_mb_node = 1;
       break;
+
     case OP_OPEN_DUP_NUM:
       if (syntax & RE_CONTEXT_INVALID_DUP)
@@ -2246 +2288 @@
           return NULL;
         }
-      /* FALLTHROUGH */
+      FALLTHROUGH;
     case OP_DUP_ASTERISK:
     case OP_DUP_PLUS:
@@ -2260 +2302 @@
           return parse_expression (regexp, preg, token, syntax, nest, err);
         }
-      /* else fall through  */
+      FALLTHROUGH;
     case OP_CLOSE_SUBEXP:
-      if ((token->type == OP_CLOSE_SUBEXP) &&
-          !(syntax & RE_UNMATCHED_RIGHT_PAREN_ORD))
+      if ((token->type == OP_CLOSE_SUBEXP)
+          && !(syntax & RE_UNMATCHED_RIGHT_PAREN_ORD))
         {
           *err = REG_ERPAREN;
           return NULL;
         }
-      /* else fall through  */
+      FALLTHROUGH;
     case OP_CLOSE_DUP_NUM:
       /* We treat it as a normal character.  */
@@ -2277 +2319 @@
          by peek_token.  */
       tree = create_token_tree (dfa, NULL, NULL, token);
-      if (BE (tree == NULL, 0))
+      if (__glibc_unlikely (tree == NULL))
         {
           *err = REG_ESPACE;
@@ -2283 +2325 @@
         }
       break;
+
     case ANCHOR:
       if ((token->opr.ctx_type
@@ -2289 +2332 @@
         init_word_char (dfa);
       if (token->opr.ctx_type == WORD_DELIM
-          || token->opr.ctx_type == NOT_WORD_DELIM)
+          || token->opr.ctx_type == NOT_WORD_DELIM)
         {
           bin_tree_t *tree_first, *tree_last;
@@ -2297 +2340 @@
               tree_first = create_token_tree (dfa, NULL, NULL, token);
               token->opr.ctx_type = WORD_LAST;
-            }
-          else
-            {
+            }
+          else
+            {
               token->opr.ctx_type = INSIDE_WORD;
               tree_first = create_token_tree (dfa, NULL, NULL, token);
               token->opr.ctx_type = INSIDE_NOTWORD;
-            }
+            }
           tree_last = create_token_tree (dfa, NULL, NULL, token);
           tree = create_tree (dfa, tree_first, tree_last, OP_ALT);
-          if (BE (tree_first == NULL || tree_last == NULL || tree == NULL, 0))
+          if (__glibc_unlikely (tree_first == NULL || tree_last == NULL
+                                || tree == NULL))
             {
               *err = REG_ESPACE;
@@ -2315 +2359 @@
         {
           tree = create_token_tree (dfa, NULL, NULL, token);
-          if (BE (tree == NULL, 0))
+          if (__glibc_unlikely (tree == NULL))
             {
               *err = REG_ESPACE;
@@ -2327 +2371 @@
       fetch_token (token, regexp, syntax);
       return tree;
+
     case OP_PERIOD:
       tree = create_token_tree (dfa, NULL, NULL, token);
-      if (BE (tree == NULL, 0))
+      if (__glibc_unlikely (tree == NULL))
         {
           *err = REG_ESPACE;
@@ -2337 +2382 @@
         dfa->has_mb_node = 1;
       break;
+
     case OP_WORD:
     case OP_NOTWORD:
       tree = build_charclass_op (dfa, regexp->trans,
-                                 (const unsigned char *) "alnum",
-                                 (const unsigned char *) "_",
+                                 "alnum",
+                                 "_",
                                  token->type == OP_NOTWORD, err);
-      if (BE (*err != REG_NOERROR && tree == NULL, 0))
+      if (__glibc_unlikely (*err != REG_NOERROR && tree == NULL))
         return NULL;
       break;
+
     case OP_SPACE:
     case OP_NOTSPACE:
       tree = build_charclass_op (dfa, regexp->trans,
-                                 (const unsigned char *) "space",
-                                 (const unsigned char *) "",
+                                 "space",
+                                 "",
                                  token->type == OP_NOTSPACE, err);
-      if (BE (*err != REG_NOERROR && tree == NULL, 0))
+      if (__glibc_unlikely (*err != REG_NOERROR && tree == NULL))
         return NULL;
       break;
+
     case OP_ALT:
     case END_OF_RE:
       return NULL;
+
     case BACK_SLASH:
       *err = REG_EESCAPE;
       return NULL;
+
     default:
       /* Must not happen?  */
-#ifdef DEBUG
-      assert (0);
-#endif
+      DEBUG_ASSERT (false);
       return NULL;
     }
@@ -2373 +2421 @@
          || token->type == OP_DUP_QUESTION || token->type == OP_OPEN_DUP_NUM)
     {
-      tree = parse_dup_op (tree, regexp, dfa, token, syntax, err);
-      if (BE (*err != REG_NOERROR && tree == NULL, 0))
-        return NULL;
+      bin_tree_t *dup_tree = parse_dup_op (tree, regexp, dfa, token,
+                                           syntax, err);
+      if (__glibc_unlikely (*err != REG_NOERROR && dup_tree == NULL))
+        {
+          if (tree != NULL)
+            postorder (tree, free_tree, NULL);
+          return NULL;
+        }
+      tree = dup_tree;
       /* In BRE consecutive duplications are not allowed.  */
       if ((syntax & RE_CONTEXT_INVALID_DUP)
@@ -2381 +2435 @@
               || token->type == OP_OPEN_DUP_NUM))
         {
+          if (tree != NULL)
+            postorder (tree, free_tree, NULL);
           *err = REG_BADRPT;
           return NULL;
@@ -2398 +2454 @@
 static bin_tree_t *
 parse_sub_exp (re_string_t *regexp, regex_t *preg, re_token_t *token,
-               reg_syntax_t syntax, int nest, reg_errcode_t *err)
-{
-  re_dfa_t *dfa = (re_dfa_t *) preg->buffer;
+               reg_syntax_t syntax, Idx nest, reg_errcode_t *err)
+{
+  re_dfa_t *dfa = preg->buffer;
   bin_tree_t *tree;
   size_t cur_nsub;
@@ -2413 +2469 @@
     {
       tree = parse_reg_exp (regexp, preg, token, syntax, nest, err);
-      if (BE (*err == REG_NOERROR && token->type != OP_CLOSE_SUBEXP, 0))
-        *err = REG_EPAREN;
-      if (BE (*err != REG_NOERROR, 0))
+      if (__glibc_unlikely (*err == REG_NOERROR
+                            && token->type != OP_CLOSE_SUBEXP))
+        {
+          if (tree != NULL)
+            postorder (tree, free_tree, NULL);
+          *err = REG_EPAREN;
+        }
+      if (__glibc_unlikely (*err != REG_NOERROR))
         return NULL;
     }
@@ -2423 +2484 @@
 
   tree = create_tree (dfa, tree, NULL, SUBEXP);
-  if (BE (tree == NULL, 0))
+  if (__glibc_unlikely (tree == NULL))
     {
       *err = REG_ESPACE;
@@ -2439 +2500 @@
 {
   bin_tree_t *tree = NULL, *old_tree = NULL;
-  int i, start, end, start_idx = re_string_cur_idx (regexp);
+  Idx i, start, end, start_idx = re_string_cur_idx (regexp);
   re_token_t start_token = *token;
 
@@ -2456 +2517 @@
             }
         }
-      if (BE (start != -2, 1))
+      if (__glibc_likely (start != -2))
         {
           /* We treat "{n}" as "{n,n}".  */
@@ -2463 +2524 @@
                     ? fetch_number (regexp, token, syntax) : -2));
         }
-      if (BE (start == -2 || end == -2, 0))
+      if (__glibc_unlikely (start == -2 || end == -2))
         {
           /* Invalid sequence.  */
-          if (BE (!(syntax & RE_INVALID_INTERVAL_ORD), 0))
+          if (__glibc_unlikely (!(syntax & RE_INVALID_INTERVAL_ORD)))
             {
               if (token->type == END_OF_RE)
@@ -2485 +2546 @@
         }
 
-      if (BE (end != -1 && start > end, 0))
+      if (__glibc_unlikely ((end != -1 && start > end)
+                            || token->type != OP_CLOSE_DUP_NUM))
         {
           /* First number greater than second.  */
@@ -2491 +2553 @@
           return NULL;
         }
+
+      if (__glibc_unlikely (RE_DUP_MAX < (end == -1 ? start : end)))
+        {
+          *err = REG_ESIZE;
+          return NULL;
+        }
     }
   else
@@ -2500 +2568 @@
   fetch_token (token, regexp, syntax);
 
-  if (BE (elem == NULL, 0))
+  if (__glibc_unlikely (elem == NULL))
     return NULL;
-  if (BE (start == 0 && end == 0, 0))
+  if (__glibc_unlikely (start == 0 && end == 0))
     {
       postorder (elem, free_tree, NULL);
@@ -2509 +2577 @@
 
   /* Extract "<re>{n,m}" to "<re><re>...<re><re>{0,<m-n>}".  */
-  if (BE (start > 0, 0))
+  if (__glibc_unlikely (start > 0))
     {
       tree = elem;
@@ -2516 +2584 @@
           elem = duplicate_tree (elem, dfa);
           tree = create_tree (dfa, tree, elem, CONCAT);
-          if (BE (elem == NULL || tree == NULL, 0))
+          if (__glibc_unlikely (elem == NULL || tree == NULL))
             goto parse_dup_op_espace;
         }
@@ -2525 +2593 @@
       /* Duplicate ELEM before it is marked optional.  */
       elem = duplicate_tree (elem, dfa);
+      if (__glibc_unlikely (elem == NULL))
+        goto parse_dup_op_espace;
       old_tree = tree;
     }
@@ -2531 +2601 @@
 
   if (elem->token.type == SUBEXP)
-    postorder (elem, mark_opt_subexp, (void *) (long) elem->token.opr.idx);
-
-  tree = create_tree (dfa, elem, NULL, (end == -1 ? OP_DUP_ASTERISK : OP_ALT));
-  if (BE (tree == NULL, 0))
+    {
+      uintptr_t subidx = elem->token.opr.idx;
+      postorder (elem, mark_opt_subexp, (void *) subidx);
+    }
+
+  tree = create_tree (dfa, elem, NULL,
+                      (end == -1 ? OP_DUP_ASTERISK : OP_ALT));
+  if (__glibc_unlikely (tree == NULL))
     goto parse_dup_op_espace;
 
@@ -2540 +2614 @@
      to rewrite <re>{0,n} as (<re>(<re>...<re>?)?)?...  We have
      already created the start+1-th copy.  */
-  for (i = start + 2; i <= end; ++i)
-    {
-      elem = duplicate_tree (elem, dfa);
-      tree = create_tree (dfa, tree, elem, CONCAT);
-      if (BE (elem == NULL || tree == NULL, 0))
-        goto parse_dup_op_espace;
-
-      tree = create_tree (dfa, tree, NULL, OP_ALT);
-      if (BE (tree == NULL, 0))
-        goto parse_dup_op_espace;
-    }
+  if (TYPE_SIGNED (Idx) || end != -1)
+    for (i = start + 2; i <= end; ++i)
+      {
+        elem = duplicate_tree (elem, dfa);
+        tree = create_tree (dfa, tree, elem, CONCAT);
+        if (__glibc_unlikely (elem == NULL || tree == NULL))
+          goto parse_dup_op_espace;
+
+        tree = create_tree (dfa, tree, NULL, OP_ALT);
+        if (__glibc_unlikely (tree == NULL))
+          goto parse_dup_op_espace;
+      }
 
   if (old_tree)
@@ -2567 +2642 @@
 
 #ifndef _LIBC
-  /* Local function for parse_bracket_exp only used in case of NOT _LIBC.
-     Build the range expression which starts from START_ELEM, and ends
-     at END_ELEM.  The result are written to MBCSET and SBCSET.
-     RANGE_ALLOC is the allocated size of mbcset->range_starts, and
-     mbcset->range_ends, is a pointer argument sinse we may
-     update it.  */
+
+/* Convert the byte B to the corresponding wide character.  In a
+   unibyte locale, treat B as itself.  In a multibyte locale, return
+   WEOF if B is an encoding error.  */
+static wint_t
+parse_byte (unsigned char b, re_dfa_t const *dfa)
+{
+  return dfa->mb_cur_max > 1 ? __btowc (b) : b;
+}
+
+/* Local function for parse_bracket_exp used in _LIBC environment.
+   Build the range expression which starts from START_ELEM, and ends
+   at END_ELEM.  The result are written to MBCSET and SBCSET.
+   RANGE_ALLOC is the allocated size of mbcset->range_starts, and
+   mbcset->range_ends, is a pointer argument since we may
+   update it.  */
 
 static reg_errcode_t
-internal_function
-# ifdef RE_ENABLE_I18N
-build_range_exp (bitset_t sbcset, re_charset_t *mbcset, int *range_alloc,
-                 bracket_elem_t *start_elem, bracket_elem_t *end_elem)
-# else /* not RE_ENABLE_I18N */
-build_range_exp (bitset_t sbcset, bracket_elem_t *start_elem,
-                 bracket_elem_t *end_elem)
-# endif /* not RE_ENABLE_I18N */
-{
-  unsigned int start_ch, end_ch;
+build_range_exp (bitset_t sbcset, re_charset_t *mbcset, Idx *range_alloc,
+                 bracket_elem_t *start_elem, bracket_elem_t *end_elem,
+                 re_dfa_t *dfa, reg_syntax_t syntax, uint_fast32_t nrules,
+                 const unsigned char *collseqmb, const char *collseqwc,
+                 int_fast32_t table_size, const void *symb_table,
+                 const unsigned char *extra)
+{
   /* Equivalence Classes and Character Classes can't be a range start/end.  */
-  if (BE (start_elem->type == EQUIV_CLASS || start_elem->type == CHAR_CLASS
-          || end_elem->type == EQUIV_CLASS || end_elem->type == CHAR_CLASS,
-          0))
+  if (__glibc_unlikely (start_elem->type == EQUIV_CLASS
+                        || start_elem->type == CHAR_CLASS
+                        || end_elem->type == EQUIV_CLASS
+                        || end_elem->type == CHAR_CLASS))
     return REG_ERANGE;
 
   /* We can handle no multi character collating elements without libc
      support.  */
-  if (BE ((start_elem->type == COLL_SYM
-           && strlen ((char *) start_elem->opr.name) > 1)
-          || (end_elem->type == COLL_SYM
-              && strlen ((char *) end_elem->opr.name) > 1), 0))
+  if (__glibc_unlikely ((start_elem->type == COLL_SYM
+                         && strlen ((char *) start_elem->opr.name) > 1)
+                        || (end_elem->type == COLL_SYM
+                            && strlen ((char *) end_elem->opr.name) > 1)))
     return REG_ECOLLATE;
 
-# ifdef RE_ENABLE_I18N
-  {
-    wchar_t wc;
-    wint_t start_wc;
-    wint_t end_wc;
-    wchar_t cmp_buf[6] = {L'\0', L'\0', L'\0', L'\0', L'\0', L'\0'};
-
+  unsigned int
     start_ch = ((start_elem->type == SB_CHAR) ? start_elem->opr.ch
                 : ((start_elem->type == COLL_SYM) ? start_elem->opr.name[0]
-                   : 0));
+                   : 0)),
     end_ch = ((end_elem->type == SB_CHAR) ? end_elem->opr.ch
               : ((end_elem->type == COLL_SYM) ? end_elem->opr.name[0]
                  : 0));
+  wint_t
     start_wc = ((start_elem->type == SB_CHAR || start_elem->type == COLL_SYM)
-                ? __btowc (start_ch) : start_elem->opr.wch);
+                ? parse_byte (start_ch, dfa) : start_elem->opr.wch),
     end_wc = ((end_elem->type == SB_CHAR || end_elem->type == COLL_SYM)
-              ? __btowc (end_ch) : end_elem->opr.wch);
-    if (start_wc == WEOF || end_wc == WEOF)
-      return REG_ECOLLATE;
-    cmp_buf[0] = start_wc;
-    cmp_buf[4] = end_wc;
-    if (wcscoll (cmp_buf, cmp_buf + 4) > 0)
-      return REG_ERANGE;
-
-    /* Got valid collation sequence values, add them as a new entry.
-       However, for !_LIBC we have no collation elements: if the
-       character set is single byte, the single byte character set
-       that we build below suffices.  parse_bracket_exp passes
-       no MBCSET if dfa->mb_cur_max == 1.  */
-    if (mbcset)
-      {
-        /* Check the space of the arrays.  */
-        if (BE (*range_alloc == mbcset->nranges, 0))
-          {
-            /* There is not enough space, need realloc.  */
-            wchar_t *new_array_start, *new_array_end;
-            int new_nranges;
-
-            /* +1 in case of mbcset->nranges is 0.  */
-            new_nranges = 2 * mbcset->nranges + 1;
-            /* Use realloc since mbcset->range_starts and mbcset->range_ends
-               are NULL if *range_alloc == 0.  */
-            new_array_start = re_realloc (mbcset->range_starts, wchar_t,
-                                          new_nranges);
-            new_array_end = re_realloc (mbcset->range_ends, wchar_t,
-                                        new_nranges);
-
-            if (BE (new_array_start == NULL || new_array_end == NULL, 0))
-              return REG_ESPACE;
-
-            mbcset->range_starts = new_array_start;
-            mbcset->range_ends = new_array_end;
-            *range_alloc = new_nranges;
-          }
-
-        mbcset->range_starts[mbcset->nranges] = start_wc;
-        mbcset->range_ends[mbcset->nranges++] = end_wc;
-      }
-
-    /* Build the table for single byte characters.  */
-    for (wc = 0; wc < SBC_MAX; ++wc)
-      {
-        cmp_buf[2] = wc;
-        if (wcscoll (cmp_buf, cmp_buf + 2) <= 0
-            && wcscoll (cmp_buf + 2, cmp_buf + 4) <= 0)
-          bitset_set (sbcset, wc);
-      }
-  }
-# else /* not RE_ENABLE_I18N */
-  {
-    unsigned int ch;
-    start_ch = ((start_elem->type == SB_CHAR ) ? start_elem->opr.ch
-                : ((start_elem->type == COLL_SYM) ? start_elem->opr.name[0]
-                   : 0));
-    end_ch = ((end_elem->type == SB_CHAR ) ? end_elem->opr.ch
-              : ((end_elem->type == COLL_SYM) ? end_elem->opr.name[0]
-                 : 0));
-    if (start_ch > end_ch)
-      return REG_ERANGE;
-    /* Build the table for single byte characters.  */
-    for (ch = 0; ch < SBC_MAX; ++ch)
-      if (start_ch <= ch  && ch <= end_ch)
-        bitset_set (sbcset, ch);
-  }
-# endif /* not RE_ENABLE_I18N */
+              ? parse_byte (end_ch, dfa) : end_elem->opr.wch);
+
+  if (start_wc == WEOF || end_wc == WEOF)
+    return REG_ECOLLATE;
+  else if (__glibc_unlikely ((syntax & RE_NO_EMPTY_RANGES)
+                             && start_wc > end_wc))
+    return REG_ERANGE;
+
+  /* Got valid collation sequence values, add them as a new entry.
+     However, for !_LIBC we have no collation elements: if the
+     character set is single byte, the single byte character set
+     that we build below suffices.  parse_bracket_exp passes
+     no MBCSET if dfa->mb_cur_max == 1.  */
+  if (dfa->mb_cur_max > 1)
+    {
+      /* Check the space of the arrays.  */
+      if (__glibc_unlikely (*range_alloc == mbcset->nranges))
+        {
+          /* There is not enough space, need realloc.  */
+          wchar_t *new_array_start, *new_array_end;
+          Idx new_nranges;
+
+          /* +1 in case of mbcset->nranges is 0.  */
+          new_nranges = 2 * mbcset->nranges + 1;
+          /* Use realloc since mbcset->range_starts and mbcset->range_ends
+             are NULL if *range_alloc == 0.  */
+          new_array_start = re_realloc (mbcset->range_starts, wchar_t,
+                                        new_nranges);
+          new_array_end = re_realloc (mbcset->range_ends, wchar_t,
+                                      new_nranges);
+
+          if (__glibc_unlikely (new_array_start == NULL
+                                || new_array_end == NULL))
+            {
+              re_free (new_array_start);
+              re_free (new_array_end);
+              return REG_ESPACE;
+            }
+
+          mbcset->range_starts = new_array_start;
+          mbcset->range_ends = new_array_end;
+          *range_alloc = new_nranges;
+        }
+
+      mbcset->range_starts[mbcset->nranges] = start_wc;
+      mbcset->range_ends[mbcset->nranges++] = end_wc;
+    }
+
+  /* Build the table for single byte characters.  */
+  for (wchar_t wc = 0; wc < SBC_MAX; ++wc)
+    {
+      if (start_wc <= wc && wc <= end_wc)
+        bitset_set (sbcset, wc);
+    }
+
   return REG_NOERROR;
 }
@@ -2689 +2753 @@
 
 #ifndef _LIBC
-/* Helper function for parse_bracket_exp only used in case of NOT _LIBC..
+/* Helper function for parse_bracket_exp only used in case of NOT _LIBC.
    Build the collating element which is represented by NAME.
    The result are written to MBCSET and SBCSET.
@@ -2696 +2760 @@
 
 static reg_errcode_t
-internal_function
-# ifdef RE_ENABLE_I18N
 build_collating_symbol (bitset_t sbcset, re_charset_t *mbcset,
-                        int *coll_sym_alloc, const unsigned char *name)
-# else /* not RE_ENABLE_I18N */
-build_collating_symbol (bitset_t sbcset, const unsigned char *name)
-# endif /* not RE_ENABLE_I18N */
+                        Idx *coll_sym_alloc, const unsigned char *name,
+                        uint_fast32_t nrules, int_fast32_t table_size,
+                        const void *symb_table, const unsigned char *extra)
 {
   size_t name_len = strlen ((const char *) name);
-  if (BE (name_len != 1, 0))
+  if (__glibc_unlikely (name_len != 1))
     return REG_ECOLLATE;
   else
@@ -2715 +2776 @@
 #endif /* not _LIBC */
 
-/* This function parse bracket expression like "[abc]", "[a-c]",
-   "[[.a-a.]]" etc.  */
-
-static bin_tree_t *
-parse_bracket_exp (re_string_t *regexp, re_dfa_t *dfa, re_token_t *token,
-                   reg_syntax_t syntax, reg_errcode_t *err)
-{
 #ifdef _LIBC
-  const unsigned char *collseqmb;
-  const char *collseqwc;
-  uint32_t nrules;
-  int32_t table_size;
-  const int32_t *symb_table;
-  const unsigned char *extra;
-
-  /* Local function for parse_bracket_exp used in _LIBC environement.
-     Seek the collating symbol entry correspondings to NAME.
-     Return the index of the symbol in the SYMB_TABLE.  */
-
-  auto inline int32_t
-  __attribute ((always_inline))
-  seek_collating_symbol_entry (name, name_len)
-         const unsigned char *name;
-         size_t name_len;
-    {
-      int32_t hash = elem_hash ((const char *) name, name_len);
-      int32_t elem = hash % table_size;
-      if (symb_table[2 * elem] != 0)
-        {
-          int32_t second = hash % (table_size - 2) + 1;
-
-          do
-            {
-              /* First compare the hashing value.  */
-              if (symb_table[2 * elem] == hash
-                  /* Compare the length of the name.  */
-                  && name_len == extra[symb_table[2 * elem + 1]]
-                  /* Compare the name.  */
-                  && memcmp (name, &extra[symb_table[2 * elem + 1] + 1],
-                             name_len) == 0)
-                {
-                  /* Yep, this is the entry.  */
-                  break;
-                }
-
-              /* Next entry.  */
-              elem += second;
-            }
-          while (symb_table[2 * elem] != 0);
-        }
-      return elem;
-    }
-
-  /* Local function for parse_bracket_exp used in _LIBC environement.
-     Look up the collation sequence value of BR_ELEM.
-     Return the value if succeeded, UINT_MAX otherwise.  */
-
-  auto inline unsigned int
-  __attribute ((always_inline))
-  lookup_collation_sequence_value (br_elem)
-         bracket_elem_t *br_elem;
-    {
-      if (br_elem->type == SB_CHAR)
-        {
-          /*
-          if (MB_CUR_MAX == 1)
-          */
-          if (nrules == 0)
-            return collseqmb[br_elem->opr.ch];
-          else
-            {
-              wint_t wc = __btowc (br_elem->opr.ch);
-              return __collseq_table_lookup (collseqwc, wc);
-            }
-        }
-      else if (br_elem->type == MB_CHAR)
-        {
-          return __collseq_table_lookup (collseqwc, br_elem->opr.wch);
-        }
-      else if (br_elem->type == COLL_SYM)
-        {
-          size_t sym_name_len = strlen ((char *) br_elem->opr.name);
-          if (nrules != 0)
-            {
-              int32_t elem, idx;
-              elem = seek_collating_symbol_entry (br_elem->opr.name,
-                                                  sym_name_len);
-              if (symb_table[2 * elem] != 0)
-                {
-                  /* We found the entry.  */
-                  idx = symb_table[2 * elem + 1];
-                  /* Skip the name of collating element name.  */
-                  idx += 1 + extra[idx];
-                  /* Skip the byte sequence of the collating element.  */
-                  idx += 1 + extra[idx];
-                  /* Adjust for the alignment.  */
-                  idx = (idx + 3) & ~3;
-                  /* Skip the multibyte collation sequence value.  */
-                  idx += sizeof (unsigned int);
-                  /* Skip the wide char sequence of the collating element.  */
-                  idx += sizeof (unsigned int) *
-                    (1 + *(unsigned int *) (extra + idx));
-                  /* Return the collation sequence value.  */
-                  return *(unsigned int *) (extra + idx);
-                }
-              else if (symb_table[2 * elem] == 0 && sym_name_len == 1)
-                {
-                  /* No valid character.  Match it as a single byte
-                     character.  */
-                  return collseqmb[br_elem->opr.name[0]];
-                }
-            }
-          else if (sym_name_len == 1)
-            return collseqmb[br_elem->opr.name[0]];
-        }
-      return UINT_MAX;
-    }
-
-  /* Local function for parse_bracket_exp used in _LIBC environement.
-     Build the range expression which starts from START_ELEM, and ends
-     at END_ELEM.  The result are written to MBCSET and SBCSET.
-     RANGE_ALLOC is the allocated size of mbcset->range_starts, and
-     mbcset->range_ends, is a pointer argument sinse we may
-     update it.  */
-
-  auto inline reg_errcode_t
-  __attribute ((always_inline))
-  build_range_exp (sbcset, mbcset, range_alloc, start_elem, end_elem)
-         re_charset_t *mbcset;
-         int *range_alloc;
-         bitset_t sbcset;
-         bracket_elem_t *start_elem, *end_elem;
-    {
-      unsigned int ch;
-      uint32_t start_collseq;
-      uint32_t end_collseq;
-
-      /* Equivalence Classes and Character Classes can't be a range
-         start/end.  */
-      if (BE (start_elem->type == EQUIV_CLASS || start_elem->type == CHAR_CLASS
-              || end_elem->type == EQUIV_CLASS || end_elem->type == CHAR_CLASS,
-              0))
-        return REG_ERANGE;
-
-      start_collseq = lookup_collation_sequence_value (start_elem);
-      end_collseq = lookup_collation_sequence_value (end_elem);
-      /* Check start/end collation sequence values.  */
-      if (BE (start_collseq == UINT_MAX || end_collseq == UINT_MAX, 0))
-        return REG_ECOLLATE;
-      if (BE ((syntax & RE_NO_EMPTY_RANGES) && start_collseq > end_collseq, 0))
-        return REG_ERANGE;
-
-      /* Got valid collation sequence values, add them as a new entry.
-         However, if we have no collation elements, and the character set
-         is single byte, the single byte character set that we
-         build below suffices. */
-      if (nrules > 0 || dfa->mb_cur_max > 1)
-        {
-          /* Check the space of the arrays.  */
-          if (BE (*range_alloc == mbcset->nranges, 0))
-            {
-              /* There is not enough space, need realloc.  */
-              uint32_t *new_array_start;
-              uint32_t *new_array_end;
-              int new_nranges;
-
-              /* +1 in case of mbcset->nranges is 0.  */
-              new_nranges = 2 * mbcset->nranges + 1;
-              new_array_start = re_realloc (mbcset->range_starts, uint32_t,
-                                            new_nranges);
-              new_array_end = re_realloc (mbcset->range_ends, uint32_t,
-                                          new_nranges);
-
-              if (BE (new_array_start == NULL || new_array_end == NULL, 0))
-                return REG_ESPACE;
-
-              mbcset->range_starts = new_array_start;
-              mbcset->range_ends = new_array_end;
-              *range_alloc = new_nranges;
-            }
-
-          mbcset->range_starts[mbcset->nranges] = start_collseq;
-          mbcset->range_ends[mbcset->nranges++] = end_collseq;
-        }
-
-      /* Build the table for single byte characters.  */
-      for (ch = 0; ch < SBC_MAX; ch++)
-        {
-          uint32_t ch_collseq;
-          /*
-          if (MB_CUR_MAX == 1)
-          */
-          if (nrules == 0)
-            ch_collseq = collseqmb[ch];
-          else
-            ch_collseq = __collseq_table_lookup (collseqwc, __btowc (ch));
-          if (start_collseq <= ch_collseq && ch_collseq <= end_collseq)
-            bitset_set (sbcset, ch);
-        }
-      return REG_NOERROR;
-    }
-
-  /* Local function for parse_bracket_exp used in _LIBC environement.
-     Build the collating element which is represented by NAME.
-     The result are written to MBCSET and SBCSET.
-     COLL_SYM_ALLOC is the allocated size of mbcset->coll_sym, is a
-     pointer argument sinse we may update it.  */
-
-  auto inline reg_errcode_t
-  __attribute ((always_inline))
-  build_collating_symbol (sbcset, mbcset, coll_sym_alloc, name)
-         re_charset_t *mbcset;
-         int *coll_sym_alloc;
-         bitset_t sbcset;
-         const unsigned char *name;
-    {
-      int32_t elem, idx;
-      size_t name_len = strlen ((const char *) name);
+/* Local function for parse_bracket_exp used in _LIBC environment.
+   Seek the collating symbol entry corresponding to NAME.
+   Return the index of the symbol in the SYMB_TABLE,
+   or -1 if not found.  */
+
+static __always_inline int32_t
+seek_collating_symbol_entry (const unsigned char *name, size_t name_len,
+                             const int32_t *symb_table,
+                             int_fast32_t table_size,
+                             const unsigned char *extra)
+{
+  int_fast32_t elem;
+
+  for (elem = 0; elem < table_size; elem++)
+    if (symb_table[2 * elem] != 0)
+      {
+        int32_t idx = symb_table[2 * elem + 1];
+        /* Skip the name of collating element name.  */
+        idx += 1 + extra[idx];
+        if (/* Compare the length of the name.  */
+            name_len == extra[idx]
+            /* Compare the name.  */
+            && memcmp (name, &extra[idx + 1], name_len) == 0)
+          /* Yep, this is the entry.  */
+          return elem;
+      }
+  return -1;
+}
+
+/* Local function for parse_bracket_exp used in _LIBC environment.
+   Look up the collation sequence value of BR_ELEM.
+   Return the value if succeeded, UINT_MAX otherwise.  */
+
+static __always_inline unsigned int
+lookup_collation_sequence_value (bracket_elem_t *br_elem, uint32_t nrules,
+                                 const unsigned char *collseqmb,
+                                 const char *collseqwc,
+                                 int_fast32_t table_size,
+                                 const int32_t *symb_table,
+                                 const unsigned char *extra)
+{
+  if (br_elem->type == SB_CHAR)
+    {
+      /* if (MB_CUR_MAX == 1) */
+      if (nrules == 0)
+        return collseqmb[br_elem->opr.ch];
+      else
+        {
+          wint_t wc = __btowc (br_elem->opr.ch);
+          return __collseq_table_lookup (collseqwc, wc);
+        }
+    }
+  else if (br_elem->type == MB_CHAR)
+    {
       if (nrules != 0)
-        {
-          elem = seek_collating_symbol_entry (name, name_len);
-          if (symb_table[2 * elem] != 0)
+        return __collseq_table_lookup (collseqwc, br_elem->opr.wch);
+    }
+  else if (br_elem->type == COLL_SYM)
+    {
+      size_t sym_name_len = strlen ((char *) br_elem->opr.name);
+      if (nrules != 0)
+        {
+          int32_t elem, idx;
+          elem = seek_collating_symbol_entry (br_elem->opr.name,
+                                              sym_name_len,
+                                              symb_table, table_size,
+                                              extra);
+          if (elem != -1)
             {
               /* We found the entry.  */
@@ -2942 +2850 @@
               /* Skip the name of collating element name.  */
               idx += 1 + extra[idx];
+              /* Skip the byte sequence of the collating element.  */
+              idx += 1 + extra[idx];
+              /* Adjust for the alignment.  */
+              idx = (idx + 3) & ~3;
+              /* Skip the multibyte collation sequence value.  */
+              idx += sizeof (unsigned int);
+              /* Skip the wide char sequence of the collating element.  */
+              idx += sizeof (unsigned int) *
+                (1 + *(unsigned int *) (extra + idx));
+              /* Return the collation sequence value.  */
+              return *(unsigned int *) (extra + idx);
             }
-          else if (symb_table[2 * elem] == 0 && name_len == 1)
+          else if (sym_name_len == 1)
             {
-              /* No valid character, treat it as a normal
+              /* No valid character.  Match it as a single byte
                  character.  */
-              bitset_set (sbcset, name[0]);
-              return REG_NOERROR;
+              return collseqmb[br_elem->opr.name[0]];
             }
-          else
-            return REG_ECOLLATE;
-
-          /* Got valid collation sequence, add it as a new entry.  */
-          /* Check the space of the arrays.  */
-          if (BE (*coll_sym_alloc == mbcset->ncoll_syms, 0))
-            {
-              /* Not enough, realloc it.  */
-              /* +1 in case of mbcset->ncoll_syms is 0.  */
-              int new_coll_sym_alloc = 2 * mbcset->ncoll_syms + 1;
-              /* Use realloc since mbcset->coll_syms is NULL
-                 if *alloc == 0.  */
-              int32_t *new_coll_syms = re_realloc (mbcset->coll_syms, int32_t,
-                                                   new_coll_sym_alloc);
-              if (BE (new_coll_syms == NULL, 0))
-                return REG_ESPACE;
-              mbcset->coll_syms = new_coll_syms;
-              *coll_sym_alloc = new_coll_sym_alloc;
-            }
-          mbcset->coll_syms[mbcset->ncoll_syms++] = idx;
+        }
+      else if (sym_name_len == 1)
+        return collseqmb[br_elem->opr.name[0]];
+    }
+  return UINT_MAX;
+}
+
+/* Local function for parse_bracket_exp used in _LIBC environment.
+   Build the range expression which starts from START_ELEM, and ends
+   at END_ELEM.  The result are written to MBCSET and SBCSET.
+   RANGE_ALLOC is the allocated size of mbcset->range_starts, and
+   mbcset->range_ends, is a pointer argument since we may
+   update it.  */
+
+static __always_inline reg_errcode_t
+build_range_exp (bitset_t sbcset, re_charset_t *mbcset, Idx *range_alloc,
+                 bracket_elem_t *start_elem, bracket_elem_t *end_elem,
+                 re_dfa_t *dfa, reg_syntax_t syntax, uint32_t nrules,
+                 const unsigned char *collseqmb, const char *collseqwc,
+                 int_fast32_t table_size, const int32_t *symb_table,
+                 const unsigned char *extra)
+{
+  unsigned int ch;
+  uint32_t start_collseq;
+  uint32_t end_collseq;
+
+  /* Equivalence Classes and Character Classes can't be a range
+     start/end.  */
+  if (__glibc_unlikely (start_elem->type == EQUIV_CLASS
+                        || start_elem->type == CHAR_CLASS
+                        || end_elem->type == EQUIV_CLASS
+                        || end_elem->type == CHAR_CLASS))
+    return REG_ERANGE;
+
+  /* FIXME: Implement rational ranges here, too.  */
+  start_collseq = lookup_collation_sequence_value (start_elem, nrules, collseqmb, collseqwc,
+                                                   table_size, symb_table, extra);
+  end_collseq = lookup_collation_sequence_value (end_elem, nrules, collseqmb, collseqwc,
+                                                 table_size, symb_table, extra);
+  /* Check start/end collation sequence values.  */
+  if (__glibc_unlikely (start_collseq == UINT_MAX
+                        || end_collseq == UINT_MAX))
+    return REG_ECOLLATE;
+  if (__glibc_unlikely ((syntax & RE_NO_EMPTY_RANGES)
+                        && start_collseq > end_collseq))
+    return REG_ERANGE;
+
+  /* Got valid collation sequence values, add them as a new entry.
+     However, if we have no collation elements, and the character set
+     is single byte, the single byte character set that we
+     build below suffices. */
+  if (nrules > 0 || dfa->mb_cur_max > 1)
+    {
+      /* Check the space of the arrays.  */
+      if (__glibc_unlikely (*range_alloc == mbcset->nranges))
+        {
+          /* There is not enough space, need realloc.  */
+          uint32_t *new_array_start;
+          uint32_t *new_array_end;
+          int new_nranges;
+
+          /* +1 in case of mbcset->nranges is 0.  */
+          new_nranges = 2 * mbcset->nranges + 1;
+          new_array_start = re_realloc (mbcset->range_starts, uint32_t,
+                                        new_nranges);
+          new_array_end = re_realloc (mbcset->range_ends, uint32_t,
+                                      new_nranges);
+
+          if (__glibc_unlikely (new_array_start == NULL
+                                || new_array_end == NULL))
+            return REG_ESPACE;
+
+          mbcset->range_starts = new_array_start;
+          mbcset->range_ends = new_array_end;
+          *range_alloc = new_nranges;
+        }
+
+      mbcset->range_starts[mbcset->nranges] = start_collseq;
+      mbcset->range_ends[mbcset->nranges++] = end_collseq;
+    }
+
+  /* Build the table for single byte characters.  */
+  for (ch = 0; ch < SBC_MAX; ch++)
+    {
+      uint32_t ch_collseq;
+      /* if (MB_CUR_MAX == 1) */
+      if (nrules == 0)
+        ch_collseq = collseqmb[ch];
+      else
+        ch_collseq = __collseq_table_lookup (collseqwc, __btowc (ch));
+      if (start_collseq <= ch_collseq && ch_collseq <= end_collseq)
+        bitset_set (sbcset, ch);
+    }
+  return REG_NOERROR;
+}
+
+/* Local function for parse_bracket_exp used in _LIBC environment.
+   Build the collating element which is represented by NAME.
+   The result are written to MBCSET and SBCSET.
+   COLL_SYM_ALLOC is the allocated size of mbcset->coll_sym, is a
+   pointer argument since we may update it.  */
+
+static __always_inline reg_errcode_t
+build_collating_symbol (bitset_t sbcset, re_charset_t *mbcset,
+                        Idx *coll_sym_alloc, const unsigned char *name,
+                        uint_fast32_t nrules, int_fast32_t table_size,
+                        const int32_t *symb_table, const unsigned char *extra)
+{
+  int32_t elem, idx;
+  size_t name_len = strlen ((const char *) name);
+  if (nrules != 0)
+    {
+      elem = seek_collating_symbol_entry (name, name_len, symb_table,
+                                          table_size, extra);
+      if (elem != -1)
+        {
+          /* We found the entry.  */
+          idx = symb_table[2 * elem + 1];
+          /* Skip the name of collating element name.  */
+          idx += 1 + extra[idx];
+        }
+      else if (name_len == 1)
+        {
+          /* No valid character, treat it as a normal
+             character.  */
+          bitset_set (sbcset, name[0]);
           return REG_NOERROR;
         }
       else
-        {
-          if (BE (name_len != 1, 0))
-            return REG_ECOLLATE;
-          else
-            {
-              bitset_set (sbcset, name[0]);
-              return REG_NOERROR;
-            }
-        }
-    }
-#endif
+        return REG_ECOLLATE;
+
+      /* Got valid collation sequence, add it as a new entry.  */
+      /* Check the space of the arrays.  */
+      if (__glibc_unlikely (*coll_sym_alloc == mbcset->ncoll_syms))
+        {
+          /* Not enough, realloc it.  */
+          /* +1 in case of mbcset->ncoll_syms is 0.  */
+          int new_coll_sym_alloc = 2 * mbcset->ncoll_syms + 1;
+          /* Use realloc since mbcset->coll_syms is NULL
+             if *alloc == 0.  */
+          int32_t *new_coll_syms = re_realloc (mbcset->coll_syms, int32_t,
+                                               new_coll_sym_alloc);
+          if (__glibc_unlikely (new_coll_syms == NULL))
+            return REG_ESPACE;
+          mbcset->coll_syms = new_coll_syms;
+          *coll_sym_alloc = new_coll_sym_alloc;
+        }
+      mbcset->coll_syms[mbcset->ncoll_syms++] = idx;
+      return REG_NOERROR;
+    }
+  else
+    {
+      if (__glibc_unlikely (name_len != 1))
+        return REG_ECOLLATE;
+      else
+        {
+          bitset_set (sbcset, name[0]);
+          return REG_NOERROR;
+        }
+    }
+}
+#endif /* _LIBC */
+
+/* This function parse bracket expression like "[abc]", "[a-c]",
+   "[[.a-a.]]" etc.  */
+
+static bin_tree_t *
+parse_bracket_exp (re_string_t *regexp, re_dfa_t *dfa, re_token_t *token,
+                   reg_syntax_t syntax, reg_errcode_t *err)
+{
+  const unsigned char *collseqmb = NULL;
+  const char *collseqwc = NULL;
+  uint_fast32_t nrules = 0;
+  int_fast32_t table_size = 0;
+  const void *symb_table = NULL;
+  const unsigned char *extra = NULL;
 
   re_token_t br_token;
   re_bitset_ptr_t sbcset;
-#ifdef RE_ENABLE_I18N
   re_charset_t *mbcset;
-  int coll_sym_alloc = 0, range_alloc = 0, mbchar_alloc = 0;
-  int equiv_class_alloc = 0, char_class_alloc = 0;
-#endif /* not RE_ENABLE_I18N */
-  int non_match = 0;
+  Idx coll_sym_alloc = 0, range_alloc = 0, mbchar_alloc = 0;
+  Idx equiv_class_alloc = 0, char_class_alloc = 0;
+  bool non_match = false;
   bin_tree_t *work_tree;
   int token_len;
-  int first_round = 1;
+  bool first_round = true;
 #ifdef _LIBC
   collseqmb = (const unsigned char *)
@@ -3007 +3065 @@
       collseqwc = _NL_CURRENT (LC_COLLATE, _NL_COLLATE_COLLSEQWC);
       table_size = _NL_CURRENT_WORD (LC_COLLATE, _NL_COLLATE_SYMB_HASH_SIZEMB);
-      symb_table = (const int32_t *) _NL_CURRENT (LC_COLLATE,
-                                                  _NL_COLLATE_SYMB_TABLEMB);
+      symb_table = _NL_CURRENT (LC_COLLATE, _NL_COLLATE_SYMB_TABLEMB);
       extra = (const unsigned char *) _NL_CURRENT (LC_COLLATE,
                                                    _NL_COLLATE_SYMB_EXTRAMB);
@@ -3014 +3071 @@
 #endif
   sbcset = (re_bitset_ptr_t) calloc (sizeof (bitset_t), 1);
-#ifdef RE_ENABLE_I18N
   mbcset = (re_charset_t *) calloc (sizeof (re_charset_t), 1);
-#endif /* RE_ENABLE_I18N */
-#ifdef RE_ENABLE_I18N
-  if (BE (sbcset == NULL || mbcset == NULL, 0))
-#else
-  if (BE (sbcset == NULL, 0))
-#endif /* RE_ENABLE_I18N */
-    {
+  if (__glibc_unlikely (sbcset == NULL || mbcset == NULL))
+    {
+      re_free (sbcset);
+      re_free (mbcset);
       *err = REG_ESPACE;
       return NULL;
@@ -3028 +3081 @@
 
   token_len = peek_token_bracket (token, regexp, syntax);
-  if (BE (token->type == END_OF_RE, 0))
+  if (__glibc_unlikely (token->type == END_OF_RE))
     {
       *err = REG_BADPAT;
@@ -3035 +3088 @@
   if (token->type == OP_NON_MATCH_LIST)
     {
-#ifdef RE_ENABLE_I18N
       mbcset->non_match = 1;
-#endif /* not RE_ENABLE_I18N */
-      non_match = 1;
+      non_match = true;
       if (syntax & RE_HAT_LISTS_NOT_NEWLINE)
-        bitset_set (sbcset, '\0');
+        bitset_set (sbcset, '\n');
       re_string_skip_bytes (regexp, token_len); /* Skip a token.  */
       token_len = peek_token_bracket (token, regexp, syntax);
-      if (BE (token->type == END_OF_RE, 0))
+      if (__glibc_unlikely (token->type == END_OF_RE))
         {
           *err = REG_BADPAT;
@@ -3060 +3111 @@
       unsigned char end_name_buf[BRACKET_NAME_BUF_SIZE];
       reg_errcode_t ret;
-      int token_len2 = 0, is_range_exp = 0;
+      int token_len2 = 0;
+      bool is_range_exp = false;
       re_token_t token2;
 
       start_elem.opr.name = start_name_buf;
+      start_elem.type = COLL_SYM;
       ret = parse_bracket_element (&start_elem, regexp, token, token_len, dfa,
                                    syntax, first_round);
-      if (BE (ret != REG_NOERROR, 0))
+      if (__glibc_unlikely (ret != REG_NOERROR))
         {
           *err = ret;
           goto parse_bracket_exp_free_return;
         }
-      first_round = 0;
+      first_round = false;
 
       /* Get information about the next token.  We need it in any case.  */
@@ -3079 +3132 @@
       if (start_elem.type != CHAR_CLASS && start_elem.type != EQUIV_CLASS)
         {
-          if (BE (token->type == END_OF_RE, 0))
+          if (__glibc_unlikely (token->type == END_OF_RE))
             {
               *err = REG_EBRACK;
@@ -3088 +3141 @@
               re_string_skip_bytes (regexp, token_len); /* Skip '-'.  */
               token_len2 = peek_token_bracket (&token2, regexp, syntax);
-              if (BE (token2.type == END_OF_RE, 0))
+              if (__glibc_unlikely (token2.type == END_OF_RE))
                 {
                   *err = REG_EBRACK;
@@ -3100 +3153 @@
                 }
               else
-                is_range_exp = 1;
+                is_range_exp = true;
             }
         }
 
-      if (is_range_exp == 1)
+      if (is_range_exp == true)
         {
           end_elem.opr.name = end_name_buf;
+          end_elem.type = COLL_SYM;
           ret = parse_bracket_element (&end_elem, regexp, &token2, token_len2,
-                                       dfa, syntax, 1);
-          if (BE (ret != REG_NOERROR, 0))
+                                       dfa, syntax, true);
+          if (__glibc_unlikely (ret != REG_NOERROR))
             {
               *err = ret;
@@ -3117 +3171 @@
           token_len = peek_token_bracket (token, regexp, syntax);
 
-#ifdef _LIBC
           *err = build_range_exp (sbcset, mbcset, &range_alloc,
-                                  &start_elem, &end_elem);
-#else
-# ifdef RE_ENABLE_I18N
-          *err = build_range_exp (sbcset,
-                                  dfa->mb_cur_max > 1 ? mbcset : NULL,
-                                  &range_alloc, &start_elem, &end_elem);
-# else
-          *err = build_range_exp (sbcset, &start_elem, &end_elem);
-# endif
-#endif /* RE_ENABLE_I18N */
-          if (BE (*err != REG_NOERROR, 0))
+                                  &start_elem, &end_elem,
+                                  dfa, syntax, nrules, collseqmb, collseqwc,
+                                  table_size, symb_table, extra);
+          if (__glibc_unlikely (*err != REG_NOERROR))
             goto parse_bracket_exp_free_return;
         }
@@ -3139 +3185 @@
               bitset_set (sbcset, start_elem.opr.ch);
               break;
-#ifdef RE_ENABLE_I18N
             case MB_CHAR:
               /* Check whether the array has enough space.  */
-              if (BE (mbchar_alloc == mbcset->nmbchars, 0))
+              if (__glibc_unlikely (mbchar_alloc == mbcset->nmbchars))
                 {
                   wchar_t *new_mbchars;
@@ -3151 +3196 @@
                   new_mbchars = re_realloc (mbcset->mbchars, wchar_t,
                                             mbchar_alloc);
-                  if (BE (new_mbchars == NULL, 0))
+                  if (__glibc_unlikely (new_mbchars == NULL))
                     goto parse_bracket_exp_espace;
                   mbcset->mbchars = new_mbchars;
@@ -3157 +3202 @@
               mbcset->mbchars[mbcset->nmbchars++] = start_elem.opr.wch;
               break;
-#endif /* RE_ENABLE_I18N */
             case EQUIV_CLASS:
               *err = build_equiv_class (sbcset,
-#ifdef RE_ENABLE_I18N
                                         mbcset, &equiv_class_alloc,
-#endif /* RE_ENABLE_I18N */
                                         start_elem.opr.name);
-              if (BE (*err != REG_NOERROR, 0))
+              if (__glibc_unlikely (*err != REG_NOERROR))
                 goto parse_bracket_exp_free_return;
               break;
             case COLL_SYM:
               *err = build_collating_symbol (sbcset,
-#ifdef RE_ENABLE_I18N
                                              mbcset, &coll_sym_alloc,
-#endif /* RE_ENABLE_I18N */
-                                             start_elem.opr.name);
-              if (BE (*err != REG_NOERROR, 0))
+                                             start_elem.opr.name,
+                                             nrules, table_size, symb_table, extra);
+              if (__glibc_unlikely (*err != REG_NOERROR))
                 goto parse_bracket_exp_free_return;
               break;
             case CHAR_CLASS:
               *err = build_charclass (regexp->trans, sbcset,
-#ifdef RE_ENABLE_I18N
                                       mbcset, &char_class_alloc,
-#endif /* RE_ENABLE_I18N */
-                                      start_elem.opr.name, syntax);
-              if (BE (*err != REG_NOERROR, 0))
+                                      (const char *) start_elem.opr.name,
+                                      syntax);
+              if (__glibc_unlikely (*err != REG_NOERROR))
                goto parse_bracket_exp_free_return;
               break;
             default:
-              assert (0);
+              DEBUG_ASSERT (false);
               break;
             }
         }
-      if (BE (token->type == END_OF_RE, 0))
+      if (__glibc_unlikely (token->type == END_OF_RE))
         {
           *err = REG_EBRACK;
@@ -3205 +3245 @@
     bitset_not (sbcset);
 
-#ifdef RE_ENABLE_I18N
   /* Ensure only single byte characters are set.  */
   if (dfa->mb_cur_max > 1)
@@ -3221 +3260 @@
       br_token.opr.mbcset = mbcset;
       mbc_tree = create_token_tree (dfa, NULL, NULL, &br_token);
-      if (BE (mbc_tree == NULL, 0))
+      if (__glibc_unlikely (mbc_tree == NULL))
         goto parse_bracket_exp_espace;
       for (sbc_idx = 0; sbc_idx < BITSET_WORDS; ++sbc_idx)
@@ -3230 +3269 @@
       if (sbc_idx < BITSET_WORDS)
         {
-          /* Build a tree for simple bracket.  */
-          br_token.type = SIMPLE_BRACKET;
-          br_token.opr.sbcset = sbcset;
-          work_tree = create_token_tree (dfa, NULL, NULL, &br_token);
-          if (BE (work_tree == NULL, 0))
-            goto parse_bracket_exp_espace;
-
-          /* Then join them by ALT node.  */
-          work_tree = create_tree (dfa, work_tree, mbc_tree, OP_ALT);
-          if (BE (work_tree == NULL, 0))
-            goto parse_bracket_exp_espace;
+          /* Build a tree for simple bracket.  */
+          br_token.type = SIMPLE_BRACKET;
+          br_token.opr.sbcset = sbcset;
+          work_tree = create_token_tree (dfa, NULL, NULL, &br_token);
+          if (__glibc_unlikely (work_tree == NULL))
+            goto parse_bracket_exp_espace;
+
+          /* Then join them by ALT node.  */
+          work_tree = create_tree (dfa, work_tree, mbc_tree, OP_ALT);
+          if (__glibc_unlikely (work_tree == NULL))
+            goto parse_bracket_exp_espace;
         }
       else
@@ -3249 +3288 @@
     }
   else
-#endif /* not RE_ENABLE_I18N */
-    {
-#ifdef RE_ENABLE_I18N
+    {
       free_charset (mbcset);
-#endif
       /* Build a tree for simple bracket.  */
       br_token.type = SIMPLE_BRACKET;
       br_token.opr.sbcset = sbcset;
       work_tree = create_token_tree (dfa, NULL, NULL, &br_token);
-      if (BE (work_tree == NULL, 0))
-        goto parse_bracket_exp_espace;
+      if (__glibc_unlikely (work_tree == NULL))
+        goto parse_bracket_exp_espace;
     }
   return work_tree;
@@ -3267 +3303 @@
  parse_bracket_exp_free_return:
   re_free (sbcset);
-#ifdef RE_ENABLE_I18N
   free_charset (mbcset);
-#endif /* RE_ENABLE_I18N */
   return NULL;
 }
@@ -3278 +3312 @@
 parse_bracket_element (bracket_elem_t *elem, re_string_t *regexp,
                        re_token_t *token, int token_len, re_dfa_t *dfa,
-                       reg_syntax_t syntax, int accept_hyphen)
-{
-#ifdef RE_ENABLE_I18N
+                       reg_syntax_t syntax, bool accept_hyphen)
+{
   int cur_char_size;
   cur_char_size = re_string_char_size_at (regexp, re_string_cur_idx (regexp));
@@ -3290 +3323 @@
       return REG_NOERROR;
     }
-#endif /* RE_ENABLE_I18N */
   re_string_skip_bytes (regexp, token_len); /* Skip a token.  */
   if (token->type == OP_OPEN_COLL_ELEM || token->type == OP_OPEN_CHAR_CLASS
       || token->type == OP_OPEN_EQUIV_CLASS)
     return parse_bracket_symbol (elem, regexp, token);
-  if (BE (token->type == OP_CHARSET_RANGE, 0) && !accept_hyphen)
+  if (__glibc_unlikely (token->type == OP_CHARSET_RANGE) && !accept_hyphen)
     {
       /* A '-' must only appear as anything but a range indicator before
@@ -3360 +3392 @@
      The result are written to MBCSET and SBCSET.
      EQUIV_CLASS_ALLOC is the allocated size of mbcset->equiv_classes,
-     is a pointer argument sinse we may update it.  */
+     is a pointer argument since we may update it.  */
 
 static reg_errcode_t
-#ifdef RE_ENABLE_I18N
 build_equiv_class (bitset_t sbcset, re_charset_t *mbcset,
-                   int *equiv_class_alloc, const unsigned char *name)
-#else /* not RE_ENABLE_I18N */
-build_equiv_class (bitset_t sbcset, const unsigned char *name)
-#endif /* not RE_ENABLE_I18N */
+                   Idx *equiv_class_alloc, const unsigned char *name)
 {
 #ifdef _LIBC
@@ -3380 +3408 @@
       unsigned int ch;
       size_t len;
-      /* This #include defines a local function!  */
-# include <locale/weight.h>
       /* Calculate the index for equivalence class.  */
       cp = name;
@@ -3391 +3417 @@
       indirect = (const int32_t *) _NL_CURRENT (LC_COLLATE,
                                                 _NL_COLLATE_INDIRECTMB);
-      idx1 = findidx (&cp);
-      if (BE (idx1 == 0 || cp < name + strlen ((const char *) name), 0))
+      idx1 = findidx (table, indirect, extra, &cp, -1);
+      if (__glibc_unlikely (idx1 == 0 || *cp != '\0'))
         /* This isn't a valid character.  */
         return REG_ECOLLATE;
 
-      /* Build single byte matcing table for this equivalence class.  */
-      char_buf[1] = (unsigned char) '\0';
-      len = weights[idx1];
+      /* Build single byte matching table for this equivalence class.  */
+      len = weights[idx1 & 0xffffff];
       for (ch = 0; ch < SBC_MAX; ++ch)
         {
           char_buf[0] = ch;
           cp = char_buf;
-          idx2 = findidx (&cp);
+          idx2 = findidx (table, indirect, extra, &cp, 1);
 /*
           idx2 = table[ch];
@@ -3410 +3435 @@
             /* This isn't a valid character.  */
             continue;
-          if (len == weights[idx2])
-            {
-              int cnt = 0;
-              while (cnt <= len &&
-                     weights[idx1 + 1 + cnt] == weights[idx2 + 1 + cnt])
-                ++cnt;
-
-              if (cnt > len)
-                bitset_set (sbcset, ch);
-            }
+          /* Compare only if the length matches and the collation rule
+             index is the same.  */
+          if (len == weights[idx2 & 0xffffff] && (idx1 >> 24) == (idx2 >> 24)
+              && memcmp (weights + (idx1 & 0xffffff) + 1,
+                         weights + (idx2 & 0xffffff) + 1, len) == 0)
+            bitset_set (sbcset, ch);
         }
       /* Check whether the array has enough space.  */
-      if (BE (*equiv_class_alloc == mbcset->nequiv_classes, 0))
+      if (__glibc_unlikely (*equiv_class_alloc == mbcset->nequiv_classes))
         {
           /* Not enough, realloc it.  */
           /* +1 in case of mbcset->nequiv_classes is 0.  */
-          int new_equiv_class_alloc = 2 * mbcset->nequiv_classes + 1;
+          Idx new_equiv_class_alloc = 2 * mbcset->nequiv_classes + 1;
           /* Use realloc since the array is NULL if *alloc == 0.  */
           int32_t *new_equiv_classes = re_realloc (mbcset->equiv_classes,
                                                    int32_t,
                                                    new_equiv_class_alloc);
-          if (BE (new_equiv_classes == NULL, 0))
+          if (__glibc_unlikely (new_equiv_classes == NULL))
             return REG_ESPACE;
           mbcset->equiv_classes = new_equiv_classes;
@@ -3441 +3462 @@
 #endif /* _LIBC */
     {
-      if (BE (strlen ((const char *) name) != 1, 0))
+      if (__glibc_unlikely (strlen ((const char *) name) != 1))
         return REG_ECOLLATE;
       bitset_set (sbcset, *name);
@@ -3452 +3473 @@
      The result are written to MBCSET and SBCSET.
      CHAR_CLASS_ALLOC is the allocated size of mbcset->char_classes,
-     is a pointer argument sinse we may update it.  */
+     is a pointer argument since we may update it.  */
 
 static reg_errcode_t
-#ifdef RE_ENABLE_I18N
 build_charclass (RE_TRANSLATE_TYPE trans, bitset_t sbcset,
-                 re_charset_t *mbcset, int *char_class_alloc,
-                 const unsigned char *class_name, reg_syntax_t syntax)
-#else /* not RE_ENABLE_I18N */
-build_charclass (RE_TRANSLATE_TYPE trans, bitset_t sbcset,
-                 const unsigned char *class_name, reg_syntax_t syntax)
-#endif /* not RE_ENABLE_I18N */
+                 re_charset_t *mbcset, Idx *char_class_alloc,
+                 const char *class_name, reg_syntax_t syntax)
 {
   int i;
-  const char *name = (const char *) class_name;
+  const char *name = class_name;
 
   /* In case of REG_ICASE "upper" and "lower" match the both of
@@ -3473 +3489 @@
     name = "alpha";
 
-#ifdef RE_ENABLE_I18N
   /* Check the space of the arrays.  */
-  if (BE (*char_class_alloc == mbcset->nchar_classes, 0))
+  if (__glibc_unlikely (*char_class_alloc == mbcset->nchar_classes))
     {
       /* Not enough, realloc it.  */
       /* +1 in case of mbcset->nchar_classes is 0.  */
-      int new_char_class_alloc = 2 * mbcset->nchar_classes + 1;
+      Idx new_char_class_alloc = 2 * mbcset->nchar_classes + 1;
       /* Use realloc since array is NULL if *alloc == 0.  */
       wctype_t *new_char_classes = re_realloc (mbcset->char_classes, wctype_t,
                                                new_char_class_alloc);
-      if (BE (new_char_classes == NULL, 0))
+      if (__glibc_unlikely (new_char_classes == NULL))
         return REG_ESPACE;
       mbcset->char_classes = new_char_classes;
@@ -3489 +3504 @@
     }
   mbcset->char_classes[mbcset->nchar_classes++] = __wctype (name);
-#endif /* RE_ENABLE_I18N */
 
 #define BUILD_CHARCLASS_LOOP(ctype_func)        \
   do {                                          \
-    if (BE (trans != NULL, 0))                  \
+    if (__glibc_unlikely (trans != NULL))                       \
       {                                         \
         for (i = 0; i < SBC_MAX; ++i)           \
-          if (ctype_func (i))                   \
+          if (ctype_func (i))                   \
             bitset_set (sbcset, trans[i]);      \
       }                                         \
@@ -3502 +3516 @@
       {                                         \
         for (i = 0; i < SBC_MAX; ++i)           \
-          if (ctype_func (i))                   \
+          if (ctype_func (i))                   \
             bitset_set (sbcset, i);             \
       }                                         \
@@ -3539 +3553 @@
 static bin_tree_t *
 build_charclass_op (re_dfa_t *dfa, RE_TRANSLATE_TYPE trans,
-                    const unsigned char *class_name,
-                    const unsigned char *extra, int non_match,
+                    const char *class_name,
+                    const char *extra, bool non_match,
                     reg_errcode_t *err)
 {
   re_bitset_ptr_t sbcset;
-#ifdef RE_ENABLE_I18N
   re_charset_t *mbcset;
-  int alloc = 0;
-#endif /* not RE_ENABLE_I18N */
+  Idx alloc = 0;
   reg_errcode_t ret;
-  re_token_t br_token;
   bin_tree_t *tree;
 
   sbcset = (re_bitset_ptr_t) calloc (sizeof (bitset_t), 1);
-#ifdef RE_ENABLE_I18N
-  mbcset = (re_charset_t *) calloc (sizeof (re_charset_t), 1);
-#endif /* RE_ENABLE_I18N */
-
-#ifdef RE_ENABLE_I18N
-  if (BE (sbcset == NULL || mbcset == NULL, 0))
-#else /* not RE_ENABLE_I18N */
-  if (BE (sbcset == NULL, 0))
-#endif /* not RE_ENABLE_I18N */
+  if (__glibc_unlikely (sbcset == NULL))
     {
       *err = REG_ESPACE;
       return NULL;
     }
-
-  if (non_match)
-    {
-#ifdef RE_ENABLE_I18N
-      /*
-      if (syntax & RE_HAT_LISTS_NOT_NEWLINE)
-        bitset_set(cset->sbcset, '\0');
-      */
-      mbcset->non_match = 1;
-#endif /* not RE_ENABLE_I18N */
-    }
+  mbcset = (re_charset_t *) calloc (sizeof (re_charset_t), 1);
+  if (__glibc_unlikely (mbcset == NULL))
+    {
+      re_free (sbcset);
+      *err = REG_ESPACE;
+      return NULL;
+    }
+  mbcset->non_match = non_match;
 
   /* We don't care the syntax in this case.  */
-  ret = build_charclass (trans, sbcset,
-#ifdef RE_ENABLE_I18N
-                         mbcset, &alloc,
-#endif /* RE_ENABLE_I18N */
-                         class_name, 0);
-
-  if (BE (ret != REG_NOERROR, 0))
+  ret = build_charclass (trans, sbcset, mbcset, &alloc, class_name, 0);
+
+  if (__glibc_unlikely (ret != REG_NOERROR))
     {
       re_free (sbcset);
-#ifdef RE_ENABLE_I18N
       free_charset (mbcset);
-#endif /* RE_ENABLE_I18N */
       *err = ret;
       return NULL;
@@ -3602 +3596 @@
     bitset_not (sbcset);
 
-#ifdef RE_ENABLE_I18N
   /* Ensure only single byte characters are set.  */
   if (dfa->mb_cur_max > 1)
     bitset_mask (sbcset, dfa->sb_char);
-#endif
 
   /* Build a tree for simple bracket.  */
-  br_token.type = SIMPLE_BRACKET;
-  br_token.opr.sbcset = sbcset;
+  re_token_t br_token = { .type = SIMPLE_BRACKET, .opr.sbcset = sbcset };
   tree = create_token_tree (dfa, NULL, NULL, &br_token);
-  if (BE (tree == NULL, 0))
+  if (__glibc_unlikely (tree == NULL))
     goto build_word_op_espace;
 
-#ifdef RE_ENABLE_I18N
   if (dfa->mb_cur_max > 1)
     {
@@ -3624 +3614 @@
       dfa->has_mb_node = 1;
       mbc_tree = create_token_tree (dfa, NULL, NULL, &br_token);
-      if (BE (mbc_tree == NULL, 0))
+      if (__glibc_unlikely (mbc_tree == NULL))
         goto build_word_op_espace;
       /* Then join them by ALT node.  */
       tree = create_tree (dfa, tree, mbc_tree, OP_ALT);
-      if (BE (mbc_tree != NULL, 1))
+      if (__glibc_likely (mbc_tree != NULL))
         return tree;
     }
@@ -3636 +3626 @@
       return tree;
     }
-#else /* not RE_ENABLE_I18N */
-  return tree;
-#endif /* not RE_ENABLE_I18N */
 
  build_word_op_espace:
   re_free (sbcset);
-#ifdef RE_ENABLE_I18N
   free_charset (mbcset);
-#endif /* RE_ENABLE_I18N */
   *err = REG_ESPACE;
   return NULL;
@@ -3650 +3635 @@
 
 /* This is intended for the expressions like "a{1,3}".
-   Fetch a number from `input', and return the number.
-   Return -1, if the number field is empty like "{,1}".
-   Return -2, If an error is occured.  */
-
-static int
+   Fetch a number from 'input', and return the number.
+   Return -1 if the number field is empty like "{,1}".
+   Return RE_DUP_MAX + 1 if the number field is too large.
+   Return -2 if an error occurred.  */
+
+static Idx
 fetch_number (re_string_t *input, re_token_t *token, reg_syntax_t syntax)
 {
-  int num = -1;
+  Idx num = -1;
   unsigned char c;
   while (1)
@@ -3663 +3649 @@
       fetch_token (token, input, syntax);
       c = token->opr.c;
-      if (BE (token->type == END_OF_RE, 0))
+      if (__glibc_unlikely (token->type == END_OF_RE))
         return -2;
       if (token->type == OP_CLOSE_DUP_NUM || c == ',')
         break;
       num = ((token->type != CHARACTER || c < '0' || '9' < c || num == -2)
-             ? -2 : ((num == -1) ? c - '0' : num * 10 + c - '0'));
-      num = (num > RE_DUP_MAX) ? -2 : num;
+             ? -2
+             : num == -1
+             ? c - '0'
+             : MIN (RE_DUP_MAX + 1, num * 10 + c - '0'));
     }
   return num;
@@ -3675 +3663 @@
 
 
-#ifdef RE_ENABLE_I18N
 static void
 free_charset (re_charset_t *cset)
 {
   re_free (cset->mbchars);
-# ifdef _LIBC
+#ifdef _LIBC
   re_free (cset->coll_syms);
   re_free (cset->equiv_classes);
+#endif
   re_free (cset->range_starts);
   re_free (cset->range_ends);
-# endif
   re_free (cset->char_classes);
   re_free (cset);
 }
-#endif /* RE_ENABLE_I18N */
 
 
@@ -3700 +3686 @@
              re_token_type_t type)
 {
-  re_token_t t;
-  t.type = type;
+  re_token_t t = { .type = type };
   return create_token_tree (dfa, left, right, &t);
 }
@@ -3710 +3695 @@
 {
   bin_tree_t *tree;
-  if (BE (dfa->str_tree_storage_idx == BIN_TREE_STORAGE_SIZE, 0))
+  if (__glibc_unlikely (dfa->str_tree_storage_idx == BIN_TREE_STORAGE_SIZE))
     {
       bin_tree_storage_t *storage = re_malloc (bin_tree_storage_t, 1);
@@ -3745 +3730 @@
 mark_opt_subexp (void *extra, bin_tree_t *node)
 {
-  int idx = (int) (long) extra;
+  Idx idx = (uintptr_t) extra;
   if (node->token.type == SUBEXP && node->token.opr.idx == idx)
     node->token.opt_subexp = 1;
@@ -3757 +3742 @@
 free_token (re_token_t *node)
 {
-#ifdef RE_ENABLE_I18N
   if (node->type == COMPLEX_BRACKET && node->duplicated == 0)
     free_charset (node->opr.mbcset);
-  else
-#endif /* RE_ENABLE_I18N */
-    if (node->type == SIMPLE_BRACKET && node->duplicated == 0)
-      re_free (node->opr.sbcset);
+  else if (node->type == SIMPLE_BRACKET && node->duplicated == 0)
+    re_free (node->opr.sbcset);
 }
 
@@ -3814 +3796 @@
               dup_node = dup_node->parent;
               if (!node)
-                return dup_root;
+                return dup_root;
             }
           node = node->right;