Changeset 37702 in vbox for trunk/include/VBox

Timestamp:

Jun 30, 2011 10:09:59 AM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

72562

Message:

REM/VMM: Don't flush the TLB if you don't hold the EM/REM lock, some other EMT may be executing code in the recompiler and could be really surprised by a TLB flush.

Location:

trunk/include/VBox

Files:

• dis.h (modified) (6 diffs)
• types.h (modified) (1 diff)
• vmm/em.h (modified) (2 diffs)

trunk/include/VBox/dis.h

@@ -32 +32 @@
 
 #if defined(__L4ENV__)
-#include <setjmp.h>
+# include <setjmp.h>
 #endif
 
@@ -368 +368 @@
  * Operand Parameter.
  */
-typedef struct _OP_PARAMETER
+typedef struct OP_PARAMETER
 {
     /** @todo switch param and parval and move disp64 and flags up here with the other 64-bit vars to get more natural alignment and save space. */
@@ -416 +416 @@
 
 
-struct _OPCODE;
 /** Pointer to opcode. */
-typedef struct _OPCODE *POPCODE;
+typedef struct OPCODE *POPCODE;
 /** Pointer to const opcode. */
-typedef const struct _OPCODE *PCOPCODE;
+typedef const struct OPCODE *PCOPCODE;
 
 typedef DECLCALLBACK(int) FN_DIS_READBYTES(RTUINTPTR pSrc, uint8_t *pDest, unsigned size, void *pvUserdata);
 typedef FN_DIS_READBYTES *PFN_DIS_READBYTES;
-
-/* forward decl */
-struct _DISCPUSTATE;
-/** Pointer to the disassembler CPU state. */
-typedef struct _DISCPUSTATE *PDISCPUSTATE;
 
 /** Parser callback.
@@ -435 +429 @@
 typedef FNDISPARSE *PFNDISPARSE;
 
-typedef struct _DISCPUSTATE
+typedef struct DISCPUSTATE
 {
     /* Global setting */
@@ -513 +507 @@
 } DISCPUSTATE;
 
-/** Pointer to a const disassembler CPU state. */
-typedef DISCPUSTATE const *PCDISCPUSTATE;
-
 /** The storage padding sufficient to hold the largest DISCPUSTATE in all
  * contexts (R3, R0 and RC). Used various places in the VMM internals.   */
@@ -522 +513 @@
 /** Opcode. */
 #pragma pack(4)
-typedef struct _OPCODE
+typedef struct OPCODE
 {
 #ifndef DIS_CORE_ONLY

trunk/include/VBox/types.h

@@ -1054 +1054 @@
 } CPUMMODE;
 
+
+/** Pointer to the disassembler CPU state. */
+typedef struct DISCPUSTATE *PDISCPUSTATE;
+/** Pointer to a const disassembler CPU state. */
+typedef struct DISCPUSTATE const *PCDISCPUSTATE;
+
+
 /** @} */
 

trunk/include/VBox/vmm/em.h

@@ -29 +29 @@
 #include <VBox/types.h>
 #include <VBox/vmm/trpm.h>
-#include <VBox/dis.h>
 
 
@@ -189 +188 @@
 VMMDECL(void)       EMRemLock(PVM pVM);
 VMMDECL(bool)       EMRemIsLockOwner(PVM pVM);
-VMMDECL(int)        EMTryEnterRemLock(PVM pVM);
+VMMDECL(int)        EMRemTryLock(PVM pVM);
 /** @} */