Changeset 37702 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Jun 30, 2011 10:09:59 AM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

72562

Message:

REM/VMM: Don't flush the TLB if you don't hold the EM/REM lock, some other EMT may be executing code in the recompiler and could be really surprised by a TLB flush.

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• EMAll.cpp (modified) (2 diffs)
• REMAll.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/EMAll.cpp

@@ -3136 +3136 @@
 VMMDECL(bool) EMRemIsLockOwner(PVM pVM)
 {
+    if (!PDMCritSectIsInitialized(&pVM->em.s.CritSectREM))
+        return true;   /* early init */
+
     return PDMCritSectIsOwner(&pVM->em.s.CritSectREM);
 }
@@ -3145 +3148 @@
  * @param   pVM         The VM to operate on.
  */
-VMMDECL(int) EMTryEnterRemLock(PVM pVM)
-{
+VMMDECL(int) EMRemTryLock(PVM pVM)
+{
+    if (!PDMCritSectIsInitialized(&pVM->em.s.CritSectREM))
+        return VINF_SUCCESS; /* early init */
+
     return PDMCritSectTryEnter(&pVM->em.s.CritSectREM);
 }

trunk/src/VBox/VMM/VMMAll/REMAll.cpp

@@ -47 +47 @@
      */
     if (   pVM->rem.s.cInvalidatedPages < RT_ELEMENTS(pVM->rem.s.aGCPtrInvalidatedPages)
-        && EMTryEnterRemLock(pVM) == VINF_SUCCESS)
+        && EMRemTryLock(pVM) == VINF_SUCCESS)
     {
         uint32_t iPage = pVM->rem.s.cInvalidatedPages;