Changeset 39402 in vbox for trunk/src/VBox

Timestamp:

Nov 23, 2011 4:25:04 PM (13 years ago)

Author:

vboxsync

Message:

VMM: don't use generic IPE status codes, use specific ones. Part 1.

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/EMAll.cpp (modified) (3 diffs)
• VMMAll/IEMAll.cpp (modified) (1 diff)
• VMMAll/IOMAllMMIO.cpp (modified) (5 diffs)
• VMMAll/PDMAll.cpp (modified) (2 diffs)
• VMMAll/PDMAllCritSect.cpp (modified) (1 diff)
• VMMAll/PGMAll.cpp (modified) (11 diffs)
• VMMAll/PGMAllBth.h (modified) (11 diffs)
• VMMAll/PGMAllHandler.cpp (modified) (3 diffs)
• VMMAll/PGMAllPhys.cpp (modified) (8 diffs)
• VMMAll/PGMAllPool.cpp (modified) (2 diffs)
• VMMAll/PGMAllShw.h (modified) (1 diff)
• VMMAll/TMAll.cpp (modified) (6 diffs)
• VMMAll/TMAllCpu.cpp (modified) (2 diffs)
• VMMAll/TMAllVirtual.cpp (modified) (4 diffs)
• VMMR0/GMMR0.cpp (modified) (48 diffs)
• VMMR0/GVMMR0.cpp (modified) (14 diffs)
• VMMR0/HWACCMR0.cpp (modified) (1 diff)
• VMMR0/HWSVMR0.cpp (modified) (7 diffs)
• VMMR0/HWVMXR0.cpp (modified) (2 diffs)
• VMMR0/PGMR0.cpp (modified) (2 diffs)
• VMMR0/VMMR0JmpA-amd64.asm (modified) (4 diffs)
• VMMR0/VMMR0JmpA-x86.asm (modified) (3 diffs)
• VMMR3/HWACCM.cpp (modified) (1 diff)
• VMMR3/IOM.cpp (modified) (5 diffs)
• VMMR3/MMHyper.cpp (modified) (1 diff)
• VMMR3/PDM.cpp (modified) (1 diff)
• VMMR3/PDMCritSect.cpp (modified) (3 diffs)
• VMMR3/PDMDevHlp.cpp (modified) (3 diffs)
• VMMR3/PDMDevMiscHlp.cpp (modified) (1 diff)
• VMMR3/PDMThread.cpp (modified) (8 diffs)
• VMMR3/PGM.cpp (modified) (1 diff)
• VMMR3/PGMMap.cpp (modified) (2 diffs)
• VMMR3/PGMPhys.cpp (modified) (4 diffs)
• VMMR3/PGMPool.cpp (modified) (1 diff)
• VMMR3/PGMSavedState.cpp (modified) (13 diffs)
• VMMR3/SELM.cpp (modified) (2 diffs)
• VMMR3/SSM.cpp (modified) (20 diffs)
• VMMR3/TM.cpp (modified) (5 diffs)
• VMMR3/VM.cpp (modified) (10 diffs)
• VMMR3/VMEmt.cpp (modified) (1 diff)
• VMMR3/VMM.cpp (modified) (5 diffs)
• VMMR3/VMMSwitcher.cpp (modified) (1 diff)
• VMMR3/VMReq.cpp (modified) (1 diff)
• VMMRC/IOMRC.cpp (modified) (1 diff)
• VMMRC/MMRamRC.cpp (modified) (2 diffs)
• VMMRC/TRPMRCHandlers.cpp (modified) (5 diffs)
• VMMRZ/PGMRZDynMap.cpp (modified) (15 diffs)
• VMMRZ/VMMRZ.cpp (modified) (1 diff)
• testcase/tstIEMCheckMc.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/EMAll.cpp

@@ -218 +218 @@
  * @returns VBox status code, see SELMToFlatEx and EMInterpretDisasOneEx for
  *          details.
- * @retval  VERR_INTERNAL_ERROR on DISCoreOneEx failure.
+ * @retval  VERR_EM_INTERNAL_DISAS_ERROR on DISCoreOneEx failure.
  *
  * @param   pVM             The VM handle.
@@ -246 +246 @@
  *
  * @returns VBox status code.
- * @retval  VERR_INTERNAL_ERROR on DISCoreOneEx failure.
+ * @retval  VERR_EM_INTERNAL_DISAS_ERROR on DISCoreOneEx failure.
  *
  * @param   pVM             The VM handle.
@@ -291 +291 @@
         return VINF_SUCCESS;
     AssertMsgFailed(("DISCoreOne failed to GCPtrInstr=%RGv rc=%Rrc\n", GCPtrInstr, rc));
-    return VERR_INTERNAL_ERROR;
+    return VERR_EM_INTERNAL_DISAS_ERROR;
 }
 

trunk/src/VBox/VMM/VMMAll/IEMAll.cpp

@@ -154 +154 @@
 /** Used to shut up GCC warnings about variables that 'may be used uninitialized'
  * due to GCC lacking knowledge about the value range of a switch. */
-#define IEM_NOT_REACHED_DEFAULT_CASE_RET() default: AssertFailedReturn(VERR_INTERNAL_ERROR_4)
+#define IEM_NOT_REACHED_DEFAULT_CASE_RET() default: AssertFailedReturn(VERR_IPE_NOT_REACHED_DEFAULT_CASE)
 
 /**

trunk/src/VBox/VMM/VMMAll/IOMAllMMIO.cpp

@@ -95 +95 @@
     AssertReturn(   (pRange->fFlags & IOMMMIO_FLAGS_WRITE_MODE) != IOMMMIO_FLAGS_WRITE_PASSTHRU
                  || (pRange->fFlags & IOMMMIO_FLAGS_WRITE_MODE) <= IOMMMIO_FLAGS_WRITE_DWORD_QWORD_READ_MISSING,
-                 VERR_INTERNAL_ERROR_5);
-    AssertReturn(cbValue != 0 && cbValue <= 16, VERR_INTERNAL_ERROR_4);
+                 VERR_IOM_MMIO_IPE_1);
+    AssertReturn(cbValue != 0 && cbValue <= 16, VERR_IOM_MMIO_IPE_2);
     RTGCPHYS const GCPhysStart  = GCPhys; NOREF(GCPhysStart);
     bool const     fReadMissing = (pRange->fFlags & IOMMMIO_FLAGS_WRITE_MODE) >= IOMMMIO_FLAGS_WRITE_DWORD_READ_MISSING;
@@ -189 +189 @@
                 break;
             default:
-                AssertFailedReturn(VERR_INTERNAL_ERROR_3);
+                AssertFailedReturn(VERR_IOM_MMIO_IPE_3);
         }
         if (offAccess)
@@ -296 +296 @@
     AssertReturn(   (pRange->fFlags & IOMMMIO_FLAGS_READ_MODE) == IOMMMIO_FLAGS_READ_DWORD
                  || (pRange->fFlags & IOMMMIO_FLAGS_READ_MODE) == IOMMMIO_FLAGS_READ_DWORD_QWORD,
-                 VERR_INTERNAL_ERROR_5);
-    AssertReturn(cbValue != 0 && cbValue <= 16, VERR_INTERNAL_ERROR_4);
+                 VERR_IOM_MMIO_IPE_1);
+    AssertReturn(cbValue != 0 && cbValue <= 16, VERR_IOM_MMIO_IPE_2);
     RTGCPHYS const GCPhysStart = GCPhys; NOREF(GCPhysStart);
 
@@ -1788 +1788 @@
      */
     PIOMMMIORANGE pRange = iomMmioGetRange(pVM, GCPhys);
-    AssertMsg(pRange, ("Handlers and page tables are out of sync or something! GCPhys=%RGp cbValue=%d\n", GCPhys, cbValue));
     if (!pRange)
     {
+        AssertMsgFailed(("Handlers and page tables are out of sync or something! GCPhys=%RGp cbValue=%d\n", GCPhys, cbValue));
         IOM_UNLOCK(pVM);
-        return VERR_INTERNAL_ERROR;
+        return VERR_IOM_MMIO_RANGE_NOT_FOUND;
     }
 #ifdef VBOX_WITH_STATISTICS
@@ -1917 +1917 @@
      */
     PIOMMMIORANGE pRange = iomMmioGetRange(pVM, GCPhys);
-    AssertMsg(pRange, ("Handlers and page tables are out of sync or something! GCPhys=%RGp cbValue=%d\n", GCPhys, cbValue));
     if (!pRange)
     {
+        AssertMsgFailed(("Handlers and page tables are out of sync or something! GCPhys=%RGp cbValue=%d\n", GCPhys, cbValue));
         IOM_UNLOCK(pVM);
-        return VERR_INTERNAL_ERROR;
+        return VERR_IOM_MMIO_RANGE_NOT_FOUND;
     }
 #ifdef VBOX_WITH_STATISTICS

trunk/src/VBox/VMM/VMMAll/PDMAll.cpp

@@ -352 +352 @@
 {
 #ifdef IN_RING3
-    int rc = PDMCritSectEnter(&pVM->pdm.s.CritSect, VERR_INTERNAL_ERROR);
+    int rc = PDMCritSectEnter(&pVM->pdm.s.CritSect, VERR_IGNORED);
 #else
     int rc = PDMCritSectEnter(&pVM->pdm.s.CritSect, VERR_GENERAL_FAILURE);
@@ -402 +402 @@
         Log(("PDMVMMDevHeapR3ToGCPhys: pv=%p pvVMMDevHeap=%p cbVMMDevHeap=%#x\n",
              pv, pVM->pdm.s.pvVMMDevHeap, pVM->pdm.s.cbVMMDevHeap));
-        return VERR_INTERNAL_ERROR_3;
+        return VERR_PDM_DEV_HEAP_R3_TO_GCPHYS;
     }
 

trunk/src/VBox/VMM/VMMAll/PDMAllCritSect.cpp

@@ -482 +482 @@
 VMMR3DECL(int) PDMR3CritSectEnterEx(PPDMCRITSECT pCritSect, bool fCallRing3)
 {
-    int rc = PDMCritSectEnter(pCritSect, VERR_INTERNAL_ERROR);
+    int rc = PDMCritSectEnter(pCritSect, VERR_IGNORED);
     if (    rc == VINF_SUCCESS
         &&  fCallRing3

trunk/src/VBox/VMM/VMMAll/PGMAll.cpp

@@ -996 +996 @@
     {
         pShwPage = pgmPoolGetPage(pPool, pPdpe->u & X86_PDPE_PG_MASK);
-        AssertReturn(pShwPage, VERR_INTERNAL_ERROR);
+        AssertReturn(pShwPage, VERR_PGM_POOL_GET_PAGE_FAILED);
         Assert((pPdpe->u & X86_PDPE_PG_MASK) == pShwPage->Core.Key);
 
@@ -1032 +1032 @@
     /* Fetch the pgm pool shadow descriptor. */
     PPGMPOOLPAGE pShwPde = pgmPoolGetPage(pVM->pgm.s.CTX_SUFF(pPool), pPdpt->a[iPdPt].u & X86_PDPE_PG_MASK);
-    AssertReturn(pShwPde, VERR_INTERNAL_ERROR);
+    AssertReturn(pShwPde, VERR_PGM_POOL_GET_PAGE_FAILED);
 
     *ppShwPde = pShwPde;
@@ -1095 +1095 @@
     {
         pShwPage = pgmPoolGetPage(pPool, pPml4e->u & X86_PML4E_PG_MASK);
-        AssertReturn(pShwPage, VERR_INTERNAL_ERROR);
+        AssertReturn(pShwPage, VERR_PGM_POOL_GET_PAGE_FAILED);
 
         pgmPoolCacheUsed(pPool, pShwPage);
@@ -1132 +1132 @@
     {
         pShwPage = pgmPoolGetPage(pPool, pPdpe->u & X86_PDPE_PG_MASK);
-        AssertReturn(pShwPage, VERR_INTERNAL_ERROR);
+        AssertReturn(pShwPage, VERR_PGM_POOL_GET_PAGE_FAILED);
 
         pgmPoolCacheUsed(pPool, pShwPage);
@@ -1160 +1160 @@
     PGM_LOCK_ASSERT_OWNER(pVCpu->CTX_SUFF(pVM));
 
-    AssertReturn(pPml4e, VERR_INTERNAL_ERROR);
+    AssertReturn(pPml4e, VERR_PGM_PML4_MAPPING);
     if (ppPml4e)
         *ppPml4e = (PX86PML4E)pPml4e;
@@ -1172 +1172 @@
     PPGMPOOL        pPool    = pVM->pgm.s.CTX_SUFF(pPool);
     PPGMPOOLPAGE    pShwPage = pgmPoolGetPage(pPool, pPml4e->u & X86_PML4E_PG_MASK);
-    AssertReturn(pShwPage, VERR_INTERNAL_ERROR);
+    AssertReturn(pShwPage, VERR_PGM_POOL_GET_PAGE_FAILED);
 
     const unsigned  iPdPt = (GCPtr >> X86_PDPT_SHIFT) & X86_PDPT_MASK_AMD64;
@@ -1180 +1180 @@
 
     pShwPage = pgmPoolGetPage(pPool, pPdpt->a[iPdPt].u & X86_PDPE_PG_MASK);
-    AssertReturn(pShwPage, VERR_INTERNAL_ERROR);
+    AssertReturn(pShwPage, VERR_PGM_POOL_GET_PAGE_FAILED);
 
     *ppPD = (PX86PDPAE)PGMPOOL_PAGE_2_PTR_V2(pVM, pVCpu, pShwPage);
@@ -1228 +1228 @@
     {
         pShwPage = pgmPoolGetPage(pPool, pPml4e->u & EPT_PML4E_PG_MASK);
-        AssertReturn(pShwPage, VERR_INTERNAL_ERROR);
+        AssertReturn(pShwPage, VERR_PGM_POOL_GET_PAGE_FAILED);
 
         pgmPoolCacheUsed(pPool, pShwPage);
@@ -1257 +1257 @@
     {
         pShwPage = pgmPoolGetPage(pPool, pPdpe->u & EPT_PDPTE_PG_MASK);
-        AssertReturn(pShwPage, VERR_INTERNAL_ERROR);
+        AssertReturn(pShwPage, VERR_PGM_POOL_GET_PAGE_FAILED);
 
         pgmPoolCacheUsed(pPool, pShwPage);
@@ -1323 +1323 @@
 
         default:
-            AssertMsgFailedReturn(("%d\n", enmShwPagingMode), VERR_INTERNAL_ERROR_5);
+            AssertMsgFailedReturn(("%d\n", enmShwPagingMode), VERR_IPE_NOT_REACHED_DEFAULT_CASE);
     }
     return rc;
@@ -2054 +2054 @@
         }
         AssertRCReturn(rc, rc);
-        AssertRCSuccessReturn(rc, VERR_INTERNAL_ERROR);
+        AssertRCSuccessReturn(rc, VERR_IPE_UNEXPECTED_INFO_STATUS);
     }
 

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -588 +588 @@
     rc = pgmShwSyncPaePDPtr(pVCpu, pvFault, X86_PDPE_P, &pPDDst);       /* RW, US and A are reserved in PAE mode. */
 #   endif
-    AssertMsgReturn(rc == VINF_SUCCESS, ("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_INTERNAL_ERROR_4);
+    AssertMsgReturn(rc == VINF_SUCCESS, ("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_IPE_UNEXPECTED_INFO_STATUS);
 
 #  elif PGM_SHW_TYPE == PGM_TYPE_AMD64
@@ -599 +599 @@
     rc = pgmShwSyncLongModePDPtr(pVCpu, pvFault, GstWalk.Pml4e.u, GstWalk.Pdpe.u, &pPDDst);
 #   endif
-    AssertMsgReturn(rc == VINF_SUCCESS, ("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_INTERNAL_ERROR_4);
+    AssertMsgReturn(rc == VINF_SUCCESS, ("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_IPE_UNEXPECTED_INFO_STATUS);
 
 #  elif PGM_SHW_TYPE == PGM_TYPE_EPT
@@ -605 +605 @@
     PEPTPD          pPDDst;
     rc = pgmShwGetEPTPDPtr(pVCpu, pvFault, NULL, &pPDDst);
-    AssertMsgReturn(rc == VINF_SUCCESS, ("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_INTERNAL_ERROR_4);
+    AssertMsgReturn(rc == VINF_SUCCESS, ("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_IPE_UNEXPECTED_INFO_STATUS);
 #  endif
     Assert(pPDDst);
@@ -1091 +1091 @@
     NOREF(uErr); NOREF(pRegFrame); NOREF(pvFault);
     AssertReleaseMsgFailed(("Shw=%d Gst=%d is not implemented!\n", PGM_GST_TYPE, PGM_SHW_TYPE));
-    return VERR_INTERNAL_ERROR;
+    return VERR_PGM_NOT_USED_IN_MODE;
 # endif
 }
@@ -2276 +2276 @@
     NOREF(PdeSrc);
     AssertReleaseMsgFailed(("Shw=%d Gst=%d is not implemented!\n", PGM_GST_TYPE, PGM_SHW_TYPE));
-    return VERR_INTERNAL_ERROR;
+    return VERR_PGM_NOT_USED_IN_MODE;
 #endif
 }
@@ -2741 +2741 @@
         }
         else
-            AssertMsgFailedReturn(("rc=%Rrc\n", rc), VERR_INTERNAL_ERROR);
+            AssertMsgFailedReturn(("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_IPE_UNEXPECTED_INFO_STATUS);
         /** @todo Why do we bother preserving X86_PDE_AVL_MASK here?
          * Both PGM_PDFLAGS_MAPPING and PGM_PDFLAGS_TRACK_DIRTY should be
@@ -3170 +3170 @@
     {
        STAM_PROFILE_STOP(&pVCpu->pgm.s.CTX_SUFF(pStats)->CTX_MID_Z(Stat,SyncPT), a);
-       AssertMsgFailedReturn(("rc=%Rrc\n", rc), VERR_INTERNAL_ERROR);
+       AssertMsgFailedReturn(("rc=%Rrc\n", rc), RT_FAILURE_NP(rc) ? rc : VERR_IPE_UNEXPECTED_INFO_STATUS);
     }
 
@@ -3219 +3219 @@
     NOREF(iPDSrc); NOREF(pPDSrc);
     AssertReleaseMsgFailed(("Shw=%d Gst=%d is not implemented!\n", PGM_SHW_TYPE, PGM_GST_TYPE));
-    return VERR_INTERNAL_ERROR;
+    return VERR_PGM_NOT_USED_IN_MODE;
 #endif
 }
@@ -3553 +3553 @@
 
     AssertReleaseMsgFailed(("Shw=%d Gst=%d is not implemented!\n", PGM_GST_TYPE, PGM_SHW_TYPE));
-    return VERR_INTERNAL_ERROR;
+    return VERR_PGM_NOT_USED_IN_MODE;
 #endif /* PGM_SHW_TYPE == PGM_TYPE_EPT || PGM_SHW_TYPE == PGM_TYPE_NESTED */
 }
@@ -4435 +4435 @@
     pgmLock(pVM);
     PPGMPAGE    pPageCR3 = pgmPhysGetPage(pVM, GCPhysCR3);
-    AssertReturn(pPageCR3, VERR_INTERNAL_ERROR_2);
+    AssertReturn(pPageCR3, VERR_PGM_INVALID_CR3_ADDR);
     HCPhysGuestCR3 = PGM_PAGE_GET_HCPHYS(pPageCR3);
     /** @todo this needs some reworking wrt. locking?  */
@@ -4484 +4484 @@
                     pgmLock(pVM);
                     PPGMPAGE    pPage  = pgmPhysGetPage(pVM, GCPhys);
-                    AssertReturn(pPage, VERR_INTERNAL_ERROR_2);
+                    AssertReturn(pPage, VERR_PGM_INVALID_PDPE_ADDR);
                     HCPhys = PGM_PAGE_GET_HCPHYS(pPage);
 #  if defined(IN_RC) || defined(VBOX_WITH_2X_4GB_ADDR_SPACE_IN_R0)

trunk/src/VBox/VMM/VMMAll/PGMAllHandler.cpp

@@ -727 +727 @@
             }
             AssertMsgFailed(("whu?\n"));
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_PGM_PHYS_HANDLER_IPE;
         }
         else
@@ -792 +792 @@
 
                     Assert(pCur3 == pCur2);
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_PGM_PHYS_HANDLER_IPE;
                 }
                 else
@@ -915 +915 @@
             default:
                 AssertMsgFailed(("Invalid type %d! Corruption!\n",  pCur->enmType));
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_PGM_PHYS_HANDLER_IPE;
                 break;
         }

trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp

@@ -116 +116 @@
                 }
             }
-            else if (RT_UNLIKELY(rc == VERR_INTERNAL_ERROR))
+            else if (RT_UNLIKELY(rc == VERR_EM_INTERNAL_DISAS_ERROR))
                 return rc;
             break;
@@ -135 +135 @@
             AssertMsgFailedReturn(("enmProt=%d iPage=%d GCPhysFault=%RGp\n",
                                    pRom->aPages[iPage].enmProt, iPage, GCPhysFault),
-                                  VERR_INTERNAL_ERROR);
+                                  VERR_IPE_NOT_REACHED_DEFAULT_CASE);
     }
 
@@ -513 +513 @@
                             &&  pVM->pgm.s.cHandyPages <= RT_ELEMENTS(pVM->pgm.s.aHandyPages),
                             ("%u\n", pVM->pgm.s.cHandyPages),
-                            VERR_INTERNAL_ERROR);
+                            VERR_PGM_HANDY_PAGE_IPE);
         }
         else
@@ -1029 +1029 @@
     if (idChunk == NIL_GMM_CHUNKID)
     {
-        AssertMsgReturn(PGM_PAGE_GET_PAGEID(pPage) == NIL_GMM_PAGEID, ("pPage=%R[pgmpage]\n", pPage), VERR_INTERNAL_ERROR_2);
+        AssertMsgReturn(PGM_PAGE_GET_PAGEID(pPage) == NIL_GMM_PAGEID, ("pPage=%R[pgmpage]\n", pPage), VERR_PGM_PHYS_PAGE_MAP_IPE_1);
         if (PGM_PAGE_GET_TYPE(pPage) == PGMPAGETYPE_MMIO2)
         {
             /* Lookup the MMIO2 range and use pvR3 to calc the address. */
             PPGMRAMRANGE pRam = pgmPhysGetRange(pVM, GCPhys);
-            AssertMsgReturn(pRam || !pRam->pvR3, ("pRam=%p pPage=%R[pgmpage]\n", pRam, pPage), VERR_INTERNAL_ERROR_2);
+            AssertMsgReturn(pRam || !pRam->pvR3, ("pRam=%p pPage=%R[pgmpage]\n", pRam, pPage), VERR_PGM_PHYS_PAGE_MAP_IPE_2);
             *ppv = (void *)((uintptr_t)pRam->pvR3 + (uintptr_t)((GCPhys & ~(RTGCPHYS)PAGE_OFFSET_MASK) - pRam->GCPhys));
         }
@@ -1043 +1043 @@
              * them, that would also avoid this mess. It would actually be kind of
              * elegant... */
-            AssertLogRelMsgFailedReturn(("%RGp\n", GCPhys), VERR_INTERNAL_ERROR_3);
+            AssertLogRelMsgFailedReturn(("%RGp\n", GCPhys), VERR_PGM_MAP_MMIO2_ALIAS_MMIO);
         }
         else
         {
             /** @todo handle MMIO2 */
-            AssertMsgReturn(PGM_PAGE_IS_ZERO(pPage), ("pPage=%R[pgmpage]\n", pPage), VERR_INTERNAL_ERROR_2);
+            AssertMsgReturn(PGM_PAGE_IS_ZERO(pPage), ("pPage=%R[pgmpage]\n", pPage), VERR_PGM_PHYS_PAGE_MAP_IPE_3);
             AssertMsgReturn(PGM_PAGE_GET_HCPHYS(pPage) == pVM->pgm.s.HCPhysZeroPg,
                             ("pPage=%R[pgmpage]\n", pPage),
-                            VERR_INTERNAL_ERROR_2);
+                            VERR_PGM_PHYS_PAGE_MAP_IPE_4);
             *ppv = pVM->pgm.s.CTXALLSUFF(pvZeroPg);
         }
@@ -1306 +1306 @@
 {
     int rc;
-    AssertReturn(pPage, VERR_INTERNAL_ERROR);
+    AssertReturn(pPage, VERR_PGM_PHYS_NULL_PAGE_PARAM);
     PGM_LOCK_ASSERT_OWNER(pVM);
     pVM->pgm.s.cDeprecatedPageLocks++;
@@ -1436 +1436 @@
 {
     int rc;
-    AssertReturn(pPage, VERR_INTERNAL_ERROR);
+    AssertReturn(pPage, VERR_PGM_PHYS_NULL_PAGE_PARAM);
     PGM_LOCK_ASSERT_OWNER(pVM);
 
@@ -1499 +1499 @@
 int pgmPhysGCPhys2CCPtrInternalReadOnly(PVM pVM, PPGMPAGE pPage, RTGCPHYS GCPhys, const void **ppv, PPGMPAGEMAPLOCK pLock)
 {
-    AssertReturn(pPage, VERR_INTERNAL_ERROR);
+    AssertReturn(pPage, VERR_PGM_PHYS_NULL_PAGE_PARAM);
     PGM_LOCK_ASSERT_OWNER(pVM);
     Assert(PGM_PAGE_GET_HCPHYS(pPage) != 0);

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -2030 +2030 @@
         LogFlow(("pgmPoolCacheFreeOne: refuse CR3 mapping\n"));
         pgmPoolCacheUsed(pPool, pPage);
-        AssertLogRelReturn(iLoop < 8192, VERR_INTERNAL_ERROR);
+        AssertLogRelReturn(iLoop < 8192, VERR_PGM_POOL_TOO_MANY_LOOPS);
     }
 
@@ -4998 +4998 @@
         }
         iNew = pPool->iFreeHead;
-        AssertReleaseReturn(iNew != NIL_PGMPOOL_IDX, VERR_INTERNAL_ERROR);
+        AssertReleaseReturn(iNew != NIL_PGMPOOL_IDX, VERR_PGM_POOL_IPE);
     }
 

trunk/src/VBox/VMM/VMMAll/PGMAllShw.h

@@ -306 +306 @@
 
         PPGMMAPPING pMap = pgmGetMapping(pVM, (RTGCPTR)GCPtr);
-        AssertMsgReturn(pMap, ("GCPtr=%RGv\n", GCPtr), VERR_INTERNAL_ERROR);
+        AssertMsgReturn(pMap, ("GCPtr=%RGv\n", GCPtr), VERR_PGM_MAPPING_IPE);
 #  if PGM_SHW_TYPE == PGM_TYPE_32BIT
         pPT = pMap->aPTs[(GCPtr - pMap->GCPtr) >> X86_PD_SHIFT].CTX_SUFF(pPT);

trunk/src/VBox/VMM/VMMAll/TMAll.cpp

@@ -1347 +1347 @@
     AssertMsgFailed(("Failed waiting for stable state. state=%d (%s)\n", pTimer->enmState, R3STRING(pTimer->pszDesc)));
     STAM_PROFILE_STOP(&pVM->tm.s.CTX_SUFF_Z(StatTimerSet), a);
-    return VERR_INTERNAL_ERROR;
+    return VERR_TM_TIMER_UNSTABLE_STATE;
 }
 
@@ -1693 +1693 @@
         {
             AssertMsgFailed(("Failed waiting for stable state. state=%d (%s)\n", pTimer->enmState, R3STRING(pTimer->pszDesc)));
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_TM_TIMER_UNSTABLE_STATE;
             tmTimerSetRelativeNowWorker(pVM, enmClock, pu64Now);
             break;
@@ -1922 +1922 @@
     AssertMsgFailed(("Failed waiting for stable state. state=%d (%s)\n", pTimer->enmState, R3STRING(pTimer->pszDesc)));
     STAM_PROFILE_STOP(&pVM->tm.s.CTX_SUFF_Z(StatTimerStop), a);
-    return VERR_INTERNAL_ERROR;
+    return VERR_TM_TIMER_UNSTABLE_STATE;
 }
 
@@ -2119 +2119 @@
         default:
             AssertMsgFailed(("Invalid enmClock=%d\n", pTimer->enmClock));
-            return VERR_INTERNAL_ERROR;
+            return VERR_TM_TIMER_BAD_CLOCK;
     }
 }
@@ -2149 +2149 @@
         default:
             AssertMsgFailed(("Invalid enmClock=%d\n", pTimer->enmClock));
-            return VERR_INTERNAL_ERROR;
+            return VERR_TM_TIMER_BAD_CLOCK;
     }
 }
@@ -2179 +2179 @@
         default:
             AssertMsgFailed(("Invalid enmClock=%d\n", pTimer->enmClock));
-            return VERR_INTERNAL_ERROR;
+            return VERR_TM_TIMER_BAD_CLOCK;
     }
 }

trunk/src/VBox/VMM/VMMAll/TMAllCpu.cpp

@@ -76 +76 @@
     }
     AssertFailed();
-    return VERR_INTERNAL_ERROR;
+    return VERR_TM_TSC_ALREADY_TICKING;
 }
 
@@ -96 +96 @@
     }
     AssertFailed();
-    return VERR_INTERNAL_ERROR;
+    return VERR_TM_TSC_ALREADY_PAUSED;
 }
 

trunk/src/VBox/VMM/VMMAll/TMAllVirtual.cpp

@@ -964 +964 @@
  * Worker for TMR3PauseClocks.
  *
- * @returns VINF_SUCCESS or VERR_INTERNAL_ERROR (asserted).
+ * @returns VINF_SUCCESS or VERR_TM_VIRTUAL_TICKING_IPE (asserted).
  * @param   pVM     The VM handle.
  */
@@ -970 +970 @@
 {
     uint32_t c = ASMAtomicDecU32(&pVM->tm.s.cVirtualTicking);
-    AssertMsgReturn(c < pVM->cCpus, ("%u vs %u\n", c, pVM->cCpus), VERR_INTERNAL_ERROR);
+    AssertMsgReturn(c < pVM->cCpus, ("%u vs %u\n", c, pVM->cCpus), VERR_TM_VIRTUAL_TICKING_IPE);
     if (c == 0)
     {
@@ -984 +984 @@
  * Worker for TMR3ResumeClocks.
  *
- * @returns VINF_SUCCESS or VERR_INTERNAL_ERROR (asserted).
+ * @returns VINF_SUCCESS or VERR_TM_VIRTUAL_TICKING_IPE (asserted).
  * @param   pVM     The VM handle.
  */
@@ -990 +990 @@
 {
     uint32_t c = ASMAtomicIncU32(&pVM->tm.s.cVirtualTicking);
-    AssertMsgReturn(c <= pVM->cCpus, ("%u vs %u\n", c, pVM->cCpus), VERR_INTERNAL_ERROR);
+    AssertMsgReturn(c <= pVM->cCpus, ("%u vs %u\n", c, pVM->cCpus), VERR_TM_VIRTUAL_TICKING_IPE);
     if (c == 1)
     {

trunk/src/VBox/VMM/VMMR0/GMMR0.cpp

@@ -595 +595 @@
 
 /** Macro for obtaining and validating the g_pGMM pointer.
- * On failure it will return from the invoking function with the specified return value.
+ *  
+ * On failure it will return from the invoking function with the specified
+ * return value. 
  *
  * @param   pGMM    The name of the pGMM variable.
- * @param   rc      The return value on failure. Use VERR_INTERNAL_ERROR for
- *                  VBox status codes.
+ * @param   rc      The return value on failure. Use VERR_GMM_INSTANCE for VBox
+ *                  status codes.
  */
 #define GMM_GET_VALID_INSTANCE(pGMM, rc) \
@@ -608 +610 @@
     } while (0)
 
-/** Macro for obtaining and validating the g_pGMM pointer, void function variant.
- * On failure it will return from the invoking function.
+/** Macro for obtaining and validating the g_pGMM pointer, void function
+ * variant. 
+ *  
+ * On failure it will return from the invoking function. 
  *
  * @param   pGMM    The name of the pGMM variable.
@@ -1097 +1101 @@
 static int gmmR0ChunkMutexDropGiant(PGMMR0CHUNKMTXSTATE pMtxState)
 {
-    AssertReturn(pMtxState->fFlags == GMMR0CHUNK_MTX_KEEP_GIANT, VERR_INTERNAL_ERROR_2);
+    AssertReturn(pMtxState->fFlags == GMMR0CHUNK_MTX_KEEP_GIANT, VERR_GMM_MTX_FLAGS);
     Assert(pMtxState->pGMM->hMtxOwner == RTThreadNativeSelf());
     pMtxState->fFlags = GMMR0CHUNK_MTX_RETAKE_GIANT;
@@ -1458 +1462 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -1502 +1506 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     gmmR0MutexRelease(pGMM);
     LogFlow(("GMMR0InitialReservation: returns %Rrc\n", rc));
@@ -1555 +1559 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -1596 +1600 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     gmmR0MutexRelease(pGMM);
     LogFlow(("GMMR0UpdateReservation: returns %Rrc\n", rc));
@@ -2070 +2074 @@
 
                 /* bail out */
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_GMM_CHUNK_INSERT;
             }
             else
-                rc = VERR_INTERNAL_ERROR_5;
+                rc = VERR_GMM_IS_NOT_SANE;
             gmmR0MutexRelease(pGMM);
         }
@@ -2415 +2419 @@
             break;
         default:
-            AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_INTERNAL_ERROR);
+            AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_IPE_NOT_REACHED_DEFAULT_CASE);
     }
 
@@ -2439 +2443 @@
         case GMMACCOUNT_SHADOW: pGVM->gmm.s.Allocated.cShadowPages += cPages; break;
         case GMMACCOUNT_FIXED:  pGVM->gmm.s.Allocated.cFixedPages  += cPages; break;
-        default:                AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_INTERNAL_ERROR);
+        default:                AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_IPE_NOT_REACHED_DEFAULT_CASE);
     }
     pGVM->gmm.s.cPrivatePages += cPages;
@@ -2451 +2455 @@
     {
         iPage = gmmR0AllocatePagesInBoundMode(pGVM, iPage, cPages, paPages);
-        AssertReleaseReturn(iPage == cPages, VERR_INTERNAL_ERROR_3);
+        AssertReleaseReturn(iPage == cPages, VERR_GMM_ALLOC_PAGES_IPE);
         return VINF_SUCCESS;
     }
@@ -2528 +2532 @@
             case GMMACCOUNT_SHADOW: pGVM->gmm.s.Allocated.cShadowPages -= cPages; break;
             case GMMACCOUNT_FIXED:  pGVM->gmm.s.Allocated.cFixedPages  -= cPages; break;
-            default:                AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_INTERNAL_ERROR);
+            default:                AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_IPE_NOT_REACHED_DEFAULT_CASE);
         }
 
@@ -2599 +2603 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -2755 +2759 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     gmmR0MutexRelease(pGMM);
     LogFlow(("GMMR0AllocateHandyPages: returns %Rrc\n", rc));
@@ -2793 +2797 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -2830 +2834 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     gmmR0MutexRelease(pGMM);
     LogFlow(("GMMR0AllocatePages: returns %Rrc\n", rc));
@@ -2892 +2896 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -2969 +2973 @@
     {
         gmmR0MutexRelease(pGMM);
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     }
 
@@ -2993 +2997 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -3036 +3040 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
     gmmR0MutexRelease(pGMM);
@@ -3310 +3314 @@
             break;
         default:
-            AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_INTERNAL_ERROR);
+            AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_IPE_NOT_REACHED_DEFAULT_CASE);
     }
 
@@ -3381 +3385 @@
         case GMMACCOUNT_FIXED:  pGVM->gmm.s.Allocated.cFixedPages  -= iPage; break;
         default:
-            AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_INTERNAL_ERROR);
+            AssertMsgFailedReturn(("enmAccount=%d\n", enmAccount), VERR_IPE_NOT_REACHED_DEFAULT_CASE);
     }
 
@@ -3415 +3419 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -3440 +3444 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     gmmR0MutexRelease(pGMM);
     LogFlow(("GMMR0FreePages: returns %Rrc\n", rc));
@@ -3507 +3511 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -3606 +3610 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
     gmmR0MutexRelease(pGMM);
@@ -3658 +3662 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     pReq->cAllocPages     = pGMM->cAllocatedPages;
     pReq->cFreePages      = (pGMM->cChunks << (GMM_CHUNK_SHIFT- PAGE_SHIFT)) - pGMM->cAllocatedPages;
@@ -3692 +3696 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -3710 +3714 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
     gmmR0MutexRelease(pGMM);
@@ -3977 +3981 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVM(pVM, &pGVM);
@@ -4042 +4046 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     gmmR0MutexRelease(pGMM);
 
@@ -4087 +4091 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -4174 +4178 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -4322 +4326 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
 end:
@@ -4378 +4382 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -4443 +4447 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
     gmmR0MutexRelease(pGMM);
@@ -4553 +4557 @@
     int rc = VINF_SUCCESS;
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     unsigned cPages = pModule->aRegions[idxRegion].cbRegion >> PAGE_SHIFT;
 
@@ -4701 +4705 @@
  * RTAvlGCPtrDestroy callback.
  *
- * @returns 0 or VERR_INTERNAL_ERROR.
+ * @returns 0 or VERR_GMM_INSTANCE.
  * @param   pNode   The node to destroy.
  * @param   pvGVM   The GVM handle.
@@ -4727 +4731 @@
             /* Remove from the tree and free memory. */
             PGMM pGMM;
-            GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+            GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
             RTAvlGCPtrRemove(&pGMM->pGlobalSharedModuleTree, pRec->Core.Key);
             RTMemFree(pRec);
@@ -4772 +4776 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, idCpu, &pGVM);
@@ -4791 +4795 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
     gmmR0MutexRelease(pGMM);
@@ -4845 +4849 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
 
     /*
@@ -4852 +4856 @@
     gmmR0MutexAcquire(pGMM);
     if (!GMM_CHECK_SANITY_UPON_ENTERING(pGMM))
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
     else
         rc = VINF_SUCCESS;
@@ -4871 +4875 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
 
     gmmR0MutexRelease(pGMM);
@@ -4893 +4897 @@
      */
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
     PGVM pGVM;
     int rc = GVMMR0ByVMAndEMT(pVM, pVCpu->idCpu, &pGVM);
@@ -4923 +4927 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
 # ifndef DEBUG_sandervl
@@ -5007 +5011 @@
 
     PGMM pGMM;
-    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_GMM_INSTANCE);
 
     PGVM pGVM;
@@ -5052 +5056 @@
     }
     else
-        rc = VERR_INTERNAL_ERROR_5;
+        rc = VERR_GMM_IS_NOT_SANE;
 
     gmmR0MutexRelease(pGMM);

trunk/src/VBox/VMM/VMMR0/GVMMR0.cpp

@@ -272 +272 @@
  *
  * @param   pGVMM   The name of the pGVMM variable.
- * @param   rc      The return value on failure. Use VERR_INTERNAL_ERROR for
- *                  VBox status codes.
+ * @param   rc      The return value on failure. Use VERR_GVMM_INSTANCE for VBox
+ *                  status codes.
  */
 #define GVMM_GET_VALID_INSTANCE(pGVMM, rc) \
@@ -322 +322 @@
      */
     uint32_t cHostCpus = RTMpGetArraySize();
-    AssertMsgReturn(cHostCpus > 0 && cHostCpus < _64K, ("%d", (int)cHostCpus), VERR_INTERNAL_ERROR_2);
+    AssertMsgReturn(cHostCpus > 0 && cHostCpus < _64K, ("%d", (int)cHostCpus), VERR_GVMM_HOST_CPU_RANGE);
 
     PGVMM pGVMM = (PGVMM)RTMemAllocZ(RT_UOFFSETOF(GVMM, aHostCpus[cHostCpus]));
@@ -535 +535 @@
      */
     PGVMM pGVMM;
-    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
     AssertPtrReturn(pSession, VERR_INVALID_HANDLE);
     AssertPtrReturn(pszName, VERR_INVALID_POINTER);
@@ -602 +602 @@
      */
     PGVMM pGVMM;
-    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
     AssertPtrReturn(pSession, VERR_INVALID_HANDLE);
     AssertPtrReturn(pszName, VERR_INVALID_POINTER);
@@ -740 +740 @@
     LogFlow(("GVMMR0CreateVM: pSession=%p\n", pSession));
     PGVMM pGVMM;
-    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
 
     AssertPtrReturn(ppVM, VERR_INVALID_POINTER);
@@ -750 +750 @@
 
     RTNATIVETHREAD hEMT0 = RTThreadNativeSelf();
-    AssertReturn(hEMT0 != NIL_RTNATIVETHREAD, VERR_INTERNAL_ERROR);
+    AssertReturn(hEMT0 != NIL_RTNATIVETHREAD, VERR_GVMM_BROKEN_IPRT);
     RTNATIVETHREAD ProcId = RTProcSelf();
-    AssertReturn(ProcId != NIL_RTPROCESS, VERR_INTERNAL_ERROR);
+    AssertReturn(ProcId != NIL_RTPROCESS, VERR_GVMM_BROKEN_IPRT);
 
     /*
@@ -927 +927 @@
         }
         else
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_GVMM_IPE_1;
     }
     else
@@ -1066 +1066 @@
     LogFlow(("GVMMR0DestroyVM: pVM=%p\n", pVM));
     PGVMM pGVMM;
-    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
 
 
@@ -1118 +1118 @@
                     pHandle, pHandle->pVM, pHandle->hEMT0, pHandle->ProcId, pHandle->pvObj, pVM, hSelf);
         gvmmR0CreateDestroyUnlock(pGVMM);
-        rc = VERR_INTERNAL_ERROR;
+        rc = VERR_GVMM_IPE_2;
     }
 
@@ -1391 +1391 @@
     RTPROCESS ProcId = RTProcSelf();
     PGVMM pGVMM;
-    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
 
     /*
@@ -1484 +1484 @@
 {
     PGVMM pGVMM;
-    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+    GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
 
     /*
@@ -1503 +1503 @@
     RTPROCESS ProcId = RTProcSelf();
     AssertReturn(pHandle->ProcId == ProcId, VERR_NOT_OWNER);
-    AssertPtrReturn(pHandle->pvObj, VERR_INTERNAL_ERROR);
+    AssertPtrReturn(pHandle->pvObj, VERR_NOT_OWNER);
 
     PGVM pGVM = pHandle->pGVM;
-    AssertPtrReturn(pGVM, VERR_INTERNAL_ERROR);
-    AssertReturn(pGVM->pVM == pVM, VERR_INTERNAL_ERROR);
+    AssertPtrReturn(pGVM, VERR_NOT_OWNER);
+    AssertReturn(pGVM->pVM == pVM, VERR_NOT_OWNER);
     RTNATIVETHREAD hAllegedEMT = RTThreadNativeSelf();
     AssertReturn(idCpu < pGVM->cCpus, VERR_INVALID_CPU_ID);
-    AssertReturn(pGVM->aCpus[idCpu].hEMT == hAllegedEMT, VERR_INTERNAL_ERROR);
+    AssertReturn(pGVM->aCpus[idCpu].hEMT == hAllegedEMT, VERR_NOT_OWNER);
 
     *ppGVM = pGVM;
@@ -2352 +2352 @@
     else
     {
-        GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+        GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
         memset(&pStats->SchedVM, 0, sizeof(pStats->SchedVM));
 
@@ -2501 +2501 @@
     else
     {
-        GVMM_GET_VALID_INSTANCE(pGVMM, VERR_INTERNAL_ERROR);
+        GVMM_GET_VALID_INSTANCE(pGVMM, VERR_GVMM_INSTANCE);
 
         int rc = gvmmR0UsedLock(pGVMM);

trunk/src/VBox/VMM/VMMR0/HWACCMR0.cpp

@@ -926 +926 @@
      *       notification.  Kind of unlikely though, so ignored for now.
      */
-    AssertReturn(!g_HvmR0.fEnabled, VERR_INTERNAL_ERROR_3);
+    AssertReturn(!g_HvmR0.fEnabled, VERR_HM_ALREADY_ENABLED_IPE);
     ASMAtomicWriteBool(&g_HvmR0.fEnabled, true);
 

trunk/src/VBox/VMM/VMMR0/HWSVMR0.cpp

@@ -280 +280 @@
         SVM_VMCB *pVMCB = (SVM_VMCB *)pVM->aCpus[i].hwaccm.s.svm.pVMCB;
 
-        AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_EM_INTERNAL_ERROR);
+        AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_HMSVM_INVALID_PVMCB);
 
         /* Program the control fields. Most of them never have to be changed again. */
@@ -661 +661 @@
 
     pVMCB = (SVM_VMCB *)pVCpu->hwaccm.s.svm.pVMCB;
-    AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_EM_INTERNAL_ERROR);
+    AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_HMSVM_INVALID_PVMCB);
 
     /* Guest CPU context: ES, CS, SS, DS, FS, GS. */
@@ -979 +979 @@
 
     pVMCB = (SVM_VMCB *)pVCpu->hwaccm.s.svm.pVMCB;
-    AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_EM_INTERNAL_ERROR);
+    AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_HMSVM_INVALID_PVMCB);
 
     /* We can jump to this point to resume execution after determining that a VM-exit is innocent.
@@ -1850 +1850 @@
         default:
             AssertMsgFailed(("Unexpected vm-exit caused by exception %x\n", vector));
-            rc = VERR_EM_INTERNAL_ERROR;
+            rc = VERR_HMSVM_UNEXPECTED_XCPT_EXIT;
             break;
 
@@ -2516 +2516 @@
     default:
         /* Unexpected exit codes. */
-        rc = VERR_EM_INTERNAL_ERROR;
+        rc = VERR_HMSVM_UNEXPECTED_EXIT;
         AssertMsgFailed(("Unexpected exit code %x\n", exitCode));                 /* Can't happen. */
         break;
@@ -2620 +2620 @@
             break;
         default:
-            AssertMsgFailedReturn(("Unexpected type %d\n", pPatch->enmType), VERR_INTERNAL_ERROR);
+            AssertMsgFailedReturn(("Unexpected type %d\n", pPatch->enmType), VERR_HMSVM_UNEXPECTED_PATCH_TYPE);
         }
     }
@@ -2793 +2793 @@
 
         pVMCB = (SVM_VMCB *)pVCpu->hwaccm.s.svm.pVMCB;
-        AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_EM_INTERNAL_ERROR);
+        AssertMsgReturn(pVMCB, ("Invalid pVMCB\n"), VERR_HMSVM_INVALID_PVMCB);
 
 #if HC_ARCH_BITS == 32

trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp

@@ -2138 +2138 @@
         default:
             AssertFailed();
-            return VERR_INTERNAL_ERROR;
+            return VERR_HM_UNEXPECTED_LD_ST_MSR;
         }
     }
@@ -4817 +4817 @@
     RTHCUINTREG     uOldEFlags;
 
-    AssertReturn(pVM->hwaccm.s.pfnHost32ToGuest64R0, VERR_INTERNAL_ERROR);
+    AssertReturn(pVM->hwaccm.s.pfnHost32ToGuest64R0, VERR_HM_NO_32_TO_64_SWITCHER);
     Assert(pfnHandler);
     Assert(pVCpu->hwaccm.s.vmx.VMCSCache.Write.cValidEntries <= RT_ELEMENTS(pVCpu->hwaccm.s.vmx.VMCSCache.Write.aField));

trunk/src/VBox/VMM/VMMR0/PGMR0.cpp

@@ -80 +80 @@
      */
     uint32_t iFirst = pVM->pgm.s.cHandyPages;
-    AssertReturn(iFirst <= RT_ELEMENTS(pVM->pgm.s.aHandyPages), VERR_INTERNAL_ERROR);
+    AssertReturn(iFirst <= RT_ELEMENTS(pVM->pgm.s.aHandyPages), VERR_PGM_HANDY_PAGE_IPE);
     uint32_t cPages = RT_ELEMENTS(pVM->pgm.s.aHandyPages) - iFirst;
     if (!cPages)
@@ -589 +589 @@
 #else
     AssertLogRelFailed();
-    return VERR_INTERNAL_ERROR_4;
-#endif
-}
-
+    return VERR_PGM_NOT_USED_IN_MODE;
+#endif
+}
+

trunk/src/VBox/VMM/VMMR0/VMMR0JmpA-amd64.asm

@@ -21 +21 @@
 %include "VBox/asmdefs.mac"
 %include "VMMInternal.mac"
-%include "iprt/err.mac"
+%include "VBox/err.mac"
 %include "VBox/param.mac"
 
@@ -173 +173 @@
 
 .entry_error:
-    mov     eax, VERR_INTERNAL_ERROR_2
+    mov     eax, VERR_VMM_SET_JMP_ERROR
     jmp     .proper_return
 
 .stack_overflow:
-    mov     eax, VERR_INTERNAL_ERROR_5
+    mov     eax, VERR_VMM_SET_JMP_STACK_OVERFLOW
     jmp     .proper_return
 
@@ -195 +195 @@
     mov     r14, [xDX + VMMR0JMPBUF.r14]
     mov     r15, [xDX + VMMR0JMPBUF.r15]
-    mov     eax, VERR_INTERNAL_ERROR_3    ; todo better return code!
+    mov     eax, VERR_VMM_SET_JMP_ABORTED_RESUME
     leave
     ret
@@ -413 +413 @@
 .magic_ok:
 %endif
-    mov     eax, VERR_INTERNAL_ERROR_4
+    mov     eax, VERR_VMM_LONG_JMP_ERROR
 %ifdef RT_OS_WINDOWS
     add     rsp, 0a0h                   ; skip XMM registers since they are unmodified.

trunk/src/VBox/VMM/VMMR0/VMMR0JmpA-x86.asm

@@ -179 +179 @@
 
 .entry_error:
-    mov     eax, VERR_INTERNAL_ERROR_2
+    mov     eax, VERR_VMM_SET_JMP_ERROR
     jmp     .proper_return
 
 .stack_overflow:
-    mov     eax, VERR_INTERNAL_ERROR_5
+    mov     eax, VERR_VMM_SET_JMP_STACK_OVERFLOW
     mov     edx, ebx
     jmp     .proper_return
 
 .stack_overflow_almost:
-    mov     eax, VERR_INTERNAL_ERROR
+    mov     eax, VERR_VMM_SET_JMP_STACK_OVERFLOW
     mov     edx, ebx
     jmp     .proper_return
@@ -200 +200 @@
     mov     esi, [xDX + VMMR0JMPBUF.esi]
     mov     ebx, [xDX + VMMR0JMPBUF.ebx]
-    mov     eax, VERR_INTERNAL_ERROR_3    ; todo better return code!
+    mov     eax, VERR_VMM_SET_JMP_ABORTED_RESUME
     ret
 
@@ -373 +373 @@
     pop     esi
     pop     edi
-    mov     eax, VERR_INTERNAL_ERROR_4
+    mov     eax, VERR_VMM_LONG_JMP_ERROR
     leave
     ret

trunk/src/VBox/VMM/VMMR3/HWACCM.cpp

@@ -2561 +2561 @@
 
     default:
-        AssertFailed();
-        return VERR_INTERNAL_ERROR;
+        AssertLogRelFailedReturn(VERR_INTERNAL_ERROR);
     }
 

trunk/src/VBox/VMM/VMMR3/IOM.cpp

@@ -952 +952 @@
                     AssertMsgFailed(("This cannot happen!\n"));
                     MMHyperFree(pVM, pRangeNew);
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_IOM_IOPORT_IPE_1;
                 }
                 break;
@@ -1035 +1035 @@
                     AssertMsgFailed(("This cannot happen!\n"));
                     MMHyperFree(pVM, pRangeNew);
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_IOM_IOPORT_IPE_1;
                 }
                 break;
@@ -1117 +1117 @@
                     AssertMsgFailed(("This cannot happen!\n"));
                     MMHyperFree(pVM, pRangeNew);
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_IOM_IOPORT_IPE_1;
                 }
                 break;
@@ -1153 +1153 @@
         default:
             AssertReleaseMsgFailed(("cb=%d\n", cb));
-            return VERR_INTERNAL_ERROR;
+            return VERR_IOM_IOPORT_IPE_2;
     }
     return VINF_SUCCESS;
@@ -1489 +1489 @@
             DBGFR3Info(pVM, "mmio", NULL, NULL);
             AssertMsgFailed(("This cannot happen!\n"));
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_IOM_IOPORT_IPE_3;
         }
         else

trunk/src/VBox/VMM/VMMR3/MMHyper.cpp

@@ -582 +582 @@
                 RTHCPHYS HCPhys;
                 rc = PGMR3PhysMMIO2GetHCPhys(pVM, pDevIns, iRegion, offCur, &HCPhys);
-                AssertRCReturn(rc, VERR_INTERNAL_ERROR);
+                AssertRCReturn(rc, rc);
                 rc = PGMMap(pVM, GCPtr + (offCur - off), HCPhys, PAGE_SIZE, 0);
                 if (RT_FAILURE(rc))

trunk/src/VBox/VMM/VMMR3/PDM.cpp

@@ -739 +739 @@
 {
     LogFlow(("pdmR3LiveExec:\n"));
-    AssertReturn(uPass == 0, VERR_INTERNAL_ERROR_4);
+    AssertReturn(uPass == 0, VERR_SSM_UNEXPECTED_PASS);
     pdmR3SaveBoth(pVM, pSSM);
     return VINF_SSM_DONT_CALL_AGAIN;

trunk/src/VBox/VMM/VMMR3/PDMCritSect.cpp

@@ -429 +429 @@
     PVM             pVM   = pCritSect->s.pVMR3;
     PUVM            pUVM  = pVM->pUVM;
-    AssertReleaseReturn(pVM, VERR_INTERNAL_ERROR);
+    AssertReleaseReturn(pVM, VERR_PDM_CRITSECT_IPE);
     PPDMCRITSECTINT pPrev = NULL;
     RTCritSectEnter(&pUVM->pdm.s.ListCritSect);
@@ -448 +448 @@
     RTCritSectLeave(&pUVM->pdm.s.ListCritSect);
     AssertReleaseMsgFailed(("pCritSect=%p wasn't found!\n", pCritSect));
-    return VERR_INTERNAL_ERROR;
+    return VERR_PDM_CRITSECT_NOT_FOUND;
 }
 
@@ -518 +518 @@
 
 #ifdef PDMCRITSECT_STRICT
-    int rc = PDMCritSectEnterDebug(pCritSect, VERR_INTERNAL_ERROR,
+    int rc = PDMCritSectEnterDebug(pCritSect, VERR_IGNORED,
                                    SrcPos.uId, SrcPos.pszFile, SrcPos.uLine, SrcPos.pszFunction);
 #else
-    int rc = PDMCritSectEnter(pCritSect, VERR_INTERNAL_ERROR);
+    int rc = PDMCritSectEnter(pCritSect, VERR_IGNORED);
 #endif
     AssertLogRelRC(rc);

trunk/src/VBox/VMM/VMMR3/PDMDevHlp.cpp

@@ -1093 +1093 @@
          */
         AssertMsgFailed(("Only one PCI device per device is currently implemented!\n"));
-        return VERR_INTERNAL_ERROR;
+        return VERR_PDM_ONE_PCI_FUNCTION_PER_DEVICE;
     }
 
@@ -1136 +1136 @@
         if (RT_SUCCESS(rc))
         {
-            if (u8Device > 31)
-            {
-                AssertMsgFailed(("Configuration error: PCIDeviceNo=%d, max is 31. (%s/%d)\n",
-                                 u8Device, pDevIns->pReg->szName, pDevIns->iInstance));
-                return VERR_INTERNAL_ERROR;
-            }
-
-            uint8_t     u8Function;
+            AssertMsgReturn(u8Device <= 31,
+                            ("Configuration error: PCIDeviceNo=%d, max is 31. (%s/%d)\n",
+                             u8Device, pDevIns->pReg->szName, pDevIns->iInstance),
+                            VERR_PDM_BAD_PCI_CONFIG);
+
+            uint8_t u8Function;
             rc = CFGMR3QueryU8(pDevIns->Internal.s.pCfgHandle, "PCIFunctionNo", &u8Function);
-            if (RT_FAILURE(rc))
-            {
-                AssertMsgFailed(("Configuration error: PCIDeviceNo, but PCIFunctionNo query failed with rc=%Rrc (%s/%d)\n",
-                                 rc, pDevIns->pReg->szName, pDevIns->iInstance));
-                return rc;
-            }
-            if (u8Function > 7)
-            {
-                AssertMsgFailed(("Configuration error: PCIFunctionNo=%d, max is 7. (%s/%d)\n",
-                                 u8Function, pDevIns->pReg->szName, pDevIns->iInstance));
-                return VERR_INTERNAL_ERROR;
-            }
+            AssertMsgRCReturn(rc, ("Configuration error: PCIDeviceNo, but PCIFunctionNo query failed with rc=%Rrc (%s/%d)\n",
+                                   rc, pDevIns->pReg->szName, pDevIns->iInstance),
+                              rc);
+            AssertMsgReturn(u8Function <= 7, 
+                            ("Configuration error: PCIFunctionNo=%d, max is 7. (%s/%d)\n",
+                             u8Function, pDevIns->pReg->szName, pDevIns->iInstance),
+                            VERR_PDM_BAD_PCI_CONFIG);
+
             iDev = (u8Device << 3) | u8Function;
         }
@@ -1610 +1604 @@
     VM_ASSERT_STATE_RETURN(pVM, VMSTATE_CREATING, VERR_WRONG_ORDER);
 
-    AssertReturn(pDevIns->pCritSectRoR3, VERR_INTERNAL_ERROR_4);
+    AssertReturn(pDevIns->pCritSectRoR3, VERR_PDM_DEV_IPE_1);
     AssertReturn(pDevIns->pCritSectRoR3->s.fAutomaticDefaultCritsect, VERR_WRONG_ORDER);
     AssertReturn(!pDevIns->pCritSectRoR3->s.fUsedByTimerOrSimilar, VERR_WRONG_ORDER);

trunk/src/VBox/VMM/VMMR3/PDMDevMiscHlp.cpp

@@ -579 +579 @@
         {
             PPDMIHPETLEGACYNOTIFY pPort = PDMIBASE_QUERY_INTERFACE(pBase, PDMIHPETLEGACYNOTIFY);
-            AssertLogRelMsgBreakStmt(pPort, ("%s\n", s_apszDevsToNotify[i]), rc = VERR_INTERNAL_ERROR_3);
+            AssertLogRelMsgBreakStmt(pPort, ("%s\n", s_apszDevsToNotify[i]), rc = VERR_PDM_HPET_LEGACY_NOTIFY_MISSING);
             pPort->pfnModeChanged(pPort, fActivated);
         }

trunk/src/VBox/VMM/VMMR3/PDMThread.cpp

@@ -86 +86 @@
         default:
             AssertMsgFailed(("%d\n", pThread->Internal.s.enmType));
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_PDM_THREAD_IPE_1;
             break;
     }
@@ -156 +156 @@
                 if (    RT_SUCCESS(rc)
                     &&  pThread->enmState != PDMTHREADSTATE_SUSPENDED)
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_PDM_THREAD_IPE_2;
                 if (RT_SUCCESS(rc))
                 {
@@ -409 +409 @@
                 default:
                     AssertMsgFailed(("enmState=%d\n", enmState));
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_PDM_THREAD_IPE_2;
                     break;
             }
@@ -668 +668 @@
 
             if (RT_SUCCESS(rc))
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_PDM_THREAD_IPE_2;
         }
     }
@@ -732 +732 @@
      * Assert sanity.
      */
-    AssertReturn(pThread->enmState > PDMTHREADSTATE_INVALID && pThread->enmState < PDMTHREADSTATE_TERMINATED, VERR_INTERNAL_ERROR);
-    AssertReturn(pThread->Thread == RTThreadSelf(), VERR_INTERNAL_ERROR);
+    AssertReturn(pThread->enmState > PDMTHREADSTATE_INVALID && pThread->enmState < PDMTHREADSTATE_TERMINATED, VERR_PDM_THREAD_IPE_2);
+    AssertReturn(pThread->Thread == RTThreadSelf(), VERR_PDM_THREAD_INVALID_CALLER);
 
     /*
@@ -798 +798 @@
             default:
                 AssertMsgFailed(("%d\n", pThread->Internal.s.enmType));
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_PDM_THREAD_IPE_1;
                 break;
         }
@@ -947 +947 @@
                     if (    RT_SUCCESS(rc)
                         &&  pThread->enmState != PDMTHREADSTATE_SUSPENDED)
-                        rc = VERR_INTERNAL_ERROR;
+                        rc = VERR_PDM_THREAD_IPE_2;
                     if (RT_SUCCESS(rc))
                         return rc;
@@ -1040 +1040 @@
                 if (    RT_SUCCESS(rc)
                     &&  pThread->enmState != PDMTHREADSTATE_RUNNING)
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_PDM_THREAD_IPE_2;
                 if (RT_SUCCESS(rc))
                     return rc;

trunk/src/VBox/VMM/VMMR3/PGM.cpp

@@ -2216 +2216 @@
             }
 #else
-            AssertLogRelReturn(!pVM->pgm.s.fPciPassthrough, VERR_INTERNAL_ERROR_5);
+            AssertLogRelReturn(!pVM->pgm.s.fPciPassthrough, VERR_PGM_PCI_PASSTHRU_MISCONFIG);
 #endif
             break;

trunk/src/VBox/VMM/VMMR3/PGMMap.cpp

@@ -551 +551 @@
     AssertMsgReturn(cb && !(cb & X86_PAGE_4M_OFFSET_MASK), ("cb (%#x) is 0 or not aligned on a 4MB address!\n", cb),
                     VERR_INVALID_PARAMETER);
-    AssertReturn(pgmMapAreMappingsEnabled(pVM), VERR_INTERNAL_ERROR_3);
-    AssertReturn(pVM->cCpus == 1, VERR_INTERNAL_ERROR_4);
+    AssertReturn(pgmMapAreMappingsEnabled(pVM), VERR_PGM_MAPPINGS_DISABLED);
+    AssertReturn(pVM->cCpus == 1, VERR_PGM_MAPPINGS_SMP);
 
     /*
@@ -684 +684 @@
 VMMR3DECL(int) PGMR3MappingsDisable(PVM pVM)
 {
-    AssertReturn(!pVM->pgm.s.fMappingsFixed,            VERR_INTERNAL_ERROR_4);
-    AssertReturn(!pVM->pgm.s.fMappingsFixedRestored,    VERR_INTERNAL_ERROR_4);
+    AssertReturn(!pVM->pgm.s.fMappingsFixed,            VERR_PGM_MAPPINGS_FIXED);
+    AssertReturn(!pVM->pgm.s.fMappingsFixedRestored,    VERR_PGM_MAPPINGS_FIXED);
     if (pVM->pgm.s.fMappingsDisabled)
         return VINF_SUCCESS;

trunk/src/VBox/VMM/VMMR3/PGMPhys.cpp

@@ -3394 +3394 @@
                 AssertMsgFailedReturn(("enmProt=%d iPage=%d GCPhys=%RGp\n",
                                        pRom->aPages[iPage].enmProt, iPage, GCPhys),
-                                      VERR_INTERNAL_ERROR);
+                                      VERR_IPE_NOT_REACHED_DEFAULT_CASE);
         }
     }
@@ -3432 +3432 @@
                 {
                     pShadowPage = pgmPhysGetPage(pVM, GCPhys);
-                    AssertLogRelReturn(pShadowPage, VERR_INTERNAL_ERROR);
+                    AssertLogRelReturn(pShadowPage, VERR_PGM_PHYS_PAGE_GET_IPE);
                 }
 
@@ -3450 +3450 @@
                 AssertMsgFailedReturn(("enmProt=%d iPage=%d GCPhys=%RGp\n",
                                        pRom->aPages[iPage].enmProt, iPage, GCPhys),
-                                      VERR_INTERNAL_ERROR);
+                                      VERR_IPE_NOT_REACHED_DEFAULT_CASE);
         }
     }
@@ -4240 +4240 @@
      */
     uint32_t iClear = pVM->pgm.s.cHandyPages;
-    AssertMsgReturn(iClear <= RT_ELEMENTS(pVM->pgm.s.aHandyPages), ("%d", iClear), VERR_INTERNAL_ERROR);
+    AssertMsgReturn(iClear <= RT_ELEMENTS(pVM->pgm.s.aHandyPages), ("%d", iClear), VERR_PGM_HANDY_PAGE_IPE);
     Log(("PGMR3PhysAllocateHandyPages: %d -> %d\n", iClear, RT_ELEMENTS(pVM->pgm.s.aHandyPages)));
     int rcAlloc = VINF_SUCCESS;

trunk/src/VBox/VMM/VMMR3/PGMPool.cpp

@@ -459 +459 @@
 {
     PPGMPOOL pPool = pVM->pgm.s.pPoolR3;
-    AssertReturn(pPool->cCurPages < pPool->cMaxPages, VERR_INTERNAL_ERROR);
+    AssertReturn(pPool->cCurPages < pPool->cMaxPages, VERR_PGM_POOL_MAXED_OUT_ALREADY);
 
     pgmLock(pVM);

trunk/src/VBox/VMM/VMMR3/PGMSavedState.cpp

@@ -1998 +1998 @@
     {
         pgmUnlock(pVM);
-        AssertLogRelFailedReturn(VERR_INTERNAL_ERROR_2);
+        AssertLogRelFailedReturn(VERR_PGM_WRITE_MONITOR_ENGAGED);
     }
     pVM->pgm.s.fPhysWriteMonitoringEngaged = true;
@@ -2266 +2266 @@
         rc = pgmR3LoadPageBitsOld(pVM, pSSM, uType, pPage, GCPhys, pRam);
     else
-        rc = VERR_INTERNAL_ERROR;
+        rc = VERR_PGM_INVALID_SAVED_PAGE_STATE;
     AssertLogRelMsgRCReturn(rc, ("pPage=%R[pgmpage] uState=%d uType=%d GCPhys=%RGp %s rc=%Rrc\n",
                                  pPage, uState, uType, GCPhys, pRam->pszDesc, rc),
@@ -2291 +2291 @@
      */
     PPGMROMPAGE pRomPage = pgmR3GetRomPage(pVM, GCPhys);
-    AssertLogRelMsgReturn(pRomPage, ("GCPhys=%RGp %s\n", GCPhys, pRam->pszDesc), VERR_INTERNAL_ERROR);
+    AssertLogRelMsgReturn(pRomPage, ("GCPhys=%RGp %s\n", GCPhys, pRam->pszDesc), VERR_PGM_SAVED_ROM_PAGE_NOT_FOUND);
 
     uint8_t uProt;
@@ -2306 +2306 @@
         rc = PGMR3PhysRomProtect(pVM, GCPhys, PAGE_SIZE, enmProt);
         AssertLogRelRCReturn(rc, rc);
-        AssertLogRelReturn(pRomPage->enmProt == enmProt, VERR_INTERNAL_ERROR);
+        AssertLogRelReturn(pRomPage->enmProt == enmProt, VERR_PGM_SAVED_ROM_PAGE_PROT);
     }
 
@@ -2677 +2677 @@
                         }
 
-                        AssertLogRelMsgReturn(PGM_PAGE_GET_STATE(pPage) == PGM_PAGE_STATE_ALLOCATED, ("GCPhys=%RGp %R[pgmpage]\n", GCPhys, pPage), VERR_INTERNAL_ERROR_5);
+                        AssertLogRelMsgReturn(PGM_PAGE_GET_STATE(pPage) == PGM_PAGE_STATE_ALLOCATED, ("GCPhys=%RGp %R[pgmpage]\n", GCPhys, pPage), VERR_PGM_UNEXPECTED_PAGE_STATE);
 
                         /* If this is a ROM page, we must clear it and not try
@@ -2717 +2717 @@
                             AssertLogRelMsgReturn(   PGM_PAGE_GET_PDE_TYPE(pPage) != PGM_PAGE_PDE_TYPE_PDE
                                                   && PGM_PAGE_GET_PDE_TYPE(pPage) != PGM_PAGE_PDE_TYPE_PDE_DISABLED,
-                                                     ("GCPhys=%RGp %R[pgmpage]\n", GCPhys, pPage), VERR_INTERNAL_ERROR_5);
+                                                     ("GCPhys=%RGp %R[pgmpage]\n", GCPhys, pPage), VERR_PGM_LOAD_UNEXPECTED_PAGE_TYPE);
 
                             rc = pgmPhysFreePage(pVM, pReq, &cPendingPages, pPage, GCPhys);
@@ -2741 +2741 @@
 
                     default:
-                        AssertMsgFailedReturn(("%#x\n", u8), VERR_INTERNAL_ERROR);
+                        AssertMsgFailedReturn(("%#x\n", u8), VERR_PGM_SAVED_REC_TYPE);
                 }
                 id = UINT8_MAX;
@@ -2771 +2771 @@
                         if (pMmio2->idSavedState == id)
                             break;
-                    AssertLogRelMsgReturn(pMmio2, ("id=%#u iPage=%#x\n", id, iPage), VERR_INTERNAL_ERROR);
+                    AssertLogRelMsgReturn(pMmio2, ("id=%#u iPage=%#x\n", id, iPage), VERR_PGM_SAVED_MMIO2_RANGE_NOT_FOUND);
                 }
-                AssertLogRelMsgReturn(iPage < (pMmio2->RamRange.cb >> PAGE_SHIFT), ("iPage=%#x cb=%RGp %s\n", iPage, pMmio2->RamRange.cb, pMmio2->RamRange.pszDesc), VERR_INTERNAL_ERROR);
+                AssertLogRelMsgReturn(iPage < (pMmio2->RamRange.cb >> PAGE_SHIFT), ("iPage=%#x cb=%RGp %s\n", iPage, pMmio2->RamRange.cb, pMmio2->RamRange.pszDesc), VERR_PGM_SAVED_MMIO2_PAGE_NOT_FOUND);
                 void *pvDstPage = (uint8_t *)pMmio2->RamRange.pvR3 + ((size_t)iPage << PAGE_SHIFT);
 
@@ -2817 +2817 @@
                         if (pRom->idSavedState == id)
                             break;
-                    AssertLogRelMsgReturn(pRom, ("id=%#u iPage=%#x\n", id, iPage), VERR_INTERNAL_ERROR);
+                    AssertLogRelMsgReturn(pRom, ("id=%#u iPage=%#x\n", id, iPage), VERR_PGM_SAVED_ROM_RANGE_NOT_FOUND);
                 }
-                AssertLogRelMsgReturn(iPage < (pRom->cb >> PAGE_SHIFT), ("iPage=%#x cb=%RGp %s\n", iPage, pRom->cb, pRom->pszDesc), VERR_INTERNAL_ERROR);
+                AssertLogRelMsgReturn(iPage < (pRom->cb >> PAGE_SHIFT), ("iPage=%#x cb=%RGp %s\n", iPage, pRom->cb, pRom->pszDesc), VERR_PGM_SAVED_ROM_PAGE_NOT_FOUND);
                 PPGMROMPAGE pRomPage = &pRom->aPages[iPage];
                 GCPhys = pRom->GCPhys + ((RTGCPHYS)iPage << PAGE_SHIFT);
@@ -2831 +2831 @@
                     return rc;
                 PGMROMPROT enmProt = (PGMROMPROT)u8Prot;
-                AssertLogRelMsgReturn(enmProt > PGMROMPROT_INVALID && enmProt < PGMROMPROT_END, ("GCPhys=%RGp enmProt=%d\n", GCPhys, enmProt), VERR_INTERNAL_ERROR);
+                AssertLogRelMsgReturn(enmProt > PGMROMPROT_INVALID && enmProt < PGMROMPROT_END, ("GCPhys=%RGp enmProt=%d\n", GCPhys, enmProt), VERR_PGM_SAVED_ROM_PAGE_PROT);
 
                 if (enmProt != pRomPage->enmProt)
@@ -2841 +2841 @@
                     rc = PGMR3PhysRomProtect(pVM, GCPhys, PAGE_SIZE, enmProt);
                     AssertLogRelMsgRCReturn(rc, ("GCPhys=%RGp rc=%Rrc\n", GCPhys, rc), rc);
-                    AssertLogRelReturn(pRomPage->enmProt == enmProt, VERR_INTERNAL_ERROR);
+                    AssertLogRelReturn(pRomPage->enmProt == enmProt, VERR_PGM_SAVED_ROM_PAGE_PROT);
                 }
                 if ((u8 & ~PGM_STATE_REC_FLAG_ADDR) == PGM_STATE_REC_ROM_PROT)
@@ -2871 +2871 @@
                         break;
 
-                    default: AssertLogRelFailedReturn(VERR_INTERNAL_ERROR); /* shut up gcc */
+                    default: AssertLogRelFailedReturn(VERR_IPE_NOT_REACHED_DEFAULT_CASE); /* shut up gcc */
                 }
                 if (!pRealPage)
@@ -2925 +2925 @@
              */
             default:
-                AssertLogRelMsgFailedReturn(("%#x\n", u8), VERR_INTERNAL_ERROR);
+                AssertLogRelMsgFailedReturn(("%#x\n", u8), VERR_PGM_SAVED_REC_TYPE);
         }
     } /* forever */

trunk/src/VBox/VMM/VMMR3/SELM.cpp

@@ -1719 +1719 @@
     {
         Log(("SELMR3DebugCheck: ldt is out of bound SelLdt=%#x\n", SelLdt));
-        return VERR_INTERNAL_ERROR;
+        return VERR_SELM_LDT_OUT_OF_BOUNDS;
     }
     X86DESC    LDTDesc;
@@ -1745 +1745 @@
     {
         Log(("SELmR3DebugCheck: Invalid LDT %04x!\n", SelLdt));
-        return VERR_INTERNAL_ERROR;
+        return VERR_SELM_INVALID_LDT;
     }
 

trunk/src/VBox/VMM/VMMR3/SSM.cpp

@@ -964 +964 @@
     }
     AssertFailed();
-    return VERR_INTERNAL_ERROR_3;
+    return VERR_SSM_UNEXPECTED_PASS;
 }
 
@@ -2769 +2769 @@
     {
         uint64_t offCur = ssmR3StrmTell(pStrm);
-        AssertReturn(offCur <= offDst, VERR_INTERNAL_ERROR_4);
+        AssertReturn(offCur <= offDst, VERR_SSM_SKIP_BACKWARDS);
         if (offCur == offDst)
             return VINF_SUCCESS;
@@ -3188 +3188 @@
     }
     else
-        AssertLogRelMsgFailedReturn(("cb=%#x\n", cb), pSSM->rc = VERR_INTERNAL_ERROR);
+        AssertLogRelMsgFailedReturn(("cb=%#x\n", cb), pSSM->rc = VERR_SSM_MEM_TOO_BIG);
 
     Log3(("ssmR3DataWriteRecHdr: %08llx|%08llx/%08x: Type=%02x fImportant=%RTbool cbHdr=%u\n",
@@ -4257 +4257 @@
                     break;
                 default:
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_SSM_IPE_1;
                     break;
             }
@@ -4605 +4605 @@
                 break;
             default:
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_SSM_IPE_1;
                 break;
         }
@@ -4692 +4692 @@
                     break;
                 default:
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_SSM_IPE_1;
                     break;
             }
@@ -5032 +5032 @@
                     break;
                 default:
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_SSM_IPE_1;
                     break;
             }
@@ -5170 +5170 @@
                 break;
             default:
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_SSM_IPE_1;
                 break;
         }
@@ -5327 +5327 @@
                     break;
                 default:
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_SSM_IPE_1;
                     break;
             }
@@ -5904 +5904 @@
                 break;
             default:
-                return VERR_INTERNAL_ERROR;
+                return VERR_IPE_NOT_REACHED_DEFAULT_CASE;
         }
 
@@ -5952 +5952 @@
                 break;
             default:
-                return VERR_INTERNAL_ERROR;
+                return VERR_IPE_NOT_REACHED_DEFAULT_CASE;
         }
 
@@ -6072 +6072 @@
 
             default:
-                AssertMsgFailedReturn(("%x\n", pSSM->u.Read.u8TypeAndFlags), VERR_INTERNAL_ERROR_5);
+                AssertMsgFailedReturn(("%x\n", pSSM->u.Read.u8TypeAndFlags), VERR_SSM_BAD_REC_TYPE);
         }
 
@@ -6173 +6173 @@
 
             default:
-                AssertMsgFailedReturn(("%x\n", pSSM->u.Read.u8TypeAndFlags), VERR_INTERNAL_ERROR_5);
+                AssertMsgFailedReturn(("%x\n", pSSM->u.Read.u8TypeAndFlags), VERR_SSM_BAD_REC_TYPE);
         }
         /*pSSM->u.Read.offDataBuffer = 0;*/
@@ -7483 +7483 @@
         }
         else
-            AssertFailedReturn(VERR_INTERNAL_ERROR);
+            AssertFailedReturn(VERR_SSM_IPE_2);
         if (!pSSM->u.Read.fStreamCrc32)
             ssmR3StrmDisableChecksumming(&pSSM->Strm);
@@ -7581 +7581 @@
         }
         else
-            AssertFailedReturn(VERR_INTERNAL_ERROR);
+            AssertFailedReturn(VERR_SSM_IPE_1);
 
         /*
@@ -7894 +7894 @@
                                 break;
                             default:
-                                rc = VERR_INTERNAL_ERROR;
+                                rc = VERR_SSM_IPE_1;
                                 break;
                         }
@@ -8156 +8156 @@
                     break;
                 default:
-                    rc = VERR_INTERNAL_ERROR;
+                    rc = VERR_SSM_IPE_1;
                     break;
             }
@@ -8323 +8323 @@
                         break;
                     default:
-                        rc = VERR_INTERNAL_ERROR;
+                        rc = VERR_SSM_IPE_1;
                         break;
                 }
@@ -8394 +8394 @@
                         break;
                     default:
-                        rc = VERR_INTERNAL_ERROR;
+                        rc = VERR_SSM_IPE_1;
                         break;
                 }
@@ -9121 +9121 @@
         {
             AssertLogRelMsgFailed(("fCancelled=%RX32 enmOp=%d\n", u32Old, pSSM->enmOp));
-            rc = VERR_INTERNAL_ERROR_2;
+            rc = VERR_SSM_IPE_3;
         }
     }

trunk/src/VBox/VMM/VMMR3/TM.cpp

@@ -224 +224 @@
      */
     pVM->tm.s.pvGIPR3 = (void *)g_pSUPGlobalInfoPage;
-    AssertMsgReturn(pVM->tm.s.pvGIPR3, ("GIP support is now required!\n"), VERR_INTERNAL_ERROR);
+    AssertMsgReturn(pVM->tm.s.pvGIPR3, ("GIP support is now required!\n"), VERR_TM_GIP_REQUIRED);
     AssertMsgReturn((g_pSUPGlobalInfoPage->u32Version >> 16) == (SUPGLOBALINFOPAGE_VERSION >> 16),
-                    ("Unsupported GIP version!\n"), VERR_INTERNAL_ERROR);
+                    ("Unsupported GIP version!\n"), VERR_TM_GIP_VERSION);
 
     RTHCPHYS HCPhysGIP;
@@ -251 +251 @@
     if (    g_pSUPGlobalInfoPage->u32Magic == SUPGLOBALINFOPAGE_MAGIC
         &&  g_pSUPGlobalInfoPage->u32UpdateIntervalNS >= 250000000 /* 0.25s */)
-        return VMSetError(pVM, VERR_INTERNAL_ERROR, RT_SRC_POS,
+        return VMSetError(pVM, VERR_TM_GIP_UPDATE_INTERVAL_TOO_BIG, RT_SRC_POS,
                           N_("The GIP update interval is too big. u32UpdateIntervalNS=%RU32 (u32UpdateHz=%RU32)"),
                           g_pSUPGlobalInfoPage->u32UpdateIntervalNS, g_pSUPGlobalInfoPage->u32UpdateHz);
@@ -282 +282 @@
     pVM->tm.s.VirtualGetRawDataRC.pu64Prev = MMHyperR3ToRC(pVM, (void *)&pVM->tm.s.u64VirtualRawPrev);
     pVM->tm.s.VirtualGetRawDataR0.pu64Prev = MMHyperR3ToR0(pVM, (void *)&pVM->tm.s.u64VirtualRawPrev);
-    AssertReturn(pVM->tm.s.VirtualGetRawDataR0.pu64Prev, VERR_INTERNAL_ERROR);
+    AssertRelease(pVM->tm.s.VirtualGetRawDataR0.pu64Prev);
     /* The rest is done in TMR3InitFinalize since it's too early to call PDM. */
 
@@ -1994 +1994 @@
         PPDMCRITSECT    pCritSect = pTimer->pCritSect;
         if (pCritSect)
-            PDMCritSectEnter(pCritSect, VERR_INTERNAL_ERROR);
+            PDMCritSectEnter(pCritSect, VERR_IGNORED);
         Log2(("tmR3TimerQueueRun: %p:{.enmState=%s, .enmClock=%d, .enmType=%d, u64Expire=%llx (now=%llx) .pszDesc=%s}\n",
               pTimer, tmTimerState(pTimer->enmState), pTimer->enmClock, pTimer->enmType, pTimer->u64Expire, u64Now, pTimer->pszDesc));
@@ -2181 +2181 @@
         PPDMCRITSECT pCritSect = pTimer->pCritSect;
         if (pCritSect)
-            PDMCritSectEnter(pCritSect, VERR_INTERNAL_ERROR);
+            PDMCritSectEnter(pCritSect, VERR_IGNORED);
 
         Log2(("tmR3TimerQueueRun: %p:{.enmState=%s, .enmClock=%d, .enmType=%d, u64Expire=%llx (now=%llx) .pszDesc=%s}\n",

trunk/src/VBox/VMM/VMMR3/VM.cpp

@@ -1218 +1218 @@
     AssertMsgReturn(enmVMState == VMSTATE_POWERING_ON,
                     ("%s\n", VMR3GetStateName(enmVMState)),
-                    VERR_INTERNAL_ERROR_4);
+                    VERR_VM_UNEXPECTED_UNSTABLE_STATE);
 
     /*
@@ -1311 +1311 @@
                     ||  enmVMState == VMSTATE_SUSPENDING_EXT_LS,
                     ("%s\n", VMR3GetStateName(enmVMState)),
-                    VERR_INTERNAL_ERROR_4);
+                    VERR_VM_UNEXPECTED_UNSTABLE_STATE);
 
     /*
@@ -1325 +1325 @@
                                  VMSTATE_SUSPENDED_EXT_LS, VMSTATE_SUSPENDING_EXT_LS);
         if (RT_FAILURE(rc))
-            return VERR_INTERNAL_ERROR_3;
+            return VERR_VM_UNEXPECTED_UNSTABLE_STATE;
     }
 
@@ -1389 +1389 @@
     AssertMsgReturn(enmVMState == VMSTATE_RESUMING,
                     ("%s\n", VMR3GetStateName(enmVMState)),
-                    VERR_INTERNAL_ERROR_4);
+                    VERR_VM_UNEXPECTED_UNSTABLE_STATE);
 
 #if 0
@@ -1504 +1504 @@
             default:
                 AssertMsgFailed(("%s\n", VMR3GetStateName(enmVMState)));
-                rc = VERR_INTERNAL_ERROR_3;
+                rc = VERR_VM_UNEXPECTED_VM_STATE;
                 break;
         }
@@ -1518 +1518 @@
     AssertMsgReturn(enmVMState == VMSTATE_SUSPENDING_LS,
                     ("%s\n", VMR3GetStateName(enmVMState)),
-                    VERR_INTERNAL_ERROR_4);
+                    VERR_VM_UNEXPECTED_UNSTABLE_STATE);
 
     /*
@@ -1529 +1529 @@
                                  VMSTATE_SUSPENDED_LS, VMSTATE_SUSPENDING_LS);
         if (RT_FAILURE(rc))
-            return VERR_INTERNAL_ERROR_3;
+            return VERR_VM_UNEXPECTED_UNSTABLE_STATE;
 
         *pfSuspended = true;
@@ -2551 +2551 @@
         for (PVMREQ pReq = pReqHead; pReq; pReq = pReq->pNext)
         {
-            ASMAtomicUoWriteS32(&pReq->iStatus, VERR_INTERNAL_ERROR);
+            ASMAtomicUoWriteS32(&pReq->iStatus, VERR_VM_REQUEST_KILLED);
             ASMAtomicWriteSize(&pReq->enmState, VMREQSTATE_INVALID);
             RTSemEventSignal(pReq->EventSem);
@@ -2581 +2581 @@
             for (PVMREQ pReq = pReqHead; pReq; pReq = pReq->pNext)
             {
-                ASMAtomicUoWriteS32(&pReq->iStatus, VERR_INTERNAL_ERROR);
+                ASMAtomicUoWriteS32(&pReq->iStatus, VERR_VM_REQUEST_KILLED);
                 ASMAtomicWriteSize(&pReq->enmState, VMREQSTATE_INVALID);
                 RTSemEventSignal(pReq->EventSem);
@@ -2797 +2797 @@
                           || enmVMState == VMSTATE_RESETTING_LS,
                           ("%s\n", VMR3GetStateName(enmVMState)),
-                          VERR_INTERNAL_ERROR_4);
+                          VERR_VM_UNEXPECTED_UNSTABLE_STATE);
 
     /*

trunk/src/VBox/VMM/VMMR3/VMEmt.cpp

@@ -307 +307 @@
     if (pUVCpu->pVM)
         VM_FF_SET(pUVCpu->pVM, VM_FF_CHECK_VM_STATE);
-    return VERR_INTERNAL_ERROR;
+    return VERR_VM_FATAL_WAIT_ERROR;
 }
 

trunk/src/VBox/VMM/VMMR3/VMM.cpp

@@ -526 +526 @@
         LogRel(("R0 init failed, rc=%Rra\n", rc));
         if (RT_SUCCESS(rc))
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_IPE_UNEXPECTED_INFO_STATUS;
     }
     return rc;
@@ -602 +602 @@
             VMMR3FatalDump(pVM, pVCpu, rc);
             if (rc >= VINF_EM_FIRST && rc <= VINF_EM_LAST)
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_IPE_UNEXPECTED_INFO_STATUS;
         }
         AssertRC(rc);
@@ -736 +736 @@
         LogRel(("VMMR3Term: R0 term failed, rc=%Rra. (warning)\n", rc));
         if (RT_SUCCESS(rc))
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_IPE_UNEXPECTED_INFO_STATUS;
     }
 
@@ -1972 +1972 @@
     AssertLogRelMsgReturn(rc == VINF_SUCCESS || RT_FAILURE(rc),
                           ("uOperation=%u rc=%Rrc\n", uOperation, rc),
-                          VERR_INTERNAL_ERROR);
+                          VERR_IPE_UNEXPECTED_INFO_STATUS);
     return rc;
 }
@@ -2194 +2194 @@
         default:
             AssertMsgFailed(("enmCallRing3Operation=%d\n", pVCpu->vmm.s.enmCallRing3Operation));
-            return VERR_INTERNAL_ERROR;
+            return VERR_VMM_UNKNOWN_RING3_CALL;
     }
 

trunk/src/VBox/VMM/VMMR3/VMMSwitcher.cpp

@@ -992 +992 @@
 /** @todo r=bird: I would suggest that we create a dummy switcher which just does something like:
  * @code
- *       mov eax, VERR_INTERNAL_ERROR
+ *       mov eax, VERR_VMM_DUMMY_SWITCHER
  *       ret
  * @endcode

trunk/src/VBox/VMM/VMMR3/VMReq.cpp

@@ -1186 +1186 @@
                 default:
                     AssertReleaseMsgFailed(("cArgs=%d\n", pReq->u.Internal.cArgs));
-                    rcRet = rcReq = VERR_INTERNAL_ERROR;
+                    rcRet = rcReq = VERR_VM_REQUEST_TOO_MANY_ARGS_IPE;
                     break;
             }

trunk/src/VBox/VMM/VMMRC/IOMRC.cpp

@@ -87 +87 @@
         default:
             AssertMsgFailed(("Unknown I/O port access opcode %d.\n", pCpu->pCurInstr->opcode));
-            return VERR_INTERNAL_ERROR;
+            return VERR_IOM_IOPORT_UNKNOWN_OPCODE;
     }
 }

trunk/src/VBox/VMM/VMMRC/MMRamRC.cpp

@@ -143 +143 @@
     {
         /* Must be a read violation. */
-        AssertReturn(!(TRPMGetErrorCode(VMMGetCpu0(pVM)) & X86_TRAP_PF_RW), VERR_INTERNAL_ERROR);
+        AssertReturn(!(TRPMGetErrorCode(VMMGetCpu0(pVM)) & X86_TRAP_PF_RW), VERR_MM_BAD_TRAP_TYPE_IPE);
         pRegFrame->eip = (uintptr_t)&MMGCRamRead_Error;
         return VINF_SUCCESS;
@@ -155 +155 @@
     {
         /* Must be a write violation. */
-        AssertReturn(TRPMGetErrorCode(VMMGetCpu0(pVM)) & X86_TRAP_PF_RW, VERR_INTERNAL_ERROR);
+        AssertReturn(TRPMGetErrorCode(VMMGetCpu0(pVM)) & X86_TRAP_PF_RW, VERR_MM_BAD_TRAP_TYPE_IPE);
         pRegFrame->eip = (uintptr_t)&MMGCRamWrite_Error;
         return VINF_SUCCESS;

trunk/src/VBox/VMM/VMMRC/TRPMRCHandlers.cpp

@@ -344 +344 @@
      */
     int rc = DBGFRZTrap01Handler(pVM, pVCpu, pRegFrame, uDr6);
-    AssertStmt(rc != VINF_EM_RAW_GUEST_TRAP, rc = VERR_INTERNAL_ERROR_3);
+    AssertStmt(rc != VINF_EM_RAW_GUEST_TRAP, rc = VERR_TRPM_IPE_1);
 
     Log6(("TRPMGCHyper01: %Rrc (%04x:%08x %RTreg)\n", rc, pRegFrame->cs, pRegFrame->eip, uDr6));
@@ -462 +462 @@
      */
     int rc = DBGFRZTrap03Handler(pVM, pVCpu, pRegFrame);
-    AssertStmt(rc != VINF_EM_RAW_GUEST_TRAP, rc = VERR_INTERNAL_ERROR_3);
+    AssertStmt(rc != VINF_EM_RAW_GUEST_TRAP, rc = VERR_TRPM_IPE_2);
 
     Log6(("TRPMGCHyper03: %Rrc (%04x:%08x)\n", rc, pRegFrame->cs, pRegFrame->eip));
@@ -1317 +1317 @@
             default:
                 AssertMsgFailed(("Invalid uUser=%#x\n", uUser));
-                return VERR_INTERNAL_ERROR;
+                return VERR_TRPM_BAD_TRAP_IN_OP;
         }
     }
@@ -1379 +1379 @@
             default:
                 AssertMsgFailed(("Invalid uUser=%#x\n", uUser));
-                return VERR_INTERNAL_ERROR;
+                return VERR_TRPM_BAD_TRAP_IN_OP;
         }
 
@@ -1388 +1388 @@
 
     AssertMsgFailed(("Impossible!\n"));
-    return VERR_INTERNAL_ERROR;
-}
-
+    return VERR_TRPM_IPE_3;
+}
+

trunk/src/VBox/VMM/VMMRZ/PGMRZDynMap.cpp

@@ -338 +338 @@
  * Initializes the auto mapping sets for a VM.
  *
- * @returns VINF_SUCCESS on success, VERR_INTERNAL_ERROR on failure.
+ * @returns VINF_SUCCESS on success, VERR_PGM_DYNMAP_IPE on failure.
  * @param   pVM         The VM in question.
  */
@@ -344 +344 @@
 {
     VMCPUID idCpu = pVM->cCpus;
-    AssertReturn(idCpu > 0 && idCpu <= VMM_MAX_CPU_COUNT, VERR_INTERNAL_ERROR);
+    AssertReturn(idCpu > 0 && idCpu <= VMM_MAX_CPU_COUNT, VERR_PGM_DYNMAP_IPE);
     while (idCpu-- > 0)
     {
@@ -400 +400 @@
             break;
         default:
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_PGM_DYNMAP_IPE;
             break;
     }
@@ -489 +489 @@
      */
     PPGMRZDYNMAP pThis = g_pPGMR0DynMap;
-    AssertPtrReturn(pThis, VERR_INTERNAL_ERROR);
+    AssertPtrReturn(pThis, VERR_PGM_DYNMAP_IPE);
     rc = RTSemFastMutexRequest(pThis->hInitLock);
     AssertLogRelRCReturn(rc, rc);
@@ -819 +819 @@
             ASMIntEnable();
             if (i + 1 == pPgLvl->cLevels)
-                AssertReturn(pSeg->cPTs < cMaxPTs, VERR_INTERNAL_ERROR);
+                AssertReturn(pSeg->cPTs < cMaxPTs, VERR_PGM_DYNMAP_IPE);
             else
             {
@@ -872 +872 @@
                     i, pPgLvl->cLevels, uEntry, pPgLvl->a[i].fAndMask, pPgLvl->a[i].fResMask, uEntry & pPgLvl->a[i].fAndMask,
                     pPgLvl->a[i].u.pv, pvPage, iEntry, pThis->fLegacyMode));
-            return VERR_INTERNAL_ERROR;
+            return VERR_PGM_DYNMAP_IPE;
         }
         /*Log(("#%d: iEntry=%4d uEntry=%#llx pvEntry=%p HCPhys=%RHp \n", i, iEntry, uEntry, pvEntry, pPgLvl->a[i].HCPhys));*/
@@ -1007 +1007 @@
                 LogRel(("pgmR0DynMapAddSeg: internal error - page #%u HCPhysPage=%RHp HCPhysPte=%RHp pbPage=%p pvPte=%p\n",
                         iPage - pSeg->iPage, HCPhysPage, HCPhysPte, pbPage, pThis->paPages[iPage].uPte.pv));
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_PGM_DYNMAP_IPE;
                 break;
             }
@@ -1089 +1089 @@
     uint32_t cMinPages;
     uint32_t cPages = pgmR0DynMapCalcNewSize(pThis, &cMinPages);
-    AssertReturn(cPages, VERR_INTERNAL_ERROR);
+    AssertReturn(cPages, VERR_PGM_DYNMAP_IPE);
     int rc = pgmR0DynMapAddSeg(pThis, cPages);
     if (rc == VERR_NO_MEMORY)
@@ -1132 +1132 @@
     uint32_t cMinPages;
     uint32_t cPages = pgmR0DynMapCalcNewSize(pThis, &cMinPages);
-    AssertReturn(cPages, VERR_INTERNAL_ERROR);
+    AssertReturn(cPages, VERR_PGM_DYNMAP_IPE);
     if (pThis->cPages >= cPages)
         return VINF_SUCCESS;
@@ -1578 +1578 @@
             RTAssertMsg1Weak(#expr, __LINE__, __FILE__, __PRETTY_FUNCTION__); \
             RTAssertMsg2Weak a; \
-            return VERR_INTERNAL_ERROR; \
+            return VERR_PGM_DYNMAP_IPE; \
         } \
     } while (0)
@@ -2529 +2529 @@
         {
             LogRel(("failed(%d): rc=%Rrc; pv=%p pv2=%p i=%p\n", __LINE__, rc, pv, pv2, i));
-            if (RT_SUCCESS(rc)) rc = VERR_INTERNAL_ERROR;
+            if (RT_SUCCESS(rc)) rc = VERR_PGM_DYNMAP_IPE;
         }
         else if (pSet->cEntries != 5)
         {
             LogRel(("failed(%d): cEntries=%d expected %d\n", __LINE__, pSet->cEntries, RT_ELEMENTS(pSet->aEntries) / 2));
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_PGM_DYNMAP_IPE;
         }
         else if (   pSet->aEntries[4].cRefs != UINT16_MAX - 1
@@ -2546 +2546 @@
                 LogRel(("[%d]=%d, ", i, pSet->aEntries[i].cRefs));
             LogRel(("\n"));
-            rc = VERR_INTERNAL_ERROR;
+            rc = VERR_PGM_DYNMAP_IPE;
         }
         if (RT_SUCCESS(rc))
@@ -2568 +2568 @@
             {
                 LogRel(("failed(%d): rc=%Rrc; pv=%p pv2=%p i=%d\n", __LINE__, rc, pv, pv2, i));
-                if (RT_SUCCESS(rc)) rc = VERR_INTERNAL_ERROR;
+                if (RT_SUCCESS(rc)) rc = VERR_PGM_DYNMAP_IPE;
             }
             else if (pSet->cEntries != RT_ELEMENTS(pSet->aEntries))
             {
                 LogRel(("failed(%d): cEntries=%d expected %d\n", __LINE__, pSet->cEntries, RT_ELEMENTS(pSet->aEntries)));
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_PGM_DYNMAP_IPE;
             }
             LogRel(("Load=%u/%u/%u Set=%u/%u\n", pThis->cLoad, pThis->cMaxLoad, pThis->cPages - pThis->cPages, pSet->cEntries, RT_ELEMENTS(pSet->aEntries)));
@@ -2611 +2611 @@
                     LogRel(("failed(%d): rc=%Rrc, wanted %d ; pv2=%p Set=%u/%u; i=%d\n", __LINE__,
                             rc, VERR_PGM_DYNMAP_FULL_SET, pv2, pSet->cEntries, RT_ELEMENTS(pSet->aEntries), i));
-                    if (RT_SUCCESS(rc)) rc = VERR_INTERNAL_ERROR;
+                    if (RT_SUCCESS(rc)) rc = VERR_PGM_DYNMAP_IPE;
                 }
             }
@@ -2649 +2649 @@
                 LogRel(("failed(%d): cFailures=%d pu32Real=%p pu32=%p u32Expect=%#x *pu32=%#x\n", __LINE__,
                         Test.cFailures, pu32Real, Test.pu32, Test.u32Expect, *Test.pu32));
-                rc = VERR_INTERNAL_ERROR;
+                rc = VERR_PGM_DYNMAP_IPE;
             }
             else

trunk/src/VBox/VMM/VMMRZ/VMMRZ.cpp

@@ -80 +80 @@
     pVCpu->vmm.s.enmCallRing3Operation = enmOperation;
     pVCpu->vmm.s.u64CallRing3Arg = uArg;
-    pVCpu->vmm.s.rcCallRing3 = VERR_INTERNAL_ERROR;
+    pVCpu->vmm.s.rcCallRing3 = VERR_VMM_RING3_CALL_NO_RC;
 #ifdef IN_RC
     pVM->vmm.s.pfnGuestToHostRC(VINF_VMM_CALL_HOST);

trunk/src/VBox/VMM/testcase/tstIEMCheckMc.cpp

@@ -75 +75 @@
     static VBOXSTRICTRC a_Name(PIEMCPU pIemCpu, a_Type0 a_Name0, a_Type1 a_Name1) RT_NO_THROW
 
-#define IEM_NOT_REACHED_DEFAULT_CASE_RET()                  default: return VERR_INTERNAL_ERROR_4
+#define IEM_NOT_REACHED_DEFAULT_CASE_RET()                  default: return VERR_IPE_NOT_REACHED_DEFAULT_CASE
 
 #define IEM_OPCODE_GET_NEXT_U8(a_pu8)                       do { *(a_pu8)  = g_bRandom; CHK_PTYPE(uint8_t  *, a_pu8);  } while (0)