Changeset 43042 in vbox for trunk/src/VBox/VMM/VMMR0/PGMR0SharedPage.cpp

Timestamp:

Aug 28, 2012 2:18:03 PM (12 years ago)

Author:

vboxsync

Message:

PGMR0SharedPage.cpp: Must always clear all shadow page table mappings of a guest page which has been made into a shared one, even if we didn't get a new page. A private page converted to a shared one needs to be write protected.

File:

• trunk/src/VBox/VMM/VMMR0/PGMR0SharedPage.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/PGMR0SharedPage.cpp

@@ -102 +102 @@
                              GCPtrPage, PageDesc.GCPhys, PGM_PAGE_GET_HCPHYS(pPage), PageDesc.HCPhys));
 
+                        /* Page was either replaced by an existing shared
+                           version of it or converted into a read-only shared
+                           page, so, clear all references. */
+                        bool fFlush = false;
+                        rc = pgmPoolTrackUpdateGCPhys(pVM, PageDesc.GCPhys, pPage, true /* clear the entries */, &fFlush);
+                        Assert(   rc == VINF_SUCCESS
+                               || (   VMCPU_FF_ISSET(pVCpu, VMCPU_FF_PGM_SYNC_CR3)
+                                   && (pVCpu->pgm.s.fSyncFlags & PGM_SYNC_CLEAR_PGM_POOL)));
+                        if (rc == VINF_SUCCESS)
+                            fFlushTLBs |= fFlush;
+                        fFlushRemTLBs = true;
+
                         if (PageDesc.HCPhys != PGM_PAGE_GET_HCPHYS(pPage))
                         {
-                            /* Page was replaced by an existing shared version
-                               of it; clear all references first. */
-                            bool fFlush = false;
-                            rc = pgmPoolTrackUpdateGCPhys(pVM, PageDesc.GCPhys, pPage, true /* clear the entries */, &fFlush);
-                            Assert(   rc == VINF_SUCCESS
-                                   || (   VMCPU_FF_ISSET(pVCpu, VMCPU_FF_PGM_SYNC_CR3)
-                                       && (pVCpu->pgm.s.fSyncFlags & PGM_SYNC_CLEAR_PGM_POOL)));
-                            if (rc == VINF_SUCCESS)
-                                fFlushTLBs |= fFlush;
-                            fFlushRemTLBs = true;
-
                             /* Update the physical address and page id now. */
                             PGM_PAGE_SET_HCPHYS(pVM, pPage, PageDesc.HCPhys);