Changeset 43769 in vbox for trunk/src/VBox/VMM/VMMR0/HWVMXR0.h

Timestamp:

Oct 29, 2012 3:26:09 PM (12 years ago)

Author:

vboxsync

Message:

VMM/VMMR0: todos/points-to-ponder regarding segment selectors.

File:

• trunk/src/VBox/VMM/VMMR0/HWVMXR0.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HWVMXR0.h

@@ -216 +216 @@
             /* Must override this or else VT-x will fail with invalid guest state errors. */    \
             /* DPL=3, present, code/data, r/w/accessed. */                                      \
+            /** @todo we shouldn't have to do this, if it is not 0xf3 it means we screwed up elsewhere (recompiler). */  \
+            /** @todo VT-x docs explicitly mentions 0xF3. Why not just val = 0xf3 ??. */        \
             val = (pCtx->reg.Attr.u & ~0xFF) | 0xF3;                                            \
         }                                                                                       \
         else                                                                                    \
         if (    CPUMIsGuestInRealModeEx(pCtx)                                                   \
-            &&  !pVM->hm.s.vmx.fUnrestrictedGuest)                                          \
+            &&  !pVM->hm.s.vmx.fUnrestrictedGuest)                                              \
         {                                                                                       \
+            /** @todo shouldn't the 'if' condition above check for 'pRealModeTSS' ? */          \
             /* Must override this or else VT-x will fail with invalid guest state errors. */    \
             /* DPL=3, present, code/data, r/w/accessed. */                                      \