Changeset 44296 in vbox for trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDisplay.cpp

Timestamp:

Jan 15, 2013 2:12:18 PM (12 years ago)

Author:

vboxsync

Message:

VBoxTray: some auto-resize cleanup & todos/questions

File:

• trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDisplay.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDisplay.cpp

@@ -267 +267 @@
     {
         Log(("VBoxTray: ResizeDisplayDevice: EnumDisplaySettings error %d\n", GetLastError ()));
-        return FALSE;
+        /* @todo: perhaps more intelligent error reporting is needed here
+         * return DISP_CHANGE_BADMODE to avoid retries & thus infinite looping */
+        return DISP_CHANGE_BADMODE;
     }
 
@@ -346 +348 @@
     DWORD dwStatus = gCtx.pfnChangeDisplaySettingsEx(NULL, NULL, NULL, 0, NULL);
     Log(("VBoxTray: ChangeDisplay return errorNo = %d\n", GetLastError()));
+    /* @todo: if the pfnChangeDisplaySettingsEx returned status is
+     * NOT DISP_CHANGE_SUCCESSFUL AND NOT DISP_CHANGE_BADMODE,
+     * we will always end up in re-trying, see ResizeDisplayDevice
+     * is this what we want actually?  */
     return dwStatus;
 }