Changeset 44766 in vbox for trunk/src/VBox/HostServices/SharedOpenGL/render

Timestamp:

Feb 20, 2013 3:43:52 PM (12 years ago)

Author:

vboxsync

Message:

crOpenGL: host 3d window repaint impl for Win host; enable offscreen rendering for Win; 3D window repaint generics

Location:

trunk/src/VBox/HostServices/SharedOpenGL/render

Files:

• renderspu.c (modified) (26 diffs)
• renderspu.h (modified) (4 diffs)
• renderspu_cocoa.c (modified) (1 diff)
• renderspu_cocoa_helper.m (modified) (1 diff)
• renderspu_config.c (modified) (1 diff)
• renderspu_glx.c (modified) (3 diffs)
• renderspu_init.c (modified) (5 diffs)
• renderspu_wgl.c (modified) (13 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu.c

@@ -129 +129 @@
 }
 
-static ContextInfo * renderspuCreateContextInternal(const char *dpyName, GLint visBits, ContextInfo * sharedContext)
+static ContextInfo * renderspuCreateContextInternal(const char *dpyName, GLint visBits, GLint idCtx, ContextInfo * sharedContext)
 {
     ContextInfo *context;
     VisualInfo *visual;
+
+    if (idCtx <= 0)
+    {
+        idCtx = (GLint)crHashtableAllocKeys(render_spu.contextTable, 1);
+        if (idCtx <= 0)
+        {
+            crWarning("failed to allocate context id");
+            return NULL;
+        }
+    }
+    else
+    {
+        if (crHashtableIsKeyUsed(render_spu.contextTable, idCtx))
+        {
+            crWarning("the specified ctx key %d is in use", idCtx);
+            return NULL;
+        }
+    }
+
 
     if (!dpyName || crStrlen(render_spu.display_string)>0)
@@ -144 +163 @@
     if (!context)
         return NULL;
-    context->BltInfo.Base.id = render_spu.context_id;
+    context->BltInfo.Base.id = idCtx;
     context->shared = sharedContext;
     if (!renderspu_SystemCreateContext(visual, context, sharedContext))
         return NULL;
 
-    crHashtableAdd(render_spu.contextTable, render_spu.context_id, context);
-    render_spu.context_id++;
+    crHashtableAdd(render_spu.contextTable, idCtx, context);
 
     context->BltInfo.Base.visualBits = visual->visAttribs;
@@ -161 +179 @@
 }
 
+GLint renderspuCreateContextEx(const char *dpyName, GLint visBits, GLint id, GLint shareCtx)
+{
+    ContextInfo *context, *sharedContext = NULL;
+
+    if (shareCtx) {
+        sharedContext
+            = (ContextInfo *) crHashtableSearch(render_spu.contextTable, shareCtx);
+        CRASSERT(sharedContext);
+    }
+
+    context = renderspuCreateContextInternal(dpyName, visBits, id, sharedContext);
+    if (context)
+        return context->BltInfo.Base.id;
+    return -1;
+}
+
 /*
  * Context functions
@@ -168 +202 @@
 renderspuCreateContext(const char *dpyName, GLint visBits, GLint shareCtx)
 {
-    ContextInfo *context, *sharedContext = NULL;
-    bool fHasShared;
-
-    if (shareCtx > 0)
-        fHasShared = true;
-    else if (shareCtx == -1)
-    {
-        shareCtx = 0;
-        fHasShared = true;
-    }
-    else
-        fHasShared = false;
-
-    if (fHasShared) {
-        sharedContext
-            = (ContextInfo *) crHashtableSearch(render_spu.contextTable, shareCtx);
-        CRASSERT(sharedContext);
-    }
-
-    context = renderspuCreateContextInternal(dpyName, visBits, sharedContext);
-    if (context)
-        return context->BltInfo.Base.id;
-    return -1;
+    return renderspuCreateContextEx(dpyName, visBits, 0, shareCtx);
 }
 
@@ -200 +212 @@
     CRASSERT(ctx);
 
-    if (ctx == 0)
+    if (ctx == CR_RENDER_DEFAULT_CONTEXT_ID)
     {
         crWarning("request to destroy a default context, ignoring");
@@ -213 +225 @@
     if (curCtx == context)
     {
-        renderspuMakeCurrent( 0, 0, 0 );
+        renderspuMakeCurrent( CR_RENDER_DEFAULT_WINDOW_ID, 0, CR_RENDER_DEFAULT_CONTEXT_ID );
         curCtx = GET_CONTEXT_VAL();
                 Assert(curCtx);
@@ -277 +289 @@
             context->everCurrent = GL_TRUE;
         }
-        if (crWindow == 0 && window->mapPending &&
+        if (crWindow == CR_RENDER_DEFAULT_WINDOW_ID && window->mapPending &&
                 !render_spu.render_to_app_window && !render_spu.render_to_crut_window) {
-            /* Window[0] is special, it's the default window and normally hidden.
+            /* Window[CR_RENDER_DEFAULT_CONTEXT_ID] is special, it's the default window and normally hidden.
              * If the mapPending flag is set, then we should now make the window
              * visible.
@@ -288 +300 @@
         window->everCurrent = GL_TRUE;
     }
-    else
+    else if (!crWindow && !ctx)
     {
 #ifdef CHROMIUM_THREADSAFE
@@ -295 +307 @@
         render_spu.currentContext = NULL;
 #endif
+        renderspu_SystemMakeCurrent( NULL, 0, NULL );
+    }
+    else
+    {
+        crError("renderspuMakeCurrent invalid ids: crWindow(%d), ctx(%d)", crWindow, ctx);
     }
 }
@@ -303 +320 @@
  */
 
-GLint RENDER_APIENTRY
-renderspuWindowCreate( const char *dpyName, GLint visBits )
+GLint renderspuWindowCreateEx( const char *dpyName, GLint visBits, GLint id )
 {
     WindowInfo *window;
@@ -310 +326 @@
     GLboolean showIt;
 
+    if (id <= 0)
+    {
+        id = (GLint)crHashtableAllocKeys(render_spu.windowTable, 1);
+        if (id <= 0)
+        {
+            crWarning("failed to allocate window id");
+            return -1;
+        }
+    }
+    else
+    {
+        if (crHashtableIsKeyUsed(render_spu.windowTable, id))
+        {
+            crWarning("the specified window key %d is in use", id);
+            return -1;
+        }
+    }
+
+
     if (!dpyName || crStrlen(render_spu.display_string) > 0)
         dpyName = render_spu.display_string;
@@ -328 +363 @@
     }
 
-    crHashtableAdd(render_spu.windowTable, render_spu.window_id, window);
-    window->BltInfo.Base.id = render_spu.window_id;
-    render_spu.window_id++;
+    RTCritSectInit(&window->CompositorLock);
+    window->pCompositor = NULL;
+
+    crHashtableAdd(render_spu.windowTable, id, window);
+    window->BltInfo.Base.id = id;
 
     window->x = render_spu.defaultX;
@@ -341 +378 @@
         showIt = 0;
     else
-        showIt = window->BltInfo.Base.id > 0;
+        showIt = window->BltInfo.Base.id != CR_RENDER_DEFAULT_WINDOW_ID;
 
     /* Set window->title, replacing %i with the window ID number */
@@ -381 +418 @@
 }
 
+GLint RENDER_APIENTRY
+renderspuWindowCreate( const char *dpyName, GLint visBits )
+{
+    return renderspuWindowCreateEx( dpyName, visBits, 0 );
+}
+
 static void renderspuCheckCurrentCtxWindowCB(unsigned long key, void *data1, void *data2)
 {
@@ -389 +432 @@
     if (pCtx->currentWindow==pWindow)
     {
-        renderspuMakeCurrent(0, 0, pCtx->BltInfo.Base.id);
+        renderspuMakeCurrent(CR_RENDER_DEFAULT_WINDOW_ID, 0, pCtx->BltInfo.Base.id);
         pCtx->currentWindow=0;
     }
@@ -401 +444 @@
 
     CRASSERT(win >= 0);
-    if (win == 0)
+    if (win == CR_RENDER_DEFAULT_WINDOW_ID)
     {
         crWarning("request to destroy a default mural, ignoring");
@@ -410 +453 @@
         crDebug("Render SPU: Destroy window (%d)", win);
         renderspu_SystemDestroyWindow( window );
+
+        RTCritSectDelete(&window->CompositorLock);
+        window->pCompositor = NULL;
+
         /* remove window info from hash table, and free it */
         crHashtableDelete(render_spu.windowTable, win, crFree);
@@ -421 +468 @@
             if (pNewCtx!=pOldCtx)
             {
-                renderspuMakeCurrent(pOldCtx&&pOldCtx->currentWindow ? pOldCtx->currentWindow->BltInfo.Base.id:0, 0,
-                                     pOldCtx ? pOldCtx->BltInfo.Base.id:0);
+                renderspuMakeCurrent(pOldCtx&&pOldCtx->currentWindow ? pOldCtx->currentWindow->BltInfo.Base.id:CR_RENDER_DEFAULT_WINDOW_ID, 0,
+                                     pOldCtx ? pOldCtx->BltInfo.Base.id:CR_RENDER_DEFAULT_CONTEXT_ID);
             }
         }
@@ -509 +556 @@
     window = (WindowInfo *) crHashtableSearch(render_spu.windowTable, win);
     if (window) {
+        renderspuVBoxCompositorSet( window, pCompositor);
+        /* renderspuVBoxPresentComposition can be invoked from the chromium thread only and is not reentrant,
+         * no need to acquire a compositor lock here */
         renderspu_SystemVBoxPresentComposition(window, pCompositor, pChangedEntry);
     }
@@ -574 +624 @@
         if (render_spu.blitterTable)
         {
+            crHashtableLock(render_spu.blitterTable);
             pBlitter = (PCR_BLITTER)crHashtableSearch(render_spu.blitterTable, window->visual->visAttribs);
         }
@@ -599 +650 @@
                 return NULL;
             }
-        }
+
+            if (render_spu.blitterTable)
+            {
+                crHashtableAdd( render_spu.blitterTable, window->visual->visAttribs, pBlitter );
+            }
+        }
+
+        if (render_spu.blitterTable)
+            crHashtableUnlock(render_spu.blitterTable);
 
         Assert(pBlitter);
@@ -612 +671 @@
 {
     int rc;
+    PCR_BLITTER_CONTEXT pCtxInfo = NULL;
+    PCR_BLITTER_WINDOW pWindowInfo = NULL;
     GET_CONTEXT(pCtx);
 
-    if (!pCtx)
-    {
-        crWarning("renderspuVBoxPresentBlitterEnter: no current context!");
-        return VERR_INVALID_STATE;
-    }
-
-    if (!pCtx->currentWindow)
-    {
-        crWarning("renderspuVBoxPresentBlitterEnter: no current window!");
-        return VERR_INVALID_STATE;
-    }
-
-    rc = CrBltEnter(pBlitter, &pCtx->BltInfo, &pCtx->currentWindow->BltInfo);
+    if (pCtx)
+    {
+        if (pCtx->currentWindow)
+        {
+            pCtxInfo = &pCtx->BltInfo;
+            pWindowInfo =  &pCtx->currentWindow->BltInfo;
+        }
+    }
+
+    rc = CrBltEnter(pBlitter, pCtxInfo, pWindowInfo);
     if (!RT_SUCCESS(rc))
     {
@@ -647 +705 @@
     }
     return NULL;
+}
+
+PCR_BLITTER renderspuVBoxPresentBlitterEnsureCreated( WindowInfo *window )
+{
+    if (!window->pBlitter)
+    {
+        struct VBOXVR_SCR_COMPOSITOR * pTmpCompositor;
+        /* just use compositor lock to synchronize */
+        pTmpCompositor = renderspuVBoxCompositorAcquire(window);
+        CRASSERT(pTmpCompositor);
+        if (pTmpCompositor)
+        {
+            PCR_BLITTER pBlitter = renderspuVBoxPresentBlitterGet( window );
+            if (pBlitter)
+            {
+                if (!CrBltIsEverEntered(pBlitter))
+                {
+                    int rc = renderspuVBoxPresentBlitterEnter(pBlitter);
+                    if (RT_SUCCESS(rc))
+                    {
+                        CrBltLeave(pBlitter);
+                    }
+                    else
+                    {
+                        crWarning("renderspuVBoxPresentBlitterEnter failed rc %d", rc);
+                    }
+                }
+            }
+            else
+            {
+                crWarning("renderspuVBoxPresentBlitterGet failed");
+            }
+
+            renderspuVBoxCompositorRelease(window);
+        }
+        else
+        {
+            crWarning("renderspuVBoxCompositorAcquire failed");
+        }
+    }
+    return window->pBlitter;
 }
 
@@ -657 +756 @@
     renderspuVBoxCompositorBlit(pCompositor, pBlitter);
 
-    CrBltPresent(pBlitter);
+    renderspu_SystemSwapBuffers(window, 0);
 
     CrBltLeave(pBlitter);
 }
+
+void renderspuVBoxCompositorSet( WindowInfo *window, struct VBOXVR_SCR_COMPOSITOR * pCompositor)
+{
+    int rc;
+    /* renderspuVBoxCompositorSet can be invoked from the chromium thread only and is not reentrant,
+     * no need to synch here
+     * the lock is actually needed to ensure we're in synch with the redraw thread */
+    if (window->pCompositor == pCompositor)
+        return;
+    rc = RTCritSectEnter(&window->CompositorLock);
+    if (RT_SUCCESS(rc))
+    {
+        window->pCompositor = pCompositor;
+        RTCritSectLeave(&window->CompositorLock);
+        return;
+    }
+    else
+    {
+        crWarning("RTCritSectEnter failed rc %d", rc);
+    }
+}
+
+struct VBOXVR_SCR_COMPOSITOR * renderspuVBoxCompositorAcquire( WindowInfo *window)
+{
+    int rc = RTCritSectEnter(&window->CompositorLock);
+    if (RT_SUCCESS(rc))
+    {
+        VBOXVR_SCR_COMPOSITOR * pCompositor = window->pCompositor;
+        if (pCompositor)
+            return pCompositor;
+
+        /* if no compositor is set, release the lock and return */
+        RTCritSectLeave(&window->CompositorLock);
+    }
+    else
+    {
+        crWarning("RTCritSectEnter failed rc %d", rc);
+    }
+    return NULL;
+}
+
+int renderspuVBoxCompositorTryAcquire(WindowInfo *window, struct VBOXVR_SCR_COMPOSITOR **ppCompositor)
+{
+    int rc = RTCritSectTryEnter(&window->CompositorLock);
+    if (RT_SUCCESS(rc))
+    {
+        *ppCompositor = window->pCompositor;
+        if (*ppCompositor)
+            return VINF_SUCCESS;
+
+        /* if no compositor is set, release the lock and return */
+        RTCritSectLeave(&window->CompositorLock);
+        rc = VERR_INVALID_STATE;
+    }
+    else
+    {
+        *ppCompositor = NULL;
+        crWarning("RTCritSectTryEnter failed rc %d", rc);
+    }
+    return rc;
+}
+
+void renderspuVBoxCompositorRelease( WindowInfo *window)
+{
+    int rc;
+    Assert(window->pCompositor);
+    rc = RTCritSectLeave(&window->CompositorLock);
+    if (!RT_SUCCESS(rc))
+    {
+        crWarning("RTCritSectLeave failed rc %d", rc);
+    }
+}
+
 
 /*
@@ -1051 +1223 @@
     case GL_WINDOW_SIZE_CR:
         /* XXX this is old code that should be removed.
-         * NOTE: we can only resize the default (id=0) window!!!
+         * NOTE: we can only resize the default (id=CR_RENDER_DEFAULT_WINDOW_ID) window!!!
          */
         {
@@ -1061 +1233 @@
             w = ((GLint*)values)[0];
             h = ((GLint*)values)[1];
-            window = (WindowInfo *) crHashtableSearch(render_spu.windowTable, 0);
+            window = (WindowInfo *) crHashtableSearch(render_spu.windowTable, CR_RENDER_DEFAULT_WINDOW_ID);
             if (window)
             {

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu.h

@@ -31 +31 @@
 
 #include <iprt/cdefs.h>
+#include <iprt/critsect.h>
 
 #define MAX_VISUALS 32
@@ -90 +91 @@
     char *title;
 
+    PVBOXVR_SCR_COMPOSITOR pCompositor;
+    /* the composotor lock is used to synchronize the current compositor access,
+     * i.e. the compositor can be accessed by a gui refraw thread,
+     * while chromium thread might try to set a new compositor
+     * note that the compositor internally has its own lock to be used for accessing its data
+     * see CrVrScrCompositorLock/Unlock; renderspu and crserverlib would use it for compositor data access */
+    RTCRITSECT CompositorLock;
     PCR_BLITTER pBlitter;
 #if defined(WINDOWS)
@@ -165 +173 @@
     SPUDispatchTable self;
     int id;
-
-    unsigned int window_id;
-    unsigned int context_id;
 
     /** config options */
@@ -330 +335 @@
 extern void renderspu_GCWindow(void);
 extern int renderspuCreateFunctions( SPUNamedFunctionTable table[] );
+extern void renderspuVBoxCompositorSet( WindowInfo *window, struct VBOXVR_SCR_COMPOSITOR * pCompositor);
+extern struct VBOXVR_SCR_COMPOSITOR * renderspuVBoxCompositorAcquire( WindowInfo *window);
+extern int renderspuVBoxCompositorTryAcquire(WindowInfo *window, struct VBOXVR_SCR_COMPOSITOR **ppCompositor);
+extern void renderspuVBoxCompositorRelease( WindowInfo *window);
 extern void renderspuVBoxPresentCompositionGeneric( WindowInfo *window, struct VBOXVR_SCR_COMPOSITOR * pCompositor, struct VBOXVR_SCR_COMPOSITOR_ENTRY *pChangedEntry );
 extern PCR_BLITTER renderspuVBoxPresentBlitterGet( WindowInfo *window );
 extern int renderspuVBoxPresentBlitterEnter( PCR_BLITTER pBlitter );
 extern PCR_BLITTER renderspuVBoxPresentBlitterGetAndEnter( WindowInfo *window );
+extern PCR_BLITTER renderspuVBoxPresentBlitterEnsureCreated( WindowInfo *window );
 extern void renderspuVBoxCompositorBlit ( struct VBOXVR_SCR_COMPOSITOR * pCompositor, PCR_BLITTER pBlitter);
 extern void renderspuVBoxCompositorBlitStretched ( struct VBOXVR_SCR_COMPOSITOR * pCompositor, PCR_BLITTER pBlitter, GLfloat scaleX, GLfloat scaleY);
+extern GLint renderspuCreateContextEx(const char *dpyName, GLint visBits, GLint id, GLint shareCtx);
+extern GLint renderspuWindowCreateEx( const char *dpyName, GLint visBits, GLint id );
 
 extern GLint RENDER_APIENTRY renderspuWindowCreate( const char *dpyName, GLint visBits );

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu_cocoa.c

@@ -159 +159 @@
 void renderspu_SystemMakeCurrent(WindowInfo *pWinInfo, GLint nativeWindow, ContextInfo *pCtxInfo)
 {
-    CRASSERT(pWinInfo);
-    CRASSERT(pCtxInfo);
-
 /*    if(pWinInfo->visual != pCtxInfo->visual)*/
 /*        printf ("visual mismatch .....................\n");*/
 
-    cocoaViewMakeCurrentContext(pWinInfo->window, pCtxInfo->context);
+    if (pWinInfo && pCtxInfo)
+        cocoaViewMakeCurrentContext(pWinInfo->window, pCtxInfo->context);
+    else
+        cocoaViewMakeCurrentContext(NULL, NULL);
 }
 

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu_cocoa_helper.m

@@ -1593 +1593 @@
     DEBUG_MSG(("cocoaViewMakeCurrentContext(%p, %p)\n", (void*)pView, (void*)pCtx));
 
-    [(OverlayView*)pView setGLCtx:pCtx];
-    [(OverlayView*)pView makeCurrentFBO];
+    if (pView)
+    {
+        [(OverlayView*)pView setGLCtx:pCtx];
+        [(OverlayView*)pView makeCurrentFBO];
+    }
+    else
+    {
+        vboxCtxSetCurrent(NULL);
+    }
 
     [pPool release];

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu_config.c

@@ -322 +322 @@
 void renderspuSetVBoxConfiguration( RenderSPU *render_spu )
 {
-    CRConnection *conn;
     int a;
 

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu_glx.c

@@ -1177 +1177 @@
 
     CRASSERT(render_spu.ws.glXMakeCurrent);
-    window->appWindow = nativeWindow;
 
     /*crDebug("%s nativeWindow=0x%x", __FUNCTION__, (int) nativeWindow);*/
@@ -1192 +1191 @@
 
     if (window && context) {
+        window->appWindow = nativeWindow;
+
         if (window->visual != context->visual) {
             crDebug("Render SPU: MakeCurrent visual mismatch (win(%d) bits:0x%x != ctx(%d) bits:0x%x); remaking window.",
@@ -1344 +1345 @@
         }
 #endif
+    }
+    else
+    {
+        GET_CONTEXT(pCurCtx);
+        if (pCurCtx)
+        {
+            b = render_spu.ws.glXMakeCurrent( pCurCtx->currentWindow->visual->dpy, None, NULL);
+            if (!b) {
+                crWarning("glXMakeCurrent(%p, None, NULL) failed!", pCurCtx->currentWindow->visual->dpy);
+            }
+        }
+
     }
 

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu_init.c

@@ -96 +96 @@
             {
                 LPCREATESTRUCT pCS = (LPCREATESTRUCT) msg.lParam;
-                HWND *phWnd;
+                HWND hWnd;
+                WindowInfo *pWindow = (WindowInfo *)pCS->lpCreateParams;
 
                 CRASSERT(msg.lParam && !msg.wParam && pCS->lpCreateParams);
 
-                phWnd = pCS->lpCreateParams;
-
-                *phWnd = CreateWindowEx(pCS->dwExStyle, pCS->lpszName, pCS->lpszClass, pCS->style,
+                hWnd = CreateWindowEx(pCS->dwExStyle, pCS->lpszName, pCS->lpszClass, pCS->style,
                                         pCS->x, pCS->y, pCS->cx, pCS->cy,
                                         pCS->hwndParent, pCS->hMenu, pCS->hInstance, &render_spu);
+
+                pWindow->hWnd = hWnd;
 
                 SetEvent(render_spu.hWinThreadReadyEvent);
@@ -198 +199 @@
 #endif
 
-    render_spu.window_id = 0;
-    render_spu.context_id = 0;
-    render_spu.contextTable = crAllocHashtable();
-    render_spu.windowTable = crAllocHashtable();
+    render_spu.contextTable = crAllocHashtableEx(1, INT32_MAX);
+    render_spu.windowTable = crAllocHashtableEx(1, INT32_MAX);
 
     pcpwSetting = crGetenv("CR_RENDER_ENABLE_PRESENT_CONTEXT_PER_WINDOW");
@@ -212 +211 @@
     {
         /* default is enable for OSX */
-#if defined(DARWIN) && defined(VBOX_WITH_COCOA_QT)
+#if 0 //defined(DARWIN) && defined(VBOX_WITH_COCOA_QT)
         pcpwSetting = (char*)1;
 #endif
 
     }
+
 
     if (pcpwSetting)
@@ -275 +275 @@
     crDebug("Render SPU: Creating default window (visBits=0x%x, id=0)",
             render_spu.default_visual);
-    defaultWin = renderspuWindowCreate( NULL, render_spu.default_visual );
-    if (defaultWin != 0) {
+    defaultWin = renderspuWindowCreateEx( NULL, render_spu.default_visual, CR_RENDER_DEFAULT_WINDOW_ID );
+    if (defaultWin != CR_RENDER_DEFAULT_WINDOW_ID) {
         crError("Render SPU: Couldn't get a double-buffered, RGB visual with Z!");
         return NULL;
@@ -284 +284 @@
     crDebug("Render SPU: Creating default context, visBits=0x%x",
             render_spu.default_visual );
-    defaultCtx = renderspuCreateContext( NULL, render_spu.default_visual, 0 );
-    CRASSERT(defaultCtx == 0);
+    defaultCtx = renderspuCreateContextEx( NULL, render_spu.default_visual, CR_RENDER_DEFAULT_CONTEXT_ID, 0 );
+    if (defaultCtx != CR_RENDER_DEFAULT_CONTEXT_ID) {
+        crError("Render SPU: failed to create default context!");
+        return NULL;
+    }
 
     renderspuMakeCurrent( defaultWin, 0, defaultCtx );
 
     /* Get windowInfo for the default window */
-    windowInfo = (WindowInfo *) crHashtableSearch(render_spu.windowTable, 0);
+    windowInfo = (WindowInfo *) crHashtableSearch(render_spu.windowTable, CR_RENDER_DEFAULT_WINDOW_ID);
     CRASSERT(windowInfo);
     windowInfo->mapPending = GL_TRUE;

trunk/src/VBox/HostServices/SharedOpenGL/render/renderspu_wgl.c

@@ -426 +426 @@
 
     switch ( uMsg ) {
-
+        case WM_PAINT:
+        {
+            WindowInfo *pWindow = (WindowInfo *)GetWindowLongPtr(hWnd, GWLP_USERDATA);
+            if (pWindow)
+            {
+                struct VBOXVR_SCR_COMPOSITOR * pCompositor;
+
+                pCompositor = renderspuVBoxCompositorAcquire(pWindow);
+                if (pCompositor)
+                {
+                    HDC hDC, hOldDC = pWindow->device_context;
+                    PAINTSTRUCT Paint;
+
+                    Assert(pWindow->device_context);
+                    hDC = BeginPaint(pWindow->hWnd, &Paint);
+                    if (hDC)
+                    {
+                        BOOL bRc;
+                        pWindow->device_context = hDC;
+
+                        renderspuVBoxPresentCompositionGeneric(pWindow, pCompositor, NULL);
+                        renderspuVBoxCompositorRelease(pWindow);
+
+                        bRc = EndPaint(pWindow->hWnd, &Paint);
+                        if (!bRc)
+                        {
+                            DWORD winEr = GetLastError();
+                            crWarning("EndPaint failed, winEr %d", winEr);
+                        }
+
+                        pWindow->device_context = hOldDC;
+                    }
+                    else
+                    {
+                        DWORD winEr = GetLastError();
+                        crWarning("BeginPaint failed, winEr %d", winEr);
+                    }
+                }
+            }
+            break;
+        }
         case WM_SIZE:
             /* w = LOWORD( lParam ); 
@@ -558 +598 @@
     crDebug("Render SPU: wglChoosePixelFormatEXT (vis 0x%x, LastError 0x%x, pixelFormat 0x%x", vis, GetLastError(), pixelFormat);
 
+#ifdef VBOX_CR_SERVER_FORCE_WGL
     render_spu.ws.wglSetPixelFormat( hdc, pixelFormat, &ppfd );
+#else
+    SetPixelFormat( hdc, pixelFormat, &ppfd );
+#endif
 
     crDebug("Render SPU: wglSetPixelFormat (Last error 0x%x)", GetLastError());
@@ -617 +661 @@
      * versions.
      */
+#ifdef VBOX_CR_SERVER_FORCE_WGL
     if (crGetenv( "CR_WGL_DO_NOT_USE_GDI" ) != NULL)
     {
@@ -634 +679 @@
     }
     else
+#endif
     {
         /* Okay, we were loaded manually.  Call the GDI functions. */
@@ -879 +925 @@
 
     window->device_context = GetDC( window->hWnd );
+    if (!window->device_context)
+    {
+        DWORD winEr = GetLastError();
+        crWarning("GetDC failed, winEr %d", winEr);
+    }
 
     crDebug( "Render SPU: Got the DC: 0x%x", window->device_context );
@@ -1053 +1104 @@
         CREATESTRUCT cs;
 
-        cs.lpCreateParams = &window->hWnd;
+        cs.lpCreateParams = window;
 
         cs.dwExStyle    = WS_EX_NOACTIVATE | WS_EX_NOPARENTNOTIFY;
@@ -1152 +1203 @@
 
     window->device_context = GetDC( window->hWnd );
+    if (!window->device_context)
+    {
+        DWORD winEr = GetLastError();
+        crWarning("GetDC failed, winEr %d", winEr);
+    }
 
     crDebug( "Render SPU: Got the DC: 0x%x", window->device_context );
@@ -1159 +1215 @@
         crError( "Render SPU: Couldn't set up the device context!  Yikes!" );
         return GL_FALSE;
+    }
+
+    /* set the window pointer data at the last step to ensure our WM_PAINT callback does not do anything until we are fully initialized */
+    {
+        LONG_PTR oldVal = SetWindowLongPtr(window->hWnd, GWLP_USERDATA, (LONG_PTR)window);
+        Assert(!oldVal && GetLastError() == NO_ERROR);
     }
 
@@ -1185 +1247 @@
 void renderspu_SystemVBoxPresentComposition( WindowInfo *window, struct VBOXVR_SCR_COMPOSITOR * pCompositor, struct VBOXVR_SCR_COMPOSITOR_ENTRY *pChangedEntry )
 {
-    renderspuVBoxPresentCompositionGeneric(window, pCompositor, pChangedEntry);
+    struct VBOXVR_SCR_COMPOSITOR *pCurCompositor;
+    /* we do not want to be blocked with the GUI thread here, so only draw her eif we are really able to do that w/o bllocking */
+    int rc = renderspuVBoxCompositorTryAcquire(window, &pCurCompositor);
+    if (RT_SUCCESS(rc))
+    {
+        Assert(pCurCompositor == pCompositor);
+        renderspuVBoxPresentCompositionGeneric(window, pCompositor, pChangedEntry);
+        renderspuVBoxCompositorRelease(window);
+    }
+    else if (rc != VERR_SEM_BUSY)
+    {
+        render_spu.self.Flush();
+        renderspuVBoxPresentBlitterEnsureCreated(window);
+        RedrawWindow(window->hWnd, NULL, NULL, RDW_INTERNALPAINT);
+    }
+    else
+    {
+        /* this is somewhat we do not expect */
+        crWarning("renderspuVBoxCompositorTryAcquire failed rc %d", rc);
+    }
 }
 
@@ -1341 +1422 @@
                 {
                     /* share lists */
-                    render_spu.ws.wglShareLists(context->shared->hRC, context->hRC);
+                    BOOL bRc = render_spu.ws.wglShareLists(context->shared->hRC, context->hRC);
+                    if (!bRc)
+                    {
+                        DWORD winEr = GetLastError();
+                        crWarning("wglShareLists failed, winEr %d", winEr);
+                    }
                 }
 
@@ -1506 +1592 @@
 
     /* peek at the windows message queue */
-    renderspuHandleWindowMessages( w->hWnd );
+//    renderspuHandleWindowMessages( w->hWnd );
 
     /* render_to_app_window:
@@ -1515 +1601 @@
      */
     if (render_spu.render_to_app_window && w->nativeWindow) {
+#ifdef VBOX_CR_SERVER_FORCE_WGL
         return_value = render_spu.ws.wglSwapBuffers( w->nativeWindow );
+#else
+        return_value = SwapBuffers( w->nativeWindow );
+#endif
     } else {
         /*
@@ -1558 +1648 @@
         crDebug("rcClip(%d, %d, %d, %d)", rcClip.left, rcClip.top, rcClip.right, rcClip.bottom);
         */
+#ifdef VBOX_CR_SERVER_FORCE_WGL
         return_value = render_spu.ws.wglSwapBuffers( w->device_context );
+#else
+        return_value = SwapBuffers( w->device_context );
+#endif
     }
     if (!return_value)