Changeset 46885 in vbox for trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_window.c

Timestamp:

Jul 1, 2013 2:02:37 PM (12 years ago)

Author:

vboxsync

Message:

crOpenGL: TexPresent fixes

File:

• trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_window.c (modified) (23 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_window.c

@@ -17 +17 @@
 }
 
-GLint crServerMuralInit(CRMuralInfo *mural, const char *dpyName, GLint visBits, GLint preloadWinID, GLboolean fSetVRegs)
+GLint crServerMuralInit(CRMuralInfo *mural, const char *dpyName, GLint visBits, GLint preloadWinID, GLboolean fUseDefaultDEntry)
 {
     CRMuralInfo *defaultMural;
@@ -23 +23 @@
     GLint windowID = -1;
     GLint spuWindow;
-    VBOXVR_TEXTURE Tex = {0};
     int rc;
 
     crMemset(mural, 0, sizeof (*mural));
 
-    rc = CrVrScrCompositorInit(&mural->Compositor);
-    if (!RT_SUCCESS(rc))
-    {
-        crWarning("CrVrScrCompositorInit failed, rc %d", rc);
-        return -1;
-    }
+    CrVrScrCompositorInit(&mural->Compositor);
 
     if (cr_server.fRootVrOn)
     {
-        rc = CrVrScrCompositorInit(&mural->RootVrCompositor);
-        if (!RT_SUCCESS(rc))
-        {
-            crWarning("CrVrScrCompositorInit failed, rc %d", rc);
-            return -1;
-        }
+        CrVrScrCompositorInit(&mural->RootVrCompositor);
     }
 
@@ -50 +39 @@
     spuWindow = cr_server.head_spu->dispatch_table.WindowCreate( dpyName, visBits );
     if (spuWindow < 0) {
-        CrVrScrCompositorTerm(&mural->Compositor);
+        CrVrScrCompositorClear(&mural->Compositor);
         if (cr_server.fRootVrOn)
-            CrVrScrCompositorTerm(&mural->RootVrCompositor);
+            CrVrScrCompositorClear(&mural->RootVrCompositor);
         return spuWindow;
     }
@@ -59 +48 @@
     cr_server.head_spu->dispatch_table.GetChromiumParametervCR(GL_WINDOW_SIZE_CR, spuWindow, GL_INT, 2, dims);
 
-    Tex.width = dims[0];
-    Tex.height = dims[1];
-    Tex.target = GL_TEXTURE_2D;
-    Tex.hwid = 0;
-    CrVrScrCompositorEntryInit(&mural->CEntry, &Tex);
-
-    if (cr_server.fRootVrOn)
-    {
-        CrVrScrCompositorEntryInit(&mural->RootVrCEntry, &Tex);
-        mural->fRootVrOn = GL_TRUE;
+    if (fUseDefaultDEntry)
+    {
+        VBOXVR_TEXTURE Tex = {0};
+        Tex.width = dims[0];
+        Tex.height = dims[1];
+        Tex.target = GL_TEXTURE_2D;
+        Tex.hwid = 0;
+        CrVrScrCompositorEntryInit(&mural->DefaultDEntry.CEntry, &Tex);
+
+        if (cr_server.fRootVrOn)
+        {
+            CrVrScrCompositorEntryInit(&mural->DefaultDEntry.RootVrCEntry, &Tex);
+            mural->fRootVrOn = GL_TRUE;
+        }
     }
 
@@ -81 +74 @@
     mural->screenId = 0;
     mural->fHasParentWindow = !!cr_server.screen[0].winID;
-    mural->bVisible = cr_server.bWindowsInitiallyHidden;
+    mural->bVisible = !cr_server.bWindowsInitiallyHidden;
     mural->fPresentMode = CR_SERVER_REDIR_F_NONE;
 
@@ -102 +95 @@
     CR_STATE_SHAREDOBJ_USAGE_INIT(mural);
 
-    if (fSetVRegs)
+    if (fUseDefaultDEntry)
     {
         RTRECT Rect;
@@ -109 +102 @@
         Rect.yTop = 0;
         Rect.yBottom = mural->height;
-        rc = CrVrScrCompositorEntryRegionsSet(&mural->Compositor, &mural->CEntry, NULL, 1, &Rect, NULL);
+        rc = CrVrScrCompositorEntryRegionsSet(&mural->Compositor, &mural->DefaultDEntry.CEntry, NULL, 1, &Rect, false, NULL);
         if (!RT_SUCCESS(rc))
         {
@@ -123 +116 @@
         uint32_t cRects;
         const RTRECT *pRects;
-        int rc = crServerMuralSynchRootVr(mural, &cRects, &pRects);
+        int rc = crServerMuralSynchRootVr(mural);
         if (RT_SUCCESS(rc))
         {
-            if (cRects != 1
-                    || pRects[0].xLeft != 0 || pRects[0].yTop != 0
-                    || pRects[0].xRight != mural->width || pRects[0].yBottom != mural->height)
-            {
-                /* do visible rects only ig they differ from the default */
-                cr_server.head_spu->dispatch_table.WindowVisibleRegion(mural->spuWindow, cRects, (const GLint*)pRects);
+            rc = CrVrScrCompositorRegionsGet(&mural->RootVrCompositor, &cRects, NULL, &pRects, NULL);
+            if (RT_SUCCESS(rc))
+            {
+                if (cRects != 1
+                        || pRects[0].xLeft != 0 || pRects[0].yTop != 0
+                        || pRects[0].xRight != mural->width || pRects[0].yBottom != mural->height)
+                {
+                    /* do visible rects only ig they differ from the default */
+                    cr_server.head_spu->dispatch_table.WindowVisibleRegion(mural->spuWindow, cRects, (const GLint*)pRects);
+                }
+            }
+            else
+            {
+                crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
             }
         }
@@ -296 +297 @@
         crFree(mural->CreateInfo.pszDpyName);
 
-    CrVrScrCompositorTerm(&mural->Compositor);
+    CrVrScrCompositorClear(&mural->Compositor);
 
     if (mural->fRootVrOn)
-        CrVrScrCompositorTerm(&mural->RootVrCompositor);
+        CrVrScrCompositorClear(&mural->RootVrCompositor);
 }
 
@@ -401 +402 @@
 }
 
-int crServerMuralSynchRootVr(CRMuralInfo *mural, uint32_t *pcRects, const RTRECT **ppRects)
+#define CR_DENTRY_FROM_CENTRY(_pCentry) ((CR_DISPLAY_ENTRY*)((uint8_t*)(_pCentry) - RT_OFFSETOF(CR_DISPLAY_ENTRY, CEntry)))
+
+static DECLCALLBACK(VBOXVR_SCR_COMPOSITOR_ENTRY*) crServerMuralGetRootVrCEntry(VBOXVR_SCR_COMPOSITOR_ENTRY*pEntry, void *pvContext)
+{
+    CR_DISPLAY_ENTRY *pDEntry = CR_DENTRY_FROM_CENTRY(pEntry);
+    CrVrScrCompositorEntryInit(&pDEntry->RootVrCEntry, CrVrScrCompositorEntryTexGet(pEntry));
+    return &pDEntry->RootVrCEntry;
+}
+
+int crServerMuralSynchRootVr(CRMuralInfo *mural)
 {
     int rc;
 
-    rc = CrVrScrCompositorEntryRegionsGet(&mural->Compositor, &mural->CEntry, pcRects, NULL, ppRects);
+    crServerVBoxRootVrTranslateForMural(mural);
+
+    rc = CrVrScrCompositorIntersectedList(&mural->Compositor, &cr_server.RootVr, &mural->RootVrCompositor, crServerMuralGetRootVrCEntry, NULL, NULL);
     if (!RT_SUCCESS(rc))
     {
-        crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
-        return rc;
-    }
-
-    rc = CrVrScrCompositorEntryRegionsSet(&mural->RootVrCompositor, &mural->RootVrCEntry, NULL, *pcRects, *ppRects, NULL);
-    if (!RT_SUCCESS(rc))
-    {
-        crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
-        return rc;
-    }
-
-    crServerVBoxRootVrTranslateForMural(mural);
-    rc = CrVrScrCompositorEntryListIntersect(&mural->RootVrCompositor, &mural->RootVrCEntry, &cr_server.RootVr, NULL);
-    if (!RT_SUCCESS(rc))
-    {
-        crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
-        return rc;
-    }
-
-    rc = CrVrScrCompositorEntryRegionsGet(&mural->RootVrCompositor, &mural->RootVrCEntry, pcRects, NULL, ppRects);
-    if (!RT_SUCCESS(rc))
-    {
-        crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
+        crWarning("CrVrScrCompositorIntersectedList failed, rc %d", rc);
         return rc;
     }
@@ -468 +458 @@
     /* the compositor lock is not needed actually since we have prevented renderspu from using the compositor */
     /* CrVrScrCompositorLock(&mural->Compositor); */
-    if (!mural->bReceivedRects)
-    {
-        rc = CrVrScrCompositorEntryRemove(&mural->Compositor, &mural->CEntry);
-        if (!RT_SUCCESS(rc))
-        {
-            crWarning("CrVrScrCompositorEntryRemove failed, rc %d", rc);
-            goto end;
-        }
-        CrVrScrCompositorEntryInit(&mural->CEntry, &Tex);
-        /* initially set regions to all visible since this is what some guest assume
-         * and will not post any more visible regions command */
-        Rect.xLeft = 0;
-        Rect.xRight = width;
-        Rect.yTop = 0;
-        Rect.yBottom = height;
-        rc = CrVrScrCompositorEntryRegionsSet(&mural->Compositor, &mural->CEntry, NULL, 1, &Rect, NULL);
-        if (!RT_SUCCESS(rc))
-        {
-            crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
-            goto end;
+    if (mural->fUseDefaultDEntry)
+    {
+        if (!mural->bReceivedRects)
+        {
+            rc = CrVrScrCompositorEntryRemove(&mural->Compositor, &mural->DefaultDEntry.CEntry);
+            if (!RT_SUCCESS(rc))
+            {
+                crWarning("CrVrScrCompositorEntryRemove failed, rc %d", rc);
+                goto end;
+            }
+            CrVrScrCompositorEntryInit(&mural->DefaultDEntry.CEntry, &Tex);
+            /* initially set regions to all visible since this is what some guest assume
+             * and will not post any more visible regions command */
+            Rect.xLeft = 0;
+            Rect.xRight = width;
+            Rect.yTop = 0;
+            Rect.yBottom = height;
+            rc = CrVrScrCompositorEntryRegionsSet(&mural->Compositor, &mural->DefaultDEntry.CEntry, NULL, 1, &Rect, false, NULL);
+            if (!RT_SUCCESS(rc))
+            {
+                crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
+                goto end;
+            }
+        }
+        else
+        {
+            rc = CrVrScrCompositorEntryTexUpdate(&mural->Compositor, &mural->DefaultDEntry.CEntry, &Tex);
+            if (!RT_SUCCESS(rc))
+            {
+                crWarning("CrVrScrCompositorEntryTexUpdate failed, rc %d", rc);
+                goto end;
+            }
         }
     }
     else
     {
-        rc = CrVrScrCompositorEntryTexUpdate(&mural->Compositor, &mural->CEntry, &Tex);
-        if (!RT_SUCCESS(rc))
-        {
-            crWarning("CrVrScrCompositorEntryTexUpdate failed, rc %d", rc);
-            goto end;
-        }
+        CrVrScrCompositorClear(&mural->Compositor);
     }
 
@@ -512 +509 @@
     }
 
-    rc = CrVrScrCompositorEntryRegionsGet(&mural->Compositor, &mural->CEntry, &cRects, NULL, &pRects);
+    rc = CrVrScrCompositorRegionsGet(&mural->Compositor, &cRects, NULL, &pRects, NULL);
     if (!RT_SUCCESS(rc))
     {
-        crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
+        crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
         goto end;
     }
@@ -521 +518 @@
     if (mural->fRootVrOn)
     {
-        rc = CrVrScrCompositorEntryRemove(&mural->RootVrCompositor, &mural->RootVrCEntry);
+        rc = crServerMuralSynchRootVr(mural);
         if (!RT_SUCCESS(rc))
         {
-            crWarning("CrVrScrCompositorEntryRemove failed, rc %d", rc);
+            crWarning("crServerMuralSynchRootVr failed, rc %d", rc);
             goto end;
         }
-        CrVrScrCompositorEntryInit(&mural->RootVrCEntry, &Tex);
-
-        rc = CrVrScrCompositorEntryRegionsSet(&mural->RootVrCompositor, &mural->RootVrCEntry, NULL, cRects, pRects, NULL);
+
+        rc = CrVrScrCompositorRegionsGet(&mural->RootVrCompositor, &cRects, NULL, &pRects, NULL);
         if (!RT_SUCCESS(rc))
         {
-            crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
+            crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
             goto end;
         }
-
-        crServerVBoxRootVrTranslateForMural(mural);
-        rc = CrVrScrCompositorEntryListIntersect(&mural->RootVrCompositor, &mural->RootVrCEntry, &cr_server.RootVr, NULL);
-        if (!RT_SUCCESS(rc))
-        {
-            crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
-            goto end;
-        }
-
-        rc = CrVrScrCompositorEntryRegionsGet(&mural->RootVrCompositor, &mural->RootVrCEntry, &cRects, NULL, &pRects);
-        if (!RT_SUCCESS(rc))
-        {
-            crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
-            goto end;
-        }
-    }
-    else
-    {
     }
 
@@ -563 +541 @@
     if (mural->pvOutputRedirectInstance)
     {
-        if (mural->fRootVrOn)
-        {
-            rc = CrVrScrCompositorEntryRegionsGet(&mural->Compositor, &mural->CEntry, &cRects, NULL, &pRects);
+        /* always get non-stretched rects for output redirect */
+//        if (mural->fRootVrOn)
+        {
+            rc = CrVrScrCompositorRegionsGet(&mural->Compositor, &cRects, NULL, NULL, &pRects);
             if (!RT_SUCCESS(rc))
             {
-                crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
+                crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
                 goto end;
             }
@@ -609 +588 @@
 }
 
-
-void SERVER_DISPATCH_APIENTRY
-crServerDispatchWindowPosition( GLint window, GLint x, GLint y )
-{
-    CRMuralInfo *mural = (CRMuralInfo *) crHashtableSearch(cr_server.muralTable, window);
+void crServerMutalPosition(CRMuralInfo *mural, GLint x, GLint y)
+{
     GLboolean fForcePresent = GL_FALSE;
     /*  crDebug("CRServer: Window %d pos %d, %d", window, x, y);*/
-    if (!mural) {
-#if EXTRA_WARN
-         crWarning("CRServer: invalid window %d passed to WindowPosition()", window);
-#endif
-         return;
-    }
+
 //    if (mural->gX != x || mural->gY != y)
     {
@@ -648 +619 @@
             mural->gY = y;
 
-            /* the compositor lock is not needed actually since we have prevented renderspu from using the compositor */
-            /* CrVrScrCompositorLock(&mural->Compositor); */
             /* no need to set position because the position is relative to window */
             /*CrVrScrCompositorEntryPosSet(&mural->Compositor, &mural->CEntry, &Pos);*/
-            /*CrVrScrCompositorUnlock(&mural->Compositor);*/
 
             if (mural->fRootVrOn)
@@ -658 +626 @@
                 uint32_t cRects;
                 const RTRECT *pRects;
-                int rc = crServerMuralSynchRootVr(mural, &cRects, &pRects);
-
+                int rc = crServerMuralSynchRootVr(mural);
                 if (RT_SUCCESS(rc))
                 {
-                    cr_server.head_spu->dispatch_table.WindowVisibleRegion(mural->spuWindow, cRects, (const GLint*)pRects);
+                    rc = CrVrScrCompositorRegionsGet(&mural->RootVrCompositor, &cRects, NULL, &pRects, NULL);
+                    if (RT_SUCCESS(rc))
+                    {
+                        cr_server.head_spu->dispatch_table.WindowVisibleRegion(mural->spuWindow, cRects, (const GLint*)pRects);
+                    }
+                    else
+                    {
+                        crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
+                    }
                 }
                 else
@@ -679 +654 @@
 
 void SERVER_DISPATCH_APIENTRY
-crServerDispatchWindowVisibleRegion( GLint window, GLint cRects, const GLint *pRects )
+crServerDispatchWindowPosition( GLint window, GLint x, GLint y )
 {
     CRMuralInfo *mural = (CRMuralInfo *) crHashtableSearch(cr_server.muralTable, window);
+    if (!mural) {
+#if EXTRA_WARN
+         crWarning("CRServer: invalid window %d passed to WindowPosition()", window);
+#endif
+         return;
+    }
+    crServerMutalPosition(mural, x, y);
+}
+
+void crServerMuralVisibleRegion( CRMuralInfo *mural, GLint cRects, const GLint *pRects )
+{
     GLboolean fForcePresent = crServerVBoxCompositionPresentNeeded(mural);
     bool fRegionsChanged = false;
     int rc = VINF_SUCCESS;
-    if (!mural) {
-#if EXTRA_WARN
-         crWarning("CRServer: invalid window %d passed to WindowVisibleRegion()", window);
-#endif
-         return;
-    }
 
     /* since we're going to change the current compositor & the window we need to avoid
@@ -722 +702 @@
     }
 
-    /* NOTE: we can do it even if !(mural->fPresentMode & CR_SERVER_REDIR_F_DISPLAY) to make sure the compositor data is always up to date */
-    /* the compositor lock is not needed actually since we have prevented renderspu from using the compositor */
-    /* CrVrScrCompositorLock(&mural->Compositor); */
-    rc = CrVrScrCompositorEntryRegionsSet(&mural->Compositor, &mural->CEntry, NULL, cRects, (const RTRECT *)pRects, &fRegionsChanged);
-    /*CrVrScrCompositorUnlock(&mural->Compositor);*/
-    if (!RT_SUCCESS(rc))
-    {
-        crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
-        goto end;
+    if (mural->fUseDefaultDEntry)
+    {
+        /* NOTE: we can do it even if !(mural->fPresentMode & CR_SERVER_REDIR_F_DISPLAY) to make sure the compositor data is always up to date */
+        /* the compositor lock is not needed actually since we have prevented renderspu from using the compositor */
+        /* CrVrScrCompositorLock(&mural->Compositor); */
+        rc = CrVrScrCompositorEntryRegionsSet(&mural->Compositor, &mural->DefaultDEntry.CEntry, NULL, cRects, (const RTRECT *)pRects, false, &fRegionsChanged);
+        /*CrVrScrCompositorUnlock(&mural->Compositor);*/
+        if (!RT_SUCCESS(rc))
+        {
+            crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
+            goto end;
+        }
+    }
+    else
+    {
+        fRegionsChanged = true;
     }
 
@@ -740 +727 @@
         if (mural->fRootVrOn)
         {
-            rc = CrVrScrCompositorEntryRegionsSet(&mural->RootVrCompositor, &mural->RootVrCEntry, NULL, cRects, (const RTRECT *)pRects, NULL);
+            rc = rc = crServerMuralSynchRootVr(mural);
             if (!RT_SUCCESS(rc))
             {
-                crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
+                crWarning("crServerMuralSynchRootVr failed, rc %d", rc);
                 goto end;
             }
 
-            crServerVBoxRootVrTranslateForMural(mural);
-            rc = CrVrScrCompositorEntryListIntersect(&mural->RootVrCompositor, &mural->RootVrCEntry, &cr_server.RootVr, NULL);
+            rc = CrVrScrCompositorRegionsGet(&mural->RootVrCompositor, &cRealRects, NULL, &pRealRects, NULL);
             if (!RT_SUCCESS(rc))
             {
-                crWarning("CrVrScrCompositorEntryRegionsSet failed, rc %d", rc);
+                crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
                 goto end;
             }
-
-            rc = CrVrScrCompositorEntryRegionsGet(&mural->RootVrCompositor, &mural->RootVrCEntry, &cRealRects, NULL, &pRealRects);
+        }
+        else
+        {
+            rc = CrVrScrCompositorRegionsGet(&mural->Compositor, &cRealRects, NULL, &pRealRects, NULL);
             if (!RT_SUCCESS(rc))
             {
-                crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
+                crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
                 goto end;
             }
         }
-        else
-        {
-            rc = CrVrScrCompositorEntryRegionsGet(&mural->Compositor, &mural->CEntry, &cRealRects, NULL, &pRealRects);
-            if (!RT_SUCCESS(rc))
-            {
-                crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
-                goto end;
-            }
-        }
 
         cr_server.head_spu->dispatch_table.WindowVisibleRegion(mural->spuWindow, cRealRects, (const GLint*)pRealRects);
@@ -776 +755 @@
         if (mural->pvOutputRedirectInstance)
         {
-            if (mural->fRootVrOn)
-            {
-                rc = CrVrScrCompositorEntryRegionsGet(&mural->Compositor, &mural->CEntry, &cRealRects, NULL, &pRealRects);
+//            if (mural->fRootVrOn)
+            {
+                /* always get unstretched regions here */
+                rc = CrVrScrCompositorRegionsGet(&mural->Compositor, &cRealRects, NULL, NULL, &pRealRects);
                 if (!RT_SUCCESS(rc))
                 {
-                    crWarning("CrVrScrCompositorEntryRegionsGet failed, rc %d", rc);
+                    crWarning("CrVrScrCompositorRegionsGet failed, rc %d", rc);
                     goto end;
                 }
@@ -792 +772 @@
     /* 3. re-set the compositor (see above comment) */
     crServerVBoxCompositionDisableLeave(mural, fForcePresent);
+}
+
+void SERVER_DISPATCH_APIENTRY
+crServerDispatchWindowVisibleRegion( GLint window, GLint cRects, const GLint *pRects )
+{
+    CRMuralInfo *mural = (CRMuralInfo *) crHashtableSearch(cr_server.muralTable, window);
+    if (!mural) {
+#if EXTRA_WARN
+         crWarning("CRServer: invalid window %d passed to WindowVisibleRegion()", window);
+#endif
+         return;
+    }
+
+    crServerMuralVisibleRegion( mural, cRects, pRects );
+}
+
+void crServerMuralShow( CRMuralInfo *mural, GLint state )
+{
+    if (mural->fPresentMode & CR_SERVER_REDIR_F_DISPLAY)
+    {
+        cr_server.head_spu->dispatch_table.WindowShow(mural->spuWindow, state);
+
+        if (state && mural->fHasParentWindow)
+            crVBoxServerNotifyEvent(mural->screenId);
+    }
+
+    mural->bVisible = !!state;
 }
 
@@ -805 +812 @@
     }
 
-    if (mural->fPresentMode & CR_SERVER_REDIR_F_DISPLAY)
-    {
-        cr_server.head_spu->dispatch_table.WindowShow(mural->spuWindow, state);
-
-        if (state && mural->fHasParentWindow)
-            crVBoxServerNotifyEvent(mural->screenId);
-    }
-
-    mural->bVisible = !!state;
-}
-
+    crServerMuralShow( mural, state );
+}
 
 GLint