Changeset 46980 in vbox for trunk/src/VBox/Runtime/common/zip/tar.cpp

Timestamp:

Jul 4, 2013 11:38:28 AM (11 years ago)

Author:

vboxsync

Message:

Deprecated the old manifest API. r=bird: IPRT does NOT use ugly C++ references, it pointers directly - no cloak and dagger pointers thank you. Please don't reformat if expressions into unreadability. RTDIGESTTYPE_UNKNOWN should be RTDIGESTTYPE_INVALID and there is actually no need to set output variables on failure, just check the status code.

File:

• trunk/src/VBox/Runtime/common/zip/tar.cpp (modified) (5 diffs)

trunk/src/VBox/Runtime/common/zip/tar.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2009-2012 Oracle Corporation
+ * Copyright (C) 2009-2013 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -336 +336 @@
     /* Fill the header record */
 //    RT_ZERO(pRecord); - done by the caller.
+    /** @todo use RTStrCopy */
     size_t cb = RTStrPrintf(pRecord->h.name,  sizeof(pRecord->h.name),  "%s", pszSrcName);
     if (cb < strlen(pszSrcName))
@@ -1669 +1670 @@
             pInt->pFileCache = NULL;
         }
-        else/* Are we still direct behind that header? */
+        else/* Are we still directly behind that header? */
         {
             /* Yes, so the streaming can start. Just return the cached file
@@ -1678 +1679 @@
             if (pInt->pFileCache->linkflag == LF_DIR)
                 return VINF_TAR_DIR_PATH;
-            else
-                return VINF_SUCCESS;
+            return VINF_SUCCESS;
         }
 
@@ -1722 +1722 @@
 
             if (pFileInt->linkflag == LF_DIR)
-            {
                 rc = VINF_TAR_DIR_PATH;
-            }
         }
     } while (0);