Changeset 47129 in vbox for trunk/src/VBox/NetworkServices/DHCP/Config.cpp

Timestamp:

Jul 13, 2013 11:44:12 AM (11 years ago)

Author:

vboxsync

Message:

VBoxNetDHCP: cosmetics.

File:

• trunk/src/VBox/NetworkServices/DHCP/Config.cpp (modified) (2 diffs)

trunk/src/VBox/NetworkServices/DHCP/Config.cpp

@@ -513 +513 @@
     client->rawOptions.push_back(opt);
 
-    /* XXX: here should be condition MUST NOT on DHCPINFORM */
     opt.u8OptId = RTNET_DHCP_OPT_LEASE_TIME;
     *(uint32_t *)opt.au8RawOpt = RT_H2N_U32(ConfigurationManager::getConfigurationManager()->getLeaseTime());
@@ -565 +564 @@
     client->rawOptions.push_back(opt);
 
+    /*
+     * XXX: lease time should be conditional. If on dhcprequest then tim should be provided,
+     * else on dhcpinform it mustn't.
+     */
     opt.u8OptId = RTNET_DHCP_OPT_LEASE_TIME;
-    *(uint32_t *)opt.au8RawOpt = RT_H2N_U32(ConfigurationManager::getConfigurationManager()->getLeaseTime());
+    *(uint32_t *)opt.au8RawOpt = 
+      RT_H2N_U32(ConfigurationManager::getConfigurationManager()->getLeaseTime());
     opt.cbRawOpt = sizeof(RTNETADDRIPV4);
     client->rawOptions.push_back(opt);