Changeset 50379 in vbox for trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp

Timestamp:

Feb 10, 2014 10:22:43 AM (11 years ago)

Author:

vboxsync

Message:

VBoxNet*darwin: Corrected two function delcarations (use DECL macros!), header guard and a few other nits. VBoxNetSend.h should move into src/VBox/HostDrivers/darwin/, btw.

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp (modified) (5 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp

@@ -885 +885 @@
 
 
-/** A worker for vboxNetFltSendDummy() thread. */
-static int vboxNetFltSendDummyWorker(RTTHREAD ThreadSelf, void *pvUser)
+/** A worker thread for vboxNetFltSendDummy(). */
+static DECLCALLBACK(int) vboxNetFltSendDummyWorker(RTTHREAD hThreadSelf, void *pvUser)
 {
     Assert(pvUser);
@@ -893 +893 @@
 }
 
-/*
+
+/**
  * Prevent GUI icon freeze issue when VirtualBoxVM process terminates.
  *
- * This function is a workaround for stuck-in-dock issue. The
- * idea here is to send a dummy packet to an interface from the
- * context of a kernel thread. Therefore, an XNU's receive
- * thread (which is created as a result if we are the first who
- * is communicating with the interface) will be associated with the
- * kernel thread instead of VirtualBoxVM process.
+ * This function is a workaround for stuck-in-dock issue.  The idea here is to
+ * send a dummy packet to an interface from the context of a kernel thread.
+ * Therefore, an XNU's receive thread (which is created as a result if we are
+ * the first who is communicating with the interface) will be associated with
+ * the kernel thread instead of VirtualBoxVM process.
  *
  * @param pIfNet    Interface to be used to send data.
@@ -907 +907 @@
 static void vboxNetFltSendDummy(ifnet_t pIfNet)
 {
-    RTTHREAD dummyThread;
-    int rc;
-
-    rc = RTThreadCreate(&dummyThread, vboxNetFltSendDummyWorker, (void *)pIfNet, 0,
-        RTTHREADTYPE_DEFAULT, RTTHREADFLAGS_WAITABLE, "DummyThread");
-
+    RTTHREAD hThread;
+    int rc = RTThreadCreate(&hThread, vboxNetFltSendDummyWorker, (void *)pIfNet, 0,
+                            RTTHREADTYPE_DEFAULT, RTTHREADFLAGS_WAITABLE, "DummyThread");
     if (RT_SUCCESS(rc))
     {
-        RTThreadWait(dummyThread, RT_INDEFINITE_WAIT, NULL);
+        RTThreadWait(hThread, RT_INDEFINITE_WAIT, NULL);
         LogFlow(("vboxNetFltSendDummy: a dummy packet has been successfully sent in order to prevent stuck-in-dock issue\n"));
     }
@@ -921 +918 @@
         LogFlow(("vboxNetFltSendDummy: unable to send dummy packet in order to prevent stuck-in-dock issue\n"));
 }
+
 
 /**
@@ -957 +955 @@
     RTSpinlockReleaseNoInts(pThis->hSpinlock);
 
-    /* Prevent stuck-in-dock issue by associating interface receive thread with kernel thread */
+    /* Prevent stuck-in-dock issue by associating interface receive thread with kernel thread. */
     vboxNetFltSendDummy(pIfNet);