Changeset 53309 in vbox for trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

Timestamp:

Nov 12, 2014 3:47:13 AM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

96888

Message:

NAT: don't create contiguous copy of all large ICMP datagrams, only do
one when necessary.

File:

• trunk/src/VBox/Devices/Network/slirp/ip_icmp.c (modified) (5 diffs)

trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

@@ -346 +346 @@
 icmp_input(PNATState pData, struct mbuf *m, int hlen)
 {
-    register struct icmp *icp;
-    void *icp_buf = NULL;
     register struct ip *ip = mtod(m, struct ip *);
     int icmplen = ip->ip_len;
+    uint8_t icmp_type;
+    void *icp_buf = NULL;
     int status;
     uint32_t dst;
@@ -382 +382 @@
     }
 
-    if (m->m_next)
-    {
-        icp_buf = RTMemAlloc(icmplen);
-        if (!icp_buf)
-        {
-            Log(("NAT: not enought memory to allocate the buffer\n"));
-            goto end_error_free_m;
-        }
-        m_copydata(m, 0, icmplen, icp_buf);
-        icp = (struct icmp *)icp_buf;
-    }
-    else
-        icp = mtod(m, struct icmp *);
+    /* are we guaranteed to have ICMP header in first mbuf? be safe. */
+    m_copydata(m, 0, sizeof(icmp_type), (caddr_t)&icmp_type);
 
     m->m_len += hlen;
@@ -402 +391 @@
     /* code = icp->icmp_code; */
 
-    LogFlow(("icmp_type = %d\n", icp->icmp_type));
-    switch (icp->icmp_type)
+    LogFlow(("icmp_type = %d\n", icmp_type));
+    switch (icmp_type)
     {
         case ICMP_ECHO:
@@ -422 +411 @@
             else
             {
+                struct icmp *icp;
                 struct sockaddr_in addr;
 #ifdef RT_OS_WINDOWS
@@ -442 +432 @@
                 else
                     addr.sin_addr.s_addr = ip->ip_dst.s_addr;
+
+                if (m->m_next)
+                {
+                    icp_buf = RTMemAlloc(icmplen);
+                    if (!icp_buf)
+                    {
+                        Log(("NAT: not enought memory to allocate the buffer\n"));
+                        goto end_error_free_m;
+                    }
+                    m_copydata(m, hlen, icmplen, icp_buf);
+                    icp = (struct icmp *)icp_buf;
+                }
+                else
+                    icp = (struct icmp *)(mtod(m, char *) + hlen);
+
 #ifndef RT_OS_WINDOWS
                 if (pData->icmp_socket.s != -1)