Changeset 53448 in vbox for trunk/src/VBox/Devices/Network/slirp/dnsproxy/dnsproxy.h

Timestamp:

Dec 5, 2014 9:12:22 AM (10 years ago)

Author:

vboxsync

Message:

NAT: trac ticket 13630 - use generation numbers as poor man's weak
references to prevent dnsproxy from using stale request::dns_server.

This commit has some extra LogRel() for the user to confirm the fix,
which are to be changed to Log2.

XXX: TOO: Clean up in dnsproxy_query() needs more investigation.
Existing code just punts with an "XXX" comment on sendto() failure,
which doesn't doesn't look right.

File:

• trunk/src/VBox/Devices/Network/slirp/dnsproxy/dnsproxy.h (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/dnsproxy/dnsproxy.h

@@ -82 +82 @@
      * it's value on next server. And dnsproxy_query should
      * initializate with first server in the list
+     *
+     * dnsgen is a generation number - a copy of pData->dnsgen at the
+     * time of request creation (poor man's weak reference).
+     * dns_server must not be used if pData->dnsgen changed.
      */
     struct dns_entry    *dns_server;
+    uint32_t            dnsgen; 
     int nbyte; /* length of dns request */
     char byte[1]; /* copy of original request */