Changeset 57817 in vbox for trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp

Timestamp:

Sep 18, 2015 2:31:28 AM (9 years ago)

Author:

vboxsync

Message:

VBoxNetFlt/darwin: vboxNetFltDarwinIffInputOutputWorker - when we we
need to drop the packet, don't free it a few levels of nesting deep.
Makes the relation between mbuf_freem and EJUSTRETURN more obvious.

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp (modified) (2 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp

@@ -930 +930 @@
             if (vboxNetFltDarwinIsPromiscuous(pThis))
                 fDropIt = false;
-            else
-                mbuf_freem(pMBuf);
         }
     }
@@ -937 +935 @@
     vboxNetFltRelease(pThis, true /* fBusy */);
 
-    return fDropIt ? EJUSTRETURN : 0;
+    if (fDropIt)
+    {
+        mbuf_freem(pMBuf);
+        return EJUSTRETURN;
+    }
+    return 0;
 }