Changeset 59932 in vbox for trunk/src/VBox/ValidationKit/bootsectors/bs3kit/bs3kit.h

Timestamp:

Mar 4, 2016 4:01:18 PM (9 years ago)

Author:

vboxsync

Message:

bs3kit: Eliminate BS3_MSC64_FIXUP_HACK and the associated /TP (compile as C++) option as these aren't durable workarounds for the problem. Instead do quick COFF -> OMF conversion so we can better control what WLINK will do during link. This addresses a few other issues too, like dot-prefixed segment names and incorrect fixups (not using FLAT but, symbol segment as the reference frame).

File:

• trunk/src/VBox/ValidationKit/bootsectors/bs3kit/bs3kit.h (modified) (1 diff)

trunk/src/VBox/ValidationKit/bootsectors/bs3kit/bs3kit.h

@@ -455 +455 @@
 # define BS3_DATA_NM(a_Name)  a_Name
 #endif
-
-/** @def BS3_MSC64_FIXUP_HACK
- * Used to avoid IMAGE_REL_AMD64_ADDR32NB fixups where the compiler tries to
- * make use of __ImageBase as a base pointer instead of emitting rip relative
- * accesses.  Happens when there are a bunch of global data accesses in the same
- * function, probably to save space.
- *
- * The volatile variable in the lambda fixes it.
- */
-#if _MSC_VER && ARCH_BITS == 64
-# define BS3_MSC64_FIXUP_HACK(a_BaseType, a_Data) \
-    ([]() -> a_BaseType * \
-     { \
-        a_BaseType * volatile x = a_Data; \
-        return x; \
-     }())
-
-#else
-# define BS3_MSC64_FIXUP_HACK(a_BaseType, a_Data) (a_Data)
-#endif
-
 
 /**