Changeset 60740 in vbox

Timestamp:

Apr 28, 2016 12:51:47 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

106930

Message:

VMM, recompiler: Fix APIC to update pending interrupts to IRR when the force-flag is set, rather
than in PDMGetInterrupt() which gets called only with EFLAGS.IF set in certain places.

Location:

trunk/src

Files:

• VBox/VMM/VMMAll/APICAll.cpp (modified) (1 diff)
• VBox/VMM/VMMR0/HMSVMR0.cpp (modified) (2 diffs)
• VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (2 diffs)
• VBox/VMM/VMMR3/EM.cpp (modified) (2 diffs)
• VBox/VMM/VMMRC/TRPMRCHandlers.cpp (modified) (2 diffs)
• recompiler/Makefile.kmk (modified) (1 diff)
• recompiler/VBoxRecompiler.c (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/APICAll.cpp

@@ -2315 +2315 @@
         && pXApicPage->svr.u.fApicSoftwareEnable)
     {
-        APICUpdatePendingInterrupts(pVCpu);
         int const irrv = apicGetLastSetBit(&pXApicPage->irr, -1);
         if (RT_LIKELY(irrv >= 0))

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -30 +30 @@
 #include <VBox/vmm/tm.h>
 #include <VBox/vmm/gim.h>
+#ifdef VBOX_WITH_NEW_APIC
+# include <VBox/vmm/apic.h>
+#endif
 #include "HMInternal.h"
 #include <VBox/vmm/vm.h>
@@ -2660 +2663 @@
     else if (VMCPU_FF_IS_PENDING(pVCpu, (VMCPU_FF_INTERRUPT_APIC | VMCPU_FF_INTERRUPT_PIC)))
     {
+
+#ifdef VBOX_WITH_NEW_APIC
+        if (VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_APIC))
+            APICUpdatePendingInterrupts(pVCpu);
+#endif
         /*
          * Check if the guest can receive external interrupts (PIC/APIC). Once we do PDMGetInterrupt() we -must- deliver

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -34 +34 @@
 #ifdef VBOX_WITH_REM
 # include <VBox/vmm/rem.h>
+#endif
+#ifdef VBOX_WITH_NEW_APIC
+# include <VBox/vmm/apic.h>
 #endif
 #include "HMInternal.h"
@@ -7437 +7440 @@
              && !pVCpu->hm.s.fSingleInstruction)
     {
+#ifdef VBOX_WITH_NEW_APIC
+        if (VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_APIC))
+            APICUpdatePendingInterrupts(pVCpu);
+#endif
         Assert(!DBGFIsStepping(pVCpu));
         int rc = hmR0VmxSaveGuestRflags(pVCpu, pMixedCtx);

trunk/src/VBox/VMM/VMMR3/EM.cpp

@@ -49 +49 @@
 #ifdef VBOX_WITH_REM
 # include <VBox/vmm/rem.h>
+#endif
+#ifdef VBOX_WITH_NEW_APIC
+# include <VBox/vmm/apic.h>
 #endif
 #include <VBox/vmm/tm.h>
@@ -1934 +1937 @@
             if (VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_APIC | VMCPU_FF_INTERRUPT_PIC))
             {
+#ifdef VBOX_WITH_NEW_APIC
+                if (VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_APIC))
+                    APICUpdatePendingInterrupts(pVCpu);
+#endif
                 /* Note: it's important to make sure the return code from TRPMR3InjectEvent isn't ignored! */
                 /** @todo this really isn't nice, should properly handle this */

trunk/src/VBox/VMM/VMMRC/TRPMRCHandlers.cpp

@@ -28 +28 @@
 #include <VBox/vmm/em.h>
 #include <VBox/vmm/gim.h>
+#ifdef VBOX_WITH_NEW_APIC
+# include <VBox/vmm/apic.h>
+#endif
 #include <VBox/vmm/csam.h>
 #include <VBox/vmm/patm.h>
@@ -255 +258 @@
            )
         {
+#ifdef VBOX_WITH_NEW_APIC
+            /* The EFLAGS are checked in TRPMForwardTrap() below. */
+            if (VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_APIC))
+                APICUpdatePendingInterrupts(pVCpu);
+#endif
             uint8_t u8Interrupt;
             rc = PDMGetInterrupt(pVCpu, &u8Interrupt);

trunk/src/recompiler/Makefile.kmk

@@ -70 +70 @@
 ifdef IEM_VERIFICATION_MODE
  VBoxRemPrimary_DEFS          += IEM_VERIFICATION_MODE
+endif
+ifdef VBOX_WITH_NEW_APIC
+ VBoxRemPrimary_DEFS          += VBOX_WITH_NEW_APIC
 endif
 ifdef VBOX_WITH_RAW_MODE

trunk/src/recompiler/VBoxRecompiler.c

@@ -50 +50 @@
 #include <VBox/vmm/dbgf.h>
 #include <VBox/dbg.h>
+#ifdef VBOX_WITH_NEW_APIC
+# include <VBox/vmm/apic.h>
+#endif
 #include <VBox/vmm/hm.h>
 #include <VBox/vmm/patm.h>
@@ -2517 +2520 @@
     if (    pVM->rem.s.u32PendingInterrupt != REM_NO_PENDING_IRQ
         ||  VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_APIC | VMCPU_FF_INTERRUPT_PIC))
+    {
+#ifdef VBOX_WITH_NEW_APIC
+        if (VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_APIC))
+            APICUpdatePendingInterrupts(pVCpu);
+#endif
         pVM->rem.s.Env.interrupt_request |= CPU_INTERRUPT_HARD;
+    }
 
     /*