Changeset 62452 in vbox for trunk

Timestamp:

Jul 22, 2016 3:16:45 PM (8 years ago)

Author:

vboxsync

Message:

*: MSC level 4 warnings in release bldprogs.

Location:

trunk/src

Files:

• VBox/Disassembler/DisasmFormatYasm.cpp (modified) (2 diffs)
• VBox/Runtime/common/log/log.cpp (modified) (1 diff)
• VBox/Runtime/common/string/strcache.cpp (modified) (1 diff)
• VBox/Runtime/common/zip/tar.cpp (modified) (3 diffs)
• VBox/Runtime/r3/memsafer-r3.cpp (modified) (1 diff)
• VBox/Runtime/r3/win/allocex-win.cpp (modified) (1 diff)
• VBox/Runtime/r3/win/localipc-win.cpp (modified) (3 diffs)
• VBox/Runtime/r3/win/process-win.cpp (modified) (2 diffs)
• VBox/Runtime/r3/win/semevent-win.cpp (modified) (2 diffs)
• VBox/Runtime/r3/win/timer-win.cpp (modified) (3 diffs)
• bldprogs/VBoxCPP.cpp (modified) (3 diffs)

trunk/src/VBox/Disassembler/DisasmFormatYasm.cpp

@@ -1130 +1130 @@
                         PUT_SIZE_OVERRIDE();
                         PUT_SEGMENT_OVERRIDE();
+                        off = 0;
                         int rc = VERR_SYMBOL_NOT_FOUND;
                         switch (pParam->fUse & (DISUSE_IMMEDIATE_ADDR_16_16 | DISUSE_IMMEDIATE_ADDR_16_32 | DISUSE_DISPLACEMENT64 | DISUSE_DISPLACEMENT32 | DISUSE_DISPLACEMENT16))
@@ -1178 +1179 @@
                         PUT_C('[');
                         PUT_SEGMENT_OVERRIDE();
+                        off = 0;
                         int rc = VERR_SYMBOL_NOT_FOUND;
                         switch (pParam->fUse & (DISUSE_IMMEDIATE_ADDR_16_16 | DISUSE_IMMEDIATE_ADDR_16_32 | DISUSE_DISPLACEMENT64 | DISUSE_DISPLACEMENT32 | DISUSE_DISPLACEMENT16))

trunk/src/VBox/Runtime/common/log/log.cpp

@@ -2387 +2387 @@
                     {
                         int rc = RTStrCopyEx(szTmp, sizeof(szTmp), pszValue, cch);
-                        uint32_t cbRingBuf;
+                        uint32_t cbRingBuf = 0;
                         if (RT_SUCCESS(rc))
                             rc = RTStrToUInt32Full(szTmp, 0, &cbRingBuf);

trunk/src/VBox/Runtime/common/string/strcache.cpp

@@ -850 +850 @@
     {
         uint32_t cRefs = ASMAtomicIncU32(&pEntry->cRefs);
-        Assert(cRefs < UINT32_MAX / 2);
+        Assert(cRefs < UINT32_MAX / 2); NOREF(cRefs);
     }
     else

trunk/src/VBox/Runtime/common/zip/tar.cpp

@@ -243 +243 @@
     if (pInt->hVfsFss != NIL_RTVFSFSSTREAM)
     {
-        uint32_t cRefs = RTVfsFsStrmRelease(pInt->hVfsFss); Assert(cRefs != UINT32_MAX);
+        uint32_t cRefs = RTVfsFsStrmRelease(pInt->hVfsFss); Assert(cRefs != UINT32_MAX); NOREF(cRefs);
         pInt->hVfsFss  = NIL_RTVFSFSSTREAM;
     }
@@ -249 +249 @@
     if (pInt->hVfsFile != NIL_RTVFSFILE)
     {
-        uint32_t cRefs = RTVfsFileRelease(pInt->hVfsFile); Assert(cRefs != UINT32_MAX);
+        uint32_t cRefs = RTVfsFileRelease(pInt->hVfsFile); Assert(cRefs != UINT32_MAX); NOREF(cRefs);
         pInt->hVfsFile = NIL_RTVFSFILE;
     }
@@ -362 +362 @@
             if (pInt->hVfsFss != NIL_RTVFSFSSTREAM)
             {
-                uint32_t cRefs = RTVfsFsStrmRelease(pInt->hVfsFss); Assert(cRefs != UINT32_MAX);
+                uint32_t cRefs = RTVfsFsStrmRelease(pInt->hVfsFss); Assert(cRefs != UINT32_MAX); NOREF(cRefs);
                 pInt->hVfsFss  = NIL_RTVFSFSSTREAM;
             }

trunk/src/VBox/Runtime/r3/memsafer-r3.cpp

@@ -161 +161 @@
     bool fRc = RTAvlPVInsert(&g_pMemSaferTree, &pThis->Core);
     RTCritSectRwLeaveExcl(&g_MemSaferCritSect);
-    Assert(fRc);
+    Assert(fRc); NOREF(fRc);
 }
 

trunk/src/VBox/Runtime/r3/win/allocex-win.cpp

@@ -116 +116 @@
 {
     BOOL fRc = VirtualFree(pv, cb, MEM_RELEASE);
-    Assert(fRc);
+    Assert(fRc); NOREF(fRc);
 }
 

trunk/src/VBox/Runtime/r3/win/localipc-win.cpp

@@ -455 +455 @@
 {
     uint32_t cRefs = ASMAtomicIncU32(&pThis->cRefs);
-    Assert(cRefs < UINT32_MAX / 2 && cRefs);
+    Assert(cRefs < UINT32_MAX / 2 && cRefs); NOREF(cRefs);
 }
 
@@ -903 +903 @@
 {
     uint32_t cRefs = ASMAtomicIncU32(&pThis->cRefs);
-    Assert(cRefs < UINT32_MAX / 2 && cRefs);
+    Assert(cRefs < UINT32_MAX / 2 && cRefs); NOREF(cRefs);
 }
 
@@ -1531 +1531 @@
                         break;
                     }
-                    BOOL fRc = ResetEvent(pThis->Read.OverlappedIO.hEvent); Assert(fRc == TRUE);
+                    BOOL fRc = ResetEvent(pThis->Read.OverlappedIO.hEvent); Assert(fRc == TRUE); NOREF(fRc);
                     DWORD cbRead = 0;
                     if (ReadFile(pThis->hNmPipe, pThis->abBuf, 0 /*cbToRead*/, &cbRead, &pThis->Read.OverlappedIO))

trunk/src/VBox/Runtime/r3/win/process-win.cpp

@@ -2253 +2253 @@
      * Create the command line and convert the executable name.
      */
-    PRTUTF16 pwszCmdLine;
+    PRTUTF16 pwszCmdLine = NULL; /* Shut up, MSC! */
     if (RT_SUCCESS(rc))
         rc = RTGetOptArgvToUtf16String(&pwszCmdLine, papszArgs,
@@ -2498 +2498 @@
 
     BOOL fRc = GetProcessAffinityMask(GetCurrentProcess(), &dwProcessAffinityMask, &dwSystemAffinityMask);
-    Assert(fRc);
+    Assert(fRc); NOREF(fRc);
 
     return dwProcessAffinityMask;

trunk/src/VBox/Runtime/r3/win/semevent-win.cpp

@@ -220 +220 @@
 RTDECL(int)   RTSemEventWaitNoResume(RTSEMEVENT hEventSem, RTMSINTERVAL cMillies)
 {
-    PCRTLOCKVALSRCPOS pSrcPos = NULL;
-
     /*
      * Validate input.
@@ -243 +241 @@
         if (rc != WAIT_TIMEOUT || cMillies == 0)
             return rtSemEventWaitHandleStatus(pThis, rc);
-        int rc9 = RTLockValidatorRecSharedCheckBlocking(&pThis->Signallers, hThreadSelf, pSrcPos, false,
+        int rc9 = RTLockValidatorRecSharedCheckBlocking(&pThis->Signallers, hThreadSelf, NULL /*pSrcPos*/, false,
                                                         cMillies, RTTHREADSTATE_EVENT, true);
         if (RT_FAILURE(rc9))

trunk/src/VBox/Runtime/r3/win/timer-win.cpp

@@ -243 +243 @@
              * Rearm the timer handler.
              */
-#ifdef USE_CATCH_UP
+# ifdef USE_CATCH_UP
             pTimer->llNext.QuadPart += NSInterval;
             LARGE_INTEGER ll;
@@ -251 +251 @@
             else
                 ll.QuadPart = -500000 / 100; /* need to catch up, do a minimum wait of 0.5ms. */
-#else
+# else
             LARGE_INTEGER ll = pTimer->llNext;
-#endif
-            BOOL frc = SetWaitableTimer(pTimer->hTimer, &ll, 0, NULL, NULL, FALSE);
-            AssertMsg(frc || pTimer->u32Magic != RTTIMER_MAGIC, ("last error %d\n", GetLastError()));
+# endif
+            BOOL fRc = SetWaitableTimer(pTimer->hTimer, &ll, 0, NULL, NULL, FALSE);
+            AssertMsg(fRc || pTimer->u32Magic != RTTIMER_MAGIC, ("last error %d\n", GetLastError())); NOREF(fRc);
         }
         else
@@ -265 +265 @@
             int rc2 = GetLastError();
             RTThreadUserSignal(Thread);
-            AssertMsgFailed(("Wait on hTimer failed, rc=%d lasterr=%d\n", rc, rc2));
+            AssertMsgFailed(("Wait on hTimer failed, rc=%d lasterr=%d\n", rc, rc2)); NOREF(rc2);
             return -1;
         }

trunk/src/bldprogs/VBoxCPP.cpp

@@ -2607 +2607 @@
 
             bool fRc = RTStrSpaceInsert(&pThis->StrSpace, &pMacro->Core);
-            Assert(fRc);
+            Assert(fRc); NOREF(fRc);
         }
         else
@@ -4371 +4371 @@
         {
             /* Comment? */
-            unsigned ch2 = ScmStreamGetCh(pStrmInput); Assert(ch == ch2);
+            unsigned ch2 = ScmStreamGetCh(pStrmInput); Assert(ch == ch2); NOREF(ch2);
             ch = ScmStreamPeekCh(pStrmInput);
             if (ch == '*')
@@ -4403 +4403 @@
         {
             unsigned ch2 = ScmStreamGetCh(pStrmInput);
-            Assert(ch == ch2);
+            Assert(ch == ch2); NOREF(ch2);
             rcExit = RTEXITCODE_SUCCESS;
         }