Changeset 62919 in vbox for trunk/src/VBox/Devices/Audio/DrvHostDebugAudio.cpp

Timestamp:

Aug 3, 2016 2:16:14 PM (8 years ago)

Author:

vboxsync

Message:

Please use 'static const' on data that is constant, don't make the compiler recreated on the stack for each call.

File:

• trunk/src/VBox/Devices/Audio/DrvHostDebugAudio.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Audio/DrvHostDebugAudio.cpp

@@ -167 +167 @@
 
     /* Consume as many samples as would be played at the current frequency since last call. */
-    uint32_t cLive           = AudioMixBufLive(&pStream->MixBuf);
+    /*uint32_t cLive           = AudioMixBufLive(&pStream->MixBuf);*/
 
     uint64_t u64TicksNow     = PDMDrvHlpTMGetVirtualTime(pDrv->pDrvIns);
-    uint64_t u64TicksElapsed = u64TicksNow  - pDbgStream->Out.tsLastPlayed;
-    uint64_t u64TicksFreq    = PDMDrvHlpTMGetVirtualFreq(pDrv->pDrvIns);
+   // uint64_t u64TicksElapsed = u64TicksNow  - pDbgStream->Out.tsLastPlayed;
+   // uint64_t u64TicksFreq    = PDMDrvHlpTMGetVirtualFreq(pDrv->pDrvIns);
 
     /*
@@ -229 +229 @@
                                                         uint32_t *pcSamplesCaptured)
 {
+    RT_NOREF(pInterface, pStream);
+
     /* Never capture anything. */
     if (pcSamplesCaptured)
@@ -238 +240 @@
 static int debugDestroyStreamIn(PPDMIHOSTAUDIO pInterface, PPDMAUDIOSTREAM pStream)
 {
+    RT_NOREF(pInterface, pStream);
     LogFlowFuncLeaveRC(VINF_SUCCESS);
     return VINF_SUCCESS;
@@ -244 +247 @@
 static int debugDestroyStreamOut(PPDMIHOSTAUDIO pInterface, PPDMAUDIOSTREAM pStream)
 {
-    PPDMDRVINS pDrvIns = PDMIBASE_2_PDMDRV(pInterface);
-
+    RT_NOREF(pInterface);
     PDEBUGAUDIOSTREAM pDbgStream = (PDEBUGAUDIOSTREAM)pStream;
     if (   pDbgStream
@@ -270 +272 @@
 static DECLCALLBACK(PDMAUDIOBACKENDSTS) drvHostDebugAudioGetStatus(PPDMIHOSTAUDIO pInterface, PDMAUDIODIR enmDir)
 {
+    RT_NOREF(enmDir);
     AssertPtrReturn(pInterface, PDMAUDIOBACKENDSTS_UNKNOWN);
 
@@ -309 +312 @@
                                                         PPDMAUDIOSTREAM pStream, PDMAUDIOSTREAMCMD enmStreamCmd)
 {
+    RT_NOREF(enmStreamCmd);
     AssertPtrReturn(pInterface, VERR_INVALID_POINTER);
     AssertPtrReturn(pStream,    VERR_INVALID_POINTER);
@@ -359 +363 @@
 static DECLCALLBACK(int) drvHostDebugAudioConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
-    AssertPtrReturn(pDrvIns, VERR_INVALID_POINTER);
-    /* pCfg is optional. */
-
+    RT_NOREF(pCfg, fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVHOSTDEBUGAUDIO pThis = PDMINS_2_DATA(pDrvIns, PDRVHOSTDEBUGAUDIO);
     LogRel(("Audio: Initializing DEBUG driver\n"));