Changeset 63039 in vbox for trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/xpdm/VBoxMPDriver.cpp

Timestamp:

Aug 5, 2016 12:17:07 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109651

Message:

GA/NT/Graphics: warnings

File:

• trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/xpdm/VBoxMPDriver.cpp (modified) (15 diffs)

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/xpdm/VBoxMPDriver.cpp

@@ -1 +1 @@
 /* $Id$ */
-
 /** @file
  * VBox XPDM Miniport driver interface functions
@@ -17 +16 @@
  */
 
+/*********************************************************************************************************************************
+*   Header Files                                                                                                                 *
+*********************************************************************************************************************************/
 #include "VBoxMPInternal.h"
 #include <VBox/Hardware/VBoxVideoVBE.h>
@@ -27 +29 @@
 #include <VBox/version.h>
 
+
+/*********************************************************************************************************************************
+*   Global Variables                                                                                                             *
+*********************************************************************************************************************************/
 /* Resource list */
-VIDEO_ACCESS_RANGE  VBoxLegacyVGAResourceList[] =
+static VIDEO_ACCESS_RANGE  g_aVBoxLegacyVGAResources[] =
 {
     { 0x000003B0, 0x00000000, 0x0000000C, 1, 1, 1, 0 }, /* VGA regs (0x3B0-0x3BB) */
@@ -36 +42 @@
 
 /* Card info for property dialog */
-static WCHAR VBoxChipType[] = L"VBOX";
-static WCHAR VBoxDACType[] = L"Integrated RAMDAC";
-static WCHAR VBoxAdapterString[] = L"VirtualBox Video Adapter";
-static WCHAR VBoxBiosString[] = L"Version 0xB0C2 or later";
+static WCHAR g_wszVBoxChipType[]      = L"VBOX";
+static WCHAR g_wszVBoxDACType[]       = L"Integrated RAMDAC";
+static WCHAR g_wszVBoxAdapterString[] = L"VirtualBox Video Adapter";
+static WCHAR g_wszVBoxBiosString[]    = L"Version 0xB0C2 or later";
+
 
 /* Checks if we have a device supported by our driver and initialize
@@ -49 +56 @@
                    IN OUT PVIDEO_PORT_CONFIG_INFO ConfigInfo, OUT PUCHAR Again)
 {
+    RT_NOREF(HwContext,  ArgumentString, Again);
     PVBOXMP_DEVEXT pExt = (PVBOXMP_DEVEXT) HwDeviceExtension;
     VP_STATUS rc;
@@ -81 +89 @@
     /* Write hw information to registry, so that it's visible in windows property dialog */
     rc = VideoPortSetRegistryParameters(pExt, L"HardwareInformation.ChipType",
-                                        VBoxChipType, sizeof(VBoxChipType));
+                                        g_wszVBoxChipType, sizeof(g_wszVBoxChipType));
     VBOXMP_WARN_VPS(rc);
     rc = VideoPortSetRegistryParameters(pExt, L"HardwareInformation.DacType",
-                                        VBoxDACType, sizeof(VBoxDACType));
+                                        g_wszVBoxDACType, sizeof(g_wszVBoxDACType));
     VBOXMP_WARN_VPS(rc);
     rc = VideoPortSetRegistryParameters(pExt, L"HardwareInformation.MemorySize",
@@ -90 +98 @@
     VBOXMP_WARN_VPS(rc);
     rc = VideoPortSetRegistryParameters(pExt, L"HardwareInformation.AdapterString",
-                                        VBoxAdapterString, sizeof(VBoxAdapterString));
+                                        g_wszVBoxAdapterString, sizeof(g_wszVBoxAdapterString));
     VBOXMP_WARN_VPS(rc);
     rc = VideoPortSetRegistryParameters(pExt, L"HardwareInformation.BiosString",
-                                        VBoxBiosString, sizeof(VBoxBiosString));
+                                        g_wszVBoxBiosString, sizeof(g_wszVBoxBiosString));
     VBOXMP_WARN_VPS(rc);
 
@@ -364 +372 @@
             STARTIO_IN(VIDEO_POINTER_POSITION, pPos);
 
-            /** @todo set pointer position*/
+            NOREF(pPos); /** @todo set pointer position*/
             bResult = VBoxMPEnablePointer(pExt, TRUE, pStatus);
             break;
@@ -392 +400 @@
             STARTIO_OUT(VIDEO_POINTER_ATTRIBUTES, pPointerAttrs);
 
-            /* Not Implemented */
+            NOREF(pPointerAttrs); /* Not Implemented */
             pStatus->Status = ERROR_INVALID_FUNCTION;
 
@@ -592 +600 @@
 
     /*Not implemented*/
+    RT_NOREF(HwDeviceExtension, HwId, VideoPowerControl);
 
     LOGF_LEAVE();
@@ -605 +614 @@
 
     /*Not implemented*/
+    RT_NOREF(HwDeviceExtension, HwId, VideoPowerControl);
 
     LOGF_LEAVE();
@@ -616 +626 @@
                                PULONG pUnused)
 {
+    RT_NOREF(pChildDescriptor, pUnused);
     PVBOXMP_DEVEXT pExt = (PVBOXMP_DEVEXT) HwDeviceExtension;
 
@@ -640 +651 @@
 VBoxDrvResetHW(PVOID HwDeviceExtension, ULONG Columns, ULONG Rows)
 {
+    RT_NOREF(Columns, Rows);
     PVBOXMP_DEVEXT pExt = (PVBOXMP_DEVEXT) HwDeviceExtension;
 
@@ -675 +687 @@
 static VOID VBoxMPHGSMIDpc(IN PVOID  HwDeviceExtension, IN PVOID  Context)
 {
+    NOREF(Context);
     PVBOXMP_DEVEXT pExt = (PVBOXMP_DEVEXT) HwDeviceExtension;
 
@@ -754 +767 @@
 
     /*Claim legacy VGA resource ranges*/
-    vhwData.HwLegacyResourceList  = VBoxLegacyVGAResourceList;
-    vhwData.HwLegacyResourceCount = RT_ELEMENTS(VBoxLegacyVGAResourceList);
+    vhwData.HwLegacyResourceList  = g_aVBoxLegacyVGAResources;
+    vhwData.HwLegacyResourceCount = RT_ELEMENTS(g_aVBoxLegacyVGAResources);
 
     /*Size of this structure changes between windows/ddk versions,