VirtualBox

Ignore:
Timestamp:
Aug 16, 2016 2:04:03 PM (9 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
110217
Message:

scm: cleaning up todos

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Devices/PC/BIOS/eltorito.c

    r62509 r63562  
    6666
    6767
    68 //@todo: put in a header
     68/// @todo put in a header
    6969#define AX      r.gr.u.r16.ax
    7070#define BX      r.gr.u.r16.bx
     
    142142void BIOSCALL cdemu_init(void)
    143143{
    144     // @TODO: a macro or a function for getting the EBDA segment
     144    /// @todo a macro or a function for getting the EBDA segment
    145145    uint16_t    ebda_seg = read_word(0x0040,0x000E);
    146146
     
    151151uint8_t BIOSCALL cdemu_isactive(void)
    152152{
    153     // @TODO: a macro or a function for getting the EBDA segment
     153    /// @todo a macro or a function for getting the EBDA segment
    154154    uint16_t    ebda_seg = read_word(0x0040,0x000E);
    155155
     
    159159uint8_t BIOSCALL cdemu_emulated_drive(void)
    160160{
    161     // @TODO: a macro or a function for getting the EBDA segment
     161    /// @todo a macro or a function for getting the EBDA segment
    162162    uint16_t    ebda_seg = read_word(0x0040,0x000E);
    163163
     
    171171void BIOSCALL int13_eltorito(disk_regs_t r)
    172172{
    173     // @TODO: a macro or a function for getting the EBDA segment
     173    /// @todo a macro or a function for getting the EBDA segment
    174174    uint16_t        ebda_seg=read_word(0x0040,0x000E);
    175175    cdemu_t __far   *cdemu;
     
    193193    case 0x4b: // ElTorito - Terminate disk emu
    194194        // FIXME ElTorito Hardcoded
    195         //@todo: maybe our cdemu struct should match El Torito to allow memcpy()?
     195        /// @todo maybe our cdemu struct should match El Torito to allow memcpy()?
    196196        write_byte(DS,SI+0x00,0x13);
    197197        write_byte(DS,SI+0x01,cdemu->media);
     
    240240
    241241/* Utility routine to check if a device is a CD-ROM. */
    242 //@todo: this function is kinda useless as the ATAPI type check is obsolete.
     242/// @todo this function is kinda useless as the ATAPI type check is obsolete.
    243243static uint16_t device_is_cdrom(uint8_t device)
    244244{
     
    269269uint16_t cdrom_boot(void)
    270270{
    271     // @TODO: a macro or a function for getting the EBDA segment
     271    /// @todo a macro or a function for getting the EBDA segment
    272272    uint16_t            ebda_seg=read_word(0x0040,0x000E);
    273273    uint8_t             buffer[2048];
     
    314314    if (buffer[0] != 0)
    315315        return 4;
    316     //@todo: what's wrong with memcmp()?
     316    /// @todo what's wrong with memcmp()?
    317317    for (i = 0; i < 5; ++i) {
    318318        if (buffer[1+i] != isotag[i])
     
    341341        return 7;
    342342
    343     //@todo: Define a struct for the Boot Catalog, the hardcoded offsets are so dumb...
     343    /// @todo Define a struct for the Boot Catalog, the hardcoded offsets are so dumb...
    344344
    345345    /* Check if the Boot Catalog looks valid. */
     
    464464void BIOSCALL int13_cdemu(disk_regs_t r)
    465465{
    466     // @TODO: a macro or a function for getting the EBDA segment
     466    /// @todo a macro or a function for getting the EBDA segment
    467467    uint16_t            ebda_seg=read_word(0x0040,0x000E);
    468468    uint8_t             device, status;
     
    628628        /* Only set the DPT pointer for emulated floppies. */
    629629        if (cdemu->media < 4) {
    630             DI = (uint16_t)&diskette_param_table;   // @todo: should this depend on emulated medium?
    631             ES = 0xF000;                            // @todo: how to make this relocatable?
     630            DI = (uint16_t)&diskette_param_table;   /// @todo should this depend on emulated medium?
     631            ES = 0xF000;                            /// @todo how to make this relocatable?
    632632        }
    633633        goto int13_success;
     
    852852        // FIXME should handle 0xb5 valid request failed
    853853
    854 #if 0 //@todo: implement!
     854#if 0 /// @todo implement!
    855855        // Call removable media eject
    856856        ASM_START
     
    876876        break;
    877877
    878     //@todo: Part of this should be merged with analogous code in disk.c
     878    /// @todo Part of this should be merged with analogous code in disk.c
    879879    case 0x48: // IBM/MS get drive parameters
    880880        dpt = DS :> (dpt_t *)SI;
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette