Changeset 64343 in vbox for trunk/src/VBox/Runtime/common/string/strprintf.cpp

Timestamp:

Oct 20, 2016 7:28:31 PM (8 years ago)

Author:

vboxsync

Message:

strprintf.cpp: Apply the same optimizations as was done for strprintf2.cpp.

File:

• trunk/src/VBox/Runtime/common/string/strprintf.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/string/strprintf.cpp

@@ -67 +67 @@
 {
     PSTRBUFARG  pArg = (PSTRBUFARG)pvArg;
+    char *pszCur = pArg->psz; /* We actually have to spell this out for VS2010, or it will load for each case. */
 
     cbChars = RT_MIN(pArg->cch, cbChars);
     if (cbChars)
     {
-        memcpy(pArg->psz, pachChars, cbChars);
         pArg->cch -= cbChars;
-        pArg->psz += cbChars;
+
+        /* Note! For VS2010/64 we need at least 7 case statements before it generates a jump table. */
+        switch (cbChars)
+        {
+            default:
+                memcpy(pszCur, pachChars, cbChars);
+                break;
+            case 8: pszCur[7] = pachChars[7];
+            case 7: pszCur[6] = pachChars[6];
+            case 6: pszCur[5] = pachChars[5];
+            case 5: pszCur[4] = pachChars[4];
+            case 4: pszCur[3] = pachChars[3];
+            case 3: pszCur[2] = pachChars[2];
+            case 2: pszCur[1] = pachChars[1];
+            case 1: pszCur[0] = pachChars[0];
+            case 0:
+                break;
+        }
+        pArg->psz = pszCur += cbChars;
     }
-    *pArg->psz = '\0';
+    *pszCur = '\0';
 
     return cbChars;
@@ -81 +99 @@
 
 
+RTDECL(size_t) RTStrPrintf(char *pszBuffer, size_t cchBuffer, const char *pszFormat, ...)
+{
+    /* Explicitly inline RTStrPrintfV + RTStrPrintfExV here because this is a frequently use API. */
+    STRBUFARG Arg;
+    va_list args;
+    size_t cbRet;
+
+    AssertMsgReturn(cchBuffer, ("Excellent idea! Format a string with no space for the output!\n"), 0);
+    Arg.psz = pszBuffer;
+    Arg.cch = cchBuffer - 1;
+
+    va_start(args, pszFormat);
+    cbRet = RTStrFormatV(strbufoutput, &Arg, NULL, NULL, pszFormat, args);
+    va_end(args);
+
+    return cbRet;
+}
+RT_EXPORT_SYMBOL(RTStrPrintf);
+
+
 RTDECL(size_t) RTStrPrintfExV(PFNSTRFORMAT pfnFormat, void *pvArg, char *pszBuffer, size_t cchBuffer, const char *pszFormat, va_list args)
 {
     STRBUFARG Arg;
-
-    if (!cchBuffer)
-    {
-        AssertMsgFailed(("Excellent idea! Format a string with no space for the output!\n"));
-        return 0;
-    }
-
+    AssertMsgReturn(cchBuffer, ("Excellent idea! Format a string with no space for the output!\n"), 0);
     Arg.psz = pszBuffer;
     Arg.cch = cchBuffer - 1;
@@ -116 +148 @@
 RT_EXPORT_SYMBOL(RTStrPrintfEx);
 
-
-RTDECL(size_t) RTStrPrintf(char *pszBuffer, size_t cchBuffer, const char *pszFormat, ...)
-{
-    va_list args;
-    size_t cbRet;
-    va_start(args, pszFormat);
-    cbRet = RTStrPrintfV(pszBuffer, cchBuffer, pszFormat, args);
-    va_end(args);
-    return cbRet;
-}
-RT_EXPORT_SYMBOL(RTStrPrintf);
-