VirtualBox

Changeset 64766 in vbox


Ignore:
Timestamp:
Nov 30, 2016 10:59:48 AM (8 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
112111
Message:

src/VBox: Make the use of the iterator for RTListForEach()/RTListForEachSafe() more obvious. There is no need to initialize the iterator and we also must not depend on the iterator being NULL if the list was empty.

Location:
trunk/src/VBox
Files:
24 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/wddm/VBoxDispD3D.cpp

    r63566 r64766  
    339339            {
    340340                memset(aDbgAllocs, 0, sizeof (aDbgAllocs));
     341                uint32_t cAllocs = 0;
    341342                PVBOXWDDMDISP_ALLOCATION pAlloc;
    342                 uint32_t cAllocs = 0;
    343343                RTListForEach(&pDevice->DirtyAllocList, pAlloc, VBOXWDDMDISP_ALLOCATION, DirtyAllocListEntry)
    344344                {

  • trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxLA.cpp

    r63104 r64766  
    199199static void ActionExecutorDeleteActions(RTLISTANCHOR *listActions)
    200200{
    201     ACTIONENTRY *pIter = NULL;
    202     ACTIONENTRY *pIterNext = NULL;
     201    ACTIONENTRY *pIter;
     202    ACTIONENTRY *pIterNext;
    203203    RTListForEachSafe(listActions, pIter, pIterNext, ACTIONENTRY, nodeActionEntry)
    204204    {
    … …  
    322322        {
    323323            bool fAdded = false;
    324             ACTIONENTRY *pIter = NULL;
     324            ACTIONENTRY *pIter;
    325325            RTListForEach(listActions, pIter, ACTIONENTRY, nodeActionEntry)
    326326            {
    … …  
    345345
    346346#ifdef LOG_ENABLED
    347     ACTIONENTRY *pIter = NULL;
     347    ACTIONENTRY *pIter;
    348348    RTListForEach(listActions, pIter, ACTIONENTRY, nodeActionEntry)
    349349    {
    … …  
    358358    }
    359359
    360     LogFlowFunc(("action enum %d\n",
    361            bRet));
     360    LogFlowFunc(("action enum %d\n", bRet));
    362361
    363362    return bRet;
    … …  
    368367    LogFlowFunc(("ExecuteActions\n"));
    369368
    370     ACTIONENTRY *pIter = NULL;
     369    ACTIONENTRY *pIter;
    371370    RTListForEach(listActions, pIter, ACTIONENTRY, nodeActionEntry)
    372371    {

  • trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlProcess.cpp

    r62882 r64766  
    11521152        /* Search old threads using the desired PID and shut them down completely -- it's
    11531153         * not used anymore. */
    1154         PVBOXSERVICECTRLPROCESS pProcessCur;
    11551154        bool fTryAgain;
    11561155        do
    11571156        {
    11581157            fTryAgain = false;
     1158            PVBOXSERVICECTRLPROCESS pProcessCur;
    11591159            RTListForEach(&pProcess->pSession->lstProcesses, pProcessCur, VBOXSERVICECTRLPROCESS, Node)
    11601160            {

  • trunk/src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp

    r62851 r64766  
    4545     *        implementation (AVL tree). However, this is not important at the
    4646     *        moment. */
    47     PVBOXSERVICEVEPROPCACHEENTRY pNodeIt, pNode = NULL;
     47    PVBOXSERVICEVEPROPCACHEENTRY pNode = NULL;
    4848    if (RT_SUCCESS(RTCritSectEnter(&pCache->CritSect)))
    4949    {
     50        PVBOXSERVICEVEPROPCACHEENTRY pNodeIt;
    5051        RTListForEach(&pCache->NodeHead, pNodeIt, VBOXSERVICEVEPROPCACHEENTRY, NodeSucc)
    5152        {
    … …  
    323324
    324325    int rc = VERR_NOT_FOUND;
    325     PVBOXSERVICEVEPROPCACHEENTRY pNodeIt = NULL;
    326326    if (RT_SUCCESS(RTCritSectEnter(&pCache->CritSect)))
    327327    {
    … …  
    341341        {
    342342            /* Iterate through all nodes and compare their paths. */
     343            PVBOXSERVICEVEPROPCACHEENTRY pNodeIt;
    343344            RTListForEach(&pCache->NodeHead, pNodeIt, VBOXSERVICEVEPROPCACHEENTRY, NodeSucc)
    344345            {
    … …  
    369370
    370371    int rc = VINF_SUCCESS;
    371     PVBOXSERVICEVEPROPCACHEENTRY pNodeIt = NULL;
    372372    if (RT_SUCCESS(RTCritSectEnter(&pCache->CritSect)))
    373373    {
     374        PVBOXSERVICEVEPROPCACHEENTRY pNodeIt;
    374375        RTListForEach(&pCache->NodeHead, pNodeIt, VBOXSERVICEVEPROPCACHEENTRY, NodeSucc)
    375376        {

  • trunk/src/VBox/Additions/common/VBoxService/VBoxServiceToolBox.cpp

    r62850 r64766  
    492492        {
    493493            /* Process each input file. */
     494            RTFILE hInput = NIL_RTFILE;
    494495            PVBOXSERVICETOOLBOXPATHENTRY pNodeIt;
    495             RTFILE hInput = NIL_RTFILE;
    496496            RTListForEach(&inputList, pNodeIt, VBOXSERVICETOOLBOXPATHENTRY, Node)
    497497            {

  • trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp

    r63822 r64766  
    10961096        return true;
    10971097
     1098    PDMCritSectEnter(&pVGAState->CritSect, VERR_SEM_BUSY);
     1099
    10981100    VBOX_VHWA_PENDINGCMD *pIter, *pNext;
    1099 
    1100     PDMCritSectEnter(&pVGAState->CritSect, VERR_SEM_BUSY);
    1101 
    11021101    RTListForEachSafe(&pVGAState->pendingVhwaCommands.PendingList, pIter, pNext, VBOX_VHWA_PENDINGCMD, Node)
    11031102    {

  • trunk/src/VBox/Devices/Graphics/DevVGA_VDMA.cpp

    r63839 r64766  
    693693    }
    694694
     695    int rc;
    695696    VBVAEXHOSTCTL* pCtl;
    696     int rc;
    697697    RTListForEach(&pCmdVbva->GuestCtlList, pCtl, VBVAEXHOSTCTL, Node)
    698698    {

  • trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp

    r64660 r64766  
    790790static PLSILOGICMEMREGN lsilogicR3MemRegionFindByAddr(PLSILOGICSCSI pThis, uint32_t u32Addr)
    791791{
     792    PLSILOGICMEMREGN pRegion = NULL;
     793
    792794    PLSILOGICMEMREGN pIt;
    793     PLSILOGICMEMREGN pRegion = NULL;
    794 
    795795    RTListForEach(&pThis->ListMemRegns, pIt, LSILOGICMEMREGN, NodeList)
    796796    {
    … …  
    814814static void lsilogicR3MemRegionsFree(PLSILOGICSCSI pThis)
    815815{
     816    PLSILOGICMEMREGN pItNext;
     817
    816818    PLSILOGICMEMREGN pIt;
    817     PLSILOGICMEMREGN pItNext;
    818 
    819819    RTListForEachSafe(&pThis->ListMemRegns, pIt, pItNext, LSILOGICMEMREGN, NodeList)
    820820    {
    … …  
    834834static void lsilogicR3MemRegionInsert(PLSILOGICSCSI pThis, PLSILOGICMEMREGN pRegion)
    835835{
     836    bool fInserted = false;
     837
     838    /* Insert at the right position. */
    836839    PLSILOGICMEMREGN pIt;
    837     bool fInserted = false;
    838 
    839     /* Insert at the right position. */
    840840    RTListForEach(&pThis->ListMemRegns, pIt, LSILOGICMEMREGN, NodeList)
    841841    {
    … …  
    860860{
    861861    uint32_t cRegions = 0;
     862
    862863    PLSILOGICMEMREGN pIt;
    863 
    864864    RTListForEach(&pThis->ListMemRegns, pIt, LSILOGICMEMREGN, NodeList)
    865865    {
    … …  
    894894    else
    895895    {
     896        pRegion = NULL;
     897
     898        /* Create new region, first check whether we can extend another region. */
    896899        PLSILOGICMEMREGN pIt;
    897 
    898         pRegion = NULL;
    899 
    900         /* Create new region, first check whether we can extend another region. */
    901900        RTListForEach(&pThis->ListMemRegns, pIt, LSILOGICMEMREGN, NodeList)
    902901        {
    … …  
    45424541    SSMR3PutU32   (pSSM, lsilogicR3MemRegionsCount(pThis));
    45434542
    4544     PLSILOGICMEMREGN pIt = NULL;
     4543    PLSILOGICMEMREGN pIt;
    45454544    RTListForEach(&pThis->ListMemRegns, pIt, LSILOGICMEMREGN, NodeList)
    45464545    {

  • trunk/src/VBox/Devices/USB/DrvVUSBRootHub.cpp

    r64294 r64766  
    820820     */
    821821    PVUSBURBVUSB pVUsbUrb, pVUsbUrbNext;
    822 
    823822    RTListForEachSafe(&pDev->LstAsyncUrbs, pVUsbUrb, pVUsbUrbNext, VUSBURBVUSBINT, NdLst)
    824823    {
    … …  
    861860     */
    862861    PVUSBURBVUSB pVUsbUrb, pVUsbUrbNext;
    863 
    864862    RTListForEachSafe(&pDev->LstAsyncUrbs, pVUsbUrb, pVUsbUrbNext, VUSBURBVUSBINT, NdLst)
    865863    {

  • trunk/src/VBox/Devices/USB/linux/USBProxyDevice-linux.cpp

    r64325 r64766  
    238238    PUSBPROXYURBLNX pUrbLnx;
    239239    PUSBPROXYURBLNX pUrbLnxNext;
    240 
    241240    RTListForEachSafe(&pDevLnx->ListInFlight, pUrbLnx, pUrbLnxNext, USBPROXYURBLNX, NodeList)
    242241    {

  • trunk/src/VBox/Devices/USB/usbip/USBProxyDevice-usbip.cpp

    r63562 r64766  
    909909{
    910910    bool fFound = false;
     911
    911912    PUSBPROXYURBUSBIP pIt;
    912 
    913913    RTListForEach(&pProxyDevUsbIp->ListUrbsInFlight, pIt, USBPROXYURBUSBIP, NodeList)
    914914    {
    … …  
    933933{
    934934    bool fFound = false;
     935
    935936    PUSBPROXYURBUSBIP pIt;
    936 
    937937    RTListForEach(&pProxyDevUsbIp->ListUrbsInFlight, pIt, USBPROXYURBUSBIP, NodeList)
    938938    {
    … …  
    12691269    RTSemFastMutexRelease(pProxyDevUsbIp->hMtxLists);
    12701270
    1271     PUSBPROXYURBUSBIP pIter = NULL;
    1272     PUSBPROXYURBUSBIP pIterNext = NULL;
     1271    PUSBPROXYURBUSBIP pIter;
     1272    PUSBPROXYURBUSBIP pIterNext;
    12731273    RTListForEachSafe(&ListUrbsPending, pIter, pIterNext, USBPROXYURBUSBIP, NodeList)
    12741274    {
    … …  
    14251425    rc = RTSemFastMutexRequest(pDevUsbIp->hMtxLists);
    14261426    AssertRC(rc);
    1427     PUSBPROXYURBUSBIP pIter = NULL;
    1428     PUSBPROXYURBUSBIP pIterNext = NULL;
     1427    PUSBPROXYURBUSBIP pIter;
     1428    PUSBPROXYURBUSBIP pIterNext;
    14291429    RTListForEachSafe(&pDevUsbIp->ListUrbsInFlight, pIter, pIterNext, USBPROXYURBUSBIP, NodeList)
    14301430    {

  • trunk/src/VBox/GuestHost/HGSMI/HGSMIMemAlloc.cpp

    r64650 r64766  
    563563    HGSMIMABLOCK *pIter;
    564564    HGSMIMABLOCK *pNext;
    565 
    566565    RTListForEachSafe(&pMA->listBlocks, pIter, pNext, HGSMIMABLOCK, nodeBlock)
    567566    {

  • trunk/src/VBox/GuestHost/OpenGL/util/vreg.cpp

    r63199 r64766  
    137137{
    138138    PVBOXVR_REG pReg, pRegNext;
    139 
    140139    RTListForEachSafe(&pList->ListHead, pReg, pRegNext, VBOXVR_REG, ListEntry)
    141140    {

  • trunk/src/VBox/HostDrivers/VBoxNetFlt/win/drv/VBoxNetFltRt-win.cpp

    r63564 r64766  
    33733373        NdisAcquireSpinLock(&g_VBoxNetFltGlobalsWin.lockFilters);
    33743374        /* At this point the list must contain at least one element. */
    3375         PVBOXNETFLTWIN pFilter   = NULL;
    33763375        PVBOXNETFLTINS pInstance = NULL;
     3376        PVBOXNETFLTWIN pFilter;
    33773377        RTListForEach(&g_VBoxNetFltGlobalsWin.listFilters, pFilter, VBOXNETFLTWIN, node)
    33783378        {

  • trunk/src/VBox/HostDrivers/VBoxNetFlt/win/drv/VBoxNetLwf-win.cpp

    r62714 r64766  
    233233    unsigned cMaxModules = (ERROR_LOG_MAXIMUM_SIZE - FIELD_OFFSET(IO_ERROR_LOG_PACKET, DumpData)) / sizeof(RTMAC);
    234234    unsigned cModules = 0;
    235     PVBOXNETLWF_MODULE pModuleCtx = NULL;
     235    PVBOXNETLWF_MODULE pModuleCtx;
    236236    NdisAcquireSpinLock(&g_VBoxNetLwfGlobals.Lock);
    237237    RTListForEach(&g_VBoxNetLwfGlobals.listModules, pModuleCtx, VBOXNETLWF_MODULE, node)
    … …  
    25492549    AssertReturn(pThis, VERR_INVALID_PARAMETER);
    25502550    Log(("vboxNetFltOsInitInstance: trunk name=%s\n", pThis->szName));
    2551     PVBOXNETLWF_MODULE pModuleCtx = NULL;
    25522551    NdisAcquireSpinLock(&g_VBoxNetLwfGlobals.Lock);
     2552    PVBOXNETLWF_MODULE pModuleCtx;
    25532553    RTListForEach(&g_VBoxNetLwfGlobals.listModules, pModuleCtx, VBOXNETLWF_MODULE, node)
    25542554    {

  • trunk/src/VBox/Main/src-client/DrvAudioVideoRec.cpp

    r63563 r64766  
    181181{
    182182    PPDMAUDIOGSTSTRMOUT sw;
    183     PPDMAUDIOGSTSTRMOUT pIter;
    184183    int m = INT_MAX;
    185184    int nb_live = 0;
    186185
     186    PPDMAUDIOGSTSTRMOUT pIter;
    187187    RTListForEach(&hw->lstGstStrmOut, pIter, PDMAUDIOGSTSTRMOUT, Node)
    188188    {
    … …  
    241241static int audio_pcm_hw_find_min_in (PPDMAUDIOHSTSTRMIN hw)
    242242{
     243    int m = hw->cTotalSamplesCaptured;
     244
    243245    PPDMAUDIOGSTSTRMIN pIter;
    244     int m = hw->cTotalSamplesCaptured;
    245 
    246246    RTListForEach(&hw->lstGstStreamsIn, pIter, PDMAUDIOGSTSTRMIN, Node)
    247247    {

  • trunk/src/VBox/Runtime/common/dvm/dvm.cpp

    r62477 r64766  
    348348                    if (RT_FAILURE(rc))
    349349                    {
     350                        /* Remove all entries. */
    350351                        PRTDVMVOLUMEINTERNAL pItNext, pIt;
    351 
    352                         /* Remove all entries. */
    353352                        RTListForEachSafe(&pThis->VolumeList, pIt, pItNext, RTDVMVOLUMEINTERNAL, VolumeNode)
    354353                        {
    … …  
    491490               && !fAllocated)
    492491        {
    493             PRTDVMVOLUMEINTERNAL pVol;
    494492            bool fVolFound = false;
    495493            uint64_t cbIntersect;
    … …  
    503501             * contigous on the medium.
    504502             */
     503            PRTDVMVOLUMEINTERNAL pVol;
    505504            RTListForEach(&pThis->VolumeList, pVol, RTDVMVOLUMEINTERNAL, VolumeNode)
    506505            {

  • trunk/src/VBox/Runtime/common/misc/aiomgr.cpp

    r63561 r64766  
    677677    unsigned      cRequests = 0;
    678678    int           rc        = VINF_SUCCESS;
     679
     680    /* Go through the list and queue the requests. */
    679681    PRTAIOMGRREQ  pReqIt;
    680682    PRTAIOMGRREQ  pReqItNext;
    681 
    682     /* Go through the list and queue the requests. */
    683683    RTListForEachSafe(&pFile->AioMgr.ListWaitingReqs, pReqIt, pReqItNext, RTAIOMGRREQ, NodeWaitingList)
    684684    {
    … …  
    764764{
    765765    int rc = VINF_SUCCESS;
     766
    766767    PRTAIOMGRFILEINT pIt;
    767 
    768768    RTListForEach(&pThis->ListFiles, pIt, RTAIOMGRFILEINT, AioMgr.NodeAioMgrFiles)
    769769    {

  • trunk/src/VBox/Storage/QCOW.cpp

    r64272 r64766  
    475475static void qcowL2TblCacheDestroy(PQCOWIMAGE pImage)
    476476{
    477     PQCOWL2CACHEENTRY pL2Entry = NULL;
    478     PQCOWL2CACHEENTRY pL2Next  = NULL;
    479 
     477    PQCOWL2CACHEENTRY pL2Entry;
     478    PQCOWL2CACHEENTRY pL2Next;
    480479    RTListForEachSafe(&pImage->ListSearch, pL2Entry, pL2Next, QCOWL2CACHEENTRY, NodeSearch)
    481480    {
    … …  
    501500static PQCOWL2CACHEENTRY qcowL2TblCacheRetain(PQCOWIMAGE pImage, uint64_t offL2Tbl)
    502501{
    503     PQCOWL2CACHEENTRY pL2Entry = NULL;
    504 
     502    PQCOWL2CACHEENTRY pL2Entry;
    505503    RTListForEach(&pImage->ListSearch, pL2Entry, QCOWL2CACHEENTRY, NodeSearch)
    506504    {
    … …  
    517515        return pL2Entry;
    518516    }
    519     else
    520         return NULL;
     517
     518    return NULL;
    521519}
    522520
    … …  
    612610static void qcowL2TblCacheEntryInsert(PQCOWIMAGE pImage, PQCOWL2CACHEENTRY pL2Entry)
    613611{
    614     PQCOWL2CACHEENTRY pIt = NULL;
    615 
    616612    Assert(pL2Entry->offL2Tbl > 0);
    617613
    … …  
    626622    {
    627623        /* Insert into search list. */
     624        PQCOWL2CACHEENTRY pIt;
    628625        pIt = RTListGetFirst(&pImage->ListSearch, QCOWL2CACHEENTRY, NodeSearch);
    629626        if (pIt->offL2Tbl > pL2Entry->offL2Tbl)
    … …  
    643640                }
    644641            }
    645              Assert(fInserted);
     642            Assert(fInserted);
    646643        }
    647644    }

  • trunk/src/VBox/Storage/QED.cpp

    r64272 r64766  
    393393static void qedL2TblCacheDestroy(PQEDIMAGE pImage)
    394394{
    395     PQEDL2CACHEENTRY pL2Entry = NULL;
    396     PQEDL2CACHEENTRY pL2Next  = NULL;
    397 
     395    PQEDL2CACHEENTRY pL2Entry;
     396    PQEDL2CACHEENTRY pL2Next;
    398397    RTListForEachSafe(&pImage->ListSearch, pL2Entry, pL2Next, QEDL2CACHEENTRY, NodeSearch)
    399398    {
    … …  
    419418static PQEDL2CACHEENTRY qedL2TblCacheRetain(PQEDIMAGE pImage, uint64_t offL2Tbl)
    420419{
    421     PQEDL2CACHEENTRY pL2Entry = NULL;
    422 
     420    PQEDL2CACHEENTRY pL2Entry;
    423421    RTListForEach(&pImage->ListSearch, pL2Entry, QEDL2CACHEENTRY, NodeSearch)
    424422    {
    … …  
    530528static void qedL2TblCacheEntryInsert(PQEDIMAGE pImage, PQEDL2CACHEENTRY pL2Entry)
    531529{
    532     PQEDL2CACHEENTRY pIt = NULL;
    533 
    534530    Assert(pL2Entry->offL2Tbl > 0);
    535531
    … …  
    544540    {
    545541        /* Insert into search list. */
     542        PQEDL2CACHEENTRY pIt;
    546543        pIt = RTListGetFirst(&pImage->ListSearch, QEDL2CACHEENTRY, NodeSearch);
    547544        if (pIt->offL2Tbl > pL2Entry->offL2Tbl)
    … …  
    561558                }
    562559            }
    563              Assert(fInserted);
     560            Assert(fInserted);
    564561        }
    565562    }

  • trunk/src/VBox/Storage/VD.cpp

    r64765 r64766  
    36023602static PVDPLUGIN vdPluginFind(const char *pszFilename)
    36033603{
    3604     PVDPLUGIN pIt = NULL;
    3605 
     3604    PVDPLUGIN pIt;
    36063605    RTListForEach(&g_ListPluginsLoaded, pIt, VDPLUGIN, NodePlugin)
    36073606    {
    … …  
    58315830#ifndef VBOX_HDD_NO_DYNAMIC_BACKENDS
    58325831    PVDPLUGIN pPlugin, pPluginNext;
    5833 
    58345832    RTListForEachSafe(&g_ListPluginsLoaded, pPlugin, pPluginNext, VDPLUGIN, NodePlugin)
    58355833    {

  • trunk/src/VBox/Storage/testcase/tstVDIo.cpp

    r63567 r64766  
    17171717
    17181718    /* Check for the file. */
    1719     PVDFILE pIt = NULL;
    17201719    bool fFound = false;
     1720    PVDFILE pIt;
    17211721    RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
    17221722    {
    … …  
    19431943
    19441944    /* Check for the file. */
    1945     PVDFILE pIt = NULL;
    19461945    bool fFound = false;
     1946    PVDFILE pIt;
    19471947    RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
    19481948    {
    … …  
    19761976
    19771977    /* Check for the file. */
    1978     PVDFILE pIt = NULL;
    19791978    bool fFound = false;
     1979    PVDFILE pIt;
    19801980    RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
    19811981    {
    … …  
    20562056
    20572057    /* Check if the file exists. */
    2058     PVDFILE pIt = NULL;
     2058    PVDFILE pIt;
    20592059    RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
    20602060    {
    … …  
    21512151
    21522152    /* Check if the file exists. */
    2153     PVDFILE pIt = NULL;
     2153    PVDFILE pIt;
    21542154    RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
    21552155    {
    … …  
    21822182
    21832183    /* Check if the file exists. */
    2184     PVDFILE pIt = NULL;
     2184    PVDFILE pIt;
    21852185    RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
    21862186    {
    … …  
    25862586static PVDDISK tstVDIoGetDiskByName(PVDTESTGLOB pGlob, const char *pcszDisk)
    25872587{
    2588     PVDDISK pIt = NULL;
    25892588    bool fFound = false;
    25902589
    25912590    LogFlowFunc(("pGlob=%#p pcszDisk=%s\n", pGlob, pcszDisk));
    25922591
     2592    PVDDISK pIt;
    25932593    RTListForEach(&pGlob->ListDisks, pIt, VDDISK, ListNode)
    25942594    {
    … …  
    26142614static PVDPATTERN tstVDIoGetPatternByName(PVDTESTGLOB pGlob, const char *pcszName)
    26152615{
    2616     PVDPATTERN pIt = NULL;
    26172616    bool fFound = false;
    26182617
    26192618    LogFlowFunc(("pGlob=%#p pcszName=%s\n", pGlob, pcszName));
    26202619
     2620    PVDPATTERN pIt;
    26212621    RTListForEach(&pGlob->ListPatterns, pIt, VDPATTERN, ListNode)
    26222622    {

  • trunk/src/VBox/VMM/VMMR3/DBGFR3Flow.cpp

    r64590 r64766  
    339339{
    340340    /* Defer destruction if there are still basic blocks referencing us. */
    341     PDBGFFLOWBBINT pFlowBb = NULL;
    342     PDBGFFLOWBBINT pFlowBbNext = NULL;
     341    PDBGFFLOWBBINT pFlowBb;
     342    PDBGFFLOWBBINT pFlowBbNext;
    343343    RTListForEachSafe(&pThis->LstFlowBb, pFlowBb, pFlowBbNext, DBGFFLOWBBINT, NdFlowBb)
    344344    {
    … …  
    455455DECLINLINE(PDBGFFLOWBBINT) dbgfR3FlowGetUnpopulatedBb(PDBGFFLOWINT pThis)
    456456{
    457     PDBGFFLOWBBINT pFlowBb = NULL;
     457    PDBGFFLOWBBINT pFlowBb;
    458458    RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
    459459    {
    … …  
    475475DECLINLINE(PDBGFFLOWBRANCHTBLINT) dbgfR3FlowBranchTblFindByAddr(PDBGFFLOWINT pThis, PDBGFADDRESS pAddrTbl)
    476476{
    477     PDBGFFLOWBRANCHTBLINT pTbl = NULL;
     477    PDBGFFLOWBRANCHTBLINT pTbl;
    478478    RTListForEach(&pThis->LstBranchTbl, pTbl, DBGFFLOWBRANCHTBLINT, NdBranchTbl)
    479479    {
    … …  
    519519static bool dbgfR3FlowHasBbWithStartAddr(PDBGFFLOWINT pThis, PDBGFADDRESS pAddr)
    520520{
    521     PDBGFFLOWBBINT pFlowBb = NULL;
     521    PDBGFFLOWBBINT pFlowBb;
    522522    RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
    523523    {
    … …  
    616616                                    uint32_t fNewBbFlags, PDBGFFLOWBRANCHTBLINT pBranchTbl)
    617617{
    618     PDBGFFLOWBBINT pFlowBb = NULL;
     618    PDBGFFLOWBBINT pFlowBb;
    619619    RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
    620620    {
    … …  
    14311431    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
    14321432
    1433     PDBGFFLOWBBINT pFlowBb = NULL;
     1433    PDBGFFLOWBBINT pFlowBb;
    14341434    RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
    14351435    {
    … …  
    14631463    AssertPtrReturn(phFlowBb, VERR_INVALID_POINTER);
    14641464
    1465     PDBGFFLOWBBINT pFlowBb = NULL;
     1465    PDBGFFLOWBBINT pFlowBb;
    14661466    RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
    14671467    {
    … …  
    18331833
    18341834    uint32_t cRefsBb = 0;
    1835     PDBGFFLOWBBINT pFlowBbCur = NULL;
     1835    PDBGFFLOWBBINT pFlowBbCur;
    18361836    RTListForEach(&pFlowBb->pFlow->LstFlowBb, pFlowBbCur, DBGFFLOWBBINT, NdFlowBb)
    18371837    {
    … …  
    20422042        pIt->idxBbNext = 0;
    20432043        /* Fill the list and then sort. */
     2044        uint32_t idxBb = 0;
    20442045        PDBGFFLOWBBINT pFlowBb;
    2045         uint32_t idxBb = 0;
    20462046        RTListForEach(&pFlow->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
    20472047        {
    … …  
    21792179        pIt->idxTblNext = 0;
    21802180        /* Fill the list and then sort. */
     2181        uint32_t idxTbl = 0;
    21812182        PDBGFFLOWBRANCHTBLINT pFlowBranchTbl;
    2182         uint32_t idxTbl = 0;
    21832183        RTListForEach(&pFlow->LstBranchTbl, pFlowBranchTbl, DBGFFLOWBRANCHTBLINT, NdBranchTbl)
    21842184        {

  • trunk/src/VBox/VMM/VMMR3/PDMBlkCache.cpp

    r64530 r64766  
    780780{
    781781    bool fFound = false;
    782     PPDMBLKCACHE pBlkCache = NULL;
    783 
     782
     783    PPDMBLKCACHE pBlkCache;
    784784    RTListForEach(&pBlkCacheGlobal->ListUsers, pBlkCache, PDMBLKCACHE, NodeCacheUser)
    785785    {
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette